41823 2010-07-07 18:10:51 -0700 Fix adoptRef assertion failures caused by stack-allocated ResourceHandle objects 2010-07-09 07:49:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 27672 1 darin darin abarth eric gustavo webkit.review.bot xan.lopez oldest_to_newest 247914 0 darin 2010-07-07 18:10:51 -0700 Fix adoptRef assertion failures caused by stack-allocated ResourceHandle objects 247915 1 60818 darin 2010-07-07 18:12:31 -0700 Created attachment 60818 Patch 247918 2 60818 darin 2010-07-07 18:18:13 -0700 Comment on attachment 60818 Patch Anders reviewed this. 247919 3 darin 2010-07-07 18:19:44 -0700 Committed r62736: <http://trac.webkit.org/changeset/62736> 247927 4 webkit.review.bot 2010-07-07 18:39:10 -0700 http://trac.webkit.org/changeset/62736 might have broken GTK Linux 32-bit Release 248293 5 gustavo 2010-07-08 10:05:17 -0700 The failure reported by the bot seems to be indeed caused by this change. These two tests started timing out with the change, and reverting the change locally make them work again: http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync.html http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync.html 248322 6 darin 2010-07-08 10:43:27 -0700 Uh oh. Any ideas for fixing that? 248348 7 xan.lopez 2010-07-08 11:09:44 -0700 (In reply to comment #6) > Uh oh. Any ideas for fixing that? Aren't you just never calling .start() in the handle after the patch? 248349 8 darin 2010-07-08 11:10:41 -0700 (In reply to comment #7) > Aren't you just never calling .start() in the handle after the patch? I believe the synchronous loading function now calls create(), which calls start(). So that should work. 248357 9 xan.lopez 2010-07-08 11:18:03 -0700 (In reply to comment #8) > (In reply to comment #7) > > Aren't you just never calling .start() in the handle after the patch? > > I believe the synchronous loading function now calls create(), which calls start(). So that should work. I see, you are right. I guess the explanation is that it's failing in the previous checks in the create function now, otherwise the code seems identical. 248358 10 darin 2010-07-08 11:20:01 -0700 (In reply to comment #9) > I see, you are right. I guess the explanation is that it's failing in the previous checks in the create function now, otherwise the code seems identical. I guess instead of calling create we should just explicitly do adoptRef(new) and start() to keep things working for now, and consider adding a FIXME saying we should use create. Xan, do you want to use a new bug to track that change? Do you want me to do it, or would you do it? 248361 11 xan.lopez 2010-07-08 11:24:37 -0700 (In reply to comment #10) > (In reply to comment #9) > > I see, you are right. I guess the explanation is that it's failing in the previous checks in the create function now, otherwise the code seems identical. > > I guess instead of calling create we should just explicitly do adoptRef(new) and start() to keep things working for now, and consider adding a FIXME saying we should use create. Xan, do you want to use a new bug to track that change? Do you want me to do it, or would you do it? Let me do the patch and test it here, I'll attach it in the bug and you can review it. 248429 12 60927 xan.lopez 2010-07-08 12:28:16 -0700 Created attachment 60927 resourcehandle.diff Sorry for the delay, a World recompile kicked in. This fixes things locally for me. 248511 13 60927 darin 2010-07-08 13:52:49 -0700 Comment on attachment 60927 resourcehandle.diff WebCore/platform/network/soup/ResourceHandleSoup.cpp:665 + handle.get()->start(frame); No need for get() here. 248516 14 60927 xan.lopez 2010-07-08 14:02:09 -0700 Comment on attachment 60927 resourcehandle.diff Landed in r62832 with the suggested fix. 60818 2010-07-07 18:12:31 -0700 2010-07-07 18:18:13 -0700 Patch bug-41823-20100707181230.patch text/plain 5381 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MjczNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDctMDcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBh ZG9wdFJlZiBhc3NlcnRpb24gZmFpbHVyZXMgY2F1c2VkIGJ5IHN0YWNrLWFsbG9jYXRlZCBSZXNv dXJjZUhhbmRsZSBvYmplY3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MTgyMworCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9hbmRyb2lkL1Jl c291cmNlSGFuZGxlQW5kcm9pZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRs ZTo6bG9hZFJlc291cmNlU3luY2hyb25vdXNseSk6IFVzZSBhZG9wdFJlZiBhbmQgbmV3IGluc3Rl YWQKKyAgICAgICAgb2YgYWxsb2NhdGluZyBhbiBvYmplY3Qgb24gdGhlIHN0YWNrLgorICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1cmwuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmxvYWRSZXNvdXJjZVN5bmNocm9ub3VzbHkpOiBE aXR0by4KKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlSGFuZGxlUXQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmxvYWRSZXNvdXJjZVN5bmNocm9u b3VzbHkpOiBEaXR0by4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJj ZUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmxvYWRS ZXNvdXJjZVN5bmNocm9ub3VzbHkpOiBVc2UgY3JlYXRlIGluc3RlYWQgb2YKKyAgICAgICAgYWxs b2NhdGluZyBhbiBvYmplY3Qgb24gdGhlIHN0YWNrLgorCiAyMDEwLTA3LTA3ICBKb3NlcGggUGVj b3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkg UGF2ZWwgRmVsZG1hbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9hbmRyb2lkL1Jl c291cmNlSGFuZGxlQW5kcm9pZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2FuZHJvaWQvUmVzb3VyY2VIYW5kbGVBbmRyb2lkLmNwcAkocmV2aXNpb24gNjI3MzUp CisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYW5kcm9pZC9SZXNvdXJjZUhhbmRsZUFuZHJv aWQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDYsOSArMTQ2LDkgQEAgdm9pZCBSZXNvdXJjZUhh bmRsZTo6bG9hZFJlc291cmNlU3luY2hybwogICAgICAgICBGcmFtZSogZnJhbWUpIAogewogICAg IFN5bmNMb2FkZXIgcyhlcnJvciwgcmVzcG9uc2UsIGRhdGEpOwotICAgIFJlc291cmNlSGFuZGxl IGgocmVxdWVzdCwgJnMsIGZhbHNlLCBmYWxzZSwgZmFsc2UpOworICAgIFJlZlB0cjxSZXNvdXJj ZUhhbmRsZT4gaCA9IGFkb3B0UmVmKG5ldyBSZXNvdXJjZUhhbmRsZShyZXF1ZXN0LCAmcywgZmFs c2UsIGZhbHNlLCBmYWxzZSkpOwogICAgIC8vIFRoaXMgYmxvY2tzIHVudGlsIHRoZSBsb2FkIGlz IGZpbmlzaGVkLgotICAgIFJlc291cmNlTG9hZGVyQW5kcm9pZDo6c3RhcnQoJmgsIHJlcXVlc3Qs IGZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCksIGZhbHNlLCB0cnVlKTsKKyAgICBSZXNvdXJjZUxv YWRlckFuZHJvaWQ6OnN0YXJ0KGguZ2V0KCksIHJlcXVlc3QsIGZyYW1lLT5sb2FkZXIoKS0+Y2xp ZW50KCksIGZhbHNlLCB0cnVlKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDog V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVDdXJsLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1 cmwuY3BwCShyZXZpc2lvbiA2MjczNSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJs L1Jlc291cmNlSGFuZGxlQ3VybC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5MCwxMSArMTkwLDEx IEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OmxvYWRzQmxvY2tlZCgpCiB2b2lkIFJlc291cmNlSGFu ZGxlOjpsb2FkUmVzb3VyY2VTeW5jaHJvbm91c2x5KGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVx dWVzdCwgU3RvcmVkQ3JlZGVudGlhbHMgc3RvcmVkQ3JlZGVudGlhbHMsIFJlc291cmNlRXJyb3Im IGVycm9yLCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSwgVmVjdG9yPGNoYXI+JiBkYXRhLCBG cmFtZSopCiB7CiAgICAgV2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyIHN5bmNMb2FkZXI7Ci0gICAg UmVzb3VyY2VIYW5kbGUgaGFuZGxlKHJlcXVlc3QsICZzeW5jTG9hZGVyLCB0cnVlLCBmYWxzZSk7 CisgICAgUmVmUHRyPFJlc291cmNlSGFuZGxlPiBoYW5kbGUgPSBhZG9wdFJlZihuZXcgUmVzb3Vy Y2VIYW5kbGUocmVxdWVzdCwgJnN5bmNMb2FkZXIsIHRydWUsIGZhbHNlKSk7CiAKICAgICBSZXNv dXJjZUhhbmRsZU1hbmFnZXIqIG1hbmFnZXIgPSBSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OnNoYXJl ZEluc3RhbmNlKCk7CiAKLSAgICBtYW5hZ2VyLT5kaXNwYXRjaFN5bmNocm9ub3VzSm9iKCZoYW5k bGUpOworICAgIG1hbmFnZXItPmRpc3BhdGNoU3luY2hyb25vdXNKb2IoaGFuZGxlLmdldCgpKTsK IAogICAgIGVycm9yID0gc3luY0xvYWRlci5yZXNvdXJjZUVycm9yKCk7CiAgICAgZGF0YSA9IHN5 bmNMb2FkZXIuZGF0YSgpOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291 cmNlSGFuZGxlUXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9x dC9SZXNvdXJjZUhhbmRsZVF0LmNwcAkocmV2aXNpb24gNjI3MzUpCisrKyBXZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvcXQvUmVzb3VyY2VIYW5kbGVRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4 OSw5ICsxODksOSBAQCBQYXNzUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gUmVzb3VyY2VIYW5kbGU6CiB2 b2lkIFJlc291cmNlSGFuZGxlOjpsb2FkUmVzb3VyY2VTeW5jaHJvbm91c2x5KGNvbnN0IFJlc291 cmNlUmVxdWVzdCYgcmVxdWVzdCwgU3RvcmVkQ3JlZGVudGlhbHMgLypzdG9yZWRDcmVkZW50aWFs cyovLCBSZXNvdXJjZUVycm9yJiBlcnJvciwgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UsIFZl Y3RvcjxjaGFyPiYgZGF0YSwgRnJhbWUqIGZyYW1lKQogewogICAgIFdlYkNvcmVTeW5jaHJvbm91 c0xvYWRlciBzeW5jTG9hZGVyOwotICAgIFJlc291cmNlSGFuZGxlIGhhbmRsZShyZXF1ZXN0LCAm c3luY0xvYWRlciwgdHJ1ZSwgZmFsc2UpOworICAgIFJlZlB0cjxSZXNvdXJjZUhhbmRsZT4gaGFu ZGxlID0gYWRvcHRSZWYobmV3IFJlc291cmNlSGFuZGxlKHJlcXVlc3QsICZzeW5jTG9hZGVyLCB0 cnVlLCBmYWxzZSkpOwogCi0gICAgUmVzb3VyY2VIYW5kbGVJbnRlcm5hbCAqZCA9IGhhbmRsZS5n ZXRJbnRlcm5hbCgpOworICAgIFJlc291cmNlSGFuZGxlSW50ZXJuYWwqIGQgPSBoYW5kbGUtPmdl dEludGVybmFsKCk7CiAgICAgaWYgKCEoZC0+bV91c2VyLmlzRW1wdHkoKSB8fCBkLT5tX3Bhc3Mu aXNFbXB0eSgpKSkgewogICAgICAgICAvLyBJZiBjcmVkZW50aWFscyB3ZXJlIHNwZWNpZmllZCBm b3IgdGhpcyByZXF1ZXN0LCBhZGQgdGhlbSB0byB0aGUgdXJsLAogICAgICAgICAvLyBzbyB0aGF0 IHRoZXkgd2lsbCBiZSBwYXNzZWQgdG8gUU5ldHdvcmtSZXF1ZXN0LgpAQCAtMjAxLDcgKzIwMSw3 IEBAIHZvaWQgUmVzb3VyY2VIYW5kbGU6OmxvYWRSZXNvdXJjZVN5bmNocm8KICAgICAgICAgZC0+ bV9yZXF1ZXN0LnNldFVSTCh1cmxXaXRoQ3JlZGVudGlhbHMpOwogICAgIH0KICAgICBkLT5tX2Zy YW1lID0gc3RhdGljX2Nhc3Q8RnJhbWVMb2FkZXJDbGllbnRRdCo+KGZyYW1lLT5sb2FkZXIoKS0+ Y2xpZW50KCkpLT53ZWJGcmFtZSgpOwotICAgIGQtPm1fam9iID0gbmV3IFFOZXR3b3JrUmVwbHlI YW5kbGVyKCZoYW5kbGUsIFFOZXR3b3JrUmVwbHlIYW5kbGVyOjpMb2FkTm9ybWFsKTsKKyAgICBk LT5tX2pvYiA9IG5ldyBRTmV0d29ya1JlcGx5SGFuZGxlcihoYW5kbGUuZ2V0KCksIFFOZXR3b3Jr UmVwbHlIYW5kbGVyOjpMb2FkTm9ybWFsKTsKIAogICAgIHN5bmNMb2FkZXIud2FpdEZvckNvbXBs ZXRpb24oKTsKICAgICBlcnJvciA9IHN5bmNMb2FkZXIucmVzb3VyY2VFcnJvcigpOwpJbmRleDog V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNv dXAuY3BwCShyZXZpc2lvbiA2MjczNSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3Vw L1Jlc291cmNlSGFuZGxlU291cC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1OCw5ICs2NTgsNyBA QCBib29sIFJlc291cmNlSGFuZGxlOjp3aWxsTG9hZEZyb21DYWNoZShSCiB2b2lkIFJlc291cmNl SGFuZGxlOjpsb2FkUmVzb3VyY2VTeW5jaHJvbm91c2x5KGNvbnN0IFJlc291cmNlUmVxdWVzdCYg cmVxdWVzdCwgU3RvcmVkQ3JlZGVudGlhbHMgLypzdG9yZWRDcmVkZW50aWFscyovLCBSZXNvdXJj ZUVycm9yJiBlcnJvciwgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UsIFZlY3RvcjxjaGFyPiYg ZGF0YSwgRnJhbWUqIGZyYW1lKQogewogICAgIFdlYkNvcmVTeW5jaHJvbm91c0xvYWRlciBzeW5j TG9hZGVyKGVycm9yLCByZXNwb25zZSwgZGF0YSk7Ci0gICAgUmVzb3VyY2VIYW5kbGUgaGFuZGxl KHJlcXVlc3QsICZzeW5jTG9hZGVyLCB0cnVlLCBmYWxzZSk7Ci0KLSAgICBoYW5kbGUuc3RhcnQo ZnJhbWUpOworICAgIFJlZlB0cjxSZXNvdXJjZUhhbmRsZT4gaGFuZGxlID0gY3JlYXRlKHJlcXVl c3QsICZzeW5jTG9hZGVyLCBmcmFtZSwgdHJ1ZSwgZmFsc2UpOwogICAgIHN5bmNMb2FkZXIucnVu KCk7CiB9CiAKQEAgLTkyOSw0ICs5MjcsMyBAQCBTb3VwU2Vzc2lvbiogUmVzb3VyY2VIYW5kbGU6 OmRlZmF1bHRTZXNzCiB9CiAKIH0KLQo= 60927 2010-07-08 12:28:16 -0700 2010-07-08 14:02:09 -0700 resourcehandle.diff resourcehandle.diff text/plain 2689 xan.lopez RnJvbSBjODkyMTcwZWU0YzY2MDg1NTZkZDZlOThmYTRlMDA5NDY4ZDAwOWVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBU aHUsIDggSnVsIDIwMTAgMjE6Mjc6MDAgKzAyMDAKU3ViamVjdDogW1BBVENIXSAyMDEwLTA3LTA4 ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgogICAgICAgIEZpeCBhZG9wdFJlZiBhc3NlcnRpb24gZmFpbHVyZXMgY2F1 c2VkIGJ5IHN0YWNrLWFsbG9jYXRlZCBSZXNvdXJjZUhhbmRsZSBvYmplY3RzCiAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxODIzCgogICAgICAgIENyZWF0 ZSB0aGUgUmVzb3VyY2VIYW5kbGUgbWFudWFsbHkgZm9yIG5vdyBpbnN0ZWFkIG9mIGNhbGxpbmcK ICAgICAgICA6OmNyZWF0ZSwgc2luY2UgdGhhdCBtZXRob2RzIGRvZXMgYSBmZXcgZXh0cmEgY2hl Y2tzIHRoYXQgbWFrZSB1cwogICAgICAgIGZhaWwgYSBjb3VwbGUgb2YgSFRUUCB0ZXN0cy4KCiAg ICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcDoKICAg ICAgICAoV2ViQ29yZTo6KToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIC4uLi9wbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcCAgIHwgICAgNyArKysrKystCiAyIGZpbGVz IGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNDFlMmUzLi5iZWIz NTY3IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEwLTA3LTA4ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlh LmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggYWRvcHRSZWYgYXNzZXJ0aW9uIGZhaWx1cmVzIGNhdXNlZCBieSBzdGFjay1hbGxvY2F0ZWQg UmVzb3VyY2VIYW5kbGUgb2JqZWN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDE4MjMKKworICAgICAgICBDcmVhdGUgdGhlIFJlc291cmNlSGFuZGxl IG1hbnVhbGx5IGZvciBub3cgaW5zdGVhZCBvZiBjYWxsaW5nCisgICAgICAgIDo6Y3JlYXRlLCBz aW5jZSB0aGF0IG1ldGhvZHMgZG9lcyBhIGZldyBleHRyYSBjaGVja3MgdGhhdCBtYWtlIHVzCisg ICAgICAgIGZhaWwgYSBjb3VwbGUgb2YgSFRUUCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3Jt L25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 KToKKworMjAxMC0wNy0wOCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CisKICAgICAg ICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgogCiAgICAgICAgIFNpbGVuY2UgYSBmZXcg bm9pc3kgYnVpbGQgcnVsZXMuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCBkZWU0ODA4Li4wNGNjNDM2IDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3Bw CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5j cHAKQEAgLTY1OCw3ICs2NTgsMTIgQEAgYm9vbCBSZXNvdXJjZUhhbmRsZTo6d2lsbExvYWRGcm9t Q2FjaGUoUmVzb3VyY2VSZXF1ZXN0JiwgRnJhbWUqKQogdm9pZCBSZXNvdXJjZUhhbmRsZTo6bG9h ZFJlc291cmNlU3luY2hyb25vdXNseShjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIFN0 b3JlZENyZWRlbnRpYWxzIC8qc3RvcmVkQ3JlZGVudGlhbHMqLywgUmVzb3VyY2VFcnJvciYgZXJy b3IsIFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlLCBWZWN0b3I8Y2hhcj4mIGRhdGEsIEZyYW1l KiBmcmFtZSkKIHsKICAgICBXZWJDb3JlU3luY2hyb25vdXNMb2FkZXIgc3luY0xvYWRlcihlcnJv ciwgcmVzcG9uc2UsIGRhdGEpOwotICAgIFJlZlB0cjxSZXNvdXJjZUhhbmRsZT4gaGFuZGxlID0g Y3JlYXRlKHJlcXVlc3QsICZzeW5jTG9hZGVyLCBmcmFtZSwgdHJ1ZSwgZmFsc2UpOworICAgIC8v IEZJWE1FOiB3ZSBzaG91bGQgdXNlIHRoZSBSZXNvdXJjZUhhbmRsZTo6Y3JlYXRlIG1ldGhvZCBo ZXJlLAorICAgIC8vIGJ1dCBpdCBtYWtlcyB1cyB0aW1lb3V0IGluIGEgY291cGxlIG9mIHRlc3Rz LiBTZWUKKyAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE4 MjMKKyAgICBSZWZQdHI8UmVzb3VyY2VIYW5kbGU+IGhhbmRsZSA9IGFkb3B0UmVmKG5ldyBSZXNv dXJjZUhhbmRsZShyZXF1ZXN0LCAmc3luY0xvYWRlciwgdHJ1ZSwgZmFsc2UpKTsKKyAgICBoYW5k bGUuZ2V0KCktPnN0YXJ0KGZyYW1lKTsKKwogICAgIHN5bmNMb2FkZXIucnVuKCk7CiB9CiAKLS0g CjEuNy4xLjEKCg==