<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>41820</bug_id>
          
          <creation_ts>2010-07-07 17:50:41 -0700</creation_ts>
          <short_desc>commit-queue and EWS bots should report all failures</short_desc>
          <delta_ts>2010-08-24 22:19:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Eric Seidel (no email)">eric</assigned_to>
          <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>247898</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-07-07 17:50:41 -0700</bug_when>
    <thetext>commit-queue and EWS bots should report all failures</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>247903</commentid>
    <comment_count>1</comment_count>
      <attachid>60815</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-07-07 17:54:38 -0700</bug_when>
    <thetext>Created attachment 60815
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>248863</commentid>
    <comment_count>2</comment_count>
      <attachid>60815</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-07-09 02:46:29 -0700</bug_when>
    <thetext>Comment on attachment 60815
Patch

WebKitTools/Scripts/webkitpy/tool/commands/queues.py:139
 +          log_file = cls._log_from_script_error_for_upload(script_error)
You never do anything with the log_file :)

WebKitTools/Scripts/webkitpy/tool/commands/queues.py:215
 +              failure_log = self._log_from_script_error_for_upload(e)
Inconsistent naming of the result of this function.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>263006</commentid>
    <comment_count>3</comment_count>
      <attachid>60815</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-08-10 22:22:15 -0700</bug_when>
    <thetext>Comment on attachment 60815
Patch

Please address my comments above.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269015</commentid>
    <comment_count>4</comment_count>
      <attachid>65369</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-08-24 22:10:05 -0700</bug_when>
    <thetext>Created attachment 65369
Addressed Adam&apos;s comments</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269016</commentid>
    <comment_count>5</comment_count>
      <attachid>65369</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-08-24 22:11:28 -0700</bug_when>
    <thetext>Comment on attachment 65369
Addressed Adam&apos;s comments

ok</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269017</commentid>
    <comment_count>6</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-08-24 22:12:06 -0700</bug_when>
    <thetext>Committed r65979: &lt;http://trac.webkit.org/changeset/65979&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269018</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-08-24 22:19:06 -0700</bug_when>
    <thetext>I&apos;ve restarted the cq and the mac-ews.  We&apos;ll know shortly if this code is working as intended.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>60815</attachid>
            <date>2010-07-07 17:54:38 -0700</date>
            <delta_ts>2010-08-24 22:10:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-41820-20100707175437.patch</filename>
            <type>text/plain</type>
            <size>6748</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCAxNmE5NDRmYjk1Y2NkYWU4MzExOGQ0MjlmNDRlMTU1MmU1MDY4MmRkLi4wNDUyY2Zl
YzU3MGJhZWNmMmI3Zjg0NTcxNWNjYTViZmMzYTczYTQ4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s
cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAK
KzIwMTAtMDctMDcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbW1pdC1xdWV1ZSBhbmQgRVdT
IGJvdHMgc2hvdWxkIHJlcG9ydCBhbGwgZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxODIwCisKKyAgICAgICAgUmlnaHQgbm93IGNvbW1p
dC1xdWV1ZS9FV1Mgb25seSByZXBvcnQgZmFpbHVyZXMgd2hlbiB0aGUKKyAgICAgICAgcGF0Y2gg
dW5kZXIgdGVzdGluZyBmYWlscy4gIFdlIHNob3VsZCByZXBvcnQgYWxsIGZhaWx1cmVzCisgICAg
ICAgIHRvIHRoZSBzdGF0dXMgc2VydmVyIHNvIHRoYXQgd2UgY2FuIGRpYWdub3NlIHdoZW4gdGhl
IGJvdHMKKyAgICAgICAgYXJlIHdlZGdlZCB3L28gbmVlZGluZyB0byBsb2cgaW50byB0aGUgbWFj
aGluZXMuCisKKyAgICAgICAgSSBhbHNvIHJlZHVjZWQgdGhlIGFtb3VudCBvZiBkYXRhIHdlIHVw
bG9hZCBzaW5jZSB3ZSd2ZSBzZWVuCisgICAgICAgIHRpbWVvdXRzIGR1cmluZyBzdGF0dXMgdXBs
b2FkLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2
ZS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJu
aW5nc3lzdGVtLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9x
dWV1ZXMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVl
c191bml0dGVzdC5weToKKwogMjAxMC0wNy0wNyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29u
QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1dlYktpdFRv
b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkgYi9XZWJLaXRU
b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5CmluZGV4IDlj
NTg4OWJkNjNmNWYwZWIzYzlmMDc4M2RlNDM0NThmZGFkZWMxNjUuLmEwYjY4N2U0NGU5ODNjNjM1
YmY0ZGQxMGU0Y2ZkM2VhMjQ1NjI5MjcgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMv
d2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkKKysrIGIvV2ViS2l0VG9vbHMvU2Ny
aXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQpAQCAtNzMsMTAgKzczLDEw
IEBAIGNsYXNzIFNjcmlwdEVycm9yKEV4Y2VwdGlvbik6CiAgICAgZGVmIG1lc3NhZ2Vfd2l0aF9v
dXRwdXQoc2VsZiwgb3V0cHV0X2xpbWl0PTUwMCk6CiAgICAgICAgIGlmIHNlbGYub3V0cHV0Ogog
ICAgICAgICAgICAgaWYgb3V0cHV0X2xpbWl0IGFuZCBsZW4oc2VsZi5vdXRwdXQpID4gb3V0cHV0
X2xpbWl0OgotICAgICAgICAgICAgICAgIHJldHVybiAiJXNcbkxhc3QgJXMgY2hhcmFjdGVycyBv
ZiBvdXRwdXQ6XG4lcyIgJSBcCisgICAgICAgICAgICAgICAgcmV0dXJuIHUiJXNcbkxhc3QgJXMg
Y2hhcmFjdGVycyBvZiBvdXRwdXQ6XG4lcyIgJSBcCiAgICAgICAgICAgICAgICAgICAgIChzZWxm
LCBvdXRwdXRfbGltaXQsIHNlbGYub3V0cHV0Wy1vdXRwdXRfbGltaXQ6XSkKLSAgICAgICAgICAg
IHJldHVybiAiJXNcbiVzIiAlIChzZWxmLCBzZWxmLm91dHB1dCkKLSAgICAgICAgcmV0dXJuIHN0
cihzZWxmKQorICAgICAgICAgICAgcmV0dXJuIHUiJXNcbiVzIiAlIChzZWxmLCBzZWxmLm91dHB1
dCkKKyAgICAgICAgcmV0dXJuIHVuaWNvZGUoc2VsZikKIAogICAgIGRlZiBjb21tYW5kX25hbWUo
c2VsZik6CiAgICAgICAgIGNvbW1hbmRfcGF0aCA9IHNlbGYuc2NyaXB0X2FyZ3MKZGlmZiAtLWdp
dCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5p
bmdzeXN0ZW0ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMv
ZWFybHl3YXJuaW5nc3lzdGVtLnB5CmluZGV4IDlmYmZkYTZkOGJhY2UxYzUyN2FjMWQwZmQ5N2Q5
MDFlZTU5ZjExYWIuLmNhMTE1ZWViOTFiMzc5Njk4NWQ3MDk5ZDBkZGRlMTljNjE1ZDYyNWMgMTAw
NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJs
eXdhcm5pbmdzeXN0ZW0ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s
L2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQpAQCAtNTUsNyArNTUsOCBAQCBjbGFzcyBB
YnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbShBYnN0cmFjdFJldmlld1F1ZXVlKToKICAgICAgICAg
ICAgICAgICAiLS1xdWlldCJdKQogICAgICAgICAgICAgcmV0dXJuIFRydWUKICAgICAgICAgZXhj
ZXB0IFNjcmlwdEVycm9yLCBlOgotICAgICAgICAgICAgc2VsZi5fdXBkYXRlX3N0YXR1cygiVW5h
YmxlIHRvIHBlcmZvcm0gYSBidWlsZCIpCisgICAgICAgICAgICBmYWlsdXJlX2xvZyA9IHNlbGYu
X2xvZ19mcm9tX3NjcmlwdF9lcnJvcl9mb3JfdXBsb2FkKGUpCisgICAgICAgICAgICBzZWxmLl91
cGRhdGVfc3RhdHVzKCJVbmFibGUgdG8gcGVyZm9ybSBhIGJ1aWxkIiwgcmVzdWx0c19maWxlPWZh
aWx1cmVfbG9nKQogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAKICAgICBkZWYgX2J1aWxkKHNl
bGYsIHBhdGNoLCBmaXJzdF9ydW49RmFsc2UpOgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2Ny
aXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weSBiL1dlYktpdFRvb2xzL1Njcmlw
dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkKaW5kZXggNWZmMzkwYzdmMjQ3Mzcw
YTEyODE5MmY5NGRhMGYwNWMwZWRmNzg2NS4uM2M4YmYzOTg4ZGRiZTJhYTA0YmM0OTY5NjIyMjNl
ZTUyMTExNGQwYiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s
L2NvbW1hbmRzL3F1ZXVlcy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv
b2wvY29tbWFuZHMvcXVldWVzLnB5CkBAIC0xMjAsMTUgKzEyMCwyNCBAQCBjbGFzcyBBYnN0cmFj
dFF1ZXVlKENvbW1hbmQsIFF1ZXVlRW5naW5lRGVsZWdhdGUpOgogICAgICAgICByZXR1cm4gZW5n
aW5lKHNlbGYubmFtZSwgc2VsZiwgc2VsZi50b29sLndha2V1cF9ldmVudCkucnVuKCkKIAogICAg
IEBjbGFzc21ldGhvZAorICAgIGRlZiBfbG9nX2Zyb21fc2NyaXB0X2Vycm9yX2Zvcl91cGxvYWQo
Y2xzLCBzY3JpcHRfZXJyb3IsIG91dHB1dF9saW1pdD1Ob25lKToKKyAgICAgICAgIyBXZSBoYXZl
IHNlZW4gcmVxdWVzdCB0aW1lb3V0cyB3aXRoIGFwcCBlbmdpbmUgZHVlIHRvIGxhcmdlCisgICAg
ICAgICMgbG9nIHVwbG9hZHMuICBUcnlpbmcgb25seSB0aGUgbGFzdCA1MTJrLgorICAgICAgICBp
ZiBub3Qgb3V0cHV0X2xpbWl0OgorICAgICAgICAgICAgb3V0cHV0X2xpbWl0ID0gNTEyICogMTAy
NCAgIyA1MTJrCisgICAgICAgIG91dHB1dCA9IHNjcmlwdF9lcnJvci5tZXNzYWdlX3dpdGhfb3V0
cHV0KG91dHB1dF9saW1pdD1vdXRwdXRfbGltaXQpCisgICAgICAgICMgV2UgcHJlLWVuY29kZSB0
aGUgc3RyaW5nIHRvIGEgYnl0ZSBhcnJheSBiZWZvcmUgcGFzc2luZyBpdAorICAgICAgICAjIHRv
IHN0YXR1c19zZXJ2ZXIsIGJlY2F1c2UgQ2xpZW50Rm9ybSAocGFydCBvZiBtZWNoYW5pemUpCisg
ICAgICAgICMgd2FudHMgYSBmaWxlLWxpa2Ugb2JqZWN0IHdpdGggcHJlLWVuY29kZWQgZGF0YS4K
KyAgICAgICAgcmV0dXJuIFN0cmluZ0lPKG91dHB1dC5lbmNvZGUoInV0Zi04IikpCisKKyAgICBA
Y2xhc3NtZXRob2QKICAgICBkZWYgX3VwZGF0ZV9zdGF0dXNfZm9yX3NjcmlwdF9lcnJvcihjbHMs
IHRvb2wsIHN0YXRlLCBzY3JpcHRfZXJyb3IsIGlzX2Vycm9yPUZhbHNlKToKICAgICAgICAgbWVz
c2FnZSA9IHN0cihzY3JpcHRfZXJyb3IpCiAgICAgICAgIGlmIGlzX2Vycm9yOgogICAgICAgICAg
ICAgbWVzc2FnZSA9ICJFcnJvcjogJXMiICUgbWVzc2FnZQotICAgICAgICBvdXRwdXQgPSBzY3Jp
cHRfZXJyb3IubWVzc2FnZV93aXRoX291dHB1dChvdXRwdXRfbGltaXQ9MTAyNCoxMDI0KSAjIDFN
QgotICAgICAgICAjIFdlIHByZS1lbmNvZGUgdGhlIHN0cmluZyB0byBhIGJ5dGUgYXJyYXkgYmVm
b3JlIHBhc3NpbmcgaXQKLSAgICAgICAgIyB0byBzdGF0dXNfc2VydmVyLCBiZWNhdXNlIENsaWVu
dEZvcm0gKHBhcnQgb2YgbWVjaGFuaXplKQotICAgICAgICAjIHdhbnRzIGEgZmlsZS1saWtlIG9i
amVjdCB3aXRoIHByZS1lbmNvZGVkIGRhdGEuCi0gICAgICAgIHJldHVybiB0b29sLnN0YXR1c19z
ZXJ2ZXIudXBkYXRlX3N0YXR1cyhjbHMubmFtZSwgbWVzc2FnZSwgc3RhdGVbInBhdGNoIl0sIFN0
cmluZ0lPKG91dHB1dC5lbmNvZGUoInV0Zi04IikpKQorICAgICAgICBsb2dfZmlsZSA9IGNscy5f
bG9nX2Zyb21fc2NyaXB0X2Vycm9yX2Zvcl91cGxvYWQoc2NyaXB0X2Vycm9yKQorICAgICAgICBy
ZXR1cm4gdG9vbC5zdGF0dXNfc2VydmVyLnVwZGF0ZV9zdGF0dXMoY2xzLm5hbWUsIG1lc3NhZ2Us
IHN0YXRlWyJwYXRjaCJdLCApCiAKIAogY2xhc3MgQWJzdHJhY3RQYXRjaFF1ZXVlKEFic3RyYWN0
UXVldWUpOgpAQCAtMjAzLDcgKzIxMiw4IEBAIGNsYXNzIENvbW1pdFF1ZXVlKEFic3RyYWN0UGF0
Y2hRdWV1ZSwgU3RlcFNlcXVlbmNlRXJyb3JIYW5kbGVyKToKICAgICAgICAgICAgICAgICAiLS1i
dWlsZC1zdHlsZT1ib3RoIiwKICAgICAgICAgICAgICAgICAiLS1xdWlldCJdKQogICAgICAgICBl
eGNlcHQgU2NyaXB0RXJyb3IsIGU6Ci0gICAgICAgICAgICBzZWxmLl91cGRhdGVfc3RhdHVzKCJV
bmFibGUgdG8gc3VjY2Vzc2Z1bGx5IGJ1aWxkIGFuZCB0ZXN0IiwgTm9uZSkKKyAgICAgICAgICAg
IGZhaWx1cmVfbG9nID0gc2VsZi5fbG9nX2Zyb21fc2NyaXB0X2Vycm9yX2Zvcl91cGxvYWQoZSkK
KyAgICAgICAgICAgIHNlbGYuX3VwZGF0ZV9zdGF0dXMoIlVuYWJsZSB0byBzdWNjZXNzZnVsbHkg
YnVpbGQgYW5kIHRlc3QiLCByZXN1bHRzX2ZpbGU9ZmFpbHVyZV9sb2cpCiAgICAgICAgICAgICBy
ZXR1cm4gRmFsc2UKICAgICAgICAgcmV0dXJuIFRydWUKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v
bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlc191bml0dGVzdC5weSBiL1dl
YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXNfdW5pdHRlc3Qu
cHkKaW5kZXggZjgyZWIxOTRmMWYzN2I5NzQzNzMxZDUzNjIzZjU4Y2Y5ZWJkOTIwZS4uY2VjMGM2
MzI5Y2Y1YzM5OGIyMjViMGVhNmNkNGMyZGMxZjFhZTIyNiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v
bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlc191bml0dGVzdC5weQorKysg
Yi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzX3VuaXR0
ZXN0LnB5CkBAIC05OSw2ICs5OSwxOCBAQCBjbGFzcyBBYnN0cmFjdFF1ZXVlVGVzdChDb21tYW5k
c1Rlc3QpOgogICAgICAgICBzZWxmLmFzc2VydFRydWUocXVldWUuc2hvdWxkX2NvbnRpbnVlX3dv
cmtfcXVldWUoKSkKICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHF1ZXVlLnNob3VsZF9jb250aW51
ZV93b3JrX3F1ZXVlKCkpCiAKKyAgICBkZWYgX2Fzc2VydF9sb2dfbWVzc2FnZShzZWxmLCBzY3Jp
cHRfZXJyb3IsIGxvZ19tZXNzYWdlKToKKyAgICAgICAgZmFpbHVyZV9sb2cgPSBBYnN0cmFjdFF1
ZXVlLl9sb2dfZnJvbV9zY3JpcHRfZXJyb3JfZm9yX3VwbG9hZChzY3JpcHRfZXJyb3IsIG91dHB1
dF9saW1pdD0xMCkKKyAgICAgICAgc2VsZi5hc3NlcnRUcnVlKGZhaWx1cmVfbG9nLnJlYWQoKSwg
bG9nX21lc3NhZ2UpCisKKyAgICBkZWYgdGVzdF9sb2dfZnJvbV9zY3JpcHRfZXJyb3JfZm9yX3Vw
bG9hZChzZWxmKToKKyAgICAgICAgc2VsZi5fYXNzZXJ0X2xvZ19tZXNzYWdlKFNjcmlwdEVycm9y
KCJ0ZXN0IiksICJ0ZXN0IikKKyAgICAgICAgdW5pY29kZV90b3IgPSB1IldlYktpdCBcdTI2NjEg
VG9yIEFybmUgVmVzdGJcdTAwRjghIgorICAgICAgICB1dGY4X3RvciA9IHVuaWNvZGVfdG9yLmVu
Y29kZSgidXRmLTgiKQorICAgICAgICBzZWxmLl9hc3NlcnRfbG9nX21lc3NhZ2UoU2NyaXB0RXJy
b3IodW5pY29kZV90b3IpLCB1dGY4X3RvcikKKyAgICAgICAgc2NyaXB0X2Vycm9yID0gU2NyaXB0
RXJyb3IodW5pY29kZV90b3IsIG91dHB1dD11bmljb2RlX3RvcikKKyAgICAgICAgZXhwZWN0ZWRf
b3V0cHV0ID0gIiVzXG5MYXN0ICVzIGNoYXJhY3RlcnMgb2Ygb3V0cHV0OlxuJXMiICUgKHV0Zjhf
dG9yLCAxMCwgdXRmOF90b3JbLTEwOl0pCisgICAgICAgIHNlbGYuX2Fzc2VydF9sb2dfbWVzc2Fn
ZShzY3JpcHRfZXJyb3IsIGV4cGVjdGVkX291dHB1dCkKIAogY2xhc3MgQWJzdHJhY3RSZXZpZXdR
dWV1ZVRlc3QoQ29tbWFuZHNUZXN0KToKICAgICBkZWYgdGVzdF9wYXRjaF9jb2xsZWN0aW9uX2Rl
bGVnYXRlX21ldGhvZHMoc2VsZik6Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65369</attachid>
            <date>2010-08-24 22:10:05 -0700</date>
            <delta_ts>2010-08-24 22:11:28 -0700</delta_ts>
            <desc>Addressed Adam&apos;s comments</desc>
            <filename>bug-41820-20100824221004.patch</filename>
            <type>text/plain</type>
            <size>6847</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCBhNDhiNDA4MWNlNDdlMDkzODFhMGY1NTRjNjNhYzQ1MTIyYjI5OTI3Li5iY2ZkYTBh
ZWIwOTdmNTc1NTYxNmJmNjRiODhhZDA2YjJmMGM4ZWUxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s
cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAK
IDIwMTAtMDgtMjQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbW1pdC1xdWV1ZSBhbmQgRVdT
IGJvdHMgc2hvdWxkIHJlcG9ydCBhbGwgZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxODIwCisKKyAgICAgICAgUmlnaHQgbm93IGNvbW1p
dC1xdWV1ZS9FV1Mgb25seSByZXBvcnQgZmFpbHVyZXMgd2hlbiB0aGUKKyAgICAgICAgcGF0Y2gg
dW5kZXIgdGVzdGluZyBmYWlscy4gIFdlIHNob3VsZCByZXBvcnQgYWxsIGZhaWx1cmVzCisgICAg
ICAgIHRvIHRoZSBzdGF0dXMgc2VydmVyIHNvIHRoYXQgd2UgY2FuIGRpYWdub3NlIHdoZW4gdGhl
IGJvdHMKKyAgICAgICAgYXJlIHdlZGdlZCB3L28gbmVlZGluZyB0byBsb2cgaW50byB0aGUgbWFj
aGluZXMuCisKKyAgICAgICAgSSBhbHNvIHJlZHVjZWQgdGhlIGFtb3VudCBvZiBkYXRhIHdlIHVw
bG9hZCBzaW5jZSB3ZSd2ZSBzZWVuCisgICAgICAgIHRpbWVvdXRzIGR1cmluZyBzdGF0dXMgdXBs
b2FkLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2
ZS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJu
aW5nc3lzdGVtLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9x
dWV1ZXMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVl
c191bml0dGVzdC5weToKKworMjAxMC0wOC0yNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5v
cmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KIAogICAgICAgICBSZW1vdmUg
SFRNTDUgcGFyc2VyIHRlc3RpbmcgaW5mcmFzdHJ1Y3R1cmUgbm93IHRoYXQgd2UgZG9uJ3QgbmVl
ZCBpdApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lz
dGVtL2V4ZWN1dGl2ZS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5
c3RlbS9leGVjdXRpdmUucHkKaW5kZXggNjA4ODY4MGFiYTUzMmZhOGJkN2NiNjY2MTI4MWRlOGQy
YzM0MzM2Zi4uN2MwMGYyMjQ3MTdjZDc2MWNiNTE1NmVmOTA1MjUzNzMwYzdhZTBiMyAxMDA2NDQK
LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2
ZS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhl
Y3V0aXZlLnB5CkBAIC03MywxMCArNzMsMTAgQEAgY2xhc3MgU2NyaXB0RXJyb3IoRXhjZXB0aW9u
KToKICAgICBkZWYgbWVzc2FnZV93aXRoX291dHB1dChzZWxmLCBvdXRwdXRfbGltaXQ9NTAwKToK
ICAgICAgICAgaWYgc2VsZi5vdXRwdXQ6CiAgICAgICAgICAgICBpZiBvdXRwdXRfbGltaXQgYW5k
IGxlbihzZWxmLm91dHB1dCkgPiBvdXRwdXRfbGltaXQ6Ci0gICAgICAgICAgICAgICAgcmV0dXJu
ICIlc1xuTGFzdCAlcyBjaGFyYWN0ZXJzIG9mIG91dHB1dDpcbiVzIiAlIFwKKyAgICAgICAgICAg
ICAgICByZXR1cm4gdSIlc1xuTGFzdCAlcyBjaGFyYWN0ZXJzIG9mIG91dHB1dDpcbiVzIiAlIFwK
ICAgICAgICAgICAgICAgICAgICAgKHNlbGYsIG91dHB1dF9saW1pdCwgc2VsZi5vdXRwdXRbLW91
dHB1dF9saW1pdDpdKQotICAgICAgICAgICAgcmV0dXJuICIlc1xuJXMiICUgKHNlbGYsIHNlbGYu
b3V0cHV0KQotICAgICAgICByZXR1cm4gc3RyKHNlbGYpCisgICAgICAgICAgICByZXR1cm4gdSIl
c1xuJXMiICUgKHNlbGYsIHNlbGYub3V0cHV0KQorICAgICAgICByZXR1cm4gdW5pY29kZShzZWxm
KQogCiAgICAgZGVmIGNvbW1hbmRfbmFtZShzZWxmKToKICAgICAgICAgY29tbWFuZF9wYXRoID0g
c2VsZi5zY3JpcHRfYXJncwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw
eS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weSBiL1dlYktpdFRvb2xzL1Njcmlw
dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkKaW5kZXggNzUw
YmJmZDhlMzMwNzI2ZjY3Y2U3N2FjNzRiNGY4YjhkZWU4MzZlZi4uNDMyYTg3NzA3Yjk2OTM0YjQ2
MTgwM2RiYzEyZDNlZGQ0YTNiYmJmNSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93
ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQorKysgYi9XZWJLaXRU
b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5
CkBAIC01NSw3ICs1NSw4IEBAIGNsYXNzIEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVtKEFic3Ry
YWN0UmV2aWV3UXVldWUpOgogICAgICAgICAgICAgICAgICItLXF1aWV0Il0pCiAgICAgICAgICAg
ICByZXR1cm4gVHJ1ZQogICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3IsIGU6Ci0gICAgICAgICAg
ICBzZWxmLl91cGRhdGVfc3RhdHVzKCJVbmFibGUgdG8gcGVyZm9ybSBhIGJ1aWxkIikKKyAgICAg
ICAgICAgIGZhaWx1cmVfbG9nID0gc2VsZi5fbG9nX2Zyb21fc2NyaXB0X2Vycm9yX2Zvcl91cGxv
YWQoZSkKKyAgICAgICAgICAgIHNlbGYuX3VwZGF0ZV9zdGF0dXMoIlVuYWJsZSB0byBwZXJmb3Jt
IGEgYnVpbGQiLCByZXN1bHRzX2ZpbGU9ZmFpbHVyZV9sb2cpCiAgICAgICAgICAgICByZXR1cm4g
RmFsc2UKIAogICAgIGRlZiBfYnVpbGQoc2VsZiwgcGF0Y2gsIGZpcnN0X3J1bj1GYWxzZSk6CmRp
ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVl
dWVzLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVl
cy5weQppbmRleCA5N2MzZGRiMWRjMDE0YjgxMzk0NWQ1ZDhiNjc3ODQ1YWUwODRiYjljLi40ZDJh
OWRmZDA5OGFkZDlhYWViNTBjMDY4OWVmM2NkZWIyY2YwNTQ1IDEwMDY0NAotLS0gYS9XZWJLaXRU
b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CisrKyBiL1dlYktp
dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkKQEAgLTEyMCwx
NSArMTIwLDI0IEBAIGNsYXNzIEFic3RyYWN0UXVldWUoQ29tbWFuZCwgUXVldWVFbmdpbmVEZWxl
Z2F0ZSk6CiAgICAgICAgIHJldHVybiBlbmdpbmUoc2VsZi5uYW1lLCBzZWxmLCBzZWxmLnRvb2wu
d2FrZXVwX2V2ZW50KS5ydW4oKQogCiAgICAgQGNsYXNzbWV0aG9kCisgICAgZGVmIF9sb2dfZnJv
bV9zY3JpcHRfZXJyb3JfZm9yX3VwbG9hZChjbHMsIHNjcmlwdF9lcnJvciwgb3V0cHV0X2xpbWl0
PU5vbmUpOgorICAgICAgICAjIFdlIGhhdmUgc2VlbiByZXF1ZXN0IHRpbWVvdXRzIHdpdGggYXBw
IGVuZ2luZSBkdWUgdG8gbGFyZ2UKKyAgICAgICAgIyBsb2cgdXBsb2Fkcy4gIFRyeWluZyBvbmx5
IHRoZSBsYXN0IDUxMmsuCisgICAgICAgIGlmIG5vdCBvdXRwdXRfbGltaXQ6CisgICAgICAgICAg
ICBvdXRwdXRfbGltaXQgPSA1MTIgKiAxMDI0ICAjIDUxMmsKKyAgICAgICAgb3V0cHV0ID0gc2Ny
aXB0X2Vycm9yLm1lc3NhZ2Vfd2l0aF9vdXRwdXQob3V0cHV0X2xpbWl0PW91dHB1dF9saW1pdCkK
KyAgICAgICAgIyBXZSBwcmUtZW5jb2RlIHRoZSBzdHJpbmcgdG8gYSBieXRlIGFycmF5IGJlZm9y
ZSBwYXNzaW5nIGl0CisgICAgICAgICMgdG8gc3RhdHVzX3NlcnZlciwgYmVjYXVzZSBDbGllbnRG
b3JtIChwYXJ0IG9mIG1lY2hhbml6ZSkKKyAgICAgICAgIyB3YW50cyBhIGZpbGUtbGlrZSBvYmpl
Y3Qgd2l0aCBwcmUtZW5jb2RlZCBkYXRhLgorICAgICAgICByZXR1cm4gU3RyaW5nSU8ob3V0cHV0
LmVuY29kZSgidXRmLTgiKSkKKworICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBfdXBkYXRlX3N0
YXR1c19mb3Jfc2NyaXB0X2Vycm9yKGNscywgdG9vbCwgc3RhdGUsIHNjcmlwdF9lcnJvciwgaXNf
ZXJyb3I9RmFsc2UpOgogICAgICAgICBtZXNzYWdlID0gc3RyKHNjcmlwdF9lcnJvcikKICAgICAg
ICAgaWYgaXNfZXJyb3I6CiAgICAgICAgICAgICBtZXNzYWdlID0gIkVycm9yOiAlcyIgJSBtZXNz
YWdlCi0gICAgICAgIG91dHB1dCA9IHNjcmlwdF9lcnJvci5tZXNzYWdlX3dpdGhfb3V0cHV0KG91
dHB1dF9saW1pdD0xMDI0KjEwMjQpICMgMU1CCi0gICAgICAgICMgV2UgcHJlLWVuY29kZSB0aGUg
c3RyaW5nIHRvIGEgYnl0ZSBhcnJheSBiZWZvcmUgcGFzc2luZyBpdAotICAgICAgICAjIHRvIHN0
YXR1c19zZXJ2ZXIsIGJlY2F1c2UgQ2xpZW50Rm9ybSAocGFydCBvZiBtZWNoYW5pemUpCi0gICAg
ICAgICMgd2FudHMgYSBmaWxlLWxpa2Ugb2JqZWN0IHdpdGggcHJlLWVuY29kZWQgZGF0YS4KLSAg
ICAgICAgcmV0dXJuIHRvb2wuc3RhdHVzX3NlcnZlci51cGRhdGVfc3RhdHVzKGNscy5uYW1lLCBt
ZXNzYWdlLCBzdGF0ZVsicGF0Y2giXSwgU3RyaW5nSU8ob3V0cHV0LmVuY29kZSgidXRmLTgiKSkp
CisgICAgICAgIGZhaWx1cmVfbG9nID0gY2xzLl9sb2dfZnJvbV9zY3JpcHRfZXJyb3JfZm9yX3Vw
bG9hZChzY3JpcHRfZXJyb3IpCisgICAgICAgIHJldHVybiB0b29sLnN0YXR1c19zZXJ2ZXIudXBk
YXRlX3N0YXR1cyhjbHMubmFtZSwgbWVzc2FnZSwgc3RhdGVbInBhdGNoIl0sIGZhaWx1cmVfbG9n
KQogCiAKIGNsYXNzIEFic3RyYWN0UGF0Y2hRdWV1ZShBYnN0cmFjdFF1ZXVlKToKQEAgLTIwMyw3
ICsyMTIsOCBAQCBjbGFzcyBDb21taXRRdWV1ZShBYnN0cmFjdFBhdGNoUXVldWUsIFN0ZXBTZXF1
ZW5jZUVycm9ySGFuZGxlcik6CiAgICAgICAgICAgICAgICAgIi0tYnVpbGQtc3R5bGU9Ym90aCIs
CiAgICAgICAgICAgICAgICAgIi0tcXVpZXQiXSkKICAgICAgICAgZXhjZXB0IFNjcmlwdEVycm9y
LCBlOgotICAgICAgICAgICAgc2VsZi5fdXBkYXRlX3N0YXR1cygiVW5hYmxlIHRvIHN1Y2Nlc3Nm
dWxseSBidWlsZCBhbmQgdGVzdCIsIE5vbmUpCisgICAgICAgICAgICBmYWlsdXJlX2xvZyA9IHNl
bGYuX2xvZ19mcm9tX3NjcmlwdF9lcnJvcl9mb3JfdXBsb2FkKGUpCisgICAgICAgICAgICBzZWxm
Ll91cGRhdGVfc3RhdHVzKCJVbmFibGUgdG8gc3VjY2Vzc2Z1bGx5IGJ1aWxkIGFuZCB0ZXN0Iiwg
cmVzdWx0c19maWxlPWZhaWx1cmVfbG9nKQogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAgICAg
ICAgIHJldHVybiBUcnVlCiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0
cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXNfdW5pdHRlc3QucHkgYi9XZWJLaXRUb29scy9TY3JpcHRz
L3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzX3VuaXR0ZXN0LnB5CmluZGV4IGY4MmViMTk0
ZjFmMzdiOTc0MzczMWQ1MzYyM2Y1OGNmOWViZDkyMGUuLjk5ZjM4NmVlNDIyMWE1ZWJiMzk3MjZj
NzIzODYxMGVjOTgzNjAyMDkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0
cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXNfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2Ny
aXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlc191bml0dGVzdC5weQpAQCAtOTksNiAr
OTksMTkgQEAgY2xhc3MgQWJzdHJhY3RRdWV1ZVRlc3QoQ29tbWFuZHNUZXN0KToKICAgICAgICAg
c2VsZi5hc3NlcnRUcnVlKHF1ZXVlLnNob3VsZF9jb250aW51ZV93b3JrX3F1ZXVlKCkpCiAgICAg
ICAgIHNlbGYuYXNzZXJ0VHJ1ZShxdWV1ZS5zaG91bGRfY29udGludWVfd29ya19xdWV1ZSgpKQog
CisgICAgZGVmIF9hc3NlcnRfbG9nX21lc3NhZ2Uoc2VsZiwgc2NyaXB0X2Vycm9yLCBsb2dfbWVz
c2FnZSk6CisgICAgICAgIGZhaWx1cmVfbG9nID0gQWJzdHJhY3RRdWV1ZS5fbG9nX2Zyb21fc2Ny
aXB0X2Vycm9yX2Zvcl91cGxvYWQoc2NyaXB0X2Vycm9yLCBvdXRwdXRfbGltaXQ9MTApCisgICAg
ICAgIHNlbGYuYXNzZXJ0VHJ1ZShmYWlsdXJlX2xvZy5yZWFkKCksIGxvZ19tZXNzYWdlKQorCisg
ICAgZGVmIHRlc3RfbG9nX2Zyb21fc2NyaXB0X2Vycm9yX2Zvcl91cGxvYWQoc2VsZik6CisgICAg
ICAgIHNlbGYuX2Fzc2VydF9sb2dfbWVzc2FnZShTY3JpcHRFcnJvcigidGVzdCIpLCAidGVzdCIp
CisgICAgICAgIHVuaWNvZGVfdG9yID0gdSJXZWJLaXQgXHUyNjYxIFRvciBBcm5lIFZlc3RiXHUw
MEY4ISIKKyAgICAgICAgdXRmOF90b3IgPSB1bmljb2RlX3Rvci5lbmNvZGUoInV0Zi04IikKKyAg
ICAgICAgc2VsZi5fYXNzZXJ0X2xvZ19tZXNzYWdlKFNjcmlwdEVycm9yKHVuaWNvZGVfdG9yKSwg
dXRmOF90b3IpCisgICAgICAgIHNjcmlwdF9lcnJvciA9IFNjcmlwdEVycm9yKHVuaWNvZGVfdG9y
LCBvdXRwdXQ9dW5pY29kZV90b3IpCisgICAgICAgIGV4cGVjdGVkX291dHB1dCA9ICIlc1xuTGFz
dCAlcyBjaGFyYWN0ZXJzIG9mIG91dHB1dDpcbiVzIiAlICh1dGY4X3RvciwgMTAsIHV0ZjhfdG9y
Wy0xMDpdKQorICAgICAgICBzZWxmLl9hc3NlcnRfbG9nX21lc3NhZ2Uoc2NyaXB0X2Vycm9yLCBl
eHBlY3RlZF9vdXRwdXQpCisKIAogY2xhc3MgQWJzdHJhY3RSZXZpZXdRdWV1ZVRlc3QoQ29tbWFu
ZHNUZXN0KToKICAgICBkZWYgdGVzdF9wYXRjaF9jb2xsZWN0aW9uX2RlbGVnYXRlX21ldGhvZHMo
c2VsZik6Cg==
</data>
<flag name="review"
          id="54135"
          type_id="1"
          status="+"
          setter="abarth"
    />
    <flag name="commit-queue"
          id="54136"
          type_id="3"
          status="+"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>