41810 2010-07-07 16:19:51 -0700 AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area 2010-07-07 18:04:35 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach bdakin oldest_to_newest 247835 0 cfleizach 2010-07-07 16:19:51 -0700 A text area in a webpage will return a null value for AXSelectedTextRange if the cursor is not in the text range. It should return a text range of 0,0 instead Here's webkit AXSelectedText (W): "" AXSelectedTextRange (W): "(null)" here's TextEdit AXSelectedText (W): "" AXSelectedTextRange (W): "pos=0 len=0" 247840 1 60799 cfleizach 2010-07-07 16:25:24 -0700 Created attachment 60799 Patch 247887 2 60799 darin 2010-07-07 17:41:45 -0700 Comment on attachment 60799 Patch Is this better? It returns the same value it would if the insertion point was at the start of the text area. It seems to me that a blinking insertion point is different from not having selection at all. r=me 247907 3 cfleizach 2010-07-07 17:56:37 -0700 (In reply to comment #2) > (From update of attachment 60799 [details]) > Is this better? It returns the same value it would if the insertion point was at the start of the text area. It seems to me that a blinking insertion point is different from not having selection at all. > > r=me This matches TextEdit and Cocoa behavior. I had come across a VoiceOver bug a while ago that was relying on this value not being nil. When nil is returned, that usually propagates back a AX error. I think we should match Cocoa behavior in this case. 247912 4 cfleizach 2010-07-07 18:04:35 -0700 http://trac.webkit.org/changeset/62735 60799 2010-07-07 16:25:24 -0700 2010-07-07 17:41:45 -0700 Patch bug-41810-20100707162523.patch text/plain 5920 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MjcyNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDctMDcgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBWDogVGV4dEFyZWEgc2hvdWxkIHJldHVybiBBWFNlbGVjdGVkVGV4dFJhbmdlIG9mIDAsMCBp ZiB0aGUgY3Vyc29yIGlzIG5vdCBpbiB0aGUgdGV4dCBhcmVhCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTgxMAorCisgICAgICAgIFRlc3Q6IHBsYXRm b3JtL21hYy9hY2Nlc3NpYmlsaXR5L3NlbGVjdGVkLXRleHQtcmFuZ2UtZm9yLWVtcHR5LXRleHRh cmVhLmh0bWwKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL0FjY2Vzc2liaWxpdHlPYmpl Y3RXcmFwcGVyLm1tOgorICAgICAgICAoLVtBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBhY2Nl c3NpYmlsaXR5QXR0cmlidXRlVmFsdWU6XSk6CisKIDIwMTAtMDctMDcgIENocmlzIEZsZWl6YWNo ICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBCZXRoIERha2lu LgpJbmRleDogV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9BY2Nlc3NpYmlsaXR5T2JqZWN0V3Jh cHBlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL0FjY2Vzc2li aWxpdHlPYmplY3RXcmFwcGVyLm1tCShyZXZpc2lvbiA2MjcxMikKKysrIFdlYkNvcmUvYWNjZXNz aWJpbGl0eS9tYWMvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIubW0JKHdvcmtpbmcgY29weSkK QEAgLTE0NjUsNyArMTQ2NSw3IEBAIC0gKGlkKWFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZToo TlNTdHIKICAgICAgICAgaWYgKFthdHRyaWJ1dGVOYW1lIGlzRXF1YWxUb1N0cmluZzogTlNBY2Nl c3NpYmlsaXR5U2VsZWN0ZWRUZXh0UmFuZ2VBdHRyaWJ1dGVdKSB7CiAgICAgICAgICAgICBQbGFp blRleHRSYW5nZSB0ZXh0UmFuZ2UgPSBtX29iamVjdC0+c2VsZWN0ZWRUZXh0UmFuZ2UoKTsKICAg ICAgICAgICAgIGlmICh0ZXh0UmFuZ2UuaXNOdWxsKCkpCi0gICAgICAgICAgICAgICAgcmV0dXJu IG5pbDsKKyAgICAgICAgICAgICAgICByZXR1cm4gW05TVmFsdWUgdmFsdWVXaXRoUmFuZ2U6TlNN YWtlUmFuZ2UoMCwgMCldOwogICAgICAgICAgICAgcmV0dXJuIFtOU1ZhbHVlIHZhbHVlV2l0aFJh bmdlOk5TTWFrZVJhbmdlKHRleHRSYW5nZS5zdGFydCwgdGV4dFJhbmdlLmxlbmd0aCldOwogICAg ICAgICB9CiAgICAgICAgIC8vIFRPRE86IEdldCBhY3R1YWwgdmlzaWJsZSByYW5nZS4gPHJkYXI6 Ly9wcm9ibGVtLzQ3MTIxMDE+CkluZGV4OiBXZWJLaXRUb29scy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2MjcyNikKKysrIFdlYktpdFRv b2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA3LTA3 ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQVg6IFRleHRBcmVhIHNob3VsZCByZXR1 cm4gQVhTZWxlY3RlZFRleHRSYW5nZSBvZiAwLDAgaWYgdGhlIGN1cnNvciBpcyBub3QgaW4gdGhl IHRleHQgYXJlYQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDE4MTAKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9BY2Nlc3NpYmlsaXR5VUlF bGVtZW50TWFjLm1tOgorICAgICAgICAoQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6c2VsZWN0ZWRU ZXh0UmFuZ2UpOgorCiAyMDEwLTA3LTA3ICBCcmlhbiBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFw cGxlLmNvbT4KIAogICAgICAgICBGaXggdGhlIFdpbmRvd3MgYnVpbGQgYnkgcmVtb3Zpbmcgd2lu L1Rlc3ROZXRzY2FwZVBsdWdpbi9tYWluLmNwcCBmcm9tIHRoZQpJbmRleDogV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1l bnRNYWMubW0JKHJldmlzaW9uIDYyNzEyKQorKysgV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUv bWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTEwMDAs OSArMTAwMCw5IEBAIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQgQWNjZXNzaWJpbGl0eVVJRWwKIAog SlNTdHJpbmdSZWYgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6c2VsZWN0ZWRUZXh0UmFuZ2UoKQog ewotICAgIE5TUmFuZ2UgcmFuZ2UgPSBOU01ha2VSYW5nZSgwLDApOworICAgIE5TUmFuZ2UgcmFu Z2UgPSBOU01ha2VSYW5nZShOU05vdEZvdW5kLCAwKTsKICAgICBCRUdJTl9BWF9PQkpDX0VYQ0VQ VElPTlMKLSAgICBOU051bWJlciAqaW5kZXhSYW5nZSA9IFttX2VsZW1lbnQgYWNjZXNzaWJpbGl0 eUF0dHJpYnV0ZVZhbHVlOk5TQWNjZXNzaWJpbGl0eVNlbGVjdGVkVGV4dFJhbmdlQXR0cmlidXRl XTsKKyAgICBOU1ZhbHVlICppbmRleFJhbmdlID0gW21fZWxlbWVudCBhY2Nlc3NpYmlsaXR5QXR0 cmlidXRlVmFsdWU6TlNBY2Nlc3NpYmlsaXR5U2VsZWN0ZWRUZXh0UmFuZ2VBdHRyaWJ1dGVdOwog ICAgIGlmIChpbmRleFJhbmdlKQogICAgICAgICByYW5nZSA9IFtpbmRleFJhbmdlIHJhbmdlVmFs dWVdOwogICAgIE5TTXV0YWJsZVN0cmluZyAqcmFuZ2VEZXNjcmlwdGlvbiA9IFtOU011dGFibGVT dHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAInslZCwgJWR9IixyYW5nZS5sb2NhdGlvbiwgcmFuZ2Uu bGVuZ3RoXTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDYyNzI2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMDcgIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBWDogVGV4dEFyZWEgc2hvdWxkIHJldHVybiBBWFNlbGVj dGVkVGV4dFJhbmdlIG9mIDAsMCBpZiB0aGUgY3Vyc29yIGlzIG5vdCBpbiB0aGUgdGV4dCBhcmVh CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTgxMAor CisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VsZWN0ZWQtdGV4dC1yYW5n ZS1mb3ItZW1wdHktdGV4dGFyZWEtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0 Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9zZWxlY3RlZC10ZXh0LXJhbmdlLWZvci1lbXB0eS10ZXh0 YXJlYS5odG1sOiBBZGRlZC4KKwogMjAxMC0wNy0wNyAgUGV0ZXIgS2FzdGluZyAgPHBrYXN0aW5n QGdvb2dsZS5jb20+CiAKICAgICAgICAgTm90IHJldmlld2VkLiAgQ2hyb21pdW0gdGVzdCBleHBl Y3RhdGlvbiB1cGRhdGUuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJp bGl0eS9zZWxlY3RlZC10ZXh0LXJhbmdlLWZvci1lbXB0eS10ZXh0YXJlYS1leHBlY3RlZC50eHQK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2Vs ZWN0ZWQtdGV4dC1yYW5nZS1mb3ItZW1wdHktdGV4dGFyZWEtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VsZWN0ZWQt dGV4dC1yYW5nZS1mb3ItZW1wdHktdGV4dGFyZWEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDExIEBACisKK1RoaXMgdGVzdHMgdGhhdCB0aGUgQVhTZWxlY3RlZFRleHRSYW5n ZSBmb3IgYSB0ZXh0IGFyZWEgd2lsbCBiZSAwLCAwIGluc3RlYWQgb2YgbmlsLgorCitPbiBzdWNj ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBi eSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBvYmouc2VsZWN0ZWRUZXh0UmFuZ2UgaXMgJ3sw LCAwfScKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQor CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9zZWxlY3RlZC10 ZXh0LXJhbmdlLWZvci1lbXB0eS10ZXh0YXJlYS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3NlbGVjdGVkLXRleHQtcmFuZ2UtZm9yLWVt cHR5LXRleHRhcmVhLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvYWNjZXNzaWJpbGl0eS9zZWxlY3RlZC10ZXh0LXJhbmdlLWZvci1lbXB0eS10ZXh0YXJlYS5o dG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDM1IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMg Ii0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHls ZXNoZWV0IiBocmVmPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNz cyI+Cis8c2NyaXB0PgordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IGZhbHNlOworPC9zY3JpcHQ+ Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMi Pjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgaWQ9ImJvZHkiPgorCis8dGV4dGFyZWEgaWQ9InRl eHRhcmVhIiB0YWJpbmRleD0wPjwvdGV4dGFyZWE+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9w PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisKKyAgICBkZXNjcmlwdGlv bigiVGhpcyB0ZXN0cyB0aGF0IHRoZSBBWFNlbGVjdGVkVGV4dFJhbmdlIGZvciBhIHRleHQgYXJl YSB3aWxsIGJlIDAsIDAgaW5zdGVhZCBvZiBuaWwuIik7CisKKyAgICBpZiAod2luZG93LmFjY2Vz c2liaWxpdHlDb250cm9sbGVyKSB7CisKKyAgICAgICAgICAvLyB0aGlzIHRleHQgZmllbGQgc2hv dWxkIGJlIHJlcXVpcmVkLgorICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXh0 YXJlYSIpLmZvY3VzKCk7CisgICAgICAgICAgdmFyIG9iaiA9IGFjY2Vzc2liaWxpdHlDb250cm9s bGVyLmZvY3VzZWRFbGVtZW50OworCisgICAgICAgICAgc2hvdWxkQmUoIm9iai5zZWxlY3RlZFRl eHRSYW5nZSIsICInezAsIDB9JyIpOworICAgIH0KKworICAgIHN1Y2Nlc3NmdWxseVBhcnNlZCA9 IHRydWU7Cis8L3NjcmlwdD4KKworPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3Vy Y2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==