41804 2010-07-07 14:51:50 -0700 Disable MSVC warning 4288 2010-07-07 15:20:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi andersca aroben oldest_to_newest 247780 0 dumi 2010-07-07 14:51:50 -0700 MSVC has a non-standard extension (/Ze /Zc:forScope) that allows variables declared in for-loops to remain in the "outer" scope: http://msdn.microsoft.com/en-us/library/bk5hc10s.aspx. When the same variable is re-declared after the for-loop, the compiler issues warning C4288. There's also a bug in VS2005 that enables this extension even if the /Zc:forScope option wasn't specified: http://connect.microsoft.com/VisualStudio/feedback/details/338010/bogus-compiler-warning-c4288. Looks like we got hit by that bug, so we need to disable that warning. 247789 1 60785 dumi 2010-07-07 15:05:22 -0700 Created attachment 60785 patch 247791 2 60785 aroben 2010-07-07 15:08:37 -0700 Comment on attachment 60785 patch > + MSVC has a non-standard extension (/Ze /Zc:forScope-) that allows > + variables declared in for-loops to remain visible in the same > + scope even after the for-loop > + (http://msdn.microsoft.com/en-us/library/bk5hc10s.aspx). When this > + extension is enabled, re-declaring the same variable in that scope > + results in a C4288 warning. > + > + At the same time, there seems to be a bug in VS2005 that > + erroneously enables /Zc:forScope- even when that option is not > + specified > + (http://connect.microsoft.com/VisualStudio/feedback/details/338010/bogus-compiler-warning-c4288). This makes it sound like the actual behavior gets enabled, not just the warning. Explaining in the previous paragraph that /Ze turns on the behavior and /Zc:forScope- turns on the warning could clear this up, as could changing the description in this paragraph. Other than that, r=me 247796 3 dumi 2010-07-07 15:13:49 -0700 (In reply to comment #2) > (From update of attachment 60785 [details]) > > + MSVC has a non-standard extension (/Ze /Zc:forScope-) that allows > > + variables declared in for-loops to remain visible in the same > > + scope even after the for-loop > > + (http://msdn.microsoft.com/en-us/library/bk5hc10s.aspx). When this > > + extension is enabled, re-declaring the same variable in that scope > > + results in a C4288 warning. > > + > > + At the same time, there seems to be a bug in VS2005 that > > + erroneously enables /Zc:forScope- even when that option is not > > + specified > > + (http://connect.microsoft.com/VisualStudio/feedback/details/338010/bogus-compiler-warning-c4288). > > This makes it sound like the actual behavior gets enabled, not just the warning. Explaining in the previous paragraph that /Ze turns on the behavior and /Zc:forScope- turns on the warning could clear this up, as could changing the description in this paragraph. done. made it more clear that /Ze enables all MSVC extensions and /Zc:forScope- tells the compiler to issue a warning when it sees the same variable declared in a for-loop and then re-declared in the same scope. 247800 4 dumi 2010-07-07 15:20:52 -0700 landed: r62708. 60785 2010-07-07 15:05:22 -0700 2010-07-07 15:08:37 -0700 patch patch text/plain 3360 dumi SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYyNzA0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMDcgIER1bWl0cnUg RGFuaWxpdWMgIDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZXZlcnQgcjYyNjg5LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE4MDQKKworICAgICAgICAqIHJ1bnRpbWUv Q29sbGVjdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6ZnJlZUJsb2Nrcyk6CisKIDIwMTAt MDctMDcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTYW0gV2VpbmlnLgpJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2xsZWN0b3Iu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29sbGVjdG9yLmNwcAko cmV2aXNpb24gNjI3MDQpCisrKyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTMxNSwxMyArMzE1LDEwIEBAIHZvaWQgSGVhcDo6ZnJlZUJsb2Nr cygpCiAKICAgICBtX2hlYXAubmV4dENlbGwgPSAwOwogICAgIG1faGVhcC5uZXh0QmxvY2sgPSAw OwotCi0gICAgewotICAgICAgICBEZWFkT2JqZWN0SXRlcmF0b3IgaXQobV9oZWFwLCBtX2hlYXAu bmV4dEJsb2NrLCBtX2hlYXAubmV4dENlbGwpOwotICAgICAgICBEZWFkT2JqZWN0SXRlcmF0b3Ig ZW5kKG1faGVhcCwgbV9oZWFwLnVzZWRCbG9ja3MpOwotICAgICAgICBmb3IgKCA7IGl0ICE9IGVu ZDsgKytpdCkKLSAgICAgICAgICAgICgqaXQpLT5+SlNDZWxsKCk7Ci0gICAgfQorICAgIERlYWRP YmplY3RJdGVyYXRvciBpdChtX2hlYXAsIG1faGVhcC5uZXh0QmxvY2ssIG1faGVhcC5uZXh0Q2Vs bCk7CisgICAgRGVhZE9iamVjdEl0ZXJhdG9yIGVuZChtX2hlYXAsIG1faGVhcC51c2VkQmxvY2tz KTsKKyAgICBmb3IgKCA7IGl0ICE9IGVuZDsgKytpdCkKKyAgICAgICAgKCppdCktPn5KU0NlbGwo KTsKIAogICAgIEFTU0VSVCghcHJvdGVjdGVkT2JqZWN0Q291bnQoKSk7CiAKSW5kZXg6IFdlYktp dExpYnJhcmllcy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGlicmFyaWVzL0NoYW5n ZUxvZwkocmV2aXNpb24gNjI3MDQpCisrKyBXZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTAtMDctMDcgIER1bWl0cnUgRGFuaWxpdWMg IDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBEaXNhYmxlIE1TVkMgd2FybmluZyA0Mjg4LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE4MDQKKworICAgICAgICBNU1ZDIGhh cyBhIG5vbi1zdGFuZGFyZCBleHRlbnNpb24gKC9aZSAvWmM6Zm9yU2NvcGUtKSB0aGF0IGFsbG93 cworICAgICAgICB2YXJpYWJsZXMgZGVjbGFyZWQgaW4gZm9yLWxvb3BzIHRvIHJlbWFpbiB2aXNp YmxlIGluIHRoZSBzYW1lCisgICAgICAgIHNjb3BlIGV2ZW4gYWZ0ZXIgdGhlIGZvci1sb29wCisg ICAgICAgIChodHRwOi8vbXNkbi5taWNyb3NvZnQuY29tL2VuLXVzL2xpYnJhcnkvYms1aGMxMHMu YXNweCkuIFdoZW4gdGhpcworICAgICAgICBleHRlbnNpb24gaXMgZW5hYmxlZCwgcmUtZGVjbGFy aW5nIHRoZSBzYW1lIHZhcmlhYmxlIGluIHRoYXQgc2NvcGUKKyAgICAgICAgcmVzdWx0cyBpbiBh IEM0Mjg4IHdhcm5pbmcuCisKKyAgICAgICAgQXQgdGhlIHNhbWUgdGltZSwgdGhlcmUgc2VlbXMg dG8gYmUgYSBidWcgaW4gVlMyMDA1IHRoYXQKKyAgICAgICAgZXJyb25lb3VzbHkgZW5hYmxlcyAv WmM6Zm9yU2NvcGUtIGV2ZW4gd2hlbiB0aGF0IG9wdGlvbiBpcyBub3QKKyAgICAgICAgc3BlY2lm aWVkCisgICAgICAgIChodHRwOi8vY29ubmVjdC5taWNyb3NvZnQuY29tL1Zpc3VhbFN0dWRpby9m ZWVkYmFjay9kZXRhaWxzLzMzODAxMC9ib2d1cy1jb21waWxlci13YXJuaW5nLWM0Mjg4KS4gTG9v a3MKKyAgICAgICAgbGlrZSBvdXIgYnVpbGQgZ290IGhpdCBieSB0aGF0IGJ1Zywgc28gd2UgbmVl ZCB0byBkaXNhYmxlIHdhcm5pbmcKKyAgICAgICAgNDI4OCB0byBmaXggaXQuCisKKyAgICAgICAg KiB3aW4vdG9vbHMvdnNwcm9wcy9jb21tb24udnNwcm9wczoKKwogMjAxMC0wNy0wMSAgU2ltb24g RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT YW0gV2VpbmlnLgpJbmRleDogV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL2NvbW1v bi52c3Byb3BzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9w cy9jb21tb24udnNwcm9wcwkocmV2aXNpb24gNjI3MDQpCisrKyBXZWJLaXRMaWJyYXJpZXMvd2lu L3Rvb2xzL3ZzcHJvcHMvY29tbW9uLnZzcHJvcHMJKHdvcmtpbmcgY29weSkKQEAgLTE1LDcgKzE1 LDcgQEAKIAkJV2FybmluZ0xldmVsPSI0IgogCQlXYXJuQXNFcnJvcj0idHJ1ZSIKIAkJRGVidWdJ bmZvcm1hdGlvbkZvcm1hdD0iMyIKLQkJRGlzYWJsZVNwZWNpZmljV2FybmluZ3M9IjQwMTg7NDA2 ODs0MDk5OzQxMDA7NDEyNzs0MTM4OzQxODA7NDE4OTs0MjAxOzQyNDQ7NDI1MTs0Mjc1OzQyOTE7 NDMwNTs0MzQ0OzQzNTU7NDM4OTs0NTAzOzQ1MDU7NDUxMDs0NTEyOzQ2MTA7NDcwNjs0ODAwOzQ5 NTE7NDk1Mjs0OTk2OzYwMTE7NjAzMTs2MjExOzYyNDY7NjI1NTs2Mzg3IgorCQlEaXNhYmxlU3Bl Y2lmaWNXYXJuaW5ncz0iNDAxODs0MDY4OzQwOTk7NDEwMDs0MTI3OzQxMzg7NDE4MDs0MTg5OzQy MDE7NDI0NDs0MjUxOzQyNzU7NDI4ODs0MjkxOzQzMDU7NDM0NDs0MzU1OzQzODk7NDUwMzs0NTA1 OzQ1MTA7NDUxMjs0NjEwOzQ3MDY7NDgwMDs0OTUxOzQ5NTI7NDk5Njs2MDExOzYwMzE7NjIxMTs2 MjQ2OzYyNTU7NjM4NyIKIAkvPgogCTxUb29sCiAJCU5hbWU9IlZDTGlicmFyaWFuVG9vbCIK