41780 2010-07-07 11:28:09 -0700 AX: when an element uses role="text" but no aria-label, it should default to textUnderElement() 2010-07-07 12:49:01 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach bdakin oldest_to_newest 247653 0 cfleizach 2010-07-07 11:28:09 -0700 when an element uses role="text" but no aria-label, it should default to textUnderElement() 247664 1 cfleizach 2010-07-07 11:53:38 -0700 Also found a check in accessibilityIsIgnored that said a textarea or statictext element as defined by aria should be ignored if it has no text. That seems wrong because those elements might just have an empty text 247666 2 60759 cfleizach 2010-07-07 11:56:44 -0700 Created attachment 60759 Patch 247688 3 60759 bdakin 2010-07-07 12:41:31 -0700 Comment on attachment 60759 Patch r=me! 247694 4 cfleizach 2010-07-07 12:49:01 -0700 http://trac.webkit.org/changeset/62691 60759 2010-07-07 11:56:44 -0700 2010-07-07 12:41:31 -0700 Patch bug-41780-20100707115643.patch text/plain 5712 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MjY4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDctMDcgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBWDogd2hlbiBhbiBlbGVtZW50IHVzZXMgcm9sZT0idGV4dCIgYnV0IG5vIGFyaWEtbGFiZWws IGl0IHNob3VsZCBkZWZhdWx0IHRvIHRleHRVbmRlckVsZW1lbnQoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE3ODAKKworICAgICAgICBUZXN0OiBw bGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9zdGF0aWMtdGV4dC1yb2xlLXVzZXMtdGV4dC11bmRl ci1lbGVtZW50Lmh0bWwKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJl bmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0OjpzdHJpbmdWYWx1ZSk6CisgICAgICAgICAgIEZhbGxiYWNrIHRvIHRleHRVbmRlckVsZW1l bnQoKSBpZiB0ZXh0KCkgZG9lcyBub3QgcmV0dXJuIGFueSBleHBsaWNpdGx5IHNldCB0ZXh0Lgor ICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YWNjZXNzaWJpbGl0 eUlzSWdub3JlZCk6IAorICAgICAgICAgICBSZW1vdmUgZXJyb25lb3VzIGNoZWNrIHRvIGlnbm9y ZSB0ZXh0IGVsZW1lbnRzIHRoYXQgZGlkbid0IGhhdmUgYSBleHBsaWNpdCB0ZXh0IHZhbHVlLgor CiAyMDEwLTA3LTA2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBXZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiA2 MjY4MykKKysrIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEwMSw4ICsxMTAxLDEyIEBAIFN0cmluZyBBY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0OjpzdHJpbmcKICAgICBpZiAoIW1fcmVuZGVyZXIgfHwgaXNQYXNz d29yZEZpZWxkKCkpCiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKICAgICAKLSAgICBpZiAoYXJp YVJvbGVBdHRyaWJ1dGUoKSA9PSBTdGF0aWNUZXh0Um9sZSkKLSAgICAgICAgcmV0dXJuIHRleHQo KTsKKyAgICBpZiAoYXJpYVJvbGVBdHRyaWJ1dGUoKSA9PSBTdGF0aWNUZXh0Um9sZSkgeworICAg ICAgICBTdHJpbmcgc3RhdGljVGV4dCA9IHRleHQoKTsKKyAgICAgICAgaWYgKCFzdGF0aWNUZXh0 Lmxlbmd0aCgpKQorICAgICAgICAgICAgc3RhdGljVGV4dCA9IHRleHRVbmRlckVsZW1lbnQoKTsK KyAgICAgICAgcmV0dXJuIHN0YXRpY1RleHQ7CisgICAgfQogICAgICAgICAKICAgICBpZiAobV9y ZW5kZXJlci0+aXNUZXh0KCkpCiAgICAgICAgIHJldHVybiB0ZXh0VW5kZXJFbGVtZW50KCk7CkBA IC0xNzU0LDEyICsxNzU4LDYgQEAgYm9vbCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjphY2Nl c3NpYgogICAgIGlmIChjb250cm9sT2JqZWN0ICYmICFjb250cm9sT2JqZWN0LT5leHBvc2VzVGl0 bGVVSUVsZW1lbnQoKSAmJiBjb250cm9sT2JqZWN0LT5pc0NoZWNrYm94T3JSYWRpbygpKQogICAg ICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgCi0gICAgQWNjZXNzaWJpbGl0eVJvbGUgYXJpYVJv bGUgPSBhcmlhUm9sZUF0dHJpYnV0ZSgpOwotICAgIGlmIChhcmlhUm9sZSA9PSBUZXh0QXJlYVJv bGUgfHwgYXJpYVJvbGUgPT0gU3RhdGljVGV4dFJvbGUpIHsKLSAgICAgICAgU3RyaW5nIGFyaWFU ZXh0ID0gdGV4dCgpOwotICAgICAgICByZXR1cm4gYXJpYVRleHQuaXNOdWxsKCkgfHwgYXJpYVRl eHQuaXNFbXB0eSgpOwotICAgIH0gICAgCi0gICAgCiAgICAgLy8gTk9URTogQlJzIGFsd2F5cyBo YXZlIHRleHQgYm94ZXMgbm93LCBzbyB0aGUgdGV4dCBib3ggY2hlY2sgaGVyZSBjYW4gYmUgcmVt b3ZlZAogICAgIGlmIChtX3JlbmRlcmVyLT5pc1RleHQoKSkgewogICAgICAgICAvLyBzdGF0aWMg dGV4dCBiZW5lYXRoIE1lbnVJdGVtcyBhbmQgTWVudUJ1dHRvbnMgYXJlIGp1c3QgcmVwb3J0ZWQg YWxvbmcgd2l0aCB0aGUgbWVudSBpdGVtLCBzbyBpdCdzIGlnbm9yZWQgb24gYW4gaW5kaXZpZHVh bCBsZXZlbApAQCAtMTc4NCw3ICsxNzgyLDcgQEAgYm9vbCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0OjphY2Nlc3NpYgogICAgIGlmIChpc0NvbnRyb2woKSkKICAgICAgICAgcmV0dXJuIGZhbHNl OwogICAgIAotICAgIGlmIChhcmlhUm9sZSAhPSBVbmtub3duUm9sZSkKKyAgICBpZiAoYXJpYVJv bGVBdHRyaWJ1dGUoKSAhPSBVbmtub3duUm9sZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAg ICAgaWYgKCFoZWxwVGV4dCgpLmlzRW1wdHkoKSkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDYyNjg1KQor KysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDctMDcgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBWDogd2hlbiBhbiBl bGVtZW50IHVzZXMgcm9sZT0idGV4dCIgYnV0IG5vIGFyaWEtbGFiZWwsIGl0IHNob3VsZCBkZWZh dWx0IHRvIHRleHRVbmRlckVsZW1lbnQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDE3ODAKKworICAgICAgICAqIHBsYXRmb3JtL21hYy9hY2Nlc3Np YmlsaXR5L3N0YXRpYy10ZXh0LXJvbGUtdXNlcy10ZXh0LXVuZGVyLWVsZW1lbnQtZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9zdGF0aWMt dGV4dC1yb2xlLXVzZXMtdGV4dC11bmRlci1lbGVtZW50Lmh0bWw6IEFkZGVkLgorCiAyMDEwLTA3 LTA3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIE5vdCBy ZXZpZXdlZCwganVzdCB1cGRhdGluZyB0ZXN0IGV4cGVjdGF0aW9ucy4KSW5kZXg6IExheW91dFRl c3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3N0YXRpYy10ZXh0LXJvbGUtdXNlcy10ZXh0 LXVuZGVyLWVsZW1lbnQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3N0YXRpYy10ZXh0LXJvbGUtdXNlcy10ZXh0LXVuZGVy LWVsZW1lbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL2FjY2Vzc2liaWxpdHkvc3RhdGljLXRleHQtcm9sZS11c2VzLXRleHQtdW5kZXItZWxl bWVudC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTEgQEAKK1RleHQgMSBU ZXh0IDIgVGV4dCAzCitUaGlzIHRlc3RzIHRoYXQgaWYgYW4gZWxlbWVudCB1c2VzIHRoZSAndGV4 dCcgcm9sZSBidXQgZG9lcyBub3QgdXNlIGFuIGFyaWEtbGFiZWwsIGl0IGNhbiByZXRyaWV2ZSB0 aGUgdGV4dCBpbnNpZGUgb2YgaXQuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmll cyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQ QVNTIHRleHQuc3RyaW5nVmFsdWUgaXMgJ0FYVmFsdWU6IFRleHQgMSBUZXh0IDIgVGV4dCAzJwor UEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6 IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3N0YXRpYy10ZXh0LXJvbGUt dXNlcy10ZXh0LXVuZGVyLWVsZW1lbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9zdGF0aWMtdGV4dC1yb2xlLXVzZXMtdGV4dC11bmRl ci1lbGVtZW50Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv YWNjZXNzaWJpbGl0eS9zdGF0aWMtdGV4dC1yb2xlLXVzZXMtdGV4dC11bmRlci1lbGVtZW50Lmh0 bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDEgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAi LS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxl c2hlZXQiIGhyZWY9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3Nz Ij4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5q cyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IGZhbHNlOwor aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgIGxheW91dFRlc3RDb250cm9sbGVy LmR1bXBBc1RleHQoKTsKKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisKKzxkaXYgcm9sZT0i dGV4dCIgdGFiaW5kZXg9MCBpZD0ndGV4dDEnPgorPGEgaHJlZj0iI25hbWUxIiBpZD0ibmFtZTFs aW5rIj5UZXh0IDE8L2E+Cis8YSBocmVmPSIjbmFtZTIiIGlkPSJuYW1lMmxpbmsiPlRleHQgMjwv YT4KKzxzcGFuPjxiPjxzcGFuPlRleHQgMzwvc3Bhbj48L2I+PC9zcGFuPgorPC9kaXY+CisKKwor PHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPHNj cmlwdD4KKworICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgaWYgYW4gZWxlbWVudCB1 c2VzIHRoZSAndGV4dCcgcm9sZSBidXQgZG9lcyBub3QgdXNlIGFuIGFyaWEtbGFiZWwsIGl0IGNh biByZXRyaWV2ZSB0aGUgdGV4dCBpbnNpZGUgb2YgaXQuIik7CisKKyAgICBpZiAod2luZG93LmFj Y2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJ0ZXh0MSIpLmZvY3VzKCk7CisgICAgICAgIHZhciB0ZXh0ID0gYWNjZXNzaWJpbGl0eUNvbnRy b2xsZXIuZm9jdXNlZEVsZW1lbnQ7CisgICAgICAgIHNob3VsZEJlKCJ0ZXh0LnN0cmluZ1ZhbHVl IiwgIidBWFZhbHVlOiBUZXh0IDEgVGV4dCAyIFRleHQgMyciKTsKKyAgICB9CisKKyAgICBzdWNj ZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi8u Li9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorCis8L2JvZHk+ Cis8L2h0bWw+CisK