41778 2010-07-07 11:09:15 -0700 Add reverseFind to Vector and deploy in HTML5 parser 2010-07-07 15:38:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth eric oldest_to_newest 247644 0 abarth 2010-07-07 11:09:15 -0700 Add reverseFind to Vector and deploy in HTML5 parser 247648 1 60757 abarth 2010-07-07 11:13:17 -0700 Created attachment 60757 Patch 247670 2 60757 abarth 2010-07-07 12:02:30 -0700 Comment on attachment 60757 Patch Thanks Sam. 247712 3 60757 eric 2010-07-07 13:11:18 -0700 Comment on attachment 60757 Patch Huh? I don't understand your comparison change. How is it possible for find to work with a non-entity type? What was the speedup of changing the operator? I guess none, since it was already avoiding the operator in findIndex. 247752 4 abarth 2010-07-07 14:21:20 -0700 Committed r62697: <http://trac.webkit.org/changeset/62697> 247807 5 abarth 2010-07-07 15:38:04 -0700 I discussed this with Eric on the phone and he's on board now. 60757 2010-07-07 11:13:17 -0700 2010-07-07 13:11:18 -0700 Patch bug-41778-20100707111316.patch text/plain 6334 abarth SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYyNjgzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMDcgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgcmV2ZXJzZUZpbmQgdG8gVmVjdG9yIGFuZCBkZXBsb3kgaW4g SFRNTDUgcGFyc2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MTc3OAorCisgICAgICAgIFRoaXMgbWV0aG9kIHNlZW1zIGdlbmVyYWxseSB1c2VmdWwu ICBJJ20gc2xpZ2h0bHkgc3VycHJpc2VkIHdlIGRvbid0CisgICAgICAgIGhhdmUgaXQgYWxyZWFk eS4KKworICAgICAgICAqIHd0Zi9WZWN0b3IuaDoKKyAgICAgICAgKFdURjo6OjpyZXZlcnNlRmlu ZCk6CisKIDIwMTAtMDctMDcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvVmVj dG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCShyZXZpc2lv biA2MjY3OSkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9WZWN0b3IuaAkod29ya2luZyBjb3B5KQpA QCAtNTU3LDYgKzU1Nyw3IEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICBjb25zdCBUJiBsYXN0 KCkgY29uc3QgeyByZXR1cm4gYXQoc2l6ZSgpIC0gMSk7IH0KIAogICAgICAgICB0ZW1wbGF0ZTx0 eXBlbmFtZSBVPiBzaXplX3QgZmluZChjb25zdCBVJikgY29uc3Q7CisgICAgICAgIHRlbXBsYXRl PHR5cGVuYW1lIFU+IHNpemVfdCByZXZlcnNlRmluZChjb25zdCBVJikgY29uc3Q7CiAKICAgICAg ICAgdm9pZCBzaHJpbmsoc2l6ZV90IHNpemUpOwogICAgICAgICB2b2lkIGdyb3coc2l6ZV90IHNp emUpOwpAQCAtNzQ0LDYgKzc0NSwxOCBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICB9CiAKICAgICB0 ZW1wbGF0ZTx0eXBlbmFtZSBULCBzaXplX3QgaW5saW5lQ2FwYWNpdHk+CisgICAgdGVtcGxhdGU8 dHlwZW5hbWUgVT4KKyAgICBzaXplX3QgVmVjdG9yPFQsIGlubGluZUNhcGFjaXR5Pjo6cmV2ZXJz ZUZpbmQoY29uc3QgVSYgdmFsdWUpIGNvbnN0CisgICAgeworICAgICAgICBmb3IgKHNpemVfdCBp ID0gMTsgaSA8PSBzaXplKCk7ICsraSkgeworICAgICAgICAgICAgY29uc3Qgc2l6ZV90IGluZGV4 ID0gc2l6ZSgpIC0gaTsKKyAgICAgICAgICAgIGlmIChhdChpbmRleCkgPT0gdmFsdWUpCisgICAg ICAgICAgICAgICAgcmV0dXJuIGluZGV4OworICAgICAgICB9CisgICAgICAgIHJldHVybiBub3RG b3VuZDsKKyAgICB9CisKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCBzaXplX3QgaW5saW5lQ2Fw YWNpdHk+CiAgICAgdm9pZCBWZWN0b3I8VCwgaW5saW5lQ2FwYWNpdHk+OjpmaWxsKGNvbnN0IFQm IHZhbCwgc2l6ZV90IG5ld1NpemUpCiAgICAgewogICAgICAgICBpZiAoc2l6ZSgpID4gbmV3U2l6 ZSkKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdl TG9nCShyZXZpc2lvbiA2MjY4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMjYgQEAKKzIwMTAtMDctMDcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgcmV2ZXJzZUZpbmQgdG8gVmVjdG9yIGFuZCBkZXBsb3kgaW4gSFRNTDUgcGFyc2VyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTc3OAorCisgICAg ICAgIFRoaXMgcGF0Y2ggbW92ZXMgcmV2ZXJzZUZpbmQgZnJvbSBiZWdpbiBhbgorICAgICAgICBI VE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0LXNwZWNpZmljIGNvbmNlcHQgdG8gYmVnaW4gYSBnZW5l cmFsIFZlY3RvcgorICAgICAgICBjb25jZXB0LiAgQWxzbywgaW5zdGVhZCBvZiB1c2luZyBFbnRy eSBhcyB0aGUgdHlwZSBmb3Igb3BlcmF0b3I9PSwgd2UKKyAgICAgICAgbm93IHVzZSBlbGVtZW50 cyBkaXJlY3RseS4gIFRoZSBvbGQgY29kZSBjb21waWxlZCBiZWNhdXNlIHRoZSBFbnRyeQorICAg ICAgICBjb25zdHJ1Y3RvciB3YXNuJ3QgZXhwbGljaXQsIHdoaWNoIG1lYW5zIHdlIHdlcmUgY2h1 cm5pbmcgcmVmcyBvbiBldmVyeQorICAgICAgICBjb21wYXJpc29uIQorCisgICAgICAgICogaHRt bC9IVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxG b3JtYXR0aW5nRWxlbWVudExpc3Q6OmZpbmQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1h dHRpbmdFbGVtZW50TGlzdDo6Ym9va21hcmtGb3IpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZv cm1hdHRpbmdFbGVtZW50TGlzdDo6aW5zZXJ0QXQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZv cm1hdHRpbmdFbGVtZW50TGlzdDo6cmVtb3ZlKToKKyAgICAgICAgKiBodG1sL0hUTUxGb3JtYXR0 aW5nRWxlbWVudExpc3QuaDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtYXR0aW5nRWxlbWVu dExpc3Q6OkVudHJ5OjpvcGVyYXRvcj09KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtYXR0 aW5nRWxlbWVudExpc3Q6OkVudHJ5OjpvcGVyYXRvciE9KToKKwogMjAxMC0wNy0wNiAgU2ltb24g RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YW4gQmVybnN0ZWluLgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxGb3JtYXR0aW5nRWxlbWVudExp c3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MRm9ybWF0dGluZ0VsZW1lbnRM aXN0LmNwcAkocmV2aXNpb24gNjI2ODApCisrKyBXZWJDb3JlL2h0bWwvSFRNTEZvcm1hdHRpbmdF bGVtZW50TGlzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4LDcgKzU4LDcgQEAgYm9vbCBIVE1M Rm9ybWF0dGluZ0VsZW1lbnRMaXN0Ojpjb250YWlucwogCiBIVE1MRm9ybWF0dGluZ0VsZW1lbnRM aXN0OjpFbnRyeSogSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdDo6ZmluZChFbGVtZW50KiBlbGVt ZW50KQogewotICAgIHNpemVfdCBpbmRleCA9IGZpbmRJbmRleChlbGVtZW50KTsKKyAgICBzaXpl X3QgaW5kZXggPSBtX2VudHJpZXMucmV2ZXJzZUZpbmQoZWxlbWVudCk7CiAgICAgaWYgKGluZGV4 ICE9IG5vdEZvdW5kKSB7CiAgICAgICAgIC8vIFRoaXMgaXMgc29tZXdoYXQgb2YgYSBoYWNrLCBh bmQgaXMgd2h5IHRoaXMgbWV0aG9kIGNhbid0IGJlIGNvbnN0LgogICAgICAgICByZXR1cm4gJm1f ZW50cmllc1tpbmRleF07CkBAIC02OCw3ICs2OCw3IEBAIEhUTUxGb3JtYXR0aW5nRWxlbWVudExp c3Q6OkVudHJ5KiBIVE1MRm8KIAogSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdDo6Qm9va21hcmsg SFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdDo6Ym9va21hcmtGb3IoRWxlbWVudCogZWxlbWVudCkK IHsKLSAgICBzaXplX3QgaW5kZXggPSBmaW5kSW5kZXgoZWxlbWVudCk7CisgICAgc2l6ZV90IGlu ZGV4ID0gbV9lbnRyaWVzLnJldmVyc2VGaW5kKGVsZW1lbnQpOwogICAgIEFTU0VSVChpbmRleCAh PSBub3RGb3VuZCk7CiAgICAgRWxlbWVudCogZWxlbWVudEJlZm9yZSA9IChpbmRleCA+IDEpID8g bV9lbnRyaWVzW2luZGV4IC0gMV0uZWxlbWVudCgpIDogMDsKICAgICBFbGVtZW50KiBlbGVtZW50 QWZ0ZXIgPSAoaW5kZXggPCBtX2VudHJpZXMuc2l6ZSgpIC0gMSkgPyBtX2VudHJpZXNbaW5kZXgg KyAxXS5lbGVtZW50KCkgOiAwOwpAQCAtNzksMTIgKzc5LDEyIEBAIHZvaWQgSFRNTEZvcm1hdHRp bmdFbGVtZW50TGlzdDo6aW5zZXJ0QXQKIHsKICAgICBzaXplX3QgYmVmb3JlSW5kZXggPSBub3RG b3VuZDsKICAgICBpZiAoYm9va21hcmsuZWxlbWVudEJlZm9yZSgpKSB7Ci0gICAgICAgIGJlZm9y ZUluZGV4ID0gZmluZEluZGV4KGJvb2ttYXJrLmVsZW1lbnRCZWZvcmUoKSk7CisgICAgICAgIGJl Zm9yZUluZGV4ID0gbV9lbnRyaWVzLnJldmVyc2VGaW5kKGJvb2ttYXJrLmVsZW1lbnRCZWZvcmUo KSk7CiAgICAgICAgIEFTU0VSVChiZWZvcmVJbmRleCAhPSBub3RGb3VuZCk7CiAgICAgfQogICAg IHNpemVfdCBhZnRlckluZGV4ID0gbm90Rm91bmQ7CiAgICAgaWYgKGJvb2ttYXJrLmVsZW1lbnRB ZnRlcigpKSB7Ci0gICAgICAgIGFmdGVySW5kZXggPSBmaW5kSW5kZXgoYm9va21hcmsuZWxlbWVu dEFmdGVyKCkpOworICAgICAgICBhZnRlckluZGV4ID0gbV9lbnRyaWVzLnJldmVyc2VGaW5kKGJv b2ttYXJrLmVsZW1lbnRBZnRlcigpKTsKICAgICAgICAgQVNTRVJUKGFmdGVySW5kZXggIT0gbm90 Rm91bmQpOwogICAgIH0KIApAQCAtMTA5LDcgKzEwOSw3IEBAIHZvaWQgSFRNTEZvcm1hdHRpbmdF bGVtZW50TGlzdDo6YXBwZW5kKEUKIAogdm9pZCBIVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0Ojpy ZW1vdmUoRWxlbWVudCogZWxlbWVudCkKIHsKLSAgICBzaXplX3QgaW5kZXggPSBmaW5kSW5kZXgo ZWxlbWVudCk7CisgICAgc2l6ZV90IGluZGV4ID0gbV9lbnRyaWVzLnJldmVyc2VGaW5kKGVsZW1l bnQpOwogICAgIGlmIChpbmRleCAhPSBub3RGb3VuZCkKICAgICAgICAgbV9lbnRyaWVzLnJlbW92 ZShpbmRleCk7CiB9CkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlz dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0 LmgJKHJldmlzaW9uIDYyNjgxKQorKysgV2ViQ29yZS9odG1sL0hUTUxGb3JtYXR0aW5nRWxlbWVu dExpc3QuaAkod29ya2luZyBjb3B5KQpAQCAtNzEsMTIgKzcxLDEwIEBAIHB1YmxpYzoKICAgICAg ICAgdm9pZCByZXBsYWNlRWxlbWVudChQYXNzUmVmUHRyPEVsZW1lbnQ+IGVsZW1lbnQpIHsgbV9l bGVtZW50ID0gZWxlbWVudDsgfQogCiAgICAgICAgIC8vIE5lZWRlZCBmb3IgdXNlIHdpdGggVmVj dG9yLiAgVGhlc2UgYXJlIHN1cGVyLWhvdCBhbmQgbXVzdCBiZSBpbmxpbmUuCi0gICAgICAgIGJv b2wgb3BlcmF0b3I9PShjb25zdCBFbnRyeSYgb3RoZXIpIGNvbnN0IHsgcmV0dXJuIG1fZWxlbWVu dCA9PSBvdGhlci5tX2VsZW1lbnQ7IH0KLSAgICAgICAgYm9vbCBvcGVyYXRvciE9KGNvbnN0IEVu dHJ5JiBvdGhlcikgY29uc3QgeyByZXR1cm4gbV9lbGVtZW50ICE9IG90aGVyLm1fZWxlbWVudDsg fQorICAgICAgICBib29sIG9wZXJhdG9yPT0oRWxlbWVudCogZWxlbWVudCkgY29uc3QgeyByZXR1 cm4gbV9lbGVtZW50ID09IGVsZW1lbnQ7IH0KKyAgICAgICAgYm9vbCBvcGVyYXRvciE9KEVsZW1l bnQqIGVsZW1lbnQpIGNvbnN0IHsgcmV0dXJuIG1fZWxlbWVudCAhPSBlbGVtZW50OyB9CiAKICAg ICBwcml2YXRlOgotICAgICAgICBmcmllbmQgY2xhc3MgSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlz dDsKLQogICAgICAgICBSZWZQdHI8RWxlbWVudD4gbV9lbGVtZW50OwogICAgIH07CiAKQEAgLTEy NiwxNyArMTI0LDYgQEAgcHVibGljOgogI2VuZGlmCiAKIHByaXZhdGU6Ci0gICAgc2l6ZV90IGZp bmRJbmRleChFbGVtZW50KiBlbGVtZW50KSBjb25zdAotICAgIHsKLSAgICAgICAgQVNTRVJUKGVs ZW1lbnQpOwotICAgICAgICAvLyBBIHJldmVyc2UgZmluZCBpcyBtb3JlIGVmZmljaWVudCB0aGFu IFZlY3RvcjxUPjo6ZmluZAotICAgICAgICBmb3IgKHNpemVfdCBpID0gMTsgaSA8PSBtX2VudHJp ZXMuc2l6ZSgpOyArK2kpIHsKLSAgICAgICAgICAgIHNpemVfdCBpbmRleCA9IG1fZW50cmllcy5z aXplKCkgLSBpOwotICAgICAgICAgICAgaWYgKG1fZW50cmllc1tpbmRleF0ubV9lbGVtZW50ID09 IGVsZW1lbnQpCi0gICAgICAgICAgICAgICAgcmV0dXJuIGluZGV4OwotICAgICAgICB9Ci0gICAg ICAgIHJldHVybiBub3RGb3VuZDsKLSAgICB9CiAgICAgVmVjdG9yPEVudHJ5PiBtX2VudHJpZXM7 CiB9OwogCg==