41774 2010-07-07 09:53:24 -0700 [Qt] Enable smooth pixmap transforms by default 2011-12-15 04:33:22 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned abarth commit-queue eric kenneth magnesus2 webkit.review.bot oldest_to_newest 247607 0 kling 2010-07-07 09:53:24 -0700 Drawing scaled pixmaps currently looks a bit horrible with QtWebKit, see for instance this simple demo: http://chaos.troll.no/~kling/canvas/photos/ The solution is to enable smooth pixmaps transformations by default (which also appears to be what other ports are doing.) 247609 1 60746 kling 2010-07-07 09:55:16 -0700 Created attachment 60746 Proposed patch 247619 2 60746 vestbo 2010-07-07 10:06:10 -0700 Comment on attachment 60746 Proposed patch LGTM 247657 3 kenneth 2010-07-07 11:37:43 -0700 I would love that! Currently to use the same DPI as Android and the iPhone, we have to scale everything with 1.5 on the N900, which looks terrible. 248027 4 60746 commit-queue 2010-07-07 23:10:01 -0700 Comment on attachment 60746 Proposed patch Clearing flags on attachment: 60746 Committed r62762: <http://trac.webkit.org/changeset/62762> 248028 5 commit-queue 2010-07-07 23:10:06 -0700 All reviewed patches have been landed. Closing bug. 248035 6 webkit.review.bot 2010-07-07 23:35:08 -0700 http://trac.webkit.org/changeset/62762 might have broken GTK Linux 64-bit Debug 521827 7 magnesus2 2011-12-15 04:33:22 -0800 Looks like it's broken in QtWebKit 2.2.1 - https://bugs.webkit.org/show_bug.cgi?id=74600 60746 2010-07-07 09:55:16 -0700 2010-07-07 23:10:01 -0700 Proposed patch bug-41774.diff text/plain 1838 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzFkOTFhZC4uYmVjNzA5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNy0wNyAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRW5hYmxlIHNtb290aCBwaXhtYXAgdHJhbnNmb3Jt cyBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MTc3NAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250 ZXh0UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2 YXRlOjpHcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGUpOgorICAgICAgICAoV2ViQ29yZTo6 R3JhcGhpY3NDb250ZXh0OjpzZXRJbWFnZUludGVycG9sYXRpb25RdWFsaXR5KToKKwogMjAxMC0w Ny0wNyAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQv R3JhcGhpY3NDb250ZXh0UXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFw aGljc0NvbnRleHRRdC5jcHAKaW5kZXggOWQyMzM0MC4uOTEzYTc2NCAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKKysrIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKQEAgLTI2MCw2 ICsyNjAsNyBAQCBHcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGU6OkdyYXBoaWNzQ29udGV4 dFBsYXRmb3JtUHJpdmF0ZShRUGFpbnRlciogcCkKICAgICAgICAgYW50aUFsaWFzaW5nRm9yUmVj dHNBbmRMaW5lcyA9IHBhaW50ZXItPnRlc3RSZW5kZXJIaW50KFFQYWludGVyOjpBbnRpYWxpYXNp bmcpOwogICAgICAgICAvLyBGSVhNRTogTWF5YmUgb25seSBlbmFibGUgaW4gU1ZHIG1vZGU/CiAg ICAgICAgIHBhaW50ZXItPnNldFJlbmRlckhpbnQoUVBhaW50ZXI6OkFudGlhbGlhc2luZywgdHJ1 ZSk7CisgICAgICAgIHBhaW50ZXItPnNldFJlbmRlckhpbnQoUVBhaW50ZXI6OlNtb290aFBpeG1h cFRyYW5zZm9ybSwgdHJ1ZSk7CiAgICAgfSBlbHNlCiAgICAgICAgIGFudGlBbGlhc2luZ0ZvclJl Y3RzQW5kTGluZXMgPSBmYWxzZTsKIH0KQEAgLTEzOTQsMTMgKzEzOTUsMTMgQEAgdm9pZCBHcmFw aGljc0NvbnRleHQ6OnNldEltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkoSW50ZXJwb2xhdGlvblF1 YWxpdHkgcXVhbGl0eSkKICAgICBtX2RhdGEtPmltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkgPSBx dWFsaXR5OwogCiAgICAgc3dpdGNoIChxdWFsaXR5KSB7Ci0gICAgY2FzZSBJbnRlcnBvbGF0aW9u RGVmYXVsdDoKICAgICBjYXNlIEludGVycG9sYXRpb25Ob25lOgogICAgIGNhc2UgSW50ZXJwb2xh dGlvbkxvdzoKICAgICAgICAgLy8gdXNlIG5lYXJlc3QtbmVpZ2JvcgogICAgICAgICBtX2RhdGEt PnAoKS0+c2V0UmVuZGVySGludChRUGFpbnRlcjo6U21vb3RoUGl4bWFwVHJhbnNmb3JtLCBmYWxz ZSk7CiAgICAgICAgIGJyZWFrOwogCisgICAgY2FzZSBJbnRlcnBvbGF0aW9uRGVmYXVsdDoKICAg ICBjYXNlIEludGVycG9sYXRpb25NZWRpdW06CiAgICAgY2FzZSBJbnRlcnBvbGF0aW9uSGlnaDoK ICAgICBkZWZhdWx0Ogo=