41771 2010-07-07 08:50:44 -0700 [V8] Document wrapper memory leak in bindings 2010-07-07 23:24:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov webkit-unassigned commit-queue japhet vitalyr webkit.review.bot oldest_to_newest 247579 0 podivilov 2010-07-07 08:50:44 -0700 [V8] Document wrapper memory leak in bindings Static persistent handle to shadowConstructor in V8HTMLDocument::WrapInShadowObject keeps the first context alive forever. 247587 1 60740 podivilov 2010-07-07 09:02:53 -0700 Created attachment 60740 Proposed patch. 247590 2 webkit.review.bot 2010-07-07 09:03:35 -0700 Attachment 60740 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 247593 3 vitalyr 2010-07-07 09:09:52 -0700 LG (with style errors fixed). Nate, could you please have a look and r+? 247594 4 60740 japhet 2010-07-07 09:15:26 -0700 Comment on attachment 60740 Proposed patch. Ok, looks good (with the ChangeLog fixes, of course). 247611 5 60747 podivilov 2010-07-07 10:00:25 -0700 Created attachment 60747 Proposed patch. 247613 6 podivilov 2010-07-07 10:01:38 -0700 (In reply to comment #4) > (From update of attachment 60740 [details]) > Ok, looks good (with the ChangeLog fixes, of course). Fixed style, sorry for delay. 248033 7 60747 commit-queue 2010-07-07 23:24:01 -0700 Comment on attachment 60747 Proposed patch. Clearing flags on attachment: 60747 Committed r62763: <http://trac.webkit.org/changeset/62763> 248034 8 commit-queue 2010-07-07 23:24:05 -0700 All reviewed patches have been landed. Closing bug. 60740 2010-07-07 09:02:53 -0700 2010-07-07 10:00:43 -0700 Proposed patch. tmp.diff text/plain 2382 podivilov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mzg1ZDU4OC4uZjMxN2YwOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNy0wNyAgUGF2ZWwgUG9kaXZp bG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworCQlbVjhdIEZpeCBkb2N1bWVudCB3cmFwcGVyIG1lbW9yeSBsZWFrIGlu IGJpbmRpbmdzLgorCQlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE3 NzEKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1bWVudEN1c3RvbS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpWOEhUTUxEb2N1bWVudDo6V3JhcEluU2hhZG93T2JqZWN0 KTogRG8gbm90IGNyZWF0ZSBzdGF0aWMgcGVyc2lzdGVudCBoYW5kbGUKKyAgICAgICAgdG8gc2hh ZG93Q29uc3RydWN0b3IgYmVjYXVzZSBpdCBrZWVwcyB0aGUgZmlyc3QgY29udGV4dCBhbGl2ZSBm b3JldmVyLgorCiAyMDEwLTA3LTA3ICBMdWNhcyBEZSBNYXJjaGkgIDxsdWNhcy5kZW1hcmNoaUBw cm9mdXNpb24ubW9iaT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCBhZnRlciByNjI1 NzcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1bWVu dEN1c3RvbS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1bWVudEN1 c3RvbS5jcHAKaW5kZXggZTZmMWI4Zi4uMDlmMGE2ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwCisrKyBiL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcApAQCAtNTEsMjAgKzUxLDIw IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdjg6OkxvY2FsPHY4OjpPYmplY3Q+IFY4SFRNTERv Y3VtZW50OjpXcmFwSW5TaGFkb3dPYmplY3Qodjg6OkxvY2FsPHY4OjpPYmplY3Q+IHdyYXBwZXIs IE5vZGUqIGltcGwpCiB7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NBTCh2ODo6UGVyc2lzdGVudDx2 ODo6RnVuY3Rpb24+LCBzaGFkb3dDb25zdHJ1Y3RvciwgKCkpOwotICAgIGlmIChzaGFkb3dDb25z dHJ1Y3Rvci5Jc0VtcHR5KCkpIHsKLSAgICAgICAgdjg6OkxvY2FsPHY4OjpGdW5jdGlvblRlbXBs YXRlPiBzaGFkb3dUZW1wbGF0ZSA9IHY4OjpGdW5jdGlvblRlbXBsYXRlOjpOZXcoKTsKKyAgICBE RUZJTkVfU1RBVElDX0xPQ0FMKHY4OjpQZXJzaXN0ZW50PHY4OjpGdW5jdGlvblRlbXBsYXRlPiwg c2hhZG93VGVtcGxhdGUsICgpKTsKKyAgICBpZiAoc2hhZG93VGVtcGxhdGUuSXNFbXB0eSgpKSB7 CisgICAgICAgIHNoYWRvd1RlbXBsYXRlID0gdjg6OlBlcnNpc3RlbnQ8djg6OkZ1bmN0aW9uVGVt cGxhdGU+OjpOZXcodjg6OkZ1bmN0aW9uVGVtcGxhdGU6Ok5ldygpKTsKICAgICAgICAgaWYgKHNo YWRvd1RlbXBsYXRlLklzRW1wdHkoKSkKICAgICAgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6 Ok9iamVjdD4oKTsKICAgICAgICAgc2hhZG93VGVtcGxhdGUtPlNldENsYXNzTmFtZSh2ODo6U3Ry aW5nOjpOZXcoIkhUTUxEb2N1bWVudCIpKTsKICAgICAgICAgc2hhZG93VGVtcGxhdGUtPkluaGVy aXQoVjhIVE1MRG9jdW1lbnQ6OkdldFRlbXBsYXRlKCkpOwogICAgICAgICBzaGFkb3dUZW1wbGF0 ZS0+SW5zdGFuY2VUZW1wbGF0ZSgpLT5TZXRJbnRlcm5hbEZpZWxkQ291bnQoVjhIVE1MRG9jdW1l bnQ6OmludGVybmFsRmllbGRDb3VudCk7Ci0gICAgICAgIHNoYWRvd0NvbnN0cnVjdG9yID0gdjg6 OlBlcnNpc3RlbnQ8djg6OkZ1bmN0aW9uPjo6TmV3KHNoYWRvd1RlbXBsYXRlLT5HZXRGdW5jdGlv bigpKTsKLSAgICAgICAgaWYgKHNoYWRvd0NvbnN0cnVjdG9yLklzRW1wdHkoKSkKLSAgICAgICAg ICAgIHJldHVybiB2ODo6TG9jYWw8djg6Ok9iamVjdD4oKTsKICAgICB9CiAKLSAgICBBU1NFUlQo IXNoYWRvd0NvbnN0cnVjdG9yLklzRW1wdHkoKSk7CisgICAgdjg6OkxvY2FsPHY4OjpGdW5jdGlv bj4gc2hhZG93Q29uc3RydWN0b3IgPSBzaGFkb3dUZW1wbGF0ZS0+R2V0RnVuY3Rpb24oKTsKKyAg ICBpZiAoc2hhZG93Q29uc3RydWN0b3IuSXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gdjg6Okxv Y2FsPHY4OjpPYmplY3Q+KCk7CisKICAgICB2ODo6TG9jYWw8djg6Ok9iamVjdD4gc2hhZG93ID0g c2hhZG93Q29uc3RydWN0b3ItPk5ld0luc3RhbmNlKCk7CiAgICAgaWYgKHNoYWRvdy5Jc0VtcHR5 KCkpCiAgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6Ok9iamVjdD4oKTsK 60747 2010-07-07 10:00:25 -0700 2010-07-07 23:24:01 -0700 Proposed patch. tmp.diff text/plain 2394 podivilov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mzg1ZDU4OC4uYTQ0Y2EzNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNy0wNyAgUGF2ZWwgUG9kaXZp bG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbVjhdIEZpeCBkb2N1bWVudCB3cmFwcGVyIG1lbW9yeSBs ZWFrIGluIGJpbmRpbmdzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDE3NzEKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1 bWVudEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOEhUTUxEb2N1bWVudDo6V3JhcElu U2hhZG93T2JqZWN0KTogRG8gbm90IGNyZWF0ZSBzdGF0aWMgcGVyc2lzdGVudCBoYW5kbGUKKyAg ICAgICAgdG8gc2hhZG93Q29uc3RydWN0b3IgYmVjYXVzZSBpdCBrZWVwcyB0aGUgZmlyc3QgY29u dGV4dCBhbGl2ZSBmb3JldmVyLgorCiAyMDEwLTA3LTA3ICBMdWNhcyBEZSBNYXJjaGkgIDxsdWNh cy5kZW1hcmNoaUBwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZp eCBhZnRlciByNjI1NzcuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9W OEhUTUxEb2N1bWVudEN1c3RvbS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhU TUxEb2N1bWVudEN1c3RvbS5jcHAKaW5kZXggZTZmMWI4Zi4uMDlmMGE2ZiAxMDA2NDQKLS0tIGEv V2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwCisrKyBi L1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcApAQCAt NTEsMjAgKzUxLDIwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdjg6OkxvY2FsPHY4OjpPYmpl Y3Q+IFY4SFRNTERvY3VtZW50OjpXcmFwSW5TaGFkb3dPYmplY3Qodjg6OkxvY2FsPHY4OjpPYmpl Y3Q+IHdyYXBwZXIsIE5vZGUqIGltcGwpCiB7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NBTCh2ODo6 UGVyc2lzdGVudDx2ODo6RnVuY3Rpb24+LCBzaGFkb3dDb25zdHJ1Y3RvciwgKCkpOwotICAgIGlm IChzaGFkb3dDb25zdHJ1Y3Rvci5Jc0VtcHR5KCkpIHsKLSAgICAgICAgdjg6OkxvY2FsPHY4OjpG dW5jdGlvblRlbXBsYXRlPiBzaGFkb3dUZW1wbGF0ZSA9IHY4OjpGdW5jdGlvblRlbXBsYXRlOjpO ZXcoKTsKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKHY4OjpQZXJzaXN0ZW50PHY4OjpGdW5jdGlv blRlbXBsYXRlPiwgc2hhZG93VGVtcGxhdGUsICgpKTsKKyAgICBpZiAoc2hhZG93VGVtcGxhdGUu SXNFbXB0eSgpKSB7CisgICAgICAgIHNoYWRvd1RlbXBsYXRlID0gdjg6OlBlcnNpc3RlbnQ8djg6 OkZ1bmN0aW9uVGVtcGxhdGU+OjpOZXcodjg6OkZ1bmN0aW9uVGVtcGxhdGU6Ok5ldygpKTsKICAg ICAgICAgaWYgKHNoYWRvd1RlbXBsYXRlLklzRW1wdHkoKSkKICAgICAgICAgICAgIHJldHVybiB2 ODo6TG9jYWw8djg6Ok9iamVjdD4oKTsKICAgICAgICAgc2hhZG93VGVtcGxhdGUtPlNldENsYXNz TmFtZSh2ODo6U3RyaW5nOjpOZXcoIkhUTUxEb2N1bWVudCIpKTsKICAgICAgICAgc2hhZG93VGVt cGxhdGUtPkluaGVyaXQoVjhIVE1MRG9jdW1lbnQ6OkdldFRlbXBsYXRlKCkpOwogICAgICAgICBz aGFkb3dUZW1wbGF0ZS0+SW5zdGFuY2VUZW1wbGF0ZSgpLT5TZXRJbnRlcm5hbEZpZWxkQ291bnQo VjhIVE1MRG9jdW1lbnQ6OmludGVybmFsRmllbGRDb3VudCk7Ci0gICAgICAgIHNoYWRvd0NvbnN0 cnVjdG9yID0gdjg6OlBlcnNpc3RlbnQ8djg6OkZ1bmN0aW9uPjo6TmV3KHNoYWRvd1RlbXBsYXRl LT5HZXRGdW5jdGlvbigpKTsKLSAgICAgICAgaWYgKHNoYWRvd0NvbnN0cnVjdG9yLklzRW1wdHko KSkKLSAgICAgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6Ok9iamVjdD4oKTsKICAgICB9CiAK LSAgICBBU1NFUlQoIXNoYWRvd0NvbnN0cnVjdG9yLklzRW1wdHkoKSk7CisgICAgdjg6OkxvY2Fs PHY4OjpGdW5jdGlvbj4gc2hhZG93Q29uc3RydWN0b3IgPSBzaGFkb3dUZW1wbGF0ZS0+R2V0RnVu Y3Rpb24oKTsKKyAgICBpZiAoc2hhZG93Q29uc3RydWN0b3IuSXNFbXB0eSgpKQorICAgICAgICBy ZXR1cm4gdjg6OkxvY2FsPHY4OjpPYmplY3Q+KCk7CisKICAgICB2ODo6TG9jYWw8djg6Ok9iamVj dD4gc2hhZG93ID0gc2hhZG93Q29uc3RydWN0b3ItPk5ld0luc3RhbmNlKCk7CiAgICAgaWYgKHNo YWRvdy5Jc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6Ok9iamVjdD4oKTsK