41754 2010-07-07 03:12:28 -0700 HTMLTreeBuilder is way too slow 2010-07-07 10:44:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 eric eric abarth commit-queue oldest_to_newest 247438 0 eric 2010-07-07 03:12:28 -0700 HTMLTreeBuilder is way too slow 247441 1 60714 eric 2010-07-07 03:15:56 -0700 Created attachment 60714 Patch 247444 2 60714 abarth 2010-07-07 03:17:50 -0700 Comment on attachment 60714 Patch Yeah, I'm not sure Vector is the right thing either. We do too much surgery on the list. Might be nice to get stats for how big it is typically. 247620 3 60714 abarth 2010-07-07 10:11:38 -0700 Comment on attachment 60714 Patch Clearing flags on attachment: 60714 Committed r62678: <http://trac.webkit.org/changeset/62678> 247621 4 abarth 2010-07-07 10:11:43 -0700 All reviewed patches have been landed. Closing bug. 247632 5 60714 commit-queue 2010-07-07 10:44:08 -0700 Comment on attachment 60714 Patch Rejecting patch 60714 from commit-queue. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 60714, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: cgi?id=60714&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=41754&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 60714 from bug 41754. NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 60714 2010-07-07 03:15:56 -0700 2010-07-07 10:44:08 -0700 Patch bug-41754-20100707031554.patch text/plain 4815 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDQ2MWQyMjYwNmUyMWMyNjJiNjE3YTY3ZGVlYmZiMzQxYmE0MjFjOS4uYjQ1NzRiMDNiNTgwMDI1 MzU5MmFlODI0YzQ0ODY2NjUwMDhjNjE4MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwzMyBAQAogMjAxMC0wNy0wNyAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSFRNTFRyZWVCdWlsZGVyIGlzIHdheSB0b28gc2xvdworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE3NTQKKworICAg ICAgICBUaGlzIHRha2VzIHVzIGZyb20gMTRzIHRvIDdzIG9uIG91ciBwYXJzaW5nIGJlbmNobWFy ay4KKyAgICAgICAgVGhhdCdzIHN0aWxsIG11Y2ggc2xvd2VyIHRoYW4gdGhlIG9sZCB0cmVlIGJ1 aWxkZXIsIGJ1dCB0aGVyZQorICAgICAgICBpcyBhIGh1Z2UgYW1vdW50IG9mIGZhdCBsZWZ0IHRv IHRyaW0uCisKKyAgICAgICAgVmVjdG9yPFQ+IHdhc24ndCBhYmxlIHRvIGlubGluZSBhbGwgdGhl IEVudHJ5IGZ1bmN0aW9ucyB3aGVuCisgICAgICAgIHRoZXkgd2VyZSBidXJpZWQgaW4gdGhlIGNw cC4gIFR1cm5zIG91dCB0aGUgYWN0aXZlIGZvcm1hdHRpbmcgZWxlbWVudHMKKyAgICAgICAgbGlz dCBpcyB2ZXJ5IGhvdC4KKworICAgICAgICBJJ20gbm90IHN1cmUgVmVjdG9yPFQ+IGlzIGdvaW5n IHRvIGJlIHRoZSByaWdodCBkYXRhIHN0cnVjdHVyZSBmb3IgdXMKKyAgICAgICAgaW4gdGhlIGVu ZCwgYnV0IGl0IGhhcyBkb25lIGFscmlnaHQgZm9yIGJyaW5nLXVwLgorCisgICAgICAgICogaHRt bC9IVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0LmNwcDoKKyAgICAgICAgKiBodG1sL0hUTUxGb3Jt YXR0aW5nRWxlbWVudExpc3QuaDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtYXR0aW5nRWxl bWVudExpc3Q6OkVudHJ5OjpFbnRyeSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybWF0dGlu Z0VsZW1lbnRMaXN0OjpFbnRyeTo6fkVudHJ5KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3Jt YXR0aW5nRWxlbWVudExpc3Q6OkVudHJ5Ojppc01hcmtlcik6CisgICAgICAgIChXZWJDb3JlOjpI VE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0OjpFbnRyeTo6ZWxlbWVudCk6CisgICAgICAgIChXZWJD b3JlOjpIVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0OjpFbnRyeTo6cmVwbGFjZUVsZW1lbnQpOgor ICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdDo6RW50cnk6Om9wZXJh dG9yPT0pOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdDo6RW50 cnk6Om9wZXJhdG9yIT0pOgorCisyMDEwLTA3LTA3ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0 Lm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgogCiAgICAgICAgIEZpeCA8 L2h0bWw+IGhhbmRsaW5nIGluIGJlZm9yZSBoZWFkIG1vZGUKZGlmZiAtLWdpdCBhL1dlYkNvcmUv aHRtbC9IVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0LmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MRm9y bWF0dGluZ0VsZW1lbnRMaXN0LmNwcAppbmRleCBlMDQ2YjUxMDA4MzAwYmZlMTgzOTlhOGM4N2Zl NjBiOTg1MDZhMTA2Li5iN2Q0YWIxZTNmZmFkMGYzOTNiNTc1NmM3YjNkYzE1ZDg0MGY5ZDZkIDEw MDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdC5jcHAKKysr IGIvV2ViQ29yZS9odG1sL0hUTUxGb3JtYXR0aW5nRWxlbWVudExpc3QuY3BwCkBAIC0zMSw0OSAr MzEsNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLUhUTUxGb3JtYXR0aW5nRWxlbWVudExp c3Q6OkVudHJ5OjpFbnRyeShFbGVtZW50KiBlbGVtZW50KQotICAgIDogbV9lbGVtZW50KGVsZW1l bnQpCi17Ci0gICAgQVNTRVJUKGVsZW1lbnQpOwotfQotCi1IVE1MRm9ybWF0dGluZ0VsZW1lbnRM aXN0OjpFbnRyeTo6RW50cnkoTWFya2VyRW50cnlUeXBlKQotewotfQotCi1IVE1MRm9ybWF0dGlu Z0VsZW1lbnRMaXN0OjpFbnRyeTo6fkVudHJ5KCkKLXsKLX0KLQotYm9vbCBIVE1MRm9ybWF0dGlu Z0VsZW1lbnRMaXN0OjpFbnRyeTo6aXNNYXJrZXIoKSBjb25zdAotewotICAgIHJldHVybiAhbV9l bGVtZW50OwotfQotCi1FbGVtZW50KiBIVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0OjpFbnRyeTo6 ZWxlbWVudCgpIGNvbnN0Ci17Ci0gICAgLy8gVGhlIGZhY3QgdGhhdCAhbV9lbGVtZW50ID09IGlz TWFya2VyKCkgaXMgYW4gaW1wbGVtZW50YXRpb24gZGV0YWlsCi0gICAgLy8gY2FsbGVycyBzaG91 bGQgY2hlY2sgaXNNYXJrZXIoKSBiZWZvcmUgY2FsbGluZyBlbGVtZW50KCkuCi0gICAgQVNTRVJU KG1fZWxlbWVudCk7Ci0gICAgcmV0dXJuIG1fZWxlbWVudC5nZXQoKTsKLX0KLQotdm9pZCBIVE1M Rm9ybWF0dGluZ0VsZW1lbnRMaXN0OjpFbnRyeTo6cmVwbGFjZUVsZW1lbnQoUGFzc1JlZlB0cjxF bGVtZW50PiBlbGVtZW50KQotewotICAgIEFTU0VSVChtX2VsZW1lbnQpOyAvLyBPbmNlIGEgbWFy a2VyLCBhbHdheXMgYSBtYXJrZXIuCi0gICAgbV9lbGVtZW50ID0gZWxlbWVudDsKLX0KLQotYm9v bCBIVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0OjpFbnRyeTo6b3BlcmF0b3I9PShjb25zdCBFbnRy eSYgb3RoZXIpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIG1fZWxlbWVudCA9PSBvdGhlci5tX2VsZW1l bnQ7Ci19Ci0KLWJvb2wgSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdDo6RW50cnk6Om9wZXJhdG9y IT0oY29uc3QgRW50cnkmIG90aGVyKSBjb25zdAotewotICAgIHJldHVybiBtX2VsZW1lbnQgIT0g b3RoZXIubV9lbGVtZW50OwotfQotCiBIVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0OjpIVE1MRm9y bWF0dGluZ0VsZW1lbnRMaXN0KCkKIHsKIH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1M Rm9ybWF0dGluZ0VsZW1lbnRMaXN0LmggYi9XZWJDb3JlL2h0bWwvSFRNTEZvcm1hdHRpbmdFbGVt ZW50TGlzdC5oCmluZGV4IGQ1ZmNjMGY0Mjc0YjcxYzg3ZmIyM2FlOGNjMzhkZTYyYzMyYmU1MmMu LjBjMmE0MGY3ZGY2Yjc4NTFhYzNkOWMwZGYxNWY0NTQzNzRkODJlNmYgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaHRtbC9IVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0LmgKKysrIGIvV2ViQ29yZS9odG1s L0hUTUxGb3JtYXR0aW5nRWxlbWVudExpc3QuaApAQCAtNDYsMTkgKzQ2LDMzIEBAIHB1YmxpYzoK ICAgICAvLyBhY2Nlc3MgdG8gRW50cnk6OmlzTWFya2VyKCkgYW5kIEVudHJ5OjpyZXBsYWNlRWxl bWVudCgpIHRvIGRvIHNvLgogICAgIGNsYXNzIEVudHJ5IHsKICAgICBwdWJsaWM6Ci0gICAgICAg IEVudHJ5KEVsZW1lbnQqKTsKKyAgICAgICAgLy8gSW5saW5lIGJlY2F1c2UgdGhleSdyZSBob3Qg YW5kIFZlY3RvcjxUPiB1c2VzIHRoZW0uCisgICAgICAgIEVudHJ5KEVsZW1lbnQqIGVsZW1lbnQp CisgICAgICAgICAgICA6IG1fZWxlbWVudChlbGVtZW50KQorICAgICAgICB7CisgICAgICAgICAg ICBBU1NFUlQoZWxlbWVudCk7CisgICAgICAgIH0KICAgICAgICAgZW51bSBNYXJrZXJFbnRyeVR5 cGUgeyBNYXJrZXJFbnRyeSB9OwotICAgICAgICBFbnRyeShNYXJrZXJFbnRyeVR5cGUpOwotICAg ICAgICB+RW50cnkoKTsKKyAgICAgICAgRW50cnkoTWFya2VyRW50cnlUeXBlKQorICAgICAgICAg ICAgOiBtX2VsZW1lbnQoMCkKKyAgICAgICAgeworICAgICAgICB9CisgICAgICAgIH5FbnRyeSgp IHt9CiAKLSAgICAgICAgYm9vbCBpc01hcmtlcigpIGNvbnN0OworICAgICAgICBib29sIGlzTWFy a2VyKCkgY29uc3QgeyByZXR1cm4gIW1fZWxlbWVudDsgfQogCi0gICAgICAgIEVsZW1lbnQqIGVs ZW1lbnQoKSBjb25zdDsKLSAgICAgICAgdm9pZCByZXBsYWNlRWxlbWVudChQYXNzUmVmUHRyPEVs ZW1lbnQ+KTsKKyAgICAgICAgRWxlbWVudCogZWxlbWVudCgpIGNvbnN0CisgICAgICAgIHsKKyAg ICAgICAgICAgIC8vIFRoZSBmYWN0IHRoYXQgIW1fZWxlbWVudCA9PSBpc01hcmtlcigpIGlzIGFu IGltcGxlbWVudGF0aW9uIGRldGFpbAorICAgICAgICAgICAgLy8gY2FsbGVycyBzaG91bGQgY2hl Y2sgaXNNYXJrZXIoKSBiZWZvcmUgY2FsbGluZyBlbGVtZW50KCkuCisgICAgICAgICAgICBBU1NF UlQobV9lbGVtZW50KTsKKyAgICAgICAgICAgIHJldHVybiBtX2VsZW1lbnQuZ2V0KCk7CisgICAg ICAgIH0KKyAgICAgICAgdm9pZCByZXBsYWNlRWxlbWVudChQYXNzUmVmUHRyPEVsZW1lbnQ+IGVs ZW1lbnQpIHsgbV9lbGVtZW50ID0gZWxlbWVudDsgfQogCi0gICAgICAgIC8vIE5lZWRlZCBmb3Ig dXNlIHdpdGggVmVjdG9yLgotICAgICAgICBib29sIG9wZXJhdG9yPT0oY29uc3QgRW50cnkmKSBj b25zdDsKLSAgICAgICAgYm9vbCBvcGVyYXRvciE9KGNvbnN0IEVudHJ5JikgY29uc3Q7CisgICAg ICAgIC8vIE5lZWRlZCBmb3IgdXNlIHdpdGggVmVjdG9yLiAgVGhlc2UgYXJlIHN1cGVyLWhvdCBh bmQgbXVzdCBiZSBpbmxpbmUuCisgICAgICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBFbnRyeSYg b3RoZXIpIGNvbnN0IHsgcmV0dXJuIG1fZWxlbWVudCA9PSBvdGhlci5tX2VsZW1lbnQ7IH0KKyAg ICAgICAgYm9vbCBvcGVyYXRvciE9KGNvbnN0IEVudHJ5JiBvdGhlcikgY29uc3QgeyByZXR1cm4g bV9lbGVtZW50ICE9IG90aGVyLm1fZWxlbWVudDsgfQogCiAgICAgcHJpdmF0ZToKICAgICAgICAg UmVmUHRyPEVsZW1lbnQ+IG1fZWxlbWVudDsK