41753 2010-07-07 03:04:32 -0700 [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions 2010-07-08 20:49:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tkent tkent abarth dglazkov eric hamaji rolandsteiner webkit.review.bot oldest_to_newest 247430 0 tkent 2010-07-07 03:04:32 -0700 [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions 247432 1 60712 tkent 2010-07-07 03:07:10 -0700 Created attachment 60712 Patch 247570 2 60712 dglazkov 2010-07-07 08:36:02 -0700 Comment on attachment 60712 Patch Sounds good, but please use notImplemented() :) 247929 3 tkent 2010-07-07 18:40:50 -0700 (In reply to comment #2) > Sounds good, but please use notImplemented() :) Unfortunately, notImplemented() is a WebCore API. DRT should not use WebCore API directly. 247930 4 dglazkov 2010-07-07 18:47:31 -0700 (In reply to comment #3) > (In reply to comment #2) > > Sounds good, but please use notImplemented() :) > > Unfortunately, notImplemented() is a WebCore API. DRT should not use WebCore API directly. Doh! Then LGTM :) 247935 5 tkent 2010-07-07 18:52:47 -0700 Landed as r62740 247943 6 webkit.review.bot 2010-07-07 19:15:32 -0700 http://trac.webkit.org/changeset/62740 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/62739 http://trac.webkit.org/changeset/62740 60712 2010-07-07 03:07:10 -0700 2010-07-08 20:49:07 -0700 Patch bug-41753-20100707190708.patch text/plain 1904 tkent ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0MWMzNjI4N2I5ZGMzNGU4YWI5MDk5MWI3NGE1OWMxY2Y4MzM4MTdiLi5jNTBiZWFh NzdhMTAyNTBjYjlhMTFjNjM5ZjIxNGIwZGE4ZWM1ZWQ2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTAtMDctMDcgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtEUlQvQ2hyb21pdW1dIFJl bW92ZSBBU1NFUlRfTk9UX1JFQUNIRUQgaW4gc29tZSBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNzUzCisKKyAgICAgICAgVGhlIG9y aWdpbmFsIGNvZGUgb2YgdGhlIGZvbGxvd2luZyBmdW5jdGlvbnMgaW4KKyAgICAgICAgdGVzdF9z aGVsbF9kZXZ0b29sc19jbGllbnQuY2MgaGF2ZSBOT1RJTVBMRU1FTlRFRCgpLCBub3QKKyAgICAg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCkuIFRoZSBwcm9ncmFtIHNob3VsZG4ndCBzdG9wIGF0IHRo ZXNlCisgICAgICAgIGZ1bmN0aW9ucy4KKyAgICAgICAgCisgICAgICAgICogRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vRFJURGV2VG9vbHNDbGllbnQuY3BwOgorICAgICAgICAoRFJURGV2VG9vbHND bGllbnQ6OmFjdGl2YXRlV2luZG93KToKKyAgICAgICAgKERSVERldlRvb2xzQ2xpZW50OjpjbG9z ZVdpbmRvdyk6CisgICAgICAgIChEUlREZXZUb29sc0NsaWVudDo6ZG9ja1dpbmRvdyk6CisgICAg ICAgIChEUlREZXZUb29sc0NsaWVudDo6dW5kb2NrV2luZG93KToKKwogMjAxMC0wNy0wNiAgS2Vu dCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2hp bmljaGlybyBIYW1hamkuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9EUlREZXZUb29sc0NsaWVudC5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9EUlREZXZUb29sc0NsaWVudC5jcHAKaW5kZXggOGVmOTY1YjhmMjUxMGU4ZjQw ZDRhMzVkNmQzN2VjZDEzMjFmMDIyNS4uZTE0ZjAwODkyZTQ2NDk5YjU2M2RlZjE4YTA5ZTc4MWYx MGM3NzZiZiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v RFJURGV2VG9vbHNDbGllbnQuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL0RSVERldlRvb2xzQ2xpZW50LmNwcApAQCAtNzgsMjUgKzc4LDIxIEBAIHZvaWQgRFJU RGV2VG9vbHNDbGllbnQ6OnNlbmREZWJ1Z2dlckNvbW1hbmRUb0FnZW50KGNvbnN0IFdlYlN0cmlu ZyYgY29tbWFuZCkKIHZvaWQgRFJURGV2VG9vbHNDbGllbnQ6OmFjdGl2YXRlV2luZG93KCkKIHsK ICAgICAvLyBOb3QgaW1wbGVtZW50ZWQuCi0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CiAK IHZvaWQgRFJURGV2VG9vbHNDbGllbnQ6OmNsb3NlV2luZG93KCkKIHsKICAgICAvLyBOb3QgaW1w bGVtZW50ZWQuCi0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CiAKIHZvaWQgRFJURGV2VG9v bHNDbGllbnQ6OmRvY2tXaW5kb3coKQogewogICAgIC8vIE5vdCBpbXBsZW1lbnRlZC4KLSAgICBB U1NFUlRfTk9UX1JFQUNIRUQoKTsKIH0KIAogdm9pZCBEUlREZXZUb29sc0NsaWVudDo6dW5kb2Nr V2luZG93KCkKIHsKICAgICAvLyBOb3QgaW1wbGVtZW50ZWQuCi0gICAgQVNTRVJUX05PVF9SRUFD SEVEKCk7CiB9CiAKIHZvaWQgRFJURGV2VG9vbHNDbGllbnQ6OmFzeW5jQ2FsbChjb25zdCBEUlRE ZXZUb29sc0NhbGxBcmdzJiBhcmdzKQo=