41736 2010-07-06 22:03:19 -0700 Implement start table tag in table mode 2010-07-11 16:09:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth commit-queue eric oldest_to_newest 247302 0 abarth 2010-07-06 22:03:19 -0700 Implement start table tag in table mode 247303 1 60680 abarth 2010-07-06 22:04:04 -0700 Created attachment 60680 Patch 247381 2 60680 commit-queue 2010-07-07 01:24:16 -0700 Comment on attachment 60680 Patch Rejecting patch 60680 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Last 500 characters of output: /HTMLTreeBuilder.h Hunk #1 FAILED at 122. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLTreeBuilder.h.rej patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/html5lib/runner-expected-html5.txt Hunk #1 FAILED at 595. Hunk #2 FAILED at 758. Hunk #3 succeeded at 1132 (offset -71 lines). Hunk #4 FAILED at 3536. Hunk #5 FAILED at 3553. 4 out of 5 hunks FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej Full output: http://webkit-commit-queue.appspot.com/results/3375427 249661 3 abarth 2010-07-11 16:09:36 -0700 This must have landed already. 60680 2010-07-06 22:04:04 -0700 2010-07-07 01:24:16 -0700 Patch bug-41736-20100706220403.patch text/plain 4755 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MjYyMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBs ZW1lbnQgc3RhcnQgdGFibGUgdGFnIGluIHRhYmxlIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNzM2CisKKyAgICAgICAgKiBodG1sL0hUTUxU cmVlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OnByb2Nl c3NTdGFydFRhZ0ZvckluVGFibGUpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWlsZGVy Ojpwcm9jZXNzVGFibGVFbmRUYWdGb3JJblRhYmxlKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxU cmVlQnVpbGRlcjo6cHJvY2Vzc0VuZFRhZ0ZvckluVGFibGUpOgorICAgICAgICAqIGh0bWwvSFRN TFRyZWVCdWlsZGVyLmg6CisKIDIwMTAtMDctMDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUv aHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1M VHJlZUJ1aWxkZXIuY3BwCShyZXZpc2lvbiA2MjYyMSkKKysrIFdlYkNvcmUvaHRtbC9IVE1MVHJl ZUJ1aWxkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NDMsNyArODQzLDEyIEBAIHZvaWQgSFRN TFRyZWVCdWlsZGVyOjpwcm9jZXNzU3RhcnRUYWdGb3IKICAgICAgICAgcmV0dXJuOwogICAgIH0K ICAgICBpZiAodG9rZW4ubmFtZSgpID09IHRhYmxlVGFnKSB7Ci0gICAgICAgIG5vdEltcGxlbWVu dGVkKCk7CisgICAgICAgIHBhcnNlRXJyb3IodG9rZW4pOworICAgICAgICBpZiAoIXByb2Nlc3NU YWJsZUVuZFRhZ0ZvckluVGFibGUoKSkgeworICAgICAgICAgICAgQVNTRVJUKG1faXNQYXJzaW5n RnJhZ21lbnQpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAgICAgIHByb2Nl c3NTdGFydFRhZyh0b2tlbik7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgaWYgKHRva2Vu Lm5hbWUoKSA9PSBzdHlsZVRhZyB8fCB0b2tlbi5uYW1lKCkgPT0gc2NyaXB0VGFnKSB7CkBAIC0x NTYxLDE4ICsxNTY2LDI0IEBAIGJvb2wgSFRNTFRyZWVCdWlsZGVyOjpwcm9jZXNzVHJFbmRUYWdG b3IKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAorYm9vbCBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NU YWJsZUVuZFRhZ0ZvckluVGFibGUoKQoreworICAgIGlmICghbV90cmVlLm9wZW5FbGVtZW50cygp LT5pblRhYmxlU2NvcGUodGFibGVUYWcpKSB7CisgICAgICAgIEFTU0VSVChtX2lzUGFyc2luZ0Zy YWdtZW50KTsKKyAgICAgICAgLy8gRklYTUU6IHBhcnNlIGVycm9yLgorICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgfQorICAgIG1fdHJlZS5vcGVuRWxlbWVudHMoKS0+cG9wVW50aWwodGFibGVU YWcubG9jYWxOYW1lKCkpOworICAgIG1fdHJlZS5vcGVuRWxlbWVudHMoKS0+cG9wKCk7CisgICAg cmVzZXRJbnNlcnRpb25Nb2RlQXBwcm9wcmlhdGVseSgpOworICAgIHJldHVybiB0cnVlOworfQor CiB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc0VuZFRhZ0ZvckluVGFibGUoQXRvbWljSFRN TFRva2VuJiB0b2tlbikKIHsKICAgICBBU1NFUlQodG9rZW4udHlwZSgpID09IEhUTUxUb2tlbjo6 RW5kVGFnKTsKICAgICBpZiAodG9rZW4ubmFtZSgpID09IHRhYmxlVGFnKSB7Ci0gICAgICAgIGlm ICghbV90cmVlLm9wZW5FbGVtZW50cygpLT5pblRhYmxlU2NvcGUodG9rZW4ubmFtZSgpKSkgewot ICAgICAgICAgICAgQVNTRVJUKG1faXNQYXJzaW5nRnJhZ21lbnQpOwotICAgICAgICAgICAgcGFy c2VFcnJvcih0b2tlbik7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KLSAgICAgICAg bV90cmVlLm9wZW5FbGVtZW50cygpLT5wb3BVbnRpbCh0YWJsZVRhZy5sb2NhbE5hbWUoKSk7Ci0g ICAgICAgIG1fdHJlZS5vcGVuRWxlbWVudHMoKS0+cG9wKCk7Ci0gICAgICAgIHJlc2V0SW5zZXJ0 aW9uTW9kZUFwcHJvcHJpYXRlbHkoKTsKKyAgICAgICAgcHJvY2Vzc1RhYmxlRW5kVGFnRm9ySW5U YWJsZSgpOwogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIGlmICh0b2tlbi5uYW1lKCkgPT0g Ym9keVRhZwpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuaAkocmV2aXNpb24gNjI2MjEpCisrKyBX ZWJDb3JlL2h0bWwvSFRNTFRyZWVCdWlsZGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyMiw2ICsx MjIsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBwcm9jZXNzSXNpbmRleFN0YXJ0VGFnRm9ySW5C b2R5KEF0b21pY0hUTUxUb2tlbiYpOwogICAgIGJvb2wgcHJvY2Vzc0JvZHlFbmRUYWdGb3JJbkJv ZHkoQXRvbWljSFRNTFRva2VuJik7CisgICAgYm9vbCBwcm9jZXNzVGFibGVFbmRUYWdGb3JJblRh YmxlKCk7CiAgICAgYm9vbCBwcm9jZXNzQ2FwdGlvbkVuZFRhZ0ZvckluQ2FwdGlvbigpOwogICAg IGJvb2wgcHJvY2Vzc0NvbGdyb3VwRW5kVGFnRm9ySW5Db2x1bW5Hcm91cCgpOwogICAgIGJvb2wg cHJvY2Vzc1RyRW5kVGFnRm9ySW5Sb3coKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDYyNjIyKQorKysg TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIw MTAtMDctMDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgc3RhcnQgdGFibGUg dGFnIGluIHRhYmxlIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQxNzM2CisKKyAgICAgICAgKiBodG1sNWxpYi9ydW5uZXItZXhwZWN0ZWQtaHRt bDUudHh0OgorCiAyMDEwLTA3LTA2ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCB0ZXN0IGV4cGVjdGF0aW9uIHVwZGF0ZS4KSW5kZXg6IExh eW91dFRlc3RzL2h0bWw1bGliL3J1bm5lci1leHBlY3RlZC1odG1sNS50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvaHRtbDVsaWIvcnVubmVyLWV4cGVjdGVkLWh0bWw1LnR4dAkocmV2aXNp b24gNjI2MjEpCisrKyBMYXlvdXRUZXN0cy9odG1sNWxpYi9ydW5uZXItZXhwZWN0ZWQtaHRtbDUu dHh0CSh3b3JraW5nIGNvcHkpCkBAIC01OTUsNyArNTk1LDYgQEAgcmVzb3VyY2VzL3Rlc3RzNi5k YXQ6CiAyNwogMzAKIDM3Ci00MgogNDQKIDQ1CiA0NgpAQCAtNzU5LDIwICs3NTgsNiBAQCBHb3Q6 CiBFeHBlY3RlZDoKIHwgPHRyPgogCi1UZXN0IDQyIG9mIDUxIGluIHJlc291cmNlcy90ZXN0czYu ZGF0IGZhaWxlZC4gSW5wdXQ6Ci08dGFibGU+PHRhYmxlPgotR290OgotfCA8aHRtbD4KLXwgICA8 aGVhZD4KLXwgICA8Ym9keT4KLXwgICAgIDx0YWJsZT4KLUV4cGVjdGVkOgotfCA8aHRtbD4KLXwg ICA8aGVhZD4KLXwgICA8Ym9keT4KLXwgICAgIDx0YWJsZT4KLXwgICAgIDx0YWJsZT4KLQogVGVz dCA0NCBvZiA1MSBpbiByZXNvdXJjZXMvdGVzdHM2LmRhdCBmYWlsZWQuIElucHV0OgogPC90YWJs ZT48dHI+CiBHb3Q6CkBAIC0xMjE4LDYgKzEyMDMsNyBAQCBHb3Q6CiB8ICAgPGJvZHk+CiB8ICAg ICAieCIKIHwgICAgIDx0YWJsZT4KK3wgICAgIDx0YWJsZT4KIHwgICAgICAgIngiCiBFeHBlY3Rl ZDoKIHwgPGh0bWw+CkBAIC0zNjIxLDcgKzM2MDcsNiBAQCByZXNvdXJjZXMvaXNpbmRleC5kYXQ6 IFBBU1MKIAogcmVzb3VyY2VzL3RhYmxlczAxLmRhdDoKIDQKLTgKIAogVGVzdCA0IG9mIDE1IGlu IHJlc291cmNlcy90YWJsZXMwMS5kYXQgZmFpbGVkLiBJbnB1dDoKIDx0YWJsZT48Y29sZ3JvdXA+ PC9odG1sPmZvbwpAQCAtMzYzOSwyMCArMzYyNCw0IEBAIEV4cGVjdGVkOgogfCAgICAgImZvbyIK IHwgICAgIDx0YWJsZT4KIHwgICAgICAgPGNvbGdyb3VwPgotCi1UZXN0IDggb2YgMTUgaW4gcmVz b3VyY2VzL3RhYmxlczAxLmRhdCBmYWlsZWQuIElucHV0OgotPHRhYmxlPjxzZWxlY3Q+PHRhYmxl PjwvdGFibGU+PC9zZWxlY3Q+PC90YWJsZT4KLUdvdDoKLXwgPGh0bWw+Ci18ICAgPGhlYWQ+Ci18 ICAgPGJvZHk+Ci18ICAgICA8c2VsZWN0PgotfCAgICAgPHRhYmxlPgotRXhwZWN0ZWQ6Ci18IDxo dG1sPgotfCAgIDxoZWFkPgotfCAgIDxib2R5PgotfCAgICAgPHNlbGVjdD4KLXwgICAgIDx0YWJs ZT4KLXwgICAgIDx0YWJsZT4KICNFT0YK