41726 2010-07-06 17:55:56 -0700 Expose URL matching from WebUserContentURLPattern 2010-07-06 22:42:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sfalken sfalken oldest_to_newest 247249 0 sfalken 2010-07-06 17:55:56 -0700 Expose URL matching from WebUserContentURLPattern 247253 1 60667 sfalken 2010-07-06 18:02:36 -0700 Created attachment 60667 Patch 247306 2 60667 simon.fraser 2010-07-06 22:22:46 -0700 Comment on attachment 60667 Patch > Index: WebCore/ChangeLog > =================================================================== > + Expose URL matching from WebUserContentURLPattern > + https://bugs.webkit.org/show_bug.cgi?id=41726 > + > + No new tests. (OOPS!) You should remove this line. > Index: WebKit/mac/ChangeLog > =================================================================== > --- WebKit/mac/ChangeLog (revision 62607) > +++ WebKit/mac/ChangeLog (working copy) > @@ -1,3 +1,14 @@ > +2010-07-06 Steve Falkenburg <sfalken@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Expose URL matching from WebUserContentURLPattern > + https://bugs.webkit.org/show_bug.cgi?id=41726 > + > + * Misc/WebUserContentURLPattern.h: > + * Misc/WebUserContentURLPattern.mm: > + (-[WebUserContentURLPattern matchesURL:]): I would like to see a few words about the change. > Index: WebKit/win/ChangeLog > =================================================================== > + Expose URL matching from WebUserContentURLPattern > + https://bugs.webkit.org/show_bug.cgi?id=41726 > + > + * Interfaces/IWebUserContentURLPattern.idl: > + * Interfaces/IWebView.idl: > + * WebUserContentURLPattern.cpp: > + (WebUserContentURLPattern::matchesURL): > + * WebUserContentURLPattern.h: You could explain the whitespace change to the idl file here at least. r=me 247316 3 sfalken 2010-07-06 22:42:47 -0700 http://trac.webkit.org/changeset/62625 60667 2010-07-06 18:02:36 -0700 2010-07-06 22:22:46 -0700 Patch bug-41726-20100706180049.patch text/plain 5831 sfalken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MjYwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDctMDYgIFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBFeHBvc2UgVVJMIG1hdGNoaW5nIGZyb20gV2ViVXNlckNvbnRlbnRVUkxQYXR0ZXJuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTcyNgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogV2ViQ29yZS5iYXNlLmV4cDoK KwogMjAxMC0wNy0wNiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5iYXNlLmV4 cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUuYmFzZS5leHAJKHJldmlzaW9uIDYyMzM1 KQorKysgV2ViQ29yZS9XZWJDb3JlLmJhc2UuZXhwCSh3b3JraW5nIGNvcHkpCkBAIC05MDEsNiAr OTAxLDcgQEAgX19aTks3V2ViQ29yZTIwUmVzb3VyY2VSZXNwb25zZUJhc2UxNnRleAogX19aTks3 V2ViQ29yZTIwUmVzb3VyY2VSZXNwb25zZUJhc2UxN3N1Z2dlc3RlZEZpbGVuYW1lRXYKIF9fWk5L N1dlYkNvcmUyMFJlc291cmNlUmVzcG9uc2VCYXNlM3VybEV2CiBfX1pOSzdXZWJDb3JlMjBSZXNv dXJjZVJlc3BvbnNlQmFzZThtaW1lVHlwZUV2CitfX1pOSzdXZWJDb3JlMjFVc2VyQ29udGVudFVS TFBhdHRlcm43bWF0Y2hlc0VSS05TXzRLVVJMRQogX19aTks3V2ViQ29yZTIzRnJhbWVMb2FkZXJT dGF0ZU1hY2hpbmUxNWZpcnN0TGF5b3V0RG9uZUV2CiBfX1pOSzdXZWJDb3JlMjNGcmFtZUxvYWRl clN0YXRlTWFjaGluZTIzY29tbWl0dGluZ0ZpcnN0UmVhbExvYWRFdgogX19aTks3V2ViQ29yZTI2 TmV0c2NhcGVQbHVnSW5TdHJlYW1Mb2FkZXI2aXNEb25lRXYKSW5kZXg6IFdlYktpdC9tYWMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2MjYw NykKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTAtMDctMDYgIFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHBvc2UgVVJM IG1hdGNoaW5nIGZyb20gV2ViVXNlckNvbnRlbnRVUkxQYXR0ZXJuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTcyNgorCisgICAgICAgICogTWlzYy9X ZWJVc2VyQ29udGVudFVSTFBhdHRlcm4uaDoKKyAgICAgICAgKiBNaXNjL1dlYlVzZXJDb250ZW50 VVJMUGF0dGVybi5tbToKKyAgICAgICAgKC1bV2ViVXNlckNvbnRlbnRVUkxQYXR0ZXJuIG1hdGNo ZXNVUkw6XSk6CisKIDIwMTAtMDYtMjMgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KSW5kZXg6IFdlYktp dC9tYWMvTWlzYy9XZWJVc2VyQ29udGVudFVSTFBhdHRlcm4uaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvbWFjL01pc2MvV2ViVXNlckNvbnRlbnRVUkxQYXR0ZXJuLmgJKHJldmlzaW9uIDYyMzM1KQor KysgV2ViS2l0L21hYy9NaXNjL1dlYlVzZXJDb250ZW50VVJMUGF0dGVybi5oCSh3b3JraW5nIGNv cHkpCkBAIC0zNCw1ICszNCw2IEBAIEBpbnRlcmZhY2UgV2ViVXNlckNvbnRlbnRVUkxQYXR0ZXJu IDogTlMKIC0gKE5TU3RyaW5nICopc2NoZW1lOwogLSAoTlNTdHJpbmcgKilob3N0OwogLSAoQk9P TCltYXRjaGVzU3ViZG9tYWluczsKKy0gKEJPT0wpbWF0Y2hlc1VSTDooTlNVUkwgKil1cmw7CiAK IEBlbmQKSW5kZXg6IFdlYktpdC9tYWMvTWlzYy9XZWJVc2VyQ29udGVudFVSTFBhdHRlcm4ubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9NaXNjL1dlYlVzZXJDb250ZW50VVJMUGF0dGVybi5t bQkocmV2aXNpb24gNjIzMzUpCisrKyBXZWJLaXQvbWFjL01pc2MvV2ViVXNlckNvbnRlbnRVUkxQ YXR0ZXJuLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNCw2ICsyNCw3IEBACiAKICNpbXBvcnQgIldl YlVzZXJDb250ZW50VVJMUGF0dGVybi5oIgogCisjaW1wb3J0IDxXZWJDb3JlL0tVUkwuaD4KICNp bXBvcnQgPFdlYkNvcmUvVXNlckNvbnRlbnRVUkxQYXR0ZXJuLmg+CiAKIHVzaW5nIG5hbWVzcGFj ZSBXZWJDb3JlOwpAQCAtODAsNCArODEsOSBAQCAtIChCT09MKW1hdGNoZXNTdWJkb21haW5zCiAg ICAgcmV0dXJuIF9wcml2YXRlLT5wYXR0ZXJuLm1hdGNoU3ViZG9tYWlucygpOwogfQogCistIChC T09MKW1hdGNoZXNVUkw6KE5TVVJMICopdXJsCit7CisgICAgcmV0dXJuIF9wcml2YXRlLT5wYXR0 ZXJuLm1hdGNoZXModXJsKTsKK30KKwogQGVuZApJbmRleDogV2ViS2l0L3dpbi9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDYyNjA3KQorKysg V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAx MC0wNy0wNiAgU3RldmUgRmFsa2VuYnVyZyAgPHNmYWxrZW5AYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cG9zZSBVUkwgbWF0Y2hp bmcgZnJvbSBXZWJVc2VyQ29udGVudFVSTFBhdHRlcm4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNzI2CisKKyAgICAgICAgKiBJbnRlcmZhY2VzL0lX ZWJVc2VyQ29udGVudFVSTFBhdHRlcm4uaWRsOgorICAgICAgICAqIEludGVyZmFjZXMvSVdlYlZp ZXcuaWRsOgorICAgICAgICAqIFdlYlVzZXJDb250ZW50VVJMUGF0dGVybi5jcHA6CisgICAgICAg IChXZWJVc2VyQ29udGVudFVSTFBhdHRlcm46Om1hdGNoZXNVUkwpOgorICAgICAgICAqIFdlYlVz ZXJDb250ZW50VVJMUGF0dGVybi5oOgorCiAyMDEwLTA3LTAzICBKb24gSG9uZXljdXR0ICA8amhv bmV5Y3V0dEBhcHBsZS5jb20+CiAKICAgICAgICAgVGhlIG1pc3NpbmcgcGx1Zy1pbiBpbmRpY2F0 b3Igc2hvdWxkIGJlIGNsaWNrYWJsZQpJbmRleDogV2ViS2l0L3dpbi9XZWJVc2VyQ29udGVudFVS TFBhdHRlcm4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vV2ViVXNlckNvbnRlbnRVUkxQ YXR0ZXJuLmNwcAkocmV2aXNpb24gNjIzMzUpCisrKyBXZWJLaXQvd2luL1dlYlVzZXJDb250ZW50 VVJMUGF0dGVybi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzLDkgKzIzLDExIEBACiAgKi8KIAog I2luY2x1ZGUgImNvbmZpZy5oIgotI2luY2x1ZGUgIldlYktpdERMTC5oIgogI2luY2x1ZGUgIldl YlVzZXJDb250ZW50VVJMUGF0dGVybi5oIgogCisjaW5jbHVkZSAiTWFyc2hhbGxpbmdIZWxwZXJz LmgiCisjaW5jbHVkZSAiV2ViS2l0RExMLmgiCisKICNpbmNsdWRlIDxXZWJDb3JlL0JTdHJpbmcu aD4KICNpbmNsdWRlIDxXZWJDb3JlL0tVUkwuaD4KIApAQCAtMTE4LDMgKzEyMCwxMSBAQCBIUkVT VUxUIFdlYlVzZXJDb250ZW50VVJMUGF0dGVybjo6bWF0Y2hlCiAgICAgKm1hdGNoZXMgPSBtX3Bh dHRlcm4ubWF0Y2hTdWJkb21haW5zKCk7CiAgICAgcmV0dXJuIFNfT0s7CiB9CisKK0hSRVNVTFQg V2ViVXNlckNvbnRlbnRVUkxQYXR0ZXJuOjptYXRjaGVzVVJMKEJTVFIgdXJsLCBCT09MKiBtYXRj aGVzKQoreworICAgIGlmICghbWF0Y2hlcykKKyAgICAgICAgcmV0dXJuIEVfUE9JTlRFUjsKKyAg ICAqbWF0Y2hlcyA9IG1fcGF0dGVybi5tYXRjaGVzKE1hcnNoYWxsaW5nSGVscGVyczo6QlNUUlRv S1VSTCh1cmwpKTsKKyAgICByZXR1cm4gU19PSzsKK30KSW5kZXg6IFdlYktpdC93aW4vV2ViVXNl ckNvbnRlbnRVUkxQYXR0ZXJuLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3dpbi9XZWJVc2VyQ29u dGVudFVSTFBhdHRlcm4uaAkocmV2aXNpb24gNjIzMzUpCisrKyBXZWJLaXQvd2luL1dlYlVzZXJD b250ZW50VVJMUGF0dGVybi5oCSh3b3JraW5nIGNvcHkpCkBAIC00OSw2ICs0OSw3IEBAIHByaXZh dGU6CiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHNjaGVtZShCU1RSKik7 CiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIGhvc3QoQlNUUiopOwogICAg IHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBtYXRjaGVzU3ViZG9tYWlucyhCT09M KiBtYXRjaGVzKTsKKyAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgbWF0Y2hl c1VSTChCU1RSLCBCT09MKik7CiAKICAgICBVTE9ORyBtX3JlZkNvdW50OwogICAgIFdlYkNvcmU6 OlVzZXJDb250ZW50VVJMUGF0dGVybiBtX3BhdHRlcm47CkluZGV4OiBXZWJLaXQvd2luL0ludGVy ZmFjZXMvSVdlYlVzZXJDb250ZW50VVJMUGF0dGVybi5pZGwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L3dpbi9JbnRlcmZhY2VzL0lXZWJVc2VyQ29udGVudFVSTFBhdHRlcm4uaWRsCShyZXZpc2lvbiA2 MjMzNSkKKysrIFdlYktpdC93aW4vSW50ZXJmYWNlcy9JV2ViVXNlckNvbnRlbnRVUkxQYXR0ZXJu LmlkbAkod29ya2luZyBjb3B5KQpAQCAtNDAsNCArNDAsNSBAQCBpbnRlcmZhY2UgSVdlYlVzZXJD b250ZW50VVJMUGF0dGVybiA6IElVCiAgICAgSFJFU1VMVCBzY2hlbWUoW291dCwgcmV0dmFsXSBC U1RSKik7CiAgICAgSFJFU1VMVCBob3N0KFtvdXQsIHJldHZhbF0gQlNUUiopOwogICAgIEhSRVNV TFQgbWF0Y2hlc1N1YmRvbWFpbnMoW291dCwgcmV0dmFsXSBCT09MKiBtYXRjaGVzKTsKKyAgICBI UkVTVUxUIG1hdGNoZXNVUkwoW2luXSBCU1RSIHVybCwgW291dCwgcmV0dmFsXSBCT09MKiBtYXRj aGVzKTsKIH0KSW5kZXg6IFdlYktpdC93aW4vSW50ZXJmYWNlcy9JV2ViVmlldy5pZGwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L3dpbi9JbnRlcmZhY2VzL0lXZWJWaWV3LmlkbAkocmV2aXNpb24gNjIz MzUpCisrKyBXZWJLaXQvd2luL0ludGVyZmFjZXMvSVdlYlZpZXcuaWRsCSh3b3JraW5nIGNvcHkp CkBAIC0xMjE2LDMgKzEyMTYsNiBAQCBpbnRlcmZhY2UgSVdlYlZpZXdFZGl0aW5nQWN0aW9ucyA6 IElVbmtuCiAgICAgKi8KICAgICBIUkVTVUxUIHN0b3BTcGVha2luZyhbaW5dIElVbmtub3duKiBz ZW5kZXIpOwogfQorCisKKwo=