41704 2010-07-06 10:32:02 -0700 [GTK] build-webkit should not run autogen.sh unconditionally 2010-07-06 10:45:36 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned oldest_to_newest 247122 0 mrobinson 2010-07-06 10:32:02 -0700 Currently build-webkit runs autogen.sh always. The makefiles that autotools generates should be smart enough to know when the originally build files have been modified and re-rerun autogen.sh. On my machine, this change reduces a null build from 60 seconds to 14 seconds. 247123 1 60637 mrobinson 2010-07-06 10:33:53 -0700 Created attachment 60637 Patch 247126 2 60637 xan.lopez 2010-07-06 10:37:34 -0700 Comment on attachment 60637 Patch Looks good to me! 247130 3 mrobinson 2010-07-06 10:45:36 -0700 Committed r62564: <http://trac.webkit.org/changeset/62564> 60637 2010-07-06 10:33:53 -0700 2010-07-06 10:37:34 -0700 Patch bug-41704-20100706103352.patch text/plain 2825 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyNGFjZmQyZGVlYmYzNDY0MzI4YjEzMDA2OWIyY2JlNzRmZmNlMzc3Li5jMTEzN2Fh NDY1YTI0OWYxZmZiMTk2ZDczODE3NDNjNTVjOTM3YTAxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDctMDYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIGJ1aWxk LXdlYmtpdCBzaG91bGQgbm90IHJ1biBhdXRvZ2VuLnNoIHVuY29uZGl0aW9uYWxseQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE3MDQKKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbTogT25seSBydW4gYXV0b2dlbi5zaCBkdXJpbmcgYSBi dWlsZCBpZiBHTlVtYWtlZmlsZQorICAgICAgICBkb2Vzbid0IGV4aXN0LiBBdXRvdG9vbHMgc2hv dWxkIHJlLXJ1biBhdXRvZ2VuLnNoIHdoZW4gbmVjZXNzYXJ5LiBBbHNvIGRvCisgICAgICAgIHNv bWUgdmVyeSBtaW5vciBjbGVhbnVwLgorCiAyMDEwLTA3LTA2ICBEYXJpbiBBZGxlciAgPGRhcmlu QGFwcGxlLmNvbT4KIAogICAgICAgICBUcnkgdG8gZml4IENocm9taXVtIGJ1aWxkLgpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDlmNTRjM2U2MjJhODEzMjc2MDljMWQxMDk5NTRlMTdk OTgxZDcyY2EuLjBjZmI1YmU1YjEzOGVjZGY2ZjcyZTY3NTVlYWU0MWIzOGFlZGI5NjMgMTAwNjQ0 Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTEzMDksMzEgKzEzMDksMjkgQEAgc3ViIGJ1aWxk QXV0b3Rvb2xzUHJvamVjdCgkQCkKICAgICB9CiAKICAgICBpZiAoISAtZCAkZGlyKSB7Ci0gICAg ICAgIHN5c3RlbSAibWtkaXIiLCAiLXAiLCAiJGRpciI7Ci0gICAgICAgIGlmICghIC1kICRkaXIp IHsKLSAgICAgICAgICAgIGRpZSAiRmFpbGVkIHRvIGNyZWF0ZSBidWlsZCBkaXJlY3RvcnkgIiAu ICRkaXI7Ci0gICAgICAgIH0KKyAgICAgICAgRmlsZTo6UGF0aDo6bWtwYXRoKCRkaXIpIG9yIGRp ZSAiRmFpbGVkIHRvIGNyZWF0ZSBidWlsZCBkaXJlY3RvcnkgIiAuICRkaXIKICAgICB9Ci0KICAg ICBjaGRpciAkZGlyIG9yIGRpZSAiRmFpbGVkIHRvIGNkIGludG8gIiAuICRkaXIgLiAiXG4iOwog Ci0gICAgbXkgJHJlc3VsdDsKICAgICBpZiAoJGNsZWFuKSB7Ci0gICAgICAgICMkcmVzdWx0ID0g c3lzdGVtICRtYWtlLCAiZGlzdGNsZWFuIjsKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogCi0g ICAgcHJpbnQgIkNhbGxpbmcgY29uZmlndXJlIGluICIgLiAkZGlyIC4gIlxuXG4iOwotICAgIHBy aW50ICJJbnN0YWxsYXRpb24gcHJlZml4IGRpcmVjdG9yeTogJHByZWZpeFxuIiBpZihkZWZpbmVk KCRwcmVmaXgpKTsKLQotICAgICMgTWFrZSB0aGUgcGF0aCByZWxhdGl2ZSBzaW5jZSBpdCB3aWxs IGFwcGVhciBpbiBhbGwgLUkgY29tcGlsZXIgZmxhZ3MuCi0gICAgIyBMb25nIGFyZ3VtZW50IGxp c3RzIGNhdXNlIGJpemFycmUgc2xvd2Rvd25zIGluIGxpYnRvb2wuCi0gICAgbXkgJHJlbFNvdXJj ZURpciA9IEZpbGU6OlNwZWMtPmFiczJyZWwoJHNvdXJjZURpcik7Ci0gICAgJHJlbFNvdXJjZURp ciA9ICIuIiBpZiAhJHJlbFNvdXJjZURpcjsKLQotICAgICRyZXN1bHQgPSBzeXN0ZW0gIiRyZWxT b3VyY2VEaXIvYXV0b2dlbi5zaCIsIEBidWlsZEFyZ3M7Ci0gICAgaWYgKCRyZXN1bHQgbmUgMCkg ewotICAgICAgICBkaWUgIkZhaWxlZCB0byBzZXR1cCBidWlsZCBlbnZpcm9ubWVudCB1c2luZyAn YXV0b3Rvb2xzJyFcbiI7CisgICAgIyBJZiBHTlVtYWtlZmlsZSBleGlzdHMsIGRvbid0IHJ1biBh dXRvZ2VuLnNoLiBUaGUgbWFrZWZpbGUgc2hvdWxkIGJlCisgICAgIyBzbWFydCBlbm91Z2ggdG8g dHJhY2sgYXV0b3Rvb2xzIGRlcGVuZGVuY2llcyBhbmQgcmUtcnVuIGF1dG9nZW4uc2gKKyAgICAj IHdoZW4gYnVpbGQgZmlsZXMgY2hhbmdlLgorICAgIG15ICRyZXN1bHQ7CisgICAgaWYgKCEgLWUg IkdOVW1ha2VmaWxlIikgeworICAgICAgICBwcmludCAiQ2FsbGluZyBjb25maWd1cmUgaW4gIiAu ICRkaXIgLiAiXG5cbiI7CisgICAgICAgIHByaW50ICJJbnN0YWxsYXRpb24gcHJlZml4IGRpcmVj dG9yeTogJHByZWZpeFxuIiBpZihkZWZpbmVkKCRwcmVmaXgpKTsKKworICAgICAgICAjIE1ha2Ug dGhlIHBhdGggcmVsYXRpdmUgc2luY2UgaXQgd2lsbCBhcHBlYXIgaW4gYWxsIC1JIGNvbXBpbGVy IGZsYWdzLgorICAgICAgICAjIExvbmcgYXJndW1lbnQgbGlzdHMgY2F1c2UgYml6YXJyZSBzbG93 ZG93bnMgaW4gbGlidG9vbC4KKyAgICAgICAgbXkgJHJlbFNvdXJjZURpciA9IEZpbGU6OlNwZWMt PmFiczJyZWwoJHNvdXJjZURpcikgfHwgIi4iOworICAgICAgICAkcmVzdWx0ID0gc3lzdGVtICIk cmVsU291cmNlRGlyL2F1dG9nZW4uc2giLCBAYnVpbGRBcmdzOworICAgICAgICBpZiAoJHJlc3Vs dCBuZSAwKSB7CisgICAgICAgICAgICBkaWUgIkZhaWxlZCB0byBzZXR1cCBidWlsZCBlbnZpcm9u bWVudCB1c2luZyAnYXV0b3Rvb2xzJyFcbiI7CisgICAgICAgIH0KICAgICB9CiAKICAgICAkcmVz dWx0ID0gc3lzdGVtICIkbWFrZSAkbWFrZUFyZ3MiOwo=