41696 2010-07-06 07:04:28 -0700 Web Inspector: script names are shown with ":0" 2010-07-07 03:25:39 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 podivilov webkit-unassigned commit-queue eric tonyg yurys oldest_to_newest 247063 0 podivilov 2010-07-06 07:04:28 -0700 Web Inspector: script names are shown with ":0" 247064 1 60630 podivilov 2010-07-06 07:06:44 -0700 Created attachment 60630 Proposed patch. 247161 2 60630 commit-queue 2010-07-06 11:52:19 -0700 Comment on attachment 60630 Proposed patch. Clearing flags on attachment: 60630 Committed r62575: <http://trac.webkit.org/changeset/62575> 247162 3 commit-queue 2010-07-06 11:52:24 -0700 All reviewed patches have been landed. Closing bug. 247420 4 60630 yurys 2010-07-07 02:44:27 -0700 Comment on attachment 60630 Proposed patch. WebCore/bindings/v8/ScriptDebugServer.cpp:383 + object->Get(v8::String::New("lineOffset"))->ToInteger()->Value() + 1, This should be done in DebuggerScript.js using DebuggerScript._v8ToWebkitLineNumber. Please fix this in a separate change. 247423 5 eric 2010-07-07 02:49:42 -0700 There isn't really any such thing as a "webkit line number". Line numbers are a mess. The code is sprinkled with all sorts of +1's, not all of which make sense. Search for lineNumber() to see what I mean. 247427 6 yurys 2010-07-07 02:55:08 -0700 (In reply to comment #5) > There isn't really any such thing as a "webkit line number". Line numbers are a mess. The code is sprinkled with all sorts of +1's, not all of which make sense. > > Search for lineNumber() to see what I mean. In case of debugger we try to localize line number arithmetic related to v8(script line numbers start from 0)/WebCore(script line numbers are assumed to start from 1) in DebuggerScript.js 247449 7 eric 2010-07-07 03:25:39 -0700 The question is where you get the line number from in WebCore. I think the parser starts at 0, but ScriptController/JavaScriptCore start at 1. Someone needs to straighten this all out some day. 60630 2010-07-06 07:06:44 -0700 2010-07-07 02:44:27 -0700 Proposed patch. tmp.diff text/plain 1428 podivilov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTVkYzhjMS4uOTMyMWNlZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0wNiAgUGF2ZWwgUG9kaXZp bG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBjb252ZXJ0IHNjcmlwdCBvZmZz ZXQgdG8gd2Via2l0IGZvcm1hdCBpbiB2OCBTY3JpcHREZWJ1Z1NlcnZlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE2OTYKKworICAgICAgICAqIGJp bmRpbmdzL3Y4L1NjcmlwdERlYnVnU2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlw dERlYnVnU2VydmVyOjpkaXNwYXRjaERpZFBhcnNlU291cmNlKToKKwogMjAxMC0wNy0wNiAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBC YXJ0aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0RGVidWdTZXJ2ZXIu Y3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5jcHAKaW5kZXggODU1 M2VlNS4uZTJkMGY3MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHREZWJ1 Z1NlcnZlci5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5j cHAKQEAgLTM4MCw3ICszODAsNyBAQCB2b2lkIFNjcmlwdERlYnVnU2VydmVyOjpkaXNwYXRjaERp ZFBhcnNlU291cmNlKFNjcmlwdERlYnVnTGlzdGVuZXIqIGxpc3RlbmVyLCB2OAogICAgICAgICB0 b1dlYkNvcmVTdHJpbmdXaXRoTnVsbE9yVW5kZWZpbmVkQ2hlY2sob2JqZWN0LT5HZXQodjg6OlN0 cmluZzo6TmV3KCJpZCIpKSksCiAgICAgICAgIHRvV2ViQ29yZVN0cmluZ1dpdGhOdWxsT3JVbmRl ZmluZWRDaGVjayhvYmplY3QtPkdldCh2ODo6U3RyaW5nOjpOZXcoIm5hbWUiKSkpLAogICAgICAg ICB0b1dlYkNvcmVTdHJpbmdXaXRoTnVsbE9yVW5kZWZpbmVkQ2hlY2sob2JqZWN0LT5HZXQodjg6 OlN0cmluZzo6TmV3KCJzb3VyY2UiKSkpLAotICAgICAgICBvYmplY3QtPkdldCh2ODo6U3RyaW5n OjpOZXcoImxpbmVPZmZzZXQiKSktPlRvSW50ZWdlcigpLT5WYWx1ZSgpLAorICAgICAgICBvYmpl Y3QtPkdldCh2ODo6U3RyaW5nOjpOZXcoImxpbmVPZmZzZXQiKSktPlRvSW50ZWdlcigpLT5WYWx1 ZSgpICsgMSwKICAgICAgICAgc3RhdGljX2Nhc3Q8U2NyaXB0V29ybGRUeXBlPihvYmplY3QtPkdl dCh2ODo6U3RyaW5nOjpOZXcoInNjcmlwdFdvcmxkVHlwZSIpKS0+SW50MzJWYWx1ZSgpKSk7CiB9 CiAK