41695 2010-07-06 06:37:22 -0700 [DRT] Assertion failed when drag and move a draggable element. 2010-08-04 05:38:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 39725 1 morrita morrita eric oldest_to_newest 247055 0 60627 morrita 2010-07-06 06:37:22 -0700 Created attachment 60627 reproduce. DumprRenderTree gets assertion failure when drag an element with mouseDown() followed by multiple mouseMoveTo() calls. A reproduction is attached. This problem prevents testing Bug 39725. 247061 1 60629 morrita 2010-07-06 06:58:54 -0700 Created attachment 60629 patch v0 247062 2 morrita 2010-07-06 07:00:22 -0700 Hi Eric, could you review this? All tests are passed. 259722 3 60629 tony 2010-08-03 15:08:34 -0700 Comment on attachment 60629 patch v0 The code looks fine, just some small style nits. > diff --git a/LayoutTests/fast/events/dragging-mouse-moves.html b/LayoutTests/fast/events/dragging-mouse-moves.html > + <style> * { margin: 0px; padding: 0px; } </style> > + <script> > + function log(msg) > + { The code is indented a strange amount here. Maybe line it up with the <script> tag? > + if (window.layoutTestController) { > + layoutTestController.waitUntilDone(); > + layoutTestController.dumpAsText(); > + testDragAndMove(); > + } It would be nice to have a message saying this test requires DRT if !window.layoutTestController. > + eventSender.mouseMoveTo(startX,startY); > + eventSender.mouseDown(); > + // Them drag it. OK not to crash. Grammar nit: "Then drag it." > diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog > + mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started. > + But Cocoa doesn't call mouseDragged() untill dragging is done. Spelling: until > + Other part of DumpRenderTree also assumes Cocoa behaviour and an assertion Spelling/Grammar: behavior (to use the US spelling) > + on UIDelegate failed when mouseDragged() is called dudring dragging. Spelling: during 259980 4 morrita 2010-08-04 05:38:53 -0700 Committed r64643: <http://trac.webkit.org/changeset/64643> 60627 2010-07-06 06:37:22 -0700 2010-07-06 06:37:22 -0700 reproduce. dragging-mouse-moves.html text/html 1513 morrita PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIKCSJodHRwOi8vd3d3LnczLm9yZy9UUi94aHRtbDEvRFREL3hodG1sMS10cmFuc2l0aW9u YWwuZHRkIj4KPGh0bWw+CiAgICA8aGVhZD4KICAgICAgICA8c3R5bGU+ICogeyBtYXJnaW46IDBw eDsgcGFkZGluZzogMHB4OyB9IDwvc3R5bGU+CiAgICAgICAgPHNjcmlwdD4KICAgICAgIGZ1bmN0 aW9uIGxvZyhtc2cpCiAgICAgICB7CiAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J2NvbnNvbGUnKS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShtc2cgKyAnXG4n KSk7CiAgICAgICB9CgogICAgICAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICB7CiAgICAgICAgICAg aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgICAgICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CiAgICAgICAgICAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKICAgICAgICAgICAgICAgdGVzdERyYWdBbmRNb3ZlKCk7 CiAgICAgICAgICAgfQogICAgICAgfQoKICAgICAgIGZ1bmN0aW9uIHRlc3REcmFnQW5kTW92ZSgp CiAgICAgICB7CiAgICAgICAgICAgdmFyIGRyYWdnYWJsZSA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJkcmFnZ2FibGVGb3JEaXYiKTsKCiAgICAgICAgICAgdmFyIHN0YXJ0WCA9IGRyYWdnYWJs ZS5vZmZzZXRMZWZ0ICsgNTsKICAgICAgICAgICB2YXIgc3RhcnRZID0gZHJhZ2dhYmxlLm9mZnNl dFRvcCArIDU7CgogICAgICAgICAgIGV2ZW50U2VuZGVyLmRyYWdNb2RlID0gZmFsc2U7CgogICAg ICAgICAgIC8vIEdyYWIgdGhlIGRyYWdnYWJsZSBub2RlCiAgICAgICAgICAgZXZlbnRTZW5kZXIu bW91c2VNb3ZlVG8oc3RhcnRYLHN0YXJ0WSk7CiAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VE b3duKCk7CiAgICAgICAgICAgLy8gVGhlbSBkcmFnIGl0LiBPSyBub3QgdG8gY3Jhc2guCiAgICAg ICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oc3RhcnRYICsgMTAsIHN0YXJ0WSArIDEwKTsK ICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhzdGFydFggKyAyMCwgc3RhcnRZICsg MjApOwoKICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdCIpLnN0eWxlLmRp c3BsYXkgPSAibm9uZSI7CiAgICAgICAgICAgbG9nKCJQQVNTIik7CiAgICAgICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwogICAgICAgIH0KICAgICAgICA8L3NjcmlwdD4K ICAgIDwvaGVhZD4KPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgogICA8ZGl2IGlkPSJ0ZXN0Ij4KICAg ICA8cD5UZXN0IGZvciBCdWcgWFhYWDwvcD4KICAgICA8c3BhbiBkcmFnZ2FibGU9InRydWUiIGlk PSJkcmFnZ2FibGVGb3JEaXYiPmRyYWdtZTwvc3Bhbj4KICAgPC9kaXY+CiAgIDxwcmUgaWQ9ImNv bnNvbGUiPjwvcHJlPgo8L2JvZHk+CjwvaHRtbD4KCg== 60629 2010-07-06 06:58:54 -0700 2010-08-03 15:08:34 -0700 patch v0 bug-41695-20100706225852.patch text/plain 5343 morrita ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MzgxNjJhZTk4ZmFhZDQ0ZDM2ZWFmZTUzMzE2YWFlYzlmY2FjYmQyLi4yMDNlZTg2 ZDcyZTU4OGY0ZDVjMGVlYWE0ZWMzOWU5MjJlZGQyNzc0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDctMDYgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0RSVF0gQXNzZXJ0aW9u IGZhaWxlZCB3aGVuIGRyYWcgYW5kIG1vdmUgYSBkcmFnZ2FibGUgZWxlbWVudC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNjk1CisKKyAgICAgICAg KiBmYXN0L2V2ZW50cy9kcmFnZ2luZy1tb3VzZS1tb3Zlcy1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvZXZlbnRzL2RyYWdnaW5nLW1vdXNlLW1vdmVzLmh0bWw6IEFkZGVkLgor CiAyMDEwLTA3LTA1ICBZdXpvIEZ1amlzaGltYSAgPHl1em9AZ29vZ2xlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9ldmVudHMvZHJhZ2dpbmctbW91c2UtbW92ZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvZHJhZ2dpbmctbW91c2UtbW92ZXMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjY5Y2ZjNWE5OGRiNzRmYmUzMmFjOWI2NzhhNjEzNGFmOTczNmRkNTkKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcmFnZ2luZy1tb3VzZS1tb3Zlcy1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSwyIEBACitQQVNTCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZXZlbnRzL2RyYWdnaW5nLW1vdXNlLW1vdmVzLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2 ZW50cy9kcmFnZ2luZy1tb3VzZS1tb3Zlcy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU3Nzk1ODc5MDYzZDg5 N2YwNGU3OTcyOTNkYmM2Yjk4MDBiZTM2N2IKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9kcmFnZ2luZy1tb3VzZS1tb3Zlcy5odG1sCkBAIC0wLDAgKzEsNTEgQEAK KzwhRE9DVFlQRSBodG1sIFBVQkxJQyAiLS8vVzNDLy9EVEQgWEhUTUwgMS4wIFRyYW5zaXRpb25h bC8vRU4iCisJImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRp b25hbC5kdGQiPgorPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDxzdHlsZT4gKiB7IG1hcmdp bjogMHB4OyBwYWRkaW5nOiAwcHg7IH0gPC9zdHlsZT4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAg ICBmdW5jdGlvbiBsb2cobXNnKQorICAgICAgIHsKKyAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ2NvbnNvbGUnKS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSht c2cgKyAnXG4nKSk7CisgICAgICAgfQorCisgICAgICAgZnVuY3Rpb24gdGVzdCgpCisgICAgICAg eworICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAg ICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgICAgICAg ICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgICAgICAgICB0 ZXN0RHJhZ0FuZE1vdmUoKTsKKyAgICAgICAgICAgfQorICAgICAgIH0KKworICAgICAgIGZ1bmN0 aW9uIHRlc3REcmFnQW5kTW92ZSgpCisgICAgICAgeworICAgICAgICAgICB2YXIgZHJhZ2dhYmxl ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRyYWdnYWJsZUZvckRpdiIpOworCisgICAgICAg ICAgIHZhciBzdGFydFggPSBkcmFnZ2FibGUub2Zmc2V0TGVmdCArIDU7CisgICAgICAgICAgIHZh ciBzdGFydFkgPSBkcmFnZ2FibGUub2Zmc2V0VG9wICsgNTsKKworICAgICAgICAgICBldmVudFNl bmRlci5kcmFnTW9kZSA9IGZhbHNlOworCisgICAgICAgICAgIC8vIEdyYWIgdGhlIGRyYWdnYWJs ZSBub2RlCisgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHN0YXJ0WCxzdGFydFkp OworICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICAgICAgICAgLy8gVGhl bSBkcmFnIGl0LiBPSyBub3QgdG8gY3Jhc2guCisgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNl TW92ZVRvKHN0YXJ0WCArIDEwLCBzdGFydFkgKyAxMCk7CisgICAgICAgICAgIGV2ZW50U2VuZGVy Lm1vdXNlTW92ZVRvKHN0YXJ0WCArIDIwLCBzdGFydFkgKyAyMCk7CisgICAgICAgICAgIGV2ZW50 U2VuZGVyLm1vdXNlVXAoKTsKKyAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRl c3QiKS5zdHlsZS5kaXNwbGF5ID0gIm5vbmUiOworICAgICAgICAgICBsb2coIlBBU1MiKTsKKyAg ICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgICAgICB9Cisg ICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVzdCgpIj4KKyAg IDxkaXYgaWQ9InRlc3QiPgorICAgICA8cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE2OTUiPkJ1ZyA0MTY5NTwvYT4uIEl0IGlzIE9L IG5vdCB0byBjcmFzaDwvcD4KKyAgICAgPGIgZHJhZ2dhYmxlPSJ0cnVlIiBpZD0iZHJhZ2dhYmxl Rm9yRGl2Ij5kcmFnbWU8L2I+CisgICA8L2Rpdj4KKyAgIDxwcmUgaWQ9ImNvbnNvbGUiPjwvcHJl PgorPC9ib2R5PgorPC9odG1sPgorCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cg Yi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggNjJhZDE5MDQ1NmFlMzM0MzIzOTEyOWM0YTRm YzVlNWRjNWM0MTg1Zi4uMDEwYmNiOTFlMTdmOTEwNWQwNTQyMjdmY2E2ZDNjYzc5MjdjZTJjYiAx MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEwLTA3LTA2ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0 YUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtEUlRdIEFzc2VydGlvbiBmYWlsZWQgd2hlbiBkcmFnIGFuZCBtb3ZlIGEgZHJhZ2dh YmxlIGVsZW1lbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MTY5NQorCisgICAgICAgIG1vdXNlTW92ZVRvWCgpIGRpZCBjYWxsIFtXZWJIVE1MVmll dyBtb3VzZURyYWdnZWRdIGV2ZW4gaWYgZHJhZ2dpbmcgc3RhcnRlZC4KKyAgICAgICAgQnV0IENv Y29hIGRvZXNuJ3QgY2FsbCBtb3VzZURyYWdnZWQoKSB1bnRpbGwgZHJhZ2dpbmcgaXMgZG9uZS4K KyAgICAgICAgT3RoZXIgcGFydCBvZiBEdW1wUmVuZGVyVHJlZSBhbHNvIGFzc3VtZXMgQ29jb2Eg YmVoYXZpb3VyIGFuZCBhbiBhc3NlcnRpb24KKyAgICAgICAgb24gVUlEZWxlZ2F0ZSBmYWlsZWQg d2hlbiBtb3VzZURyYWdnZWQoKSBpcyBjYWxsZWQgZHVkcmluZyBkcmFnZ2luZy4KKyAgICAgICAg VGhpcyBjaGFuZ2UgZWxpbWluYXRlZCB0aGUgbW91c2VEcmFnZ2VkKCkgY2FsbCB3aGVuIGRyYWdn aW5nIGJlZ2lucywKKyAgICAgICAgd2hpY2ggaXMgaW1wbGljYXRlZCBieSBkcmFnZ2luZ0luZm8g aW5zdGFuY2UuCisgICAgICAgIAorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9FdmVudFNl bmRpbmdDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtFdmVudFNlbmRpbmdDb250cm9sbGVyIG1v dXNlTW92ZVRvWDpZOl0pOgorCisgICAgICAgIFRlc3Q6IGZhc3QvZXZlbnRzL2RyYWdnaW5nLW1v dXNlLW1vdmVzLmh0bWwKKyAgICAgICAgCiAyMDEwLTA3LTA1ICBDc2FiYSBPc3p0cm9nb27DoWMg IDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRXZlbnRTZW5kaW5nQ29u dHJvbGxlci5tbSBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9FdmVudFNlbmRpbmdD b250cm9sbGVyLm1tCmluZGV4IDlkMmZjNzVlZGQwOTQ4ODA2YjM5YzgwZTVlNjY1ODgzMzc5MTky ZTUuLjQ3ODIwYzNiNjljYWUyN2JlYTViNjk1ZjlkMTkxNDM0MWJmMWMzNTcgMTAwNjQ0Ci0tLSBh L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9FdmVudFNlbmRpbmdDb250cm9sbGVyLm1t CisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9FdmVudFNlbmRpbmdDb250cm9s bGVyLm1tCkBAIC00NDksMTMgKzQ0OSwxMyBAQCBzdGF0aWMgaW50IGJ1aWxkTW9kaWZpZXJGbGFn cyhjb25zdCBXZWJTY3JpcHRPYmplY3QqIG1vZGlmaWVycykKICAgICBOU1ZpZXcgKnN1YlZpZXcg PSBbW21haW5GcmFtZSB3ZWJWaWV3XSBoaXRUZXN0OltldmVudCBsb2NhdGlvbkluV2luZG93XV07 CiAgICAgaWYgKHN1YlZpZXcpIHsKICAgICAgICAgaWYgKGxlZnRNb3VzZUJ1dHRvbkRvd24pIHsK LSAgICAgICAgICAgIFtzdWJWaWV3IG1vdXNlRHJhZ2dlZDpldmVudF07CiAgICAgICAgICAgICBp ZiAoZHJhZ2dpbmdJbmZvKSB7CiAgICAgICAgICAgICAgICAgLy8gUGVyIE5TRHJhZ2dpbmcuaDog ZHJhZ2dpbmdTb3VyY2VzIG1heSBub3QgaW1wbGVtZW50IGRyYWdnZWRJbWFnZTptb3ZlZFRvOgog ICAgICAgICAgICAgICAgIGlmIChbW2RyYWdnaW5nSW5mbyBkcmFnZ2luZ1NvdXJjZV0gcmVzcG9u ZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihkcmFnZ2VkSW1hZ2U6bW92ZWRUbzopXSkKICAgICAgICAg ICAgICAgICAgICAgW1tkcmFnZ2luZ0luZm8gZHJhZ2dpbmdTb3VyY2VdIGRyYWdnZWRJbWFnZTpb ZHJhZ2dpbmdJbmZvIGRyYWdnZWRJbWFnZV0gbW92ZWRUbzpsYXN0TW91c2VQb3NpdGlvbl07CiAg ICAgICAgICAgICAgICAgW1ttYWluRnJhbWUgd2ViVmlld10gZHJhZ2dpbmdVcGRhdGVkOmRyYWdn aW5nSW5mb107Ci0gICAgICAgICAgICB9CisgICAgICAgICAgICB9IGVsc2UKKyAgICAgICAgICAg ICAgICBbc3ViVmlldyBtb3VzZURyYWdnZWQ6ZXZlbnRdOwogICAgICAgICB9IGVsc2UKICAgICAg ICAgICAgIFtzdWJWaWV3IG1vdXNlTW92ZWQ6ZXZlbnRdOwogICAgIH0K