41679 2010-07-06 03:15:14 -0700 [Qt] REGRESSION (r62511): 64-bit build is broken 2010-07-08 11:55:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All Linux RESOLVED DUPLICATE 41641 P2 Normal --- 41641 1 ossy webkit-unassigned barraclough loki sam zherczeg oldest_to_newest 246983 0 ossy 2010-07-06 03:15:14 -0700 They don't exist on Linux: #include <mach/mach_init.h> #include <mach/vm_map.h> arc4random() function is available only on bsd based systems by default. On Linux, you have to install libbsd-dev package to use arc4random(). I think it isn't a good idea to add a new dependency because of this function. 247001 1 60611 ossy 2010-07-06 03:35:00 -0700 Created attachment 60611 Patch 247012 2 loki 2010-07-06 04:15:29 -0700 And what about QtWebKit on MAC? It satisfy both requirements - the includes and the arc4random function. (I guess the original change was induced by a bug or a limitation on Mac. In additional this patch will not fix the Gtk-64 which will have the same error (if the current include problem is fixed). 247446 3 60611 abarth 2010-07-07 03:22:43 -0700 Comment on attachment 60611 Patch I'm all for build fixes, but the second part of your diff looks like a bit of copy/paste. Is there a better way of structuring the #ifdefs to just target the arc4random part? 247456 4 60611 ossy 2010-07-07 03:33:28 -0700 Comment on attachment 60611 Patch This fix is obsolete, because the original patch was rolled-out. Gavin, could you fix this issue too when you land the fixed patch in https://bugs.webkit.org/show_bug.cgi?id=41641 ? 248396 5 barraclough 2010-07-08 11:55:22 -0700 Resolved (hopefully) as a part of relanding initial patch. *** This bug has been marked as a duplicate of bug 41641 *** 60611 2010-07-06 03:35:00 -0700 2010-07-07 03:33:28 -0700 Patch bug-41679-20100706033458.patch text/plain 1903 ossy SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYyNTQwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMDYgIENzYWJhIE9z enRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEb25lIHRvZ2V0aGVyIHdpdGggWm9sdMOhbiBIZXJjemVn IDx6aGVyY3plZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF0gQnVpbGRmaXggYWZ0ZXIgcjYy NTExCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTY3 OQorCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHA6Cisg ICAgICAgICAtIFZNX1BPT0xfQVNMUiBpcyBkaXNhYmxlZCBmb3IgUExBVEZPUk0oUVQpCisgICAg ICAgICAtICNpZiAhUExBVEZPUk0oUVQpIGd1YXJkIGFkZGVkIGZvciA8bWFjaC8qPiBpbmNsdWRl cworCiAyMDEwLTA3LTA1ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogSmF2YVNjcmlwdENv cmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAJKHJl dmlzaW9uIDYyNTQwKQorKysgSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JG aXhlZFZNUG9vbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyLDE0ICszMiwyNCBAQAogI2luY2x1 ZGUgPGVycm5vLmg+CiAKICNpbmNsdWRlICJUQ1NwaW5Mb2NrLmgiCisKKyNpZiAhUExBVEZPUk0o UVQpCiAjaW5jbHVkZSA8bWFjaC9tYWNoX2luaXQuaD4KICNpbmNsdWRlIDxtYWNoL3ZtX21hcC5o PgorI2VuZGlmCisKICNpbmNsdWRlIDxzeXMvbW1hbi5oPgogI2luY2x1ZGUgPHVuaXN0ZC5oPgog I2luY2x1ZGUgPHd0Zi9BVkxUcmVlLmg+CiAjaW5jbHVkZSA8d3RmL1ZNVGFncy5oPgogCi0jaWYg Q1BVKFg4Nl82NCkKKyNpZiBDUFUoWDg2XzY0KSAmJiBQTEFURk9STShRVCkKKyAgICAvLyBUaGVz ZSBsaW1pdHMgc3VpdGFibGUgb24gNjQtYml0IHBsYXRmb3JtcyAocGFydGljdWxhcmx5IHg4Ni02 NCwgd2hlcmUgd2UgcmVxdWlyZSBhbGwganVtcHMgdG8gaGF2ZSBhIDJHYiBtYXggcmFuZ2UpLgor ICAgICNkZWZpbmUgVk1fUE9PTF9TSVpFICgydSAqIDEwMjR1ICogMTAyNHUgKiAxMDI0dSkgLy8g MkdiCisgICAgI2RlZmluZSBDT0FMRVNDRV9MSU1JVCAoMTZ1ICogMTAyNHUgKiAxMDI0dSkgLy8g MTZNYgorICAgIC8vIGFyYzRyYW5kb20oKSBpcyBub3QgZGVmaW5lZCBvbiBhbGwgUXQgc3VwcG9y dGVkIHBsYXRmb3Jtcy4KKyAgICAjZGVmaW5lIFZNX1BPT0xfQVNMUiAwCisjZWxpZiBDUFUoWDg2 XzY0KQogICAgIC8vIFRoZXNlIGxpbWl0cyBzdWl0YWJsZSBvbiA2NC1iaXQgcGxhdGZvcm1zIChw YXJ0aWN1bGFybHkgeDg2LTY0LCB3aGVyZSB3ZSByZXF1aXJlIGFsbCBqdW1wcyB0byBoYXZlIGEg MkdiIG1heCByYW5nZSkuCiAgICAgI2RlZmluZSBWTV9QT09MX1NJWkUgKDJ1ICogMTAyNHUgKiAx MDI0dSAqIDEwMjR1KSAvLyAyR2IKICAgICAjZGVmaW5lIENPQUxFU0NFX0xJTUlUICgxNnUgKiAx MDI0dSAqIDEwMjR1KSAvLyAxNk1iCg==