41657 2010-07-06 00:19:23 -0700 QWebSettings leaks pixmaps at program end on X11 2010-07-07 04:39:35 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 marc webkit-unassigned commit-queue oldest_to_newest 246905 0 marc 2010-07-06 00:19:23 -0700 On X11, when ending an application that used QtWebKit, I get an error message: > ~QX11PixmapData(): QPixmap objects must be destroyed before the QApplication object, otherwise the native pixmap object will be leaked. 246913 1 60599 marc 2010-07-06 00:26:11 -0700 Created attachment 60599 Proposed fix 247448 2 60599 abarth 2010-07-07 03:25:32 -0700 Comment on attachment 60599 Proposed fix Thanks for the informative ChangeLog. I'm not a Qt expert, but this change is convincing. Too bad memory leaks are hard to test... 247459 3 marc 2010-07-07 03:38:20 -0700 Apparently, the warning is bogus, and removed in the upcoming Qt 4.7. Still, the change doesn't hurt, and avoids the warning on older Qt's, too. 247481 4 60599 commit-queue 2010-07-07 04:39:30 -0700 Comment on attachment 60599 Proposed fix Clearing flags on attachment: 60599 Committed r62652: <http://trac.webkit.org/changeset/62652> 247482 5 commit-queue 2010-07-07 04:39:35 -0700 All reviewed patches have been landed. Closing bug. 60599 2010-07-06 00:26:11 -0700 2010-07-07 04:39:30 -0700 Proposed fix qwebsettings-fix-pixmap-leak.diff text/plain 2039 marc ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcCBiL1dlYktpdC9xdC9B cGkvcXdlYnNldHRpbmdzLmNwcAppbmRleCBmZjdjMTAxLi40YmE2OTQzIDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0 dGluZ3MuY3BwCkBAIC04MCwxMSArODAsMjAgQEAgcHVibGljOgogdHlwZWRlZiBRSGFzaDxpbnQs IFFQaXhtYXA+IFdlYkdyYXBoaWNIYXNoOwogUV9HTE9CQUxfU1RBVElDKFdlYkdyYXBoaWNIYXNo LCBfZ3JhcGhpY3MpCiAKK3N0YXRpYyB2b2lkIGVhcmx5Q2xlYXJHcmFwaGljcygpCit7CisgICAg X2dyYXBoaWNzKCktPmNsZWFyKCk7Cit9CisKIHN0YXRpYyBXZWJHcmFwaGljSGFzaCogZ3JhcGhp Y3MoKQogewogICAgIFdlYkdyYXBoaWNIYXNoKiBoYXNoID0gX2dyYXBoaWNzKCk7CiAKICAgICBp ZiAoaGFzaC0+aXNFbXB0eSgpKSB7CisKKyAgICAgICAgLy8gcHJldmVudCB+UVBpeG1hcCBydW5u aW5nIGFmdGVyIH5RQXBwbGljYXRpb24gKGxlYWtzIG5hdGl2ZSBwaXhtYXBzKQorICAgICAgICBx QWRkUG9zdFJvdXRpbmUoZWFybHlDbGVhckdyYXBoaWNzKTsKKwogICAgICAgICBoYXNoLT5pbnNl cnQoUVdlYlNldHRpbmdzOjpNaXNzaW5nSW1hZ2VHcmFwaGljLCBRUGl4bWFwKFFMYXRpbjFTdHJp bmcoIjp3ZWJraXQvcmVzb3VyY2VzL21pc3NpbmdJbWFnZS5wbmciKSkpOwogICAgICAgICBoYXNo LT5pbnNlcnQoUVdlYlNldHRpbmdzOjpNaXNzaW5nUGx1Z2luR3JhcGhpYywgUVBpeG1hcChRTGF0 aW4xU3RyaW5nKCI6d2Via2l0L3Jlc291cmNlcy9udWxsUGx1Z2luLnBuZyIpKSk7CiAgICAgICAg IGhhc2gtPmluc2VydChRV2ViU2V0dGluZ3M6OkRlZmF1bHRGcmFtZUljb25HcmFwaGljLCBRUGl4 bWFwKFFMYXRpbjFTdHJpbmcoIjp3ZWJraXQvcmVzb3VyY2VzL3VybEljb24ucG5nIikpKTsKZGlm ZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4 IDJhNjQ5ZjYuLjkzY2MwMTAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIv V2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEwLTA3LTA2ICBNYXJjIE11 dHogIDxtYXJjLm11dHpAa2RhYi5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBRV2ViU2V0dGluZ3M6IERvbid0IGxlYWsgbmF0aXZlIHBp eG1hcHMKKworICAgICAgICBXaGVuIFFfR0xPQkFMX1NUQVRJQyBnZXRzIGFyb3VuZCB0byBkZWxl dGluZyB0aGUgUUhhc2ggd2l0aCB0aGUKKyAgICAgICAgcGl4bWFwcyBpbiwgdGhlIFFBcHBsaWNh dGlvbiBkZXN0cnVjdG9yIGhhcyBhbHJlYWR5IGJlZW4KKyAgICAgICAgY29tcGxldGVkLiBUaGlz IG1ha2VzIGl0IGltcG9zc2libGUgZm9yIH5RUGl4bWFwIHRvIHJldHVybiB0aGUKKyAgICAgICAg bmF0aXZlIHBpeG1hcCB0byB0aGUgT1MsIHRodXMgbGVha2luZyB0aGVtLgorCisgICAgICAgIFRo aXMgcGF0Y2ggYWRkcyBhIHBvc3Qgcm91dGluZSAoZXhlY3V0ZWQgYXMgcGFydCBvZiB+UUFwcGxp Y2F0aW9uKQorICAgICAgICB0aGF0IGNsZWFycyB0aGUgaGFzaCBzbyBRX0dMT0JBTF9TVEFUSUMn cyBkZXN0cnVjdGlvbiBkb2Vzbid0IGhhdmUKKyAgICAgICAgdG8gZXhlY3V0ZSB+UVBpeG1hcCdz IGFueW1vcmUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQxNjU3CisKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAgKGVh cmx5Q2xlYXJHcmFwaGljcyk6IE5ldy4gQ2xlYXJzIHRoZSBwaXhtYXAgaGFzaC4KKyAgICAgICAg KGdyYXBoaWNzKTogYWRkIGVhcmx5Q2xlYXJHcmFwaGljcyBhcyBhIHFBZGRQb3N0Um91dGluZSgp CisKIDIwMTAtMDctMDMgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgo=