41620 2010-07-05 09:41:45 -0700 Web Inspector: preserve scroll positions in source frame when switching between panes. 2010-07-05 11:04:46 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 246687 0 pfeldman 2010-07-05 09:41:45 -0700 Patch to follow. 246692 1 60549 pfeldman 2010-07-05 09:46:09 -0700 Created attachment 60549 [PATCH] Proposed fix. 246710 2 60549 joepeck 2010-07-05 10:38:32 -0700 Comment on attachment 60549 [PATCH] Proposed fix. > +++ b/WebCore/inspector/front-end/SourceFrame.js > + if (visible) { > + if (this._textViewer && this._scrollTop) > + this._textViewer.element.scrollTop = this._scrollTop; > + if (this._textViewer && this._scrollLeft) > + this._textViewer.element.scrollLeft = this._scrollLeft; > + } else { You could have prevented a duplicate check by doing an if (this._textViewer) block like you already do in the else. > this._hidePopup(); > - if (this._textViewer) > + if (this._textViewer) { > + this._scrollTop = this._textViewer.element.scrollTop; > + this._scrollLeft = this._textViewer.element.scrollLeft; > this._textViewer.freeCachedElements(); > + } There is a call to this._createViewerIfNeeded above this if/else. I think that would have created a viewer in this case so that this check wouldn't be necessary, but I think its good to be safe. Thanks! 246716 3 60549 commit-queue 2010-07-05 11:04:41 -0700 Comment on attachment 60549 [PATCH] Proposed fix. Clearing flags on attachment: 60549 Committed r62496: <http://trac.webkit.org/changeset/62496> 246717 4 commit-queue 2010-07-05 11:04:46 -0700 All reviewed patches have been landed. Closing bug. 60549 2010-07-05 09:46:09 -0700 2010-07-05 11:04:41 -0700 [PATCH] Proposed fix. source_scroll text/plain 2962 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWE3MDNmMS4uZWI2OTg1NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNy0wNSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBwcmVzZXJ2ZSBzY3JvbGwgcG9zaXRp b25zIGluIHNvdXJjZSBmcmFtZSB3aGVuIHN3aXRjaGluZyBiZXR3ZWVuIHBhbmVzLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTYyMAorCisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZS5oaWRlKToKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJj ZUZyYW1lLnByb3RvdHlwZS5zZXQgdmlzaWJsZSk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9Tb3VyY2VWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZVZpZXcucHJv dG90eXBlLmhpZGUpOgorCiAyMDEwLTA3LTA1ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzIGIvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwppbmRleCBmMjJlYWExLi41NTYz YjkzIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVs LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKQEAg LTIyNCw5ICsyMjQsOSBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZSA9IHsK ICAgICAKICAgICBoaWRlOiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICBXZWJJbnNwZWN0b3Iu UGFuZWwucHJvdG90eXBlLmhpZGUuY2FsbCh0aGlzKTsKICAgICAgICAgaWYgKHRoaXMudmlzaWJs ZVZpZXcpCiAgICAgICAgICAgICB0aGlzLnZpc2libGVWaWV3LmhpZGUoKTsKKyAgICAgICAgV2Vi SW5zcGVjdG9yLlBhbmVsLnByb3RvdHlwZS5oaWRlLmNhbGwodGhpcyk7CiAgICAgfSwKIAogICAg IGdldCBzZWFyY2hhYmxlVmlld3MoKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1NvdXJjZUZyYW1lLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJj ZUZyYW1lLmpzCmluZGV4IGYyMjEwODYuLjczYzNlMmEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvU291cmNlRnJhbWUuanMKQEAgLTU2LDEwICs1NiwxOCBAQCBXZWJJbnNwZWN0b3Iu U291cmNlRnJhbWUucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl92aXNpYmxlID0gdmlzaWJs ZTsKICAgICAgICAgdGhpcy5fY3JlYXRlVmlld2VySWZOZWVkZWQoKTsKICAgICAgICAgCi0gICAg ICAgIGlmICghdmlzaWJsZSkgeworICAgICAgICBpZiAodmlzaWJsZSkgeworICAgICAgICAgICAg aWYgKHRoaXMuX3RleHRWaWV3ZXIgJiYgdGhpcy5fc2Nyb2xsVG9wKQorICAgICAgICAgICAgICAg IHRoaXMuX3RleHRWaWV3ZXIuZWxlbWVudC5zY3JvbGxUb3AgPSB0aGlzLl9zY3JvbGxUb3A7Cisg ICAgICAgICAgICBpZiAodGhpcy5fdGV4dFZpZXdlciAmJiB0aGlzLl9zY3JvbGxMZWZ0KQorICAg ICAgICAgICAgICAgIHRoaXMuX3RleHRWaWV3ZXIuZWxlbWVudC5zY3JvbGxMZWZ0ID0gdGhpcy5f c2Nyb2xsTGVmdDsKKyAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIHRoaXMuX2hpZGVQb3B1 cCgpOwotICAgICAgICAgICAgaWYgKHRoaXMuX3RleHRWaWV3ZXIpCisgICAgICAgICAgICBpZiAo dGhpcy5fdGV4dFZpZXdlcikgeworICAgICAgICAgICAgICAgIHRoaXMuX3Njcm9sbFRvcCA9IHRo aXMuX3RleHRWaWV3ZXIuZWxlbWVudC5zY3JvbGxUb3A7CisgICAgICAgICAgICAgICAgdGhpcy5f c2Nyb2xsTGVmdCA9IHRoaXMuX3RleHRWaWV3ZXIuZWxlbWVudC5zY3JvbGxMZWZ0OwogICAgICAg ICAgICAgICAgIHRoaXMuX3RleHRWaWV3ZXIuZnJlZUNhY2hlZEVsZW1lbnRzKCk7CisgICAgICAg ICAgICB9CiAgICAgICAgIH0KICAgICB9LAogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU291cmNlVmlldy5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9T b3VyY2VWaWV3LmpzCmluZGV4IGFhYzNhNzUuLjFiZjgxOTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VWaWV3LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9Tb3VyY2VWaWV3LmpzCkBAIC01OCw4ICs1OCw4IEBAIFdlYkluc3BlY3Rvci5T b3VyY2VWaWV3LnByb3RvdHlwZSA9IHsKIAogICAgIGhpZGU6IGZ1bmN0aW9uKCkKICAgICB7Ci0g ICAgICAgIFdlYkluc3BlY3Rvci5WaWV3LnByb3RvdHlwZS5oaWRlLmNhbGwodGhpcyk7CiAgICAg ICAgIHRoaXMuc291cmNlRnJhbWUudmlzaWJsZSA9IGZhbHNlOworICAgICAgICBXZWJJbnNwZWN0 b3IuVmlldy5wcm90b3R5cGUuaGlkZS5jYWxsKHRoaXMpOwogICAgICAgICBpZiAodGhpcy5sb2Nh bFNvdXJjZUZyYW1lKQogICAgICAgICAgICAgdGhpcy5sb2NhbFNvdXJjZUZyYW1lLnZpc2libGUg PSBmYWxzZTsKICAgICAgICAgdGhpcy5fY3VycmVudFNlYXJjaFJlc3VsdEluZGV4ID0gLTE7Cg==