41597 2010-07-05 02:46:48 -0700 Don't pass image hash to DRT when pixel tests are disabled 2010-07-06 02:43:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 rgabor webkit-unassigned abecsi commit-queue dpranke eric ossy tony oldest_to_newest 246547 0 rgabor 2010-07-05 02:46:48 -0700 new-run-webkit-tests shouldn't pass image hash to DRT when pixel tests are disabled. 246565 1 60510 rgabor 2010-07-05 04:10:31 -0700 Created attachment 60510 proposed patch 246953 2 60510 eric 2010-07-06 02:05:24 -0700 Comment on attachment 60510 proposed patch Does this match old-run-webkit-tests? Why is Qt the only port which has noticed this? (Because other ports aren't using NRWT much yet?) 246956 3 rgabor 2010-07-06 02:11:54 -0700 (In reply to comment #2) > (From update of attachment 60510 [details]) > Does this match old-run-webkit-tests? Why is Qt the only port which has noticed this? (Because other ports aren't using NRWT much yet?) Yes, this behavior matches old-run-webkit-tests. Seems other ports don't use new-run-webkit-tests yet. The image hash is only used by pixel tests. 246958 4 ossy 2010-07-06 02:18:28 -0700 (In reply to comment #2) > (From update of attachment 60510 [details]) > Does this match old-run-webkit-tests? Why is Qt the only port which has noticed this? (Because other ports aren't using NRWT much yet?) ORWT only pass hash to DRT if pixel tests is enabled: ------ # Try to read expected hash file for pixel tests my $suffixExpectedHash = ""; if ($pixelTests && !$resetResults) { my $expectedPixelDir = expectedDirectoryForTest($base, 0, "png"); if (open EXPECTEDHASH, "$expectedPixelDir/$base-$expectedTag.checksum") { my $expectedHash = <EXPECTEDHASH>; chomp($expectedHash); close EXPECTEDHASH; # Format expected hash into a suffix string that is appended to the path / URL passed to DRT $suffixExpectedHash = "'$expectedHash"; } } ------ 246962 5 60510 eric 2010-07-06 02:27:45 -0700 Comment on attachment 60510 proposed patch OK. I suspect this is a regression since last time I tried NRWT then, since --platform=mac had pixel tests disabled when we were last using NRWT with it. 246968 6 60510 commit-queue 2010-07-06 02:43:29 -0700 Comment on attachment 60510 proposed patch Clearing flags on attachment: 60510 Committed r62541: <http://trac.webkit.org/changeset/62541> 246969 7 commit-queue 2010-07-06 02:43:34 -0700 All reviewed patches have been landed. Closing bug. 60510 2010-07-05 04:10:31 -0700 2010-07-06 02:43:29 -0700 proposed patch my_patch03 text/plain 1479 rgabor SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYyNDc3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDctMDUgIEdhYm9yIFJhcGNzYW55aSAg PHJnYWJvckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRG9uJ3QgcGFzcyBpbWFnZSBoYXNoIHRvIERSVCB3aGVuIHBpeGVs IHRlc3RzIGFyZSBkaXNhYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQxNTk3CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9sYXlvdXRfcGFja2FnZS9kdW1wX3JlbmRlcl90cmVlX3RocmVhZC5weToKKwogMjAxMC0w Ny0wMyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAcGFyb2dhLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2R1bXBfcmVuZGVyX3RyZWVfdGhyZWFk LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL2xheW91dF9wYWNrYWdlL2R1bXBfcmVuZGVyX3RyZWVfdGhyZWFkLnB5CShyZXZpc2lvbiA2 MjQ3NCkKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91 dF9wYWNrYWdlL2R1bXBfcmVuZGVyX3RyZWVfdGhyZWFkLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00 MjksNyArNDI5LDggQEAgY2xhc3MgVGVzdFNoZWxsVGhyZWFkKHRocmVhZGluZy5UaHJlYWQpOgog ICAgICAgICAjIHByZXZpb3VzIHJ1biB3aWxsIGJlIGNvcGllZCBpbnRvIHRoZSBiYXNlbGluZS4p CiAgICAgICAgIGltYWdlX2hhc2ggPSB0ZXN0X2luZm8uaW1hZ2VfaGFzaCgpCiAgICAgICAgIGlm IChpbWFnZV9oYXNoIGFuZAotICAgICAgICAgICAgKHNlbGYuX3Rlc3RfYXJncy5uZXdfYmFzZWxp bmUgb3Igc2VsZi5fdGVzdF9hcmdzLnJlc2V0X3Jlc3VsdHMpKToKKyAgICAgICAgICAgIChzZWxm Ll90ZXN0X2FyZ3MubmV3X2Jhc2VsaW5lIG9yIHNlbGYuX3Rlc3RfYXJncy5yZXNldF9yZXN1bHRz IG9yCisgICAgICAgICAgICBub3Qgc2VsZi5fb3B0aW9ucy5waXhlbF90ZXN0cykpOgogICAgICAg ICAgICAgaW1hZ2VfaGFzaCA9ICIiCiAgICAgICAgIHN0YXJ0ID0gdGltZS50aW1lKCkKICAgICAg ICAgY3Jhc2gsIHRpbWVvdXQsIGFjdHVhbF9jaGVja3N1bSwgb3V0cHV0LCBlcnJvciA9IFwK