41595 2010-07-05 02:25:11 -0700 [v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js 2010-07-05 05:08:44 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys abarth bweinstein eric joepeck keishi pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 246541 0 yurys 2010-07-05 02:25:11 -0700 Now that the issue with duplicate property names returned from Object.getOwnPropertyNames is fixed on v8 side we should get rid of v8-specific code dealing with getOwnPropertyNames in InjectedScript.js 246542 1 60507 yurys 2010-07-05 02:29:46 -0700 Created attachment 60507 Patch 246550 2 60507 yurys 2010-07-05 03:06:08 -0700 Comment on attachment 60507 Patch Clearing flags on attachment: 60507 Committed r62479: <http://trac.webkit.org/changeset/62479> 246551 3 yurys 2010-07-05 03:06:18 -0700 All reviewed patches have been landed. Closing bug. 246581 4 webkit.review.bot 2010-07-05 05:08:44 -0700 http://trac.webkit.org/changeset/62479 might have broken Leopard Intel Release (Tests) 60507 2010-07-05 02:29:46 -0700 2010-07-05 03:06:08 -0700 Patch bug-41595-20100705132944.patch text/plain 4260 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmQ2MGYwNDg4MjZjNWQ1NTk2NjkxM2Y3MjI5N2Q4Y2U0MzgyNDZiMS4uNWQxYjg4MzE1MDQyZjMy NGVjYjQ1ZTk2M2RhZTQ4MzE2MTFiODAzNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0wNSAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbdjhdIFdlYiBJbnNwZWN0b3I6IHJlbW92ZSB2 OC1zcGVjaWZpYyBjb2RlIGRlYWxpbmcgd2l0aCBnZXRPd25Qcm9wZXJ0eU5hbWVzIGZyb20gSW5q ZWN0ZWRTY3JpcHQuanMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQxNTk1CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2Ny aXB0LmpzOgorICAgICAgICAoaW5qZWN0ZWRTY3JpcHRDb25zdHJ1Y3Rvcik6CisKIDIwMTAtMDct MDQgIEFsaWNlIExpdSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9JbmplY3RlZFNjcmlwdC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3Rl ZFNjcmlwdC5qcwppbmRleCAxMzZhMjM2NTgwNWVjNzRmMzU4OTRiNGQ0ZDUzNTE1ZWMxOGJkYzVh Li41ZDlkMDY1YTM2ZWY2YjQ5NTI3ZGM5YjgxNmY3YmE3N2Q1NjZhOGUwIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKKysrIGIvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCkBAIC0xMjEsMjcgKzEyMSw2 IEBAIEluamVjdGVkU2NyaXB0LmdldFByb3BlcnRpZXMgPSBmdW5jdGlvbihvYmplY3RQcm94eSwg aWdub3JlSGFzT3duUHJvcGVydHksIGFiYnJlCiAgICAgaWYgKCFpZ25vcmVIYXNPd25Qcm9wZXJ0 eSAmJiBvYmplY3QuX19wcm90b19fKQogICAgICAgICBwcm9wZXJ0eU5hbWVzLnB1c2goIl9fcHJv dG9fXyIpOwogCi0gICAgaWYgKGpzRW5naW5lID09PSAidjgiKSB7Ci0gICAgICAgIC8vIENoZWNr IGlmIHRoZSBvYmplY3QgaXMgYSBzY29wZS4KLSAgICAgICAgaWYgKEluamVjdGVkU2NyaXB0Ll9p c1Njb3BlUHJveHkob2JqZWN0UHJveHkpKSB7Ci0gICAgICAgICAgICBwcm9wZXJ0eU5hbWVzID0g W107Ci0gICAgICAgICAgICBmb3IgKHZhciBuYW1lIGluIG9iamVjdCkKLSAgICAgICAgICAgICAg ICBwcm9wZXJ0eU5hbWVzLnB1c2gobmFtZSk7Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAg ICAvLyBGSVhNRShodHRwOi8vY3JidWcuY29tLzQxMjQzKTogT2JqZWN0LmdldE93blByb3BlcnR5 TmFtZXMgbWF5IHJldHVybiBkdXBsaWNhdGVkIG5hbWVzLgotICAgICAgICAgICAgdmFyIGEgPSBb XTsKLSAgICAgICAgICAgIHByb3BlcnR5TmFtZXMuc29ydCgpOwotICAgICAgICAgICAgdmFyIHBy ZXY7Ci0gICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHByb3BlcnR5TmFtZXMubGVuZ3Ro OyBpKyspIHsKLSAgICAgICAgICAgICAgICB2YXIgbiA9IHByb3BlcnR5TmFtZXNbaV07Ci0gICAg ICAgICAgICAgICAgaWYgKG4gIT0gcHJldikKLSAgICAgICAgICAgICAgICAgICAgYS5wdXNoKG4p OwotICAgICAgICAgICAgICAgIHByZXYgPSBuOwotICAgICAgICAgICAgfQotICAgICAgICAgICAg cHJvcGVydHlOYW1lcyA9IGE7Ci0gICAgICAgIH0KLSAgICB9Ci0gICAgCiAgICAgLy8gR28gb3Zl ciBwcm9wZXJ0aWVzLCBwcmVwYXJlIHJlc3VsdHMuCiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBw cm9wZXJ0eU5hbWVzLmxlbmd0aDsgKytpKSB7CiAgICAgICAgIHZhciBwcm9wZXJ0eU5hbWUgPSBw cm9wZXJ0eU5hbWVzW2ldOwpAQCAtMTcxLDEyICsxNTAsNiBAQCBJbmplY3RlZFNjcmlwdC5nZXRQ cm9wZXJ0aWVzID0gZnVuY3Rpb24ob2JqZWN0UHJveHksIGlnbm9yZUhhc093blByb3BlcnR5LCBh YmJyZQogICAgIHJldHVybiBwcm9wZXJ0aWVzOwogfQogCi1JbmplY3RlZFNjcmlwdC5faXNTY29w ZVByb3h5ID0gZnVuY3Rpb24ob2JqZWN0UHJveHkpCi17Ci0gICAgdmFyIG9iamVjdElkID0gb2Jq ZWN0UHJveHkub2JqZWN0SWQ7Ci0gICAgcmV0dXJuIHR5cGVvZiBvYmplY3RJZCA9PT0gIm9iamVj dCIgJiYgIW9iamVjdElkLnRoaXNPYmplY3QgJiYgIW9iamVjdFByb3h5LnBhdGg7Ci19IAotCiBJ bmplY3RlZFNjcmlwdC5zZXRQcm9wZXJ0eVZhbHVlID0gZnVuY3Rpb24ob2JqZWN0UHJveHksIHBy b3BlcnR5TmFtZSwgZXhwcmVzc2lvbikKIHsKICAgICB2YXIgb2JqZWN0ID0gSW5qZWN0ZWRTY3Jp cHQuX3Jlc29sdmVPYmplY3Qob2JqZWN0UHJveHkpOwpAQCAtMjE3LDcgKzE5MCw3IEBAIEluamVj dGVkU2NyaXB0Ll9wb3B1bGF0ZVByb3BlcnR5TmFtZXMgPSBmdW5jdGlvbihvYmplY3QsIHJlc3Vs dFNldCkKICAgICAgICAgdHJ5IHsKICAgICAgICAgICAgIHZhciBuYW1lcyA9IE9iamVjdC5nZXRP d25Qcm9wZXJ0eU5hbWVzKG8pOwogICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBuYW1l cy5sZW5ndGg7ICsraSkKLSAgICAgICAgICAgICAgICByZXN1bHRTZXRbbmFtZXNbaV0gKyAiIl0g PSB0cnVlOworICAgICAgICAgICAgICAgIHJlc3VsdFNldFtuYW1lc1tpXV0gPSB0cnVlOwogICAg ICAgICB9IGNhdGNoIChlKSB7CiAgICAgICAgIH0KICAgICB9CmRpZmYgLS1naXQgYS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCA5MTBk MmQyNzQ5MTFlZTMwNjFlNzExMzY4MzcxOThjOTg5ODhmYTIwLi44YzFkMTdlOTJmOTlkNWEwNDlh MDY1MDgyMGRiMjg1YWQwYzkzNDA3IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdl TG9nCisrKyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAx MC0wNy0wNSAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbdjhdIFdlYiBJbnNwZWN0 b3I6IHJlbW92ZSB2OC1zcGVjaWZpYyBjb2RlIGRlYWxpbmcgd2l0aCBnZXRPd25Qcm9wZXJ0eU5h bWVzIGZyb20gSW5qZWN0ZWRTY3JpcHQuanMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQxNTk1CisKKyAgICAgICAgKiBzcmMvanMvRGVidWdnZXJTY3Jp cHQuanM6CisKIDIwMTAtMDctMDMgIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2No cm9taXVtL3NyYy9qcy9EZWJ1Z2dlclNjcmlwdC5qcyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvanMv RGVidWdnZXJTY3JpcHQuanMKaW5kZXggNGE1ODFlNjdmNjQ4MTQxZmRjMDI3YmMwM2UzM2RlNmJk NjI4NDY0MS4uMjVkMTkwMzcxNzVkNWRiYTI5MGYwNzE1ZWEwZmU1ZmQ2MTVkYTY4ZiAxMDA2NDQK LS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9EZWJ1Z2dlclNjcmlwdC5qcworKysgYi9XZWJL aXQvY2hyb21pdW0vc3JjL2pzL0RlYnVnZ2VyU2NyaXB0LmpzCkBAIC0yMzcsNiArMjM3LDkgQEAg RGVidWdnZXJTY3JpcHQuX2ZyYW1lTWlycm9yVG9KU0NhbGxGcmFtZSA9IGZ1bmN0aW9uKGZyYW1l TWlycm9yLCBjYWxsZXJGcmFtZSkKICAgICAgICAgdmFyIHNjb3BlT2JqZWN0ID0ge307CiAgICAg ICAgIGZvciAodmFyIGogPSAwOyBqIDwgcHJvcGVydGllcy5sZW5ndGg7IGorKykKICAgICAgICAg ICAgIHNjb3BlT2JqZWN0W3Byb3BlcnRpZXNbal0ubmFtZSgpXSA9IHByb3BlcnRpZXNbal0udmFs dWVfOworICAgICAgICAvLyBSZXNldCBzY29wZSBvYmplY3QgcHJvdG90eXBlIHRvIG51bGwgc28g dGhhdCB0aGUgcHJvdG8gcHJvcGVydGllcworICAgICAgICAvLyBkb24ndCBhcHBlYXIgaW4gdGgg bG9jYWwgc2NvcGUgc2VjdGlvbi4KKyAgICAgICAgc2NvcGVPYmplY3QuX19wcm90b19fID0gbnVs bDsKICAgICAgICAgc2NvcGVUeXBlLnB1c2goc2NvcGVNaXJyb3Iuc2NvcGVUeXBlKCkpOwogICAg ICAgICBzY29wZUNoYWluLnB1c2goc2NvcGVPYmplY3QpOwogICAgIH0K