41593 2010-07-05 01:41:39 -0700 new-run-webkit-tests does not use port specific environment 2010-07-07 01:38:28 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 rgabor webkit-unassigned abecsi cjerdonek commit-queue dbates dpranke eric ojan ossy webkit.review.bot oldest_to_newest 246527 0 60502 rgabor 2010-07-05 01:41:39 -0700 Created attachment 60502 proposed patch Pass port specific environment to server process to be able to run new-run-webkit-tests on Qt port. 246528 1 webkit.review.bot 2010-07-05 01:42:14 -0700 Attachment 60502 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/Scripts/webkitpy/layout_tests/port/qt.py:97: no newline at end of file [pep8/W292] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 246538 2 60505 rgabor 2010-07-05 02:04:31 -0700 Created attachment 60505 proposed_patch_v2 fixed style 246951 3 60505 eric 2010-07-06 02:04:14 -0700 Comment on attachment 60505 proposed_patch_v2 This should copy the environment. See ChromiumPort does something similar. 247030 4 60621 rgabor 2010-07-06 05:13:18 -0700 Created attachment 60621 proposed_patch_v3 Now, the port specific environment is taken from the base class like in Chromium. 247379 5 60621 eric 2010-07-07 01:10:36 -0700 Comment on attachment 60621 proposed_patch_v3 OK. 247387 6 60621 commit-queue 2010-07-07 01:38:23 -0700 Comment on attachment 60621 proposed_patch_v3 Clearing flags on attachment: 60621 Committed r62635: <http://trac.webkit.org/changeset/62635> 247388 7 commit-queue 2010-07-07 01:38:28 -0700 All reviewed patches have been landed. Closing bug. 60502 2010-07-05 01:41:39 -0700 2010-07-05 02:04:31 -0700 proposed patch my_patch02 text/plain 2183 rgabor SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYyNDc2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDctMDUgIEdhYm9yIFJhcGNzYW55aSAg PHJnYWJvckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUGFzcyBwb3J0IHNwZWNpZmljIGVudmlyb25tZW50IHRvIHNlcnZl ciBwcm9jZXNzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9xdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dl YmtpdC5weToKKwogMjAxMC0wNy0wMyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAcGFyb2dh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHkKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5w eQkocmV2aXNpb24gNjI0NzQpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L3F0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC05MCwzICs5MCw4IEBAIGNsYXNz IFF0UG9ydChXZWJLaXRQb3J0KToKIAogICAgIGRlZiBfcGF0aF90b19kcml2ZXIoc2VsZik6CiAg ICAgICAgIHJldHVybiBzZWxmLl9idWlsZF9wYXRoKCdiaW4vRHVtcFJlbmRlclRyZWUnKQorCisg ICAgZGVmIHNldHVwX2Vudmlyb25fZm9yX3NlcnZlcihzZWxmKToKKyAgICAgICAgZW52aXJvbm1l bnQgPSBvcy5lbnZpcm9uCisgICAgICAgIGVudmlyb25tZW50WydRVFdFQktJVF9QTFVHSU5fUEFU SCddID0gc2VsZi5fYnVpbGRfcGF0aCgnbGliL3BsdWdpbnMnKQorICAgICAgICByZXR1cm4gZW52 aXJvbm1lbnQKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCkluZGV4OiBXZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5w eQkocmV2aXNpb24gNjI0NzQpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L3dlYmtpdC5weQkod29ya2luZyBjb3B5KQpAQCAtNDEsNiArNDEsNyBAQCBp bXBvcnQgc2lnbmFsCiBpbXBvcnQgc3lzCiBpbXBvcnQgdGltZQogaW1wb3J0IHdlYmJyb3dzZXIK K2ltcG9ydCB0ZW1wZmlsZQogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZl IGltcG9ydCBFeGVjdXRpdmUKIApAQCAtMzc4LDggKzM3OSw5IEBAIGNsYXNzIFdlYktpdERyaXZl cihiYXNlLkRyaXZlcik6CiAgICAgICAgIGNvbW1hbmQgKz0gW3NlbGYuX3BvcnQuX3BhdGhfdG9f ZHJpdmVyKCksICctJ10KICAgICAgICAgaWYgc2VsZi5faW1hZ2VfcGF0aDoKICAgICAgICAgICAg IGNvbW1hbmQuYXBwZW5kKCctLXBpeGVsLXRlc3RzJykKLSAgICAgICAgZW52aXJvbm1lbnQgPSBv cy5lbnZpcm9uCisgICAgICAgIGVudmlyb25tZW50ID0gc2VsZi5fcG9ydC5zZXR1cF9lbnZpcm9u X2Zvcl9zZXJ2ZXIoKQogICAgICAgICBlbnZpcm9ubWVudFsnRFlMRF9GUkFNRVdPUktfUEFUSCdd ID0gc2VsZi5fcG9ydC5fYnVpbGRfcGF0aCgpCisgICAgICAgIGVudmlyb25tZW50WydEVU1QUkVO REVSVFJFRV9URU1QJ10gPSB0ZW1wZmlsZS5ta2R0ZW1wKHByZWZpeD0nRHVtcFJlbmRlclRyZWUt JykKICAgICAgICAgc2VsZi5fc2VydmVyX3Byb2Nlc3MgPSBzZXJ2ZXJfcHJvY2Vzcy5TZXJ2ZXJQ cm9jZXNzKHNlbGYuX3BvcnQsCiAgICAgICAgICAgICAiRHVtcFJlbmRlclRyZWUiLCBjb21tYW5k LCBlbnZpcm9ubWVudCkKIAo= 60505 2010-07-05 02:04:31 -0700 2010-07-06 05:13:18 -0700 proposed_patch_v2 my_patch_new_02 text/plain 2210 rgabor SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYyNDc3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMDUgIEdhYm9yIFJhcGNzYW55aSAg PHJnYWJvckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUGFzcyBwb3J0IHNwZWNpZmljIGVudmlyb25tZW50IHRvIHNlcnZl ciBwcm9jZXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDE1OTMKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv cXQucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJr aXQucHk6CisKIDIwMTAtMDctMDMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0LnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcXQucHkJ KHJldmlzaW9uIDYyNDc0KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9xdC5weQkod29ya2luZyBjb3B5KQpAQCAtOTAsMyArOTAsOCBAQCBjbGFzcyBR dFBvcnQoV2ViS2l0UG9ydCk6CiAKICAgICBkZWYgX3BhdGhfdG9fZHJpdmVyKHNlbGYpOgogICAg ICAgICByZXR1cm4gc2VsZi5fYnVpbGRfcGF0aCgnYmluL0R1bXBSZW5kZXJUcmVlJykKKworICAg IGRlZiBzZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2ZXIoc2VsZik6CisgICAgICAgIGVudmlyb25tZW50 ID0gb3MuZW52aXJvbgorICAgICAgICBlbnZpcm9ubWVudFsnUVRXRUJLSVRfUExVR0lOX1BBVEgn XSA9IHNlbGYuX2J1aWxkX3BhdGgoJ2xpYi9wbHVnaW5zJykKKyAgICAgICAgcmV0dXJuIGVudmly b25tZW50CkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L3dlYmtpdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQkocmV2aXNpb24gNjI0NzQpCisrKyBXZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQkod29ya2lu ZyBjb3B5KQpAQCAtNDEsNiArNDEsNyBAQCBpbXBvcnQgc2lnbmFsCiBpbXBvcnQgc3lzCiBpbXBv cnQgdGltZQogaW1wb3J0IHdlYmJyb3dzZXIKK2ltcG9ydCB0ZW1wZmlsZQogCiBmcm9tIHdlYmtp dHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZlIGltcG9ydCBFeGVjdXRpdmUKIApAQCAtMzc4LDgg KzM3OSw5IEBAIGNsYXNzIFdlYktpdERyaXZlcihiYXNlLkRyaXZlcik6CiAgICAgICAgIGNvbW1h bmQgKz0gW3NlbGYuX3BvcnQuX3BhdGhfdG9fZHJpdmVyKCksICctJ10KICAgICAgICAgaWYgc2Vs Zi5faW1hZ2VfcGF0aDoKICAgICAgICAgICAgIGNvbW1hbmQuYXBwZW5kKCctLXBpeGVsLXRlc3Rz JykKLSAgICAgICAgZW52aXJvbm1lbnQgPSBvcy5lbnZpcm9uCisgICAgICAgIGVudmlyb25tZW50 ID0gc2VsZi5fcG9ydC5zZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2ZXIoKQogICAgICAgICBlbnZpcm9u bWVudFsnRFlMRF9GUkFNRVdPUktfUEFUSCddID0gc2VsZi5fcG9ydC5fYnVpbGRfcGF0aCgpCisg ICAgICAgIGVudmlyb25tZW50WydEVU1QUkVOREVSVFJFRV9URU1QJ10gPSB0ZW1wZmlsZS5ta2R0 ZW1wKHByZWZpeD0nRHVtcFJlbmRlclRyZWUtJykKICAgICAgICAgc2VsZi5fc2VydmVyX3Byb2Nl c3MgPSBzZXJ2ZXJfcHJvY2Vzcy5TZXJ2ZXJQcm9jZXNzKHNlbGYuX3BvcnQsCiAgICAgICAgICAg ICAiRHVtcFJlbmRlclRyZWUiLCBjb21tYW5kLCBlbnZpcm9ubWVudCkKIAo= 60621 2010-07-06 05:13:18 -0700 2010-07-07 01:38:23 -0700 proposed_patch_v3 my_patch_newer_02 text/plain 2419 rgabor SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYyNTA3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDctMDYgIEdhYm9yIFJhcGNzYW55aSAg PHJnYWJvckBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUGFzcyBwb3J0IHNwZWNpZmljIGVudmlyb25tZW50IHRvIHNlcnZl ciBwcm9jZXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDE1OTMKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv cXQucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJr aXQucHk6CisKIDIwMTAtMDctMDUgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9xdC5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3F0LnB5CShy ZXZpc2lvbiA2MjUwNykKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvcXQucHkJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDggQEAgaW1wb3J0IGxv Z2dpbmcKIGltcG9ydCBvcwogaW1wb3J0IHNpZ25hbAogCitpbXBvcnQgd2Via2l0CisKIGZyb20g d2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQud2Via2l0IGltcG9ydCBXZWJLaXRQb3J0CiAKIF9s b2cgPSBsb2dnaW5nLmdldExvZ2dlcigid2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQucXQiKQpA QCAtOTAsMyArOTIsOCBAQCBjbGFzcyBRdFBvcnQoV2ViS2l0UG9ydCk6CiAKICAgICBkZWYgX3Bh dGhfdG9fZHJpdmVyKHNlbGYpOgogICAgICAgICByZXR1cm4gc2VsZi5fYnVpbGRfcGF0aCgnYmlu L0R1bXBSZW5kZXJUcmVlJykKKworICAgIGRlZiBzZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2ZXIoc2Vs Zik6CisgICAgICAgIGVudiA9IHdlYmtpdC5XZWJLaXRQb3J0LnNldHVwX2Vudmlyb25fZm9yX3Nl cnZlcihzZWxmKQorICAgICAgICBlbnZbJ1FUV0VCS0lUX1BMVUdJTl9QQVRIJ10gPSBzZWxmLl9i dWlsZF9wYXRoKCdsaWIvcGx1Z2lucycpCisgICAgICAgIHJldHVybiBlbnYKSW5kZXg6IFdlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv d2Via2l0LnB5CShyZXZpc2lvbiA2MjUwNykKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC00MSw2ICs0 MSw3IEBAIGltcG9ydCBzaWduYWwKIGltcG9ydCBzeXMKIGltcG9ydCB0aW1lCiBpbXBvcnQgd2Vi YnJvd3NlcgoraW1wb3J0IHRlbXBmaWxlCiAKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5l eGVjdXRpdmUgaW1wb3J0IEV4ZWN1dGl2ZQogCkBAIC0zNzgsOCArMzc5LDkgQEAgY2xhc3MgV2Vi S2l0RHJpdmVyKGJhc2UuRHJpdmVyKToKICAgICAgICAgY29tbWFuZCArPSBbc2VsZi5fcG9ydC5f cGF0aF90b19kcml2ZXIoKSwgJy0nXQogICAgICAgICBpZiBzZWxmLl9pbWFnZV9wYXRoOgogICAg ICAgICAgICAgY29tbWFuZC5hcHBlbmQoJy0tcGl4ZWwtdGVzdHMnKQotICAgICAgICBlbnZpcm9u bWVudCA9IG9zLmVudmlyb24KKyAgICAgICAgZW52aXJvbm1lbnQgPSBzZWxmLl9wb3J0LnNldHVw X2Vudmlyb25fZm9yX3NlcnZlcigpCiAgICAgICAgIGVudmlyb25tZW50WydEWUxEX0ZSQU1FV09S S19QQVRIJ10gPSBzZWxmLl9wb3J0Ll9idWlsZF9wYXRoKCkKKyAgICAgICAgZW52aXJvbm1lbnRb J0RVTVBSRU5ERVJUUkVFX1RFTVAnXSA9IHRlbXBmaWxlLm1rZHRlbXAocHJlZml4PSdEdW1wUmVu ZGVyVHJlZS0nKQogICAgICAgICBzZWxmLl9zZXJ2ZXJfcHJvY2VzcyA9IHNlcnZlcl9wcm9jZXNz LlNlcnZlclByb2Nlc3Moc2VsZi5fcG9ydCwKICAgICAgICAgICAgICJEdW1wUmVuZGVyVHJlZSIs IGNvbW1hbmQsIGVudmlyb25tZW50KQogCg==