41590 2010-07-04 21:10:53 -0700 Add basic <col> support to the treebuilder 2010-07-05 13:03:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 eric eric abarth commit-queue oldest_to_newest 246490 0 eric 2010-07-04 21:10:53 -0700 Add basic <col> support to the treebuilder 246492 1 60492 eric 2010-07-04 21:16:47 -0700 Created attachment 60492 Patch 246495 2 60492 abarth 2010-07-04 21:34:29 -0700 Comment on attachment 60492 Patch Ok.. Too bad we fail one of the new tests. 246505 3 60492 commit-queue 2010-07-04 22:13:32 -0700 Comment on attachment 60492 Patch Rejecting patch 60492 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Last 500 characters of output: (offset 19 lines). Hunk #2 FAILED at 1405. Hunk #3 FAILED at 5656. 2 out of 3 hunks FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej patching file LayoutTests/html5lib/runner-expected.txt Hunk #1 FAILED at 4937. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected.txt.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file WebCore/html/HTMLTreeBuilder.cpp Hunk #2 succeeded at 784 (offset -3 lines). Full output: http://webkit-commit-queue.appspot.com/results/3419170 246745 4 60492 commit-queue 2010-07-05 12:29:18 -0700 Comment on attachment 60492 Patch Rejecting patch 60492 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Last 500 characters of output: (offset 19 lines). Hunk #2 FAILED at 1405. Hunk #3 FAILED at 5656. 2 out of 3 hunks FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej patching file LayoutTests/html5lib/runner-expected.txt Hunk #1 FAILED at 4937. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected.txt.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/html/HTMLTreeBuilder.cpp Hunk #2 succeeded at 784 (offset -3 lines). Full output: http://webkit-commit-queue.appspot.com/results/3402269 246751 5 60492 eric 2010-07-05 12:54:29 -0700 Comment on attachment 60492 Patch Cascading failure from earlier flaky test trouble. :( 246756 6 60492 abarth 2010-07-05 13:03:54 -0700 Comment on attachment 60492 Patch Clearing flags on attachment: 60492 Committed r62500: <http://trac.webkit.org/changeset/62500> 246757 7 abarth 2010-07-05 13:03:59 -0700 All reviewed patches have been landed. Closing bug. 60492 2010-07-04 21:16:47 -0700 2010-07-05 13:03:54 -0700 Patch bug-41590-20100704211639.patch text/plain 5363 eric ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMmQ4MmYwZDhiZjJhOTAwN2JlOTY3MmU5MjMzNDczOGU5NWVhMGZmLi5iMjdlM2M4 NWJhOGZiYmI1ZDIwNjFmMTY0NmU5YjhjNjhiZGY5MjJmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjAgQEAK IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBBZGQgYmFz aWMgPGNvbD4gc3VwcG9ydCB0byB0aGUgdHJlZWJ1aWxkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNTkwCisKKyAgICAgICAgVGVzdCB0aGUgbmV3 IDxjb2w+IHN1cHBvcnQuIFR1cm5zIG91dCB0aGUgb2xkIHRyZWVidWlsZGVyIGRvZXNuJ3QKKyAg ICAgICAgaGFuZGxlIDx0YWJsZT48Y29sPiBjb3JyZWN0bHkuCisKKyAgICAgICAgKiBodG1sNWxp Yi9yZXNvdXJjZXMvdGFibGVzMDEuZGF0OgorICAgICAgICAqIGh0bWw1bGliL3J1bm5lci1leHBl Y3RlZC1odG1sNS50eHQ6CisgICAgICAgICogaHRtbDVsaWIvcnVubmVyLWV4cGVjdGVkLnR4dDoK KworMjAxMC0wNy0wNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgQWRkIGJhc2ljICJpbiByb3ci IG1vZGUgdG8gc3VwcG9ydCA8dGQ+IGluc2VydGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE1ODgKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aHRtbDVsaWIvcmVzb3VyY2VzL3RhYmxlczAxLmRhdCBiL0xheW91dFRlc3RzL2h0bWw1bGliL3Jl c291cmNlcy90YWJsZXMwMS5kYXQKaW5kZXggOWZiNzllMGYyZWJjNWNjYWIzZTY2YmE1NDZjZTI5 M2UyOWY4NGFlZC4uYWE0YTllZTI0NjAyMWIxMWRiMTJhY2ZiNzVjZTY3YWYzYTZhYWY1NCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcmVzb3VyY2VzL3RhYmxlczAxLmRhdAorKysg Yi9MYXlvdXRUZXN0cy9odG1sNWxpYi9yZXNvdXJjZXMvdGFibGVzMDEuZGF0CkBAIC0yMSwzICsy MSwyNiBAQAogfCAgICAgICA8dGJvZHk+CiB8ICAgICAgICAgPHRyPgogfCAgICAgICAgICAgPHRk PgorCisjZGF0YQorPHRhYmxlPjxjb2wgZm9vPSdiYXInPgorI2Vycm9ycworI2RvY3VtZW50Cit8 IDxodG1sPgorfCAgIDxoZWFkPgorfCAgIDxib2R5PgorfCAgICAgPHRhYmxlPgorfCAgICAgICA8 Y29sZ3JvdXA+Cit8ICAgICAgICAgPGNvbD4KK3wgICAgICAgICAgIGZvbz0iYmFyIgorCisjZGF0 YQorPHRhYmxlPjxjb2xncm91cD48L2h0bWw+Zm9vCisjZXJyb3JzCisjZG9jdW1lbnQKK3wgPGh0 bWw+Cit8ICAgPGhlYWQ+Cit8ICAgPGJvZHk+Cit8ICAgICAiZm9vIgorfCAgICAgPHRhYmxlPgor fCAgICAgICA8Y29sZ3JvdXA+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odG1sNWxpYi9ydW5u ZXItZXhwZWN0ZWQtaHRtbDUudHh0IGIvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcnVubmVyLWV4cGVj dGVkLWh0bWw1LnR4dAppbmRleCBmMjM2MjM1NjFkZjU5YmNjZGM1OGVkMDAwOWU2YTBjMmZjOWZj YjFiLi42NGYzYjQzMDUyY2U0MmEyZThjOGQzNzU1MmQyZmU0MzhlMzkzMjI3IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9odG1sNWxpYi9ydW5uZXItZXhwZWN0ZWQtaHRtbDUudHh0CisrKyBiL0xh eW91dFRlc3RzL2h0bWw1bGliL3J1bm5lci1leHBlY3RlZC1odG1sNS50eHQKQEAgLTEzNTUsNiAr MTM1NSwxMiBAQCBHb3Q6CiB8ICAgPGJvZHk+CiB8ICAgICA8dGFibGU+CiB8ICAgICAgIDxjb2xn cm91cD4KK3wgICAgICAgICA8Y29sPgorfCAgICAgICAgIDxjb2w+Cit8ICAgICAgICAgPGNvbD4K K3wgICAgICAgICA8Y29sPgorfCAgICAgICAgIDxjb2w+Cit8ICAgICAgICAgPGNvbD4KIEV4cGVj dGVkOgogfCA8aHRtbD4KIHwgICA8aGVhZD4KQEAgLTEzODAsOSArMTM4NiwxMiBAQCBHb3Q6CiB8 ICAgPGhlYWQ+CiB8ICAgPGJvZHk+CiB8ICAgICA8dGFibGU+Ci18ICAgICAgIDx0Ym9keT4KLXwg ICAgICAgICA8dHI+Ci18ICAgICAgICAgICA8dGQ+Cit8ICAgICAgIDxjb2xncm91cD4KK3wgICAg ICAgICA8Y29sPgorfCAgICAgICAgIDxjb2w+Cit8ICAgICAgICAgPGNvbD4KK3wgICAgICAgICA8 Y29sPgorfCAgICAgICAgIDxjb2w+CiBFeHBlY3RlZDoKIHwgPGh0bWw+CiB8ICAgPGhlYWQ+CkBA IC01NjI4LDUgKzU2MzcsMjIgQEAgRXhwZWN0ZWQ6CiB8ICAgICA8dGFibGU+CiByZXNvdXJjZXMv aW5ib2R5MDEuZGF0OiBQQVNTCiAKLXJlc291cmNlcy90YWJsZXMwMS5kYXQ6IFBBU1MKK3Jlc291 cmNlcy90YWJsZXMwMS5kYXQ6Cis0CisKK1Rlc3QgNCBvZiA0IGluIHJlc291cmNlcy90YWJsZXMw MS5kYXQgZmFpbGVkLiBJbnB1dDoKKzx0YWJsZT48Y29sZ3JvdXA+PC9odG1sPmZvbworR290Ogor fCA8aHRtbD4KK3wgICA8aGVhZD4KK3wgICA8Ym9keT4KK3wgICAgIDx0YWJsZT4KK3wgICAgICAg PGNvbGdyb3VwPgorRXhwZWN0ZWQ6Cit8IDxodG1sPgorfCAgIDxoZWFkPgorfCAgIDxib2R5Pgor fCAgICAgImZvbyIKK3wgICAgIDx0YWJsZT4KK3wgICAgICAgPGNvbGdyb3VwPgogI0VPRgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcnVubmVyLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2h0bWw1bGliL3J1bm5lci1leHBlY3RlZC50eHQKaW5kZXggMGYxN2YwNzg4ODU5NmMx ZjY5ZTAxYzA4NGRlNTBmZDZkYThhZTI5NC4uOWRmMjU0YTdlZGZjYmM2MTA5M2UzNzdiMmY3ZWQ4 Y2FhNjFlNDlhYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcnVubmVyLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9odG1sNWxpYi9ydW5uZXItZXhwZWN0ZWQudHh0CkBA IC00OTM3LDQgKzQ5MzcsMjMgQEAgRXhwZWN0ZWQ6CiB8ICAgICA8dGFibGU+CiByZXNvdXJjZXMv aW5ib2R5MDEuZGF0OiBQQVNTCiAKLXJlc291cmNlcy90YWJsZXMwMS5kYXQ6IFBBU1MKK3Jlc291 cmNlcy90YWJsZXMwMS5kYXQ6CiszCisKK1Rlc3QgMyBvZiA0IGluIHJlc291cmNlcy90YWJsZXMw MS5kYXQgZmFpbGVkLiBJbnB1dDoKKzx0YWJsZT48Y29sIGZvbz0nYmFyJz4KK0dvdDoKK3wgPGh0 bWw+Cit8ICAgPGhlYWQ+Cit8ICAgPGJvZHk+Cit8ICAgICA8dGFibGU+Cit8ICAgICAgIDxjb2w+ Cit8ICAgICAgICAgZm9vPSJiYXIiCitFeHBlY3RlZDoKK3wgPGh0bWw+Cit8ICAgPGhlYWQ+Cit8 ICAgPGJvZHk+Cit8ICAgICA8dGFibGU+Cit8ICAgICAgIDxjb2xncm91cD4KK3wgICAgICAgICA8 Y29sPgorfCAgICAgICAgICAgZm9vPSJiYXIiCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGIyMjZlZWM3MjkyZjU2ODBjMzM0MjRjOTMzOGRk OWQ2NWI0NmY2MWMuLmZmODQ0YWIzZjU5ODViZGM1MzE1NzhiMWY1MThiY2NiZGUzNTUyZjkgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0y LDYgKzIsMTYgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAg ICAgICBBZGQgYmFzaWMgPGNvbD4gc3VwcG9ydCB0byB0aGUgdHJlZWJ1aWxkZXIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNTkwCisKKyAgICAgICAg KiBodG1sL0hUTUxUcmVlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1 aWxkZXI6OnByb2Nlc3NTdGFydFRhZyk6CisKKzIwMTAtMDctMDQgIEVyaWMgU2VpZGVsICA8ZXJp Y0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAg ICAgICAgIEFkZCBiYXNpYyAiaW4gcm93IiBtb2RlIHRvIHN1cHBvcnQgPHRkPiBhbmQgPHRoPiBp bnNlcnRpb24KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQxNTg4CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3BwIGIv V2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5jcHAKaW5kZXggZDdhNjI4NTViMzE4NDI1OTY3 NzJmMDNkMzg0ZmVlMjBkMGE4YWMwZi4uYmEyYmM5YzdjMGVkMzhkNmFlOGUxNGMzYmQxOTE5ZmJi YWE1NTAyMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5jcHAKKysr IGIvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5jcHAKQEAgLTc0Niw3ICs3NDYsMTAgQEAg dm9pZCBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NTdGFydFRhZyhBdG9taWNIVE1MVG9rZW4mIHRv a2VuKQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgICAgIGlmICh0b2tlbi5u YW1lKCkgPT0gY29sVGFnKSB7Ci0gICAgICAgICAgICBub3RJbXBsZW1lbnRlZCgpOworICAgICAg ICAgICAgQXRvbWljSFRNTFRva2VuIGZha2VUb2tlbihIVE1MVG9rZW46OlN0YXJ0VGFnLCBjb2xn cm91cFRhZy5sb2NhbE5hbWUoKSk7CisgICAgICAgICAgICBwcm9jZXNzU3RhcnRUYWcoZmFrZVRv a2VuKTsKKyAgICAgICAgICAgIEFTU0VSVChJbkNvbHVtbkdyb3VwTW9kZSk7CisgICAgICAgICAg ICBwcm9jZXNzU3RhcnRUYWcodG9rZW4pOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9 CiAgICAgICAgIGlmIChpc1RhYmxlQm9keUNvbnRleHRUYWcodG9rZW4ubmFtZSgpKSkgewpAQCAt Nzg0LDYgKzc4NywxNyBAQCB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc1N0YXJ0VGFnKEF0 b21pY0hUTUxUb2tlbiYgdG9rZW4pCiAgICAgICAgIHBhcnNlRXJyb3IodG9rZW4pOwogICAgICAg ICBub3RJbXBsZW1lbnRlZCgpOwogICAgICAgICBicmVhazsKKyAgICBjYXNlIEluQ29sdW1uR3Jv dXBNb2RlOgorICAgICAgICBpZiAodG9rZW4ubmFtZSgpID09IGh0bWxUYWcpIHsKKyAgICAgICAg ICAgIGluc2VydEhUTUxTdGFydFRhZ0luQm9keSh0b2tlbik7CisgICAgICAgICAgICByZXR1cm47 CisgICAgICAgIH0KKyAgICAgICAgaWYgKHRva2VuLm5hbWUoKSA9PSBjb2xUYWcpIHsKKyAgICAg ICAgICAgIGluc2VydFNlbGZDbG9zaW5nRWxlbWVudCh0b2tlbik7CisgICAgICAgICAgICByZXR1 cm47CisgICAgICAgIH0KKyAgICAgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICAgICAgYnJlYWs7 CiAgICAgY2FzZSBJblRhYmxlQm9keU1vZGU6CiAgICAgICAgIEFTU0VSVChpbnNlcnRpb25Nb2Rl KCkgPT0gSW5UYWJsZUJvZHlNb2RlKTsKICAgICAgICAgaWYgKHRva2VuLm5hbWUoKSA9PSB0clRh Zykgewo=