41589 2010-07-04 20:36:10 -0700 rebaseline-chromium-webkit-tests: UnicodeDecodeError 2010-07-05 03:51:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tkent webkit-unassigned hamaji morrita oldest_to_newest 246484 0 tkent 2010-07-04 20:36:10 -0700 Steps: 1. Run "./WebKitTools/Scripts/build-dumprendertree" to have ImageDiff 2. Prepend "REABSELINE" to a line of "BUG48154 WIN LINUX: fast/forms/indeterminate.html = IMAGE" 3. Run "./WebKitTools/Scripts/rebaseline-chromium-webkit-tests -w" Expected result: No error. Actual result: 100705 12:27:18 rebaseline_chromium_webkit_tests.py:176 INFO Html directory: "/var/folders/zz/zzzivhrRnAmviuee++0u7E++iWI/-Tmp-/tmpaEpx44/rebaseline_html" 100705 12:27:18 rebaseline_chromium_webkit_tests.py:981 INFO 100705 12:27:18 rebaseline_chromium_webkit_tests.py:154 INFO --------------------------- Rebaseline started: mac --------------------------- 100705 12:27:18 rebaseline_chromium_webkit_tests.py:154 INFO ---------------------- Compiling rebaselining tests: mac ---------------------- 100705 12:27:18 rebaseline_chromium_webkit_tests.py:297 WARNING No tests found that need rebaselining. 100705 12:27:18 rebaseline_chromium_webkit_tests.py:154 INFO ----------------------------- Rebaseline done: mac ----------------------------- 100705 12:27:18 rebaseline_chromium_webkit_tests.py:981 INFO 100705 12:27:18 rebaseline_chromium_webkit_tests.py:154 INFO --------------------------- Rebaseline started: win --------------------------- 100705 12:27:18 rebaseline_chromium_webkit_tests.py:154 INFO ---------------------- Compiling rebaselining tests: win ---------------------- 100705 12:27:18 rebaseline_chromium_webkit_tests.py:302 INFO Total number of tests needing rebaselining for "win": "1" 100705 12:27:18 rebaseline_chromium_webkit_tests.py:306 INFO 1: fast/forms/indeterminate.html ------------------------- 100705 12:27:19 rebaseline_chromium_webkit_tests.py:334 INFO Latest revision: "51623" 100705 12:27:19 rebaseline_chromium_webkit_tests.py:379 INFO Archive url: "http://build.chromium.org/buildbot/layout_test_results/webkit-rel-webkit-org/51623/layout-test-results.zip" 100705 12:27:22 rebaseline_chromium_webkit_tests.py:395 INFO Archive downloaded and saved to file: "/var/folders/zz/zzzivhrRnAmviuee++0u7E++iWI/-Tmp-/tmpNDL4Cl.zip" 100705 12:27:22 rebaseline_chromium_webkit_tests.py:254 INFO 100705 12:27:22 rebaseline_chromium_webkit_tests.py:154 INFO ------------------- Extracting and adding new baselines: win ------------------- 100705 12:27:22 rebaseline_chromium_webkit_tests.py:423 INFO Test 1: fast/forms/indeterminate.html 100705 12:27:22 rebaseline_chromium_webkit_tests.py:434 INFO .txt file not in archive. 100705 12:27:22 rebaseline_chromium_webkit_tests.py:438 INFO .png file found in archive. 100705 12:27:23 rebaseline_chromium_webkit_tests.py:620 INFO Html: copied new baseline file from "/Users/tkent/WebKit/LayoutTests/platform/chromium-win/fast/forms/indeterminate-expected.png" to "/var/folders/zz/zzzivhrRnAmviuee++0u7E++iWI/-Tmp-/tmpaEpx44/rebaseline_html/indeterminate-expected-win-new.png". Traceback (most recent call last): File "./WebKitTools/Scripts/rebaseline-chromium-webkit-tests", line 44, in <module> rebaseline_chromium_webkit_tests.main() File "/Users/tkent/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 983, in main if rebaseliner.run(backup): File "/Users/tkent/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 261, in run if not self._extract_and_add_new_baselines(archive_file): File "/Users/tkent/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 479, in _extract_and_add_new_baselines self._create_html_baseline_files(expected_fullpath) File "/Users/tkent/WebKit/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 624, in _create_html_baseline_files output = self._scm.show_head(baseline_fullpath) File "/Users/tkent/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm.py", line 665, in show_head return self.run(['git', 'show', 'HEAD:' + self.to_object_name(path)]) File "/Users/tkent/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm.py", line 114, in run decode_output=decode_output) File "/Users/tkent/WebKit2/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 91, in run_command File "/Users/tkent/WebKit2/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 296, in run_command File "/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/encodings/utf_8.py", line 16, in decode return codecs.utf_8_decode(input, errors, True) UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 0: unexpected code byte Note: This is NOT git-specific. I had the same error with a SVN checkout and a log for that case contained return self.run(['svn', 'cat', '-r', 'BASE', path]) 246485 1 tkent 2010-07-04 20:39:16 -0700 (In reply to comment #0) > 2. Prepend "REABSELINE" to a line of "BUG48154 WIN LINUX: fast/forms/indeterminate.html = IMAGE" typo: "REBASELINE" 246508 2 60494 morrita 2010-07-04 22:32:09 -0700 Created attachment 60494 patch v0 246555 3 60494 hamaji 2010-07-05 03:31:24 -0700 Comment on attachment 60494 patch v0 Looks good. 246561 4 morrita 2010-07-05 03:51:29 -0700 Committed r62480: <http://trac.webkit.org/changeset/62480> 60494 2010-07-04 22:32:09 -0700 2010-07-05 03:31:24 -0700 patch v0 bug-41589-20100705143208.patch text/plain 4690 morrita ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0ZmExNGEzY2U3MzgwMmQ3OWY5MjExNTgyMDk3OTQ1NmY2NGJlOTFmLi40OTU0N2Ni NjVlMjQ1NzZiMjI2NjgwMWE3YjFiNWRjYjI3YmJiNzA4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDctMDQgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAg ICAgcmViYXNlbGluZS1jaHJvbWl1bS13ZWJraXQtdGVzdHM6IFVuaWNvZGVEZWNvZGVFcnJvcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE1ODkKKwor ICAgICAgICAqIHJ1bigpIG1ldGhvZCBjYW4gcmVzdWx0IG5vbi11dGYtOCBieXRlcywgdGhhdCBj YXVzZXMgdXRmLTgKKyAgICAgICAgICBlbmNvZGluZyBmYWlsLiAgRml4ZWQgdG8gZGlzYWJsZSBl bmNvZGluZy4KKyAgICAgICAgKiBGaXhlZCBHaXQuZmluZF9jaGVja291dF9yb290KCkgdG8gbWFr ZSBhIHRlc3QgcGFzcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNr b3V0L3NjbS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9z Y21fdW5pdHRlc3QucHk6CisKIDIwMTAtMDctMDMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dh QHBhcm9nYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20u cHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20ucHkK aW5kZXggNzAyZTFhMGZlOTE2MDZjZWZkYWI3OTM4Mjg1OGMzMTc3ZWI3MDcyMC4uZDdjNjIxYzVi NjJlMjU5ZTUzZTBjNTI5MjQxNzBjZGQ2NjJhY2Y0NyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5CisrKyBiL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weQpAQCAtNDYwLDcgKzQ2MCw3 IEBAIGNsYXNzIFNWTihTQ00pOgogICAgICAgICAgICAgc2VsZi5fdGVhcmRvd25fYm9ndXNfZGly KGxvZykKIAogICAgIGRlZiBzaG93X2hlYWQoc2VsZiwgcGF0aCk6Ci0gICAgICAgIHJldHVybiBz ZWxmLnJ1bihbJ3N2bicsICdjYXQnLCAnLXInLCAnQkFTRScsIHBhdGhdKQorICAgICAgICByZXR1 cm4gc2VsZi5ydW4oWydzdm4nLCAnY2F0JywgJy1yJywgJ0JBU0UnLCBwYXRoXSwgZGVjb2RlX291 dHB1dD1GYWxzZSkKIAogICAgIGRlZiBfcmVwb3NpdG9yeV91cmwoc2VsZik6CiAgICAgICAgIHJl dHVybiBzZWxmLnZhbHVlX2Zyb21fc3ZuX2luZm8oc2VsZi5jaGVja291dF9yb290LCAnVVJMJykK QEAgLTUyNiw3ICs1MjYsNyBAQCBjbGFzcyBHaXQoU0NNKToKICAgICBAY2xhc3NtZXRob2QKICAg ICBkZWYgZmluZF9jaGVja291dF9yb290KGNscywgcGF0aCk6CiAgICAgICAgICMgImdpdCByZXYt cGFyc2UgLS1zaG93LWNkdXAiIHdvdWxkIGJlIGFub3RoZXIgd2F5IHRvIGdldCB0byB0aGUgcm9v dAotICAgICAgICAoY2hlY2tvdXRfcm9vdCwgZG90X2dpdCkgPSBvcy5wYXRoLnNwbGl0KHJ1bl9j b21tYW5kKFsnZ2l0JywgJ3Jldi1wYXJzZScsICctLWdpdC1kaXInXSwgY3dkPXBhdGgpKQorICAg ICAgICAoY2hlY2tvdXRfcm9vdCwgZG90X2dpdCkgPSBvcy5wYXRoLnNwbGl0KHJ1bl9jb21tYW5k KFsnZ2l0JywgJ3Jldi1wYXJzZScsICctLWdpdC1kaXInXSwgY3dkPShwYXRoIG9yICIuLyIpKSkK ICAgICAgICAgIyBJZiB3ZSB3ZXJlIHVzaW5nIDIuNiAjIGNoZWNrb3V0X3Jvb3QgPSBvcy5wYXRo LnJlbHBhdGgoY2hlY2tvdXRfcm9vdCwgcGF0aCkKICAgICAgICAgaWYgbm90IG9zLnBhdGguaXNh YnMoY2hlY2tvdXRfcm9vdCk6ICMgU29tZXRpbWVzIGdpdCByZXR1cm5zIHJlbGF0aXZlIHBhdGhz CiAgICAgICAgICAgICBjaGVja291dF9yb290ID0gb3MucGF0aC5qb2luKHBhdGgsIGNoZWNrb3V0 X3Jvb3QpCkBAIC02NjIsNyArNjYyLDcgQEAgY2xhc3MgR2l0KFNDTSk6CiAgICAgICAgIHJldHVy biBzZWxmLnJ1bihbJ2dpdCcsICdkaWZmJywgJ0hFQUQnLCAnLS0nLCBwYXRoXSkKIAogICAgIGRl ZiBzaG93X2hlYWQoc2VsZiwgcGF0aCk6Ci0gICAgICAgIHJldHVybiBzZWxmLnJ1bihbJ2dpdCcs ICdzaG93JywgJ0hFQUQ6JyArIHNlbGYudG9fb2JqZWN0X25hbWUocGF0aCldKQorICAgICAgICBy ZXR1cm4gc2VsZi5ydW4oWydnaXQnLCAnc2hvdycsICdIRUFEOicgKyBzZWxmLnRvX29iamVjdF9u YW1lKHBhdGgpXSwgZGVjb2RlX291dHB1dD1GYWxzZSkKIAogICAgIGRlZiBjb21taXR0ZXJfZW1h aWxfZm9yX3JldmlzaW9uKHNlbGYsIHJldmlzaW9uKToKICAgICAgICAgZ2l0X2NvbW1pdCA9IHNl bGYuZ2l0X2NvbW1pdF9mcm9tX3N2bl9yZXZpc2lvbihyZXZpc2lvbikKZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbV91bml0dGVzdC5w eSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbV91bml0 dGVzdC5weQppbmRleCBmNzQ0ZTJhNDRjYTE0MWVlODhiNDViOTA4MWE2NzQ3NTgyNzhlMGNiLi5l YWEzYjQ2N2U5ZmViN2IzZWU3ZWY4YzIzMTNlYzY5ZDVhZDgyZDVlIDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY21fdW5pdHRlc3QucHkK KysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtX3Vu aXR0ZXN0LnB5CkBAIC02NCw4ICs2NCwxMiBAQCBkZWYgcnVuX3NpbGVudChhcmdzLCBjd2Q9Tm9u ZSk6CiAKIAogZGVmIHdyaXRlX2ludG9fZmlsZV9hdF9wYXRoKGZpbGVfcGF0aCwgY29udGVudHMs IGVuY29kaW5nPSJ1dGYtOCIpOgotICAgIHdpdGggY29kZWNzLm9wZW4oZmlsZV9wYXRoLCAidyIs IGVuY29kaW5nKSBhcyBmaWxlOgotICAgICAgICBmaWxlLndyaXRlKGNvbnRlbnRzKQorICAgIGlm IGVuY29kaW5nOgorICAgICAgICB3aXRoIGNvZGVjcy5vcGVuKGZpbGVfcGF0aCwgInciLCBlbmNv ZGluZykgYXMgZmlsZToKKyAgICAgICAgICAgIGZpbGUud3JpdGUoY29udGVudHMpCisgICAgZWxz ZToKKyAgICAgICAgd2l0aCBvcGVuKGZpbGVfcGF0aCwgInciKSBhcyBmaWxlOgorICAgICAgICAg ICAgZmlsZS53cml0ZShjb250ZW50cykKIAogCiBkZWYgcmVhZF9mcm9tX3BhdGgoZmlsZV9wYXRo LCBlbmNvZGluZz0idXRmLTgiKToKQEAgLTY1Nyw2ICs2NjEsMTMgQEAgUTFkVEJ4MEFBQUI0Mml0 ZzRHbGdZSmpHd01ERHlPRE14TUR3MzRHQmdRRUFKUFFESkE9PQogICAgICAgICBTVk5UZXN0UmVw b3NpdG9yeS5fc3ZuX2NvbW1pdCgiZm91cnRoIGNvbW1pdCIpCiAgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwoIkhlbGxvISIsIHNlbGYuc2NtLnNob3dfaGVhZCgndGVzdF9maWxlJykpCiAKKyAgICBk ZWYgdGVzdF9zaG93X2hlYWRfYmluYXJ5KHNlbGYpOgorICAgICAgICBkYXRhID0gIlwyNDQiCisg ICAgICAgIHdyaXRlX2ludG9fZmlsZV9hdF9wYXRoKCJiaW5hcnlfZmlsZSIsIGRhdGEsIGVuY29k aW5nPU5vbmUpCisgICAgICAgIHNlbGYuc2NtLmFkZCgiYmluYXJ5X2ZpbGUiKQorICAgICAgICBz ZWxmLnNjbS5jb21taXRfd2l0aF9tZXNzYWdlKCJhIHRlc3QgY29tbWl0IikKKyAgICAgICAgc2Vs Zi5hc3NlcnRFcXVhbChkYXRhLCBzZWxmLnNjbS5zaG93X2hlYWQoJ2JpbmFyeV9maWxlJykpCisK ICAgICBkZWYgZG9fdGVzdF9kaWZmX2Zvcl9maWxlKHNlbGYpOgogICAgICAgICB3cml0ZV9pbnRv X2ZpbGVfYXRfcGF0aCgndGVzdF9maWxlJywgJ3NvbWUgY29udGVudCcpCiAgICAgICAgIHNlbGYu c2NtLmNvbW1pdF93aXRoX21lc3NhZ2UoImEgdGVzdCBjb21taXQiKQpAQCAtMTE2OSw2ICsxMTgw LDE0IEBAIGNsYXNzIEdpdFNWTlRlc3QoU0NNVGVzdCk6CiAgICAgICAgIHNlbGYuX3R3b19sb2Nh bF9jb21taXRzKCkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbCgibW9yZSB0ZXN0IGNvbnRlbnQi LCBzZWxmLnNjbS5zaG93X2hlYWQoJ3Rlc3RfZmlsZV9jb21taXQxJykpCiAKKyAgICBkZWYgdGVz dF9zaG93X2hlYWRfYmluYXJ5KHNlbGYpOgorICAgICAgICBzZWxmLl90d29fbG9jYWxfY29tbWl0 cygpCisgICAgICAgIGRhdGEgPSAiXDI0NCIKKyAgICAgICAgd3JpdGVfaW50b19maWxlX2F0X3Bh dGgoImJpbmFyeV9maWxlIiwgZGF0YSwgZW5jb2Rpbmc9Tm9uZSkKKyAgICAgICAgc2VsZi5zY20u YWRkKCJiaW5hcnlfZmlsZSIpCisgICAgICAgIHNlbGYuc2NtLmNvbW1pdF9sb2NhbGx5X3dpdGhf bWVzc2FnZSgiYSB0ZXN0IGNvbW1pdCIpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoZGF0YSwg c2VsZi5zY20uc2hvd19oZWFkKCdiaW5hcnlfZmlsZScpKQorCiAgICAgZGVmIHRlc3RfZGlmZl9m b3JfZmlsZShzZWxmKToKICAgICAgICAgc2VsZi5fdHdvX2xvY2FsX2NvbW1pdHMoKQogICAgICAg ICB3cml0ZV9pbnRvX2ZpbGVfYXRfcGF0aCgndGVzdF9maWxlX2NvbW1pdDEnLCAiVXBkYXRlZCIs IGVuY29kaW5nPU5vbmUpCg==