41548 2010-07-02 16:23:28 -0700 Use snprintf instead of sprintf everywhere in JavaScriptCore 2010-07-02 16:28:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam webkit-unassigned oldest_to_newest 246143 0 sam 2010-07-02 16:23:28 -0700 Use snprintf instead of sprintf everywhere in JavaScriptCore. 246144 1 60417 sam 2010-07-02 16:24:23 -0700 Created attachment 60417 Patch 246146 2 60417 ggaren 2010-07-02 16:25:29 -0700 Comment on attachment 60417 Patch r=me 246148 3 sam 2010-07-02 16:27:11 -0700 Landed in r62414. 246149 4 60417 darin 2010-07-02 16:28:26 -0700 Comment on attachment 60417 Patch JSGlobalObjectFunctions.cpp includes <string.h>, but now that it's using snprintf I think it needs to include StringExtras.h instead to avoid breaking the Windows build. review+ if you fix that. Also: UString::from(long long) uses snprintf, and for some reason passes sizeof(minBuf) - 1. WTF is up with that? And: UString.cpp seems to include StringExtras.h twice and also includes <string.h> unnecessarily since StringExtras.h includes that. 60417 2010-07-02 16:24:23 -0700 2010-07-02 16:28:26 -0700 Patch printf.diff text/plain 2715 sam SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYyNDEzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDctMDIgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQYXRjaCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQxNTQ4CisgICAgICAgIFVzZSBzbnByaW50ZiBpbnN0ZWFkIG9mIHNwcmludGYgZXZl cnl3aGVyZSBpbiBKYXZhU2NyaXB0Q29yZQorCisgICAgICAgICogcnVudGltZS9KU0dsb2JhbE9i amVjdEZ1bmN0aW9ucy5jcHA6CisgICAgICAgIChKU0M6OmVuY29kZSk6CisgICAgICAgIChKU0M6 Omdsb2JhbEZ1bmNFc2NhcGUpOgorICAgICAgICAqIHJ1bnRpbWUvVVN0cmluZy5jcHA6CisgICAg ICAgIChKU0M6OlVTdHJpbmc6OmZyb20pOgorCiAyMDEwLTA3LTAyICBPbGl2ZXIgSHVudCAgPG9s aXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmZyZXkgR2FyZW4uCklu ZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0RnVuY3Rpb25zLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0RnVuY3Rp b25zLmNwcAkocmV2aXNpb24gNjIyOTUpCisrKyBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xv YmFsT2JqZWN0RnVuY3Rpb25zLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjYsNyArNjYsNyBAQCBz dGF0aWMgSlNWYWx1ZSBlbmNvZGUoRXhlY1N0YXRlKiBleGVjLCBjCiAgICAgICAgICAgICBidWls ZGVyLmFwcGVuZChjKTsKICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICBjaGFyIHRtcFs0XTsK LSAgICAgICAgICAgIHNucHJpbnRmKHRtcCwgNCwgIiUlJTAyWCIsIHN0YXRpY19jYXN0PHVuc2ln bmVkIGNoYXI+KGMpKTsKKyAgICAgICAgICAgIHNucHJpbnRmKHRtcCwgc2l6ZW9mKHRtcCksICIl JSUwMlgiLCBzdGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyPihjKSk7CiAgICAgICAgICAgICBidWls ZGVyLmFwcGVuZCh0bXApOwogICAgICAgICB9CiAgICAgfQpAQCAtMzg2LDEzICszODYsMTMgQEAg RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBnbG9iYWxGdW5jRQogICAgICAgICBpbnQgdSA9 IGNbMF07CiAgICAgICAgIGlmICh1ID4gMjU1KSB7CiAgICAgICAgICAgICBjaGFyIHRtcFs3XTsK LSAgICAgICAgICAgIHNwcmludGYodG1wLCAiJSV1JTA0WCIsIHUpOworICAgICAgICAgICAgc25w cmludGYodG1wLCBzaXplb2YodG1wKSwgIiUldSUwNFgiLCB1KTsKICAgICAgICAgICAgIGJ1aWxk ZXIuYXBwZW5kKHRtcCk7CiAgICAgICAgIH0gZWxzZSBpZiAodSAhPSAwICYmIHN0cmNocihkb19u b3RfZXNjYXBlLCBzdGF0aWNfY2FzdDxjaGFyPih1KSkpCiAgICAgICAgICAgICBidWlsZGVyLmFw cGVuZChjLCAxKTsKICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICBjaGFyIHRtcFs0XTsKLSAg ICAgICAgICAgIHNwcmludGYodG1wLCAiJSUlMDJYIiwgdSk7CisgICAgICAgICAgICBzbnByaW50 Zih0bXAsIHNpemVvZih0bXApLCAiJSUlMDJYIiwgdSk7CiAgICAgICAgICAgICBidWlsZGVyLmFw cGVuZCh0bXApOwogICAgICAgICB9CiAgICAgfQpJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9VU3RyaW5nLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1VTdHJp bmcuY3BwCShyZXZpc2lvbiA2MjI5NSkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvVVN0cmlu Zy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk2LDcgKzk2LDcgQEAgVVN0cmluZyBVU3RyaW5nOjpm cm9tKGludCBpKQogICAgICAgICAqLS1wID0gJzAnOwogICAgIGVsc2UgaWYgKGkgPT0gSU5UX01J TikgewogICAgICAgICBjaGFyIG1pbkJ1ZlsxICsgc2l6ZW9mKGkpICogM107Ci0gICAgICAgIHNw cmludGYobWluQnVmLCAiJWQiLCBJTlRfTUlOKTsKKyAgICAgICAgc25wcmludGYobWluQnVmLCBz aXplb2YobWluQnVmKSwgIiVkIiwgSU5UX01JTik7CiAgICAgICAgIHJldHVybiBVU3RyaW5nKG1p bkJ1Zik7CiAgICAgfSBlbHNlIHsKICAgICAgICAgYm9vbCBuZWdhdGl2ZSA9IGZhbHNlOwpAQCAt MTc2LDcgKzE3Niw3IEBAIFVTdHJpbmcgVVN0cmluZzo6ZnJvbShsb25nIGwpCiAgICAgICAgICot LXAgPSAnMCc7CiAgICAgZWxzZSBpZiAobCA9PSBMT05HX01JTikgewogICAgICAgICBjaGFyIG1p bkJ1ZlsxICsgc2l6ZW9mKGwpICogM107Ci0gICAgICAgIHNwcmludGYobWluQnVmLCAiJWxkIiwg TE9OR19NSU4pOworICAgICAgICBzbnByaW50ZihtaW5CdWYsIHNpemVvZihtaW5CdWYpLCAiJWxk IiwgTE9OR19NSU4pOwogICAgICAgICByZXR1cm4gVVN0cmluZyhtaW5CdWYpOwogICAgIH0gZWxz ZSB7CiAgICAgICAgIGJvb2wgbmVnYXRpdmUgPSBmYWxzZTsK