41540 2010-07-02 14:21:22 -0700 WebKit2: Add InjectedCode API to get a list of subframes 2010-07-02 16:01:48 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam webkit-unassigned webkit.review.bot oldest_to_newest 246083 0 sam 2010-07-02 14:21:22 -0700 Add InjectedCode API to get a list of subframes. 246089 1 60403 sam 2010-07-02 14:30:12 -0700 Created attachment 60403 Patch 246093 2 webkit.review.bot 2010-07-02 14:33:25 -0700 Attachment 60403 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit2/WebProcess/WebPage/WebFrame.cpp:187: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 246106 3 60403 oliver 2010-07-02 14:40:54 -0700 Comment on attachment 60403 Patch > + for (Frame* child = m_coreFrame->tree()->firstChild(); child; child = child->tree()->nextSibling(), ++i) { > + WebFrame* webFrame = static_cast<WebFrameLoaderClient*>(child->loader()->client())->webFrame(); tab!!!! :-O Remove this and r=me 246137 4 sam 2010-07-02 16:01:48 -0700 Fixed in http://trac.webkit.org/changeset/62406. 60403 2010-07-02 14:30:12 -0700 2010-07-02 14:40:54 -0700 Patch childFrames.diff text/plain 4415 sam SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MjM5OSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDctMDIgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXRjaCBm b3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNTQwCisgICAgICAg IFdlYktpdDI6IEFkZCBJbmplY3RlZENvZGUgQVBJIHRvIGdldCBhIGxpc3Qgb2Ygc3ViZnJhbWVz CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlRnJh bWUuY3BwOgorICAgICAgICAoV0tCdW5kbGVGcmFtZUNvcHlDaGlsZEZyYW1lcyk6CisgICAgICAg ICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZUZyYW1lLmg6CisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 Y2hpbGRGcmFtZVJlZik6CisgICAgICAgIChXZWJLaXQ6OmNoaWxkRnJhbWVEZXJlZik6CisgICAg ICAgIChXZWJLaXQ6OldlYkZyYW1lOjpjaGlsZEZyYW1lcyk6CisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYkZyYW1lLmg6CisgICAgICAgICogbWFjL1dlYktpdDIuZXhwOgorCiAyMDEw LTA3LTAyICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQW5kZXJzIENhcmxzc29uLgpJbmRleDogV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVu ZGxlL0FQSS9jL1dLQnVuZGxlRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZUZyYW1lLmNwcAkocmV2aXNpb24gNjIz NDIpCisrKyBXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVG cmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxLDMgKzQxLDggQEAgV0tVUkxSZWYgV0tCdW5k bGVGcmFtZUdldFVSTChXS0J1bmRsZUZyYQogewogICAgIHJldHVybiB0b1VSTFJlZih0b1dLKGZy YW1lUmVmKS0+dXJsKCkuaW1wbCgpKTsKIH0KKworV0tBcnJheVJlZiBXS0J1bmRsZUZyYW1lQ29w eUNoaWxkRnJhbWVzKFdLQnVuZGxlRnJhbWVSZWYgZnJhbWVSZWYpCit7CisgICAgcmV0dXJuIHRv UmVmKHRvV0soZnJhbWVSZWYpLT5jaGlsZEZyYW1lcygpLnJlbGVhc2VSZWYoKSk7ICAgIAorfQpJ bmRleDogV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlRnJh bWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJ L2MvV0tCdW5kbGVGcmFtZS5oCShyZXZpc2lvbiA2MjM0MikKKysrIFdlYktpdDIvV2ViUHJvY2Vz cy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZUZyYW1lLmgJKHdvcmtpbmcgY29weSkKQEAg LTQxLDYgKzQxLDggQEAgV0tfRVhQT1JUIGJvb2wgV0tCdW5kbGVGcmFtZUlzTWFpbkZyYW1lKAog CiBXS19FWFBPUlQgV0tVUkxSZWYgV0tCdW5kbGVGcmFtZUdldFVSTChXS0J1bmRsZUZyYW1lUmVm IGZyYW1lKTsKIAorV0tfRVhQT1JUIFdLQXJyYXlSZWYgV0tCdW5kbGVGcmFtZUNvcHlDaGlsZEZy YW1lcyhXS0J1bmRsZUZyYW1lUmVmIGZyYW1lKTsKKwogI2lmZGVmIF9fY3BsdXNwbHVzCiB9CiAj ZW5kaWYKSW5kZXg6IFdlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJGcmFtZS5jcHAJKHJldmlz aW9uIDYyMzQyKQorKysgV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xNjIsNCArMTYyLDM4IEBAIFN0cmluZyBXZWJGcmFtZTo6dXJsKCkg Y29uc3QKICAgICByZXR1cm4gbV9jb3JlRnJhbWUtPmxvYWRlcigpLT51cmwoKS5zdHJpbmcoKTsK IH0KIAorc3RhdGljIHZvaWQgY2hpbGRGcmFtZVJlZihjb25zdCB2b2lkKiBmcmFtZSkKK3sKKyAg ICBzdGF0aWNfY2FzdDxXZWJGcmFtZSo+KGNvbnN0X2Nhc3Q8dm9pZCo+KGZyYW1lKSktPnJlZigp OworfQorCitzdGF0aWMgdm9pZCBjaGlsZEZyYW1lRGVyZWYoY29uc3Qgdm9pZCogZnJhbWUpCit7 CisgICAgc3RhdGljX2Nhc3Q8V2ViRnJhbWUqPihjb25zdF9jYXN0PHZvaWQqPihmcmFtZSkpLT5k ZXJlZigpOworfQorCitQYXNzUmVmUHRyPEltbXV0YWJsZUFycmF5PiBXZWJGcmFtZTo6Y2hpbGRG cmFtZXMoKQoreworICAgIGlmICghbV9jb3JlRnJhbWUpCisgICAgICAgIHJldHVybiBJbW11dGFi bGVBcnJheTo6Y3JlYXRlKCk7CisKKyAgICBzaXplX3Qgc2l6ZSA9IG1fY29yZUZyYW1lLT50cmVl KCktPmNoaWxkQ291bnQoKTsKKyAgICBpZiAoIXNpemUpCisgICAgICAgIHJldHVybiBJbW11dGFi bGVBcnJheTo6Y3JlYXRlKCk7CisKKyAgICB2b2lkKiogYXJyYXkgPSBuZXcgdm9pZCpbc2l6ZV07 CisgICAgdW5zaWduZWQgaSA9IDA7CisgICAgZm9yIChGcmFtZSogY2hpbGQgPSBtX2NvcmVGcmFt ZS0+dHJlZSgpLT5maXJzdENoaWxkKCk7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT50cmVlKCktPm5l eHRTaWJsaW5nKCksICsraSkgeworICAgIAlXZWJGcmFtZSogd2ViRnJhbWUgPSBzdGF0aWNfY2Fz dDxXZWJGcmFtZUxvYWRlckNsaWVudCo+KGNoaWxkLT5sb2FkZXIoKS0+Y2xpZW50KCkpLT53ZWJG cmFtZSgpOworICAgICAgICB3ZWJGcmFtZS0+cmVmKCk7CisgICAgICAgIGFycmF5W2ldID0gd2Vi RnJhbWU7CisgICAgfQorCisgICAgSW1tdXRhYmxlQXJyYXk6OkltbXV0YWJsZUFycmF5Q2FsbGJh Y2tzIGNhbGxiYWNrcyA9IHsKKyAgICAgICAgY2hpbGRGcmFtZVJlZiwKKyAgICAgICAgY2hpbGRG cmFtZURlcmVmCisgICAgfTsKKyAgICByZXR1cm4gSW1tdXRhYmxlQXJyYXk6OmFkb3B0KGFycmF5 LCBzaXplLCAmY2FsbGJhY2tzKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBX ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJGcmFtZS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmgJKHJldmlzaW9uIDYyMzQyKQorKysgV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJhbWUuaAkod29ya2luZyBjb3B5KQpAQCAtMjYs NiArMjYsNyBAQAogI2lmbmRlZiBXZWJGcmFtZV9oCiAjZGVmaW5lIFdlYkZyYW1lX2gKIAorI2lu Y2x1ZGUgIkltbXV0YWJsZUFycmF5LmgiCiAjaW5jbHVkZSAiV2ViRnJhbWVMb2FkZXJDbGllbnQu aCIKICNpbmNsdWRlIDxXZWJDb3JlL0ZyYW1lTG9hZGVyQ2xpZW50Lmg+CiAjaW5jbHVkZSA8V2Vi Q29yZS9GcmFtZUxvYWRlclR5cGVzLmg+CkBAIC02NSw2ICs2Niw3IEBAIHB1YmxpYzoKICAgICAv LyBXS0J1bmRsZUZyYW1lIEFQSSBmdW5jdGlvbnMKICAgICBib29sIGlzTWFpbkZyYW1lKCkgY29u c3Q7CiAgICAgV2ViQ29yZTo6U3RyaW5nIHVybCgpIGNvbnN0OworICAgIFBhc3NSZWZQdHI8SW1t dXRhYmxlQXJyYXk+IGNoaWxkRnJhbWVzKCk7CiAKIHByaXZhdGU6CiAgICAgV2ViRnJhbWUoV2Vi UGFnZSosIGNvbnN0IFdlYkNvcmU6OlN0cmluZyYgZnJhbWVOYW1lLCBXZWJDb3JlOjpIVE1MRnJh bWVPd25lckVsZW1lbnQqKTsKSW5kZXg6IFdlYktpdDIvbWFjL1dlYktpdDIuZXhwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdDIvbWFjL1dlYktpdDIuZXhwCShyZXZpc2lvbiA2MjM0MikKKysrIFdlYktp dDIvbWFjL1dlYktpdDIuZXhwCSh3b3JraW5nIGNvcHkpCkBAIC0zLDYgKzMsNyBAQCBfV0tBcnJh eUdldEl0ZW1BdEluZGV4CiBfV0tBcnJheUdldFNpemUKIF9XS0FycmF5UmVsZWFzZQogX1dLQXJy YXlSZXRhaW4KK19XS0J1bmRsZUZyYW1lQ29weUNoaWxkRnJhbWVzCiBfV0tCdW5kbGVGcmFtZUdl dFVSTAogX1dLQnVuZGxlRnJhbWVJc01haW5GcmFtZQogX1dLQnVuZGxlUGFnZUNvcHlSZW5kZXJU cmVlRXh0ZXJuYWxSZXByZXNlbnRhdGlvbgo=