41537 2010-07-02 13:31:41 -0700 Some http tests fail on Windows with Cygwin 1.7 2010-07-02 13:40:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein webkit.review.bot oldest_to_newest 246059 0 bweinstein 2010-07-02 13:31:41 -0700 Some http tests fail on Windows with Cygwin 1.7, because LayoutTestControllerWin::resolveCygwinPath fails, because: DWORD result = ::SHGetValueW(HKEY_LOCAL_MACHINE, TEXT("SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/"), TEXT("native"), &keyType, &rootPath, &rootPathSize); fails, due to a configuration change on Cygwin 1.7 246062 1 60399 bweinstein 2010-07-02 13:34:01 -0700 Created attachment 60399 [PATCH] Fix 246065 2 webkit.review.bot 2010-07-02 13:36:23 -0700 Attachment 60399 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:620: Tab found; better to use spaces [whitespace/tab] [1] WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:621: Tab found; better to use spaces [whitespace/tab] [1] WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:622: Tab found; better to use spaces [whitespace/tab] [1] WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:623: Tab found; better to use spaces [whitespace/tab] [1] WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:624: Tab found; better to use spaces [whitespace/tab] [1] WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:625: Tab found; better to use spaces [whitespace/tab] [1] WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:626: Tab found; better to use spaces [whitespace/tab] [1] WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp:627: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 8 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 246069 3 bweinstein 2010-07-02 13:40:24 -0700 Landed in r62400. 60399 2010-07-02 13:34:01 -0700 2010-07-02 13:36:14 -0700 [PATCH] Fix cygwin_17_resolve.patch text/plain 2225 bweinstein SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYyMzk5KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDctMDIgIEJyaWFuIFdlaW5zdGVpbiAg PGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFNvbWUgaHR0cCB0ZXN0cyBmYWlsIG9uIFdpbmRvd3Mgd2l0aCBDeWd3 aW4gMS43CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MTUzNworICAgICAgICAKKyAgICAgICAgV2l0aCBDeWd3aW4gMS43LCB0aGUgcmVnaXN0cnkga2V5 IGF0IFNPRlRXQVJFXFxDeWdudXMgU29sdXRpb25zXFxDeWd3aW5cXG1vdW50cyB2MlxcLworICAg ICAgICBkb2Vzbid0IGV4aXN0IGFueW1vcmUsIGJlY2F1c2UgdGhlIG1vdW50IHBvaW50cyBhcmUg c3RvcmVkIGluIC9ldGMvZnN0YWIuIEhvd2V2ZXIsIHdlCisgICAgICAgIGp1c3QgbmVlZCByb290 IG1vdW50IHBvaW50LCB3aGljaCBpcyBkZWZpbmVkIGluIFNPRlRXQVJFXFxDeWd3aW5cXHNldHVw LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL0xheW91dFRlc3RDb250cm9sbGVyV2lu LmNwcDoKKyAgICAgICAgKHJlc29sdmVDeWd3aW5QYXRoKTogRmFsbCBiYWNrIHRvIFNPRlRXQVJF XFxDeWd3aW5cXHNldHVwIGlmIAorICAgICAgICAgICAgU09GVFdBUkVcXEN5Z251cyBTb2x1dGlv bnNcXEN5Z3dpblxcbW91bnRzIHYyXFwvIGRvZXNuJ3Qgd29yay4KKwogMjAxMC0wNi0yMyAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgR3VzdGF2byBOb3JvbmhhIFNpbHZhLgpJbmRleDogV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRy ZWUvd2luL0xheW91dFRlc3RDb250cm9sbGVyV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS93aW4vTGF5b3V0VGVzdENvbnRyb2xsZXJXaW4uY3BwCShyZXZp c2lvbiA2MjM5NCkKKysrIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9MYXlvdXRUZXN0 Q29udHJvbGxlcldpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxNyw4ICs2MTcsMTQgQEAgc3Rh dGljIGJvb2wgcmVzb2x2ZUN5Z3dpblBhdGgoY29uc3Qgd3N0cgogICAgIERXT1JEIGtleVR5cGU7 CiAgICAgRFdPUkQgcmVzdWx0ID0gOjpTSEdldFZhbHVlVyhIS0VZX0xPQ0FMX01BQ0hJTkUsIFRF WFQoIlNPRlRXQVJFXFxDeWdudXMgU29sdXRpb25zXFxDeWd3aW5cXG1vdW50cyB2MlxcLyIpLCBU RVhUKCJuYXRpdmUiKSwgJmtleVR5cGUsICZyb290UGF0aCwgJnJvb3RQYXRoU2l6ZSk7CiAKLSAg ICBpZiAocmVzdWx0ICE9IEVSUk9SX1NVQ0NFU1MgfHwga2V5VHlwZSAhPSBSRUdfU1opCi0gICAg ICAgIHJldHVybiBmYWxzZTsKKwlpZiAocmVzdWx0ICE9IEVSUk9SX1NVQ0NFU1MgfHwga2V5VHlw ZSAhPSBSRUdfU1opIHsKKwkJLy8gQ3lnd2luIDEuNyBkb2Vzbid0IHN0b3JlIEN5Z3dpbidzIHJv b3QgYXMgYSBtb3VudCBwb2ludCBhbnltb3JlLCBiZWNhdXNlIG1vdW50IHBvaW50cyBhcmUgbm93 IHN0b3JlZCBpbiAvZXRjL2ZzdGFiLgorCQkvLyBIb3dldmVyLCAvZXRjL2ZzdGFiIGRvZXNuJ3Qg Y29udGFpbiBhbnkgaW5mb3JtYXRpb24gYWJvdXQgd2hlcmUgLyBpcyBsb2NhdGVkIGFzIGEgV2lu ZG93cyBwYXRoLCBzbyB3ZSBuZWVkIHRvIHVzZSBDeWd3aW4ncworCQkvLyBuZXcgcmVnaXN0cnkg a2V5IHRoYXQgaGFzIHRoZSByb290LgorCQlyZXN1bHQgPSA6OlNIR2V0VmFsdWVXKEhLRVlfTE9D QUxfTUFDSElORSwgVEVYVCgiU09GVFdBUkVcXEN5Z3dpblxcc2V0dXAiKSwgVEVYVCgicm9vdGRp ciIpLCAma2V5VHlwZSwgJnJvb3RQYXRoLCAmcm9vdFBhdGhTaXplKTsKKwkJaWYgKHJlc3VsdCAh PSBFUlJPUl9TVUNDRVNTIHx8IGtleVR5cGUgIT0gUkVHX1NaKQorCQkJcmV0dXJuIGZhbHNlOwor CX0KIAogICAgIHdpbmRvd3NQYXRoID0gd3N0cmluZyhyb290UGF0aCwgcm9vdFBhdGhTaXplKTsK IAo=