4153 2005-07-26 22:50:32 -0700 WebKit page cache can grow without bound when there is a snapback item around 2005-07-30 12:38:32 -0700 1 1 1 Unclassified WebKit WebKit API 412 Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 15229 0 mjs 2005-07-26 22:50:32 -0700 When a snapback page is set, the WebKit back/forward cache (AKA page cache) can grow without bound, because it will find the oldest back/forward item but will refuse to actually purge it since it is marked as the snapback item. A simple fix would be to purge the most recent non-snapback item when the page cache goes over its maximum size instead. 15230 1 3106 mjs 2005-07-26 22:58:18 -0700 Created attachment 3106 the fix 15231 2 3107 mjs 2005-07-26 23:04:34 -0700 Created attachment 3107 again, without the debug printfs Whoops, I left debug code in the last patch. 15312 3 3107 hyatt 2005-07-27 22:50:15 -0700 Comment on attachment 3107 again, without the debug printfs r=me 15494 4 darin 2005-07-30 12:38:32 -0700 Maciej landed this fix a few days ago. 3106 2005-07-26 22:58:18 -0700 2005-07-26 23:04:34 -0700 the fix page-cache-fix.patch.txt text/plain 2380 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L0No YW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMjYxCmRpZmYgLXUgLXAgLXIxLjMyNjEg Q2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMjcgSnVsIDIwMDUgMDI6MDE6MDAgLTAwMDAJMS4zMjYx CisrKyBDaGFuZ2VMb2cJMjcgSnVsIDIwMDUgMDU6NDE6MzkgLTAwMDAKQEAgLTEsMyArMSwxMyBA QAorMjAwNS0wNy0yNiAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJLSBmaXhlZCBodHRwOi8vYnVnemls bGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTQxNTMKKwkKKyAgICAgICAgKiBXZWJW aWV3LnN1YnByb2ovV2ViRnJhbWUubToKKyAgICAgICAgKC1bV2ViRnJhbWUgX3B1cmdlUGFnZUNh Y2hlXSk6IEZpbmQgdGhlIG9sZGVzdCBjYW5kaWRhdGUgZm9yCisJcHVyZ2luZyB0aGF0IGlzIG5v dCBhIHNuYXBiYWNrIGl0ZW0uCisKIDIwMDUtMDctMjYgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4u Z2FyY2lhQGFwcGxlLmNvbT4KIAogICAgICAgICBQYXRjaCBieSBUcmV5IE1hdHRlc29uIDx0cmV5 QHVzYS5uZXQ+CkluZGV4OiBXZWJWaWV3LnN1YnByb2ovV2ViRnJhbWUubQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L1dlYlZpZXcuc3VicHJvai9XZWJGcmFtZS5tLHYKcmV0 cmlldmluZyByZXZpc2lvbiAxLjI0NQpkaWZmIC11IC1wIC1yMS4yNDUgV2ViVmlldy5zdWJwcm9q L1dlYkZyYW1lLm0KLS0tIFdlYlZpZXcuc3VicHJvai9XZWJGcmFtZS5tCTI3IEp1bCAyMDA1IDAy OjAxOjAzIC0wMDAwCTEuMjQ1CisrKyBXZWJWaWV3LnN1YnByb2ovV2ViRnJhbWUubQkyNyBKdWwg MjAwNSAwNTo0MTo0MCAtMDAwMApAQCAtOTIzLDIyICs5MjMsMjUgQEAgTlNTdHJpbmcgKldlYlBh Z2VDYWNoZURvY3VtZW50Vmlld0tleSA9IAogICAgIHVuc2lnbmVkIHBhZ2VzQ2FjaGVkID0gMDsK ICAgICBXZWJCYWNrRm9yd2FyZExpc3QgKmJhY2tGb3J3YXJkTGlzdCA9IFtbc2VsZiB3ZWJWaWV3 XSBiYWNrRm9yd2FyZExpc3RdOwogICAgIE5TQXJyYXkgKmJhY2tMaXN0ID0gW2JhY2tGb3J3YXJk TGlzdCBiYWNrTGlzdFdpdGhMaW1pdDogOTk5OTk5XTsKLSAgICBXZWJIaXN0b3J5SXRlbSAqb2xk ZXN0SXRlbSA9IG5pbDsKKyAgICBXZWJIaXN0b3J5SXRlbSAqb2xkZXN0Tm9uU25hcGJhY2tJdGVt ID0gbmlsOwogICAgIAogICAgIHVuc2lnbmVkIGk7CiAgICAgZm9yIChpID0gMDsgaSA8IFtiYWNr TGlzdCBjb3VudF07IGkrKyl7CiAgICAgICAgIFdlYkhpc3RvcnlJdGVtICppdGVtID0gW2JhY2tM aXN0IG9iamVjdEF0SW5kZXg6IGldOwogICAgICAgICBpZiAoW2l0ZW0gaGFzUGFnZUNhY2hlXSl7 Ci0gICAgICAgICAgICBpZiAob2xkZXN0SXRlbSA9PSBuaWwpCi0gICAgICAgICAgICAgICAgb2xk ZXN0SXRlbSA9IGl0ZW07CisgICAgICAgICAgICBpZiAob2xkZXN0Tm9uU25hcGJhY2tJdGVtID09 IG5pbCAmJiAhW2l0ZW0gYWx3YXlzQXR0ZW1wdFRvVXNlUGFnZUNhY2hlXSkKKyAgICAgICAgICAg ICAgICBvbGRlc3ROb25TbmFwYmFja0l0ZW0gPSBpdGVtOwogICAgICAgICAgICAgcGFnZXNDYWNo ZWQrKzsKICAgICAgICAgfQogICAgIH0KKworICAgIHByaW50ZigicGFnZXMgY2FjaGVkOiAlZCwg c2l6ZSBsaW1pdDogJWRcbiIsIHBhZ2VzQ2FjaGVkLCBzaXplTGltaXQpOwogICAgIAogICAgIC8v IFNuYXBiYWNrIGl0ZW1zIGFyZSBuZXZlciBkaXJlY3RseSBwdXJnZWQgaGVyZS4KLSAgICBpZiAo cGFnZXNDYWNoZWQgPj0gc2l6ZUxpbWl0ICYmICFbb2xkZXN0SXRlbSBhbHdheXNBdHRlbXB0VG9V c2VQYWdlQ2FjaGVdKXsKLSAgICAgICAgTE9HKFBhZ2VDYWNoZSwgIlB1cmdpbmcgYmFjay9mb3J3 YXJkIGNhY2hlLCAlQFxuIiwgW29sZGVzdEl0ZW0gVVJMXSk7Ci0gICAgICAgIFtvbGRlc3RJdGVt IHNldEhhc1BhZ2VDYWNoZTogTk9dOworICAgIGlmIChwYWdlc0NhY2hlZCA+PSBzaXplTGltaXQp IHsKKyAgICAgICAgcHJpbnRmKCJQdXJnaW5nICVwXG4iLCBvbGRlc3ROb25TbmFwYmFja0l0ZW0p OworICAgICAgICBMT0coUGFnZUNhY2hlLCAiUHVyZ2luZyBiYWNrL2ZvcndhcmQgY2FjaGUsICVA XG4iLCBbb2xkZXN0Tm9uU25hcGJhY2tJdGVtIFVSTF0pOworICAgICAgICBbb2xkZXN0Tm9uU25h cGJhY2tJdGVtIHNldEhhc1BhZ2VDYWNoZTpOT107CiAgICAgfQogfQogCg== 3107 2005-07-26 23:04:34 -0700 2005-07-27 22:50:15 -0700 again, without the debug printfs page-cache-fix.patch.txt text/plain 2249 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L0No YW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMjYxCmRpZmYgLXUgLXAgLXIxLjMyNjEg Q2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMjcgSnVsIDIwMDUgMDI6MDE6MDAgLTAwMDAJMS4zMjYx CisrKyBDaGFuZ2VMb2cJMjcgSnVsIDIwMDUgMDU6NDc6MTggLTAwMDAKQEAgLTEsMyArMSwxMyBA QAorMjAwNS0wNy0yNiAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJLSBmaXhlZCBodHRwOi8vYnVnemls bGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTQxNTMKKwkKKyAgICAgICAgKiBXZWJW aWV3LnN1YnByb2ovV2ViRnJhbWUubToKKyAgICAgICAgKC1bV2ViRnJhbWUgX3B1cmdlUGFnZUNh Y2hlXSk6IEZpbmQgdGhlIG9sZGVzdCBjYW5kaWRhdGUgZm9yCisJcHVyZ2luZyB0aGF0IGlzIG5v dCBhIHNuYXBiYWNrIGl0ZW0uCisKIDIwMDUtMDctMjYgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4u Z2FyY2lhQGFwcGxlLmNvbT4KIAogICAgICAgICBQYXRjaCBieSBUcmV5IE1hdHRlc29uIDx0cmV5 QHVzYS5uZXQ+CkluZGV4OiBXZWJWaWV3LnN1YnByb2ovV2ViRnJhbWUubQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L1dlYlZpZXcuc3VicHJvai9XZWJGcmFtZS5tLHYKcmV0 cmlldmluZyByZXZpc2lvbiAxLjI0NQpkaWZmIC11IC1wIC1yMS4yNDUgV2ViVmlldy5zdWJwcm9q L1dlYkZyYW1lLm0KLS0tIFdlYlZpZXcuc3VicHJvai9XZWJGcmFtZS5tCTI3IEp1bCAyMDA1IDAy OjAxOjAzIC0wMDAwCTEuMjQ1CisrKyBXZWJWaWV3LnN1YnByb2ovV2ViRnJhbWUubQkyNyBKdWwg MjAwNSAwNTo0NzoxOSAtMDAwMApAQCAtOTIzLDIyICs5MjMsMjIgQEAgTlNTdHJpbmcgKldlYlBh Z2VDYWNoZURvY3VtZW50Vmlld0tleSA9IAogICAgIHVuc2lnbmVkIHBhZ2VzQ2FjaGVkID0gMDsK ICAgICBXZWJCYWNrRm9yd2FyZExpc3QgKmJhY2tGb3J3YXJkTGlzdCA9IFtbc2VsZiB3ZWJWaWV3 XSBiYWNrRm9yd2FyZExpc3RdOwogICAgIE5TQXJyYXkgKmJhY2tMaXN0ID0gW2JhY2tGb3J3YXJk TGlzdCBiYWNrTGlzdFdpdGhMaW1pdDogOTk5OTk5XTsKLSAgICBXZWJIaXN0b3J5SXRlbSAqb2xk ZXN0SXRlbSA9IG5pbDsKKyAgICBXZWJIaXN0b3J5SXRlbSAqb2xkZXN0Tm9uU25hcGJhY2tJdGVt ID0gbmlsOwogICAgIAogICAgIHVuc2lnbmVkIGk7CiAgICAgZm9yIChpID0gMDsgaSA8IFtiYWNr TGlzdCBjb3VudF07IGkrKyl7CiAgICAgICAgIFdlYkhpc3RvcnlJdGVtICppdGVtID0gW2JhY2tM aXN0IG9iamVjdEF0SW5kZXg6IGldOwogICAgICAgICBpZiAoW2l0ZW0gaGFzUGFnZUNhY2hlXSl7 Ci0gICAgICAgICAgICBpZiAob2xkZXN0SXRlbSA9PSBuaWwpCi0gICAgICAgICAgICAgICAgb2xk ZXN0SXRlbSA9IGl0ZW07CisgICAgICAgICAgICBpZiAob2xkZXN0Tm9uU25hcGJhY2tJdGVtID09 IG5pbCAmJiAhW2l0ZW0gYWx3YXlzQXR0ZW1wdFRvVXNlUGFnZUNhY2hlXSkKKyAgICAgICAgICAg ICAgICBvbGRlc3ROb25TbmFwYmFja0l0ZW0gPSBpdGVtOwogICAgICAgICAgICAgcGFnZXNDYWNo ZWQrKzsKICAgICAgICAgfQogICAgIH0KLSAgICAKKwogICAgIC8vIFNuYXBiYWNrIGl0ZW1zIGFy ZSBuZXZlciBkaXJlY3RseSBwdXJnZWQgaGVyZS4KLSAgICBpZiAocGFnZXNDYWNoZWQgPj0gc2l6 ZUxpbWl0ICYmICFbb2xkZXN0SXRlbSBhbHdheXNBdHRlbXB0VG9Vc2VQYWdlQ2FjaGVdKXsKLSAg ICAgICAgTE9HKFBhZ2VDYWNoZSwgIlB1cmdpbmcgYmFjay9mb3J3YXJkIGNhY2hlLCAlQFxuIiwg W29sZGVzdEl0ZW0gVVJMXSk7Ci0gICAgICAgIFtvbGRlc3RJdGVtIHNldEhhc1BhZ2VDYWNoZTog Tk9dOworICAgIGlmIChwYWdlc0NhY2hlZCA+PSBzaXplTGltaXQpIHsKKyAgICAgICAgTE9HKFBh Z2VDYWNoZSwgIlB1cmdpbmcgYmFjay9mb3J3YXJkIGNhY2hlLCAlQFxuIiwgW29sZGVzdE5vblNu YXBiYWNrSXRlbSBVUkxdKTsKKyAgICAgICAgW29sZGVzdE5vblNuYXBiYWNrSXRlbSBzZXRIYXNQ YWdlQ2FjaGU6Tk9dOwogICAgIH0KIH0KIAo=