41527 2010-07-02 11:51:45 -0700 Adding notification and touch events methods to WebChromeClient 2010-07-02 20:39:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 luiz luiz commit-queue sam oldest_to_newest 246002 0 luiz 2010-07-02 11:51:45 -0700 Adding notification and touch events methods to WebChromeClient 246004 1 60385 luiz 2010-07-02 11:55:26 -0700 Created attachment 60385 Patch 246038 2 60385 sam 2010-07-02 12:44:13 -0700 Comment on attachment 60385 Patch > + > +#if ENABLE(NOTIFICATIONS) > + virtual WebCore::NotificationPresenter* notificationPresenter() const { return 0; } > +#endif > + > +#if ENABLE(TOUCH_EVENTS) > + virtual void needTouchEvents(bool) { } > +#endif > + Please put the implementation in the .cpp file. r-. 246047 3 60393 luiz 2010-07-02 13:01:11 -0700 Created attachment 60393 patch 2 246212 4 60393 commit-queue 2010-07-02 20:39:29 -0700 Comment on attachment 60393 patch 2 Clearing flags on attachment: 60393 Committed r62428: <http://trac.webkit.org/changeset/62428> 246213 5 commit-queue 2010-07-02 20:39:33 -0700 All reviewed patches have been landed. Closing bug. 60385 2010-07-02 11:55:26 -0700 2010-07-02 13:01:11 -0700 Patch bug-41527-20100702155522.patch text/plain 1555 luiz ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg Yzg5YTdjNDM1NThmYTc4ZGRiMWRmNDA0NzlkYmUwN2IxOTNmMzA3MS4uZGQ4YjMwZTZhOWEzOGY0 Nzk3MDUyMzVmMDg4ODhlNTQ2MWFlNjI3YyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNy0wMiAgTHVp eiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgbm90aWZpY2F0aW9uIGFu ZCB0b3VjaCBldmVudHMgbWV0aG9kcyB0byBXZWJDaHJvbWVDbGllbnQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNTI3CisKKyAgICAgICAgQWRkaW5n IG1ldGhvZHMgbm90aWZpY2F0aW9uUHJlc2VudGVyKCkgYW5kIG5lZWRUb3VjaEV2ZW50cygpIHRv IGNsYXNzIFdlYkNocm9tZUNsaWVudC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1 cHBvcnQvV2ViQ2hyb21lQ2xpZW50Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYkNocm9tZUNsaWVu dDo6bm90aWZpY2F0aW9uUHJlc2VudGVyKToKKyAgICAgICAgKFdlYktpdDo6V2ViQ2hyb21lQ2xp ZW50OjpuZWVkVG91Y2hFdmVudHMpOgorCiAyMDEwLTA3LTAxICBTdGV2ZSBGYWxrZW5idXJnICA8 c2ZhbGtlbkBhcHBsZS5jb20+CiAKICAgICAgICAgRXZlbiBtb3JlIFdpbmRvd3MgYnVpbGQgZml4 aW5nLgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNo cm9tZUNsaWVudC5oIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9t ZUNsaWVudC5oCmluZGV4IGZlNWYxNGE3NWJkN2Q2MDZiNTdhM2VmZGEyYTMxZDBhYjBmZDFlZDQu LmE3MmQ0OTAxZjBiNjdmMTBlNGM5ODlkMTliOGQ2ZWZkNzA1NDM5NzYgMTAwNjQ0Ci0tLSBhL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuaAorKysgYi9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmgKQEAgLTE2 Nyw2ICsxNjcsMTUgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgc2V0TmVlZHNPbmVTaG90 RHJhd2luZ1N5bmNocm9uaXphdGlvbigpOwogICAgIHZpcnR1YWwgdm9pZCBzY2hlZHVsZUNvbXBv c2l0aW5nTGF5ZXJTeW5jKCk7CiAjZW5kaWYKKworI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQor ICAgIHZpcnR1YWwgV2ViQ29yZTo6Tm90aWZpY2F0aW9uUHJlc2VudGVyKiBub3RpZmljYXRpb25Q cmVzZW50ZXIoKSBjb25zdCB7IHJldHVybiAwOyB9CisjZW5kaWYKKworI2lmIEVOQUJMRShUT1VD SF9FVkVOVFMpCisgICAgdmlydHVhbCB2b2lkIG5lZWRUb3VjaEV2ZW50cyhib29sKSB7IH0KKyNl bmRpZgorCiAgICAgCiAgICAgV2ViQ29yZTo6U3RyaW5nIG1fY2FjaGVkVG9vbFRpcDsKICAgICBX ZWJQYWdlKiBtX3BhZ2U7Cg== 60393 2010-07-02 13:01:11 -0700 2010-07-02 20:39:28 -0700 patch 2 0001-Adding-notification-and-touch-events-methods-to-WebC.patch text/plain 2760 luiz RnJvbSA5NDRhZTZlODk2ZDBkN2U1ZjU2Y2RjYWZlNTlkNjg0MDVhZjE0NTg3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IEZyaSwgMiBKdWwgMjAxMCAxNjo1OTozMyAtMDMwMApTdWJqZWN0OiBbUEFU Q0hdIEFkZGluZyBub3RpZmljYXRpb24gYW5kIHRvdWNoIGV2ZW50cyBtZXRob2RzIHRvIFdlYkNo cm9tZUNsaWVudAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNTI3 CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9XZWJDaHJvbWVDbGllbnQuY3BwOgooV2ViS2l0OjpXZWJDaHJvbWVDbGllbnQ6Om5vdGlmaWNh dGlvblByZXNlbnRlcik6CihXZWJLaXQ6OldlYkNocm9tZUNsaWVudDo6bmVlZFRvdWNoRXZlbnRz KToKKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5oOgotLS0KIFdl YktpdDIvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMiAr KysrKysrKysrKysKIC4uLi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVu dC5jcHAgIHwgICAxMyArKysrKysrKysrKysrCiAuLi4vV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9XZWJDaHJvbWVDbGllbnQuaCAgICB8ICAgIDggKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwg MzMgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQyL0No YW5nZUxvZyBiL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGM4OWE3YzQuLjc5OGUzN2EgMTAwNjQ0 Ci0tLSBhL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTAtMDctMDIgIEx1aXogQWdvc3RpbmkgIDxsdWl6LmFnb3N0aW5pQG9wZW5i b3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkaW5nIG5vdGlmaWNhdGlvbiBhbmQgdG91Y2ggZXZlbnRzIG1ldGhvZHMgdG8gV2ViQ2hy b21lQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MTUyNworCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVD bGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDaHJvbWVDbGllbnQ6Om5vdGlmaWNhdGlv blByZXNlbnRlcik6CisgICAgICAgIChXZWJLaXQ6OldlYkNocm9tZUNsaWVudDo6bmVlZFRvdWNo RXZlbnRzKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNs aWVudC5oOgorCiAyMDEwLTA3LTAxICBTdGV2ZSBGYWxrZW5idXJnICA8c2ZhbGtlbkBhcHBsZS5j b20+CiAKICAgICAgICAgRXZlbiBtb3JlIFdpbmRvd3MgYnVpbGQgZml4aW5nLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHAg Yi9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcApp bmRleCA4YWZjZWZmLi45ODY4OGZlIDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcAorKysgYi9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcApAQCAtNDU5LDQgKzQ1OSwxNyBAQCB2 b2lkIFdlYkNocm9tZUNsaWVudDo6c2NoZWR1bGVDb21wb3NpdGluZ0xheWVyU3luYygpCiAKICNl bmRpZgogCisjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCitXZWJDb3JlOjpOb3RpZmljYXRpb25Q cmVzZW50ZXIqIFdlYkNocm9tZUNsaWVudDo6bm90aWZpY2F0aW9uUHJlc2VudGVyKCkgY29uc3QK K3sKKyAgICByZXR1cm4gMDsKK30KKyNlbmRpZgorCisjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykK K3ZvaWQgV2ViQ2hyb21lQ2xpZW50OjpuZWVkVG91Y2hFdmVudHMoYm9vbCkKK3sKK30KKyNlbmRp ZgorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuaCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuaAppbmRleCBmZTVmMTRhLi5jOTkyNzE2IDEw MDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xp ZW50LmgKKysrIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNs aWVudC5oCkBAIC0xNjcsNiArMTY3LDE0IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHNl dE5lZWRzT25lU2hvdERyYXdpbmdTeW5jaHJvbml6YXRpb24oKTsKICAgICB2aXJ0dWFsIHZvaWQg c2NoZWR1bGVDb21wb3NpdGluZ0xheWVyU3luYygpOwogI2VuZGlmCisKKyNpZiBFTkFCTEUoTk9U SUZJQ0FUSU9OUykKKyAgICB2aXJ0dWFsIFdlYkNvcmU6Ok5vdGlmaWNhdGlvblByZXNlbnRlciog bm90aWZpY2F0aW9uUHJlc2VudGVyKCkgY29uc3Q7CisjZW5kaWYKKworI2lmIEVOQUJMRShUT1VD SF9FVkVOVFMpCisgICAgdmlydHVhbCB2b2lkIG5lZWRUb3VjaEV2ZW50cyhib29sKTsKKyNlbmRp ZgogICAgIAogICAgIFdlYkNvcmU6OlN0cmluZyBtX2NhY2hlZFRvb2xUaXA7CiAgICAgV2ViUGFn ZSogbV9wYWdlOwotLSAKMS42LjMuMwoK