41524 2010-07-02 11:03:59 -0700 [BREWMP] Change the CRASH() macro to print "WebKit CRASH" log. 2010-07-03 01:17:54 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned beergun commit-queue webkit.review.bot oldest_to_newest 245976 0 skyul 2010-07-02 11:03:59 -0700 Print "WebKit CRASH" before crashing. 245977 1 60381 skyul 2010-07-02 11:05:35 -0700 Created attachment 60381 Patch 245978 2 webkit.review.bot 2010-07-02 11:06:18 -0700 Attachment 60381 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/wtf/Assertions.h:175: Missing space before ( in while( [whitespace/parens] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 245981 3 skyul 2010-07-02 11:08:27 -0700 (In reply to comment #2) > Attachment 60381 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 > JavaScriptCore/wtf/Assertions.h:175: Missing space before ( in while( [whitespace/parens] [5] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. The patch did not pass style-queue, but actually it is consistent with other CRASH macros. 246270 4 60381 commit-queue 2010-07-03 01:17:49 -0700 Comment on attachment 60381 Patch Clearing flags on attachment: 60381 Committed r62441: <http://trac.webkit.org/changeset/62441> 246271 5 commit-queue 2010-07-03 01:17:54 -0700 All reviewed patches have been landed. Closing bug. 60381 2010-07-02 11:05:35 -0700 2010-07-03 01:17:49 -0700 Patch crash.patch text/plain 1459 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYyMzkwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDctMDIgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBDaGFuZ2UgdGhlIENSQVNIKCkgbWFjcm8g dG8gcHJpbnQgIldlYktpdCBDUkFTSCIgbG9nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE1MjQKKworICAgICAgICBQcmludCAiV2ViS2l0IENSQVNI IiBiZWZvcmUgY3Jhc2hpbmcuCisKKyAgICAgICAgKiB3dGYvQXNzZXJ0aW9ucy5oOgorCiAyMDEw LTA3LTAyICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLiBCdWlsZCBmaXggZm9yIEdUSysuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93 dGYvQXNzZXJ0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9Bc3NlcnRp b25zLmgJKHJldmlzaW9uIDYyMzcxKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMu aAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsMTAgQEAKICNpbmNsdWRlIDxlMzJkZWJ1Zy5o PgogI2VuZGlmCiAKKyNpZiBQTEFURk9STShCUkVXTVApCisjaW5jbHVkZSA8QUVFU3RkTGliLmg+ CisjZW5kaWYKKwogI2lmZGVmIE5ERUJVRwogLyogRGlzYWJsZSBBU1NFUlQqIG1hY3JvcyBpbiBy ZWxlYXNlIG1vZGUuICovCiAjZGVmaW5lIEFTU0VSVElPTlNfRElTQUJMRURfREVGQVVMVCAxCkBA IC0xNjMsNiArMTY3LDEyIEBAIHZvaWQgV1RGTG9nVmVyYm9zZShjb25zdCBjaGFyKiBmaWxlLCBp bnQKICAgICBfX0RFQlVHR0VSKCk7IFwKICAgICBVc2VyOjpQYW5pYyhfTCgiV2Via2l0IENSQVNI IiksMCk7IFwKICAgICB9IHdoaWxlKGZhbHNlKQorI2VsaWYgUExBVEZPUk0oQlJFV01QKQorI2Rl ZmluZSBDUkFTSCgpIGRvIHsgXAorICAgIERCR1BSSU5URl9GQVRBTCgiV2ViS2l0IENSQVNIIik7 IFwKKyAgICAqKGludCAqKSh1aW50cHRyX3QpMHhiYmFkYmVlZiA9IDA7IFwKKyAgICAoKHZvaWQo KikoKSkwKSgpOyAvKiBNb3JlIHJlbGlhYmxlLCBidXQgZG9lc24ndCBzYXkgQkJBREJFRUYgKi8g XAorfSB3aGlsZShmYWxzZSkKICNlbHNlCiAjZGVmaW5lIENSQVNIKCkgZG8geyBcCiAgICAgKihp bnQgKikodWludHB0cl90KTB4YmJhZGJlZWYgPSAwOyBcCg==