41516 2010-07-02 03:34:21 -0700 JavaInstanceV8 needs to push a local reference frame to avoid table overflow. 2010-07-07 03:28:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned phanna steveblock oldest_to_newest 245862 0 steveblock 2010-07-02 03:34:21 -0700 Similar to jsc's implementation, this is needed to restrict the amount of local references in a given jni frame. Once the frame is popped from the stack, all local references are cleaned. 245872 1 60356 steveblock 2010-07-02 03:53:19 -0700 Created attachment 60356 Patch 245888 2 phanna 2010-07-02 05:44:37 -0700 Should the LOGV be removed from JavaInstanceV8.cpp as well? 245903 3 60364 steveblock 2010-07-02 07:03:20 -0700 Created attachment 60364 Patch 247418 4 60364 abarth 2010-07-07 02:39:48 -0700 Comment on attachment 60364 Patch This change is taxing the boundaries of my understanding of Java. Ideally, the ChangeLog would contain more information to help folks understand what problem is being solved and how this patch goes about solving them. I'm hesitating to R+ this change, but on balance, it seems like the right thing to do. WebCore/ChangeLog:8 + No new tests. sad face WebCore/bridge/jni/v8/JavaInstanceV8.cpp:50 + #define NUM_LOCAL_REFS 64 Where does this number come from? 247451 5 steveblock 2010-07-07 03:28:24 -0700 Committed r62650: <http://trac.webkit.org/changeset/62650> 60356 2010-07-02 03:53:19 -0700 2010-07-02 07:03:14 -0700 Patch bug-41516-20100702115317.patch text/plain 1931 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MjM3OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDctMDIgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEphdmFJbnN0YW5jZVY4IG5lZWRzIHRvIHB1c2ggYSBsb2NhbCByZWZlcmVuY2UgZnJhbWUgdG8g YXZvaWQgdGFibGUgb3ZlcmZsb3cuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00MTUxNgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAq IGJyaWRnZS9qbmkvdjgvSmF2YUluc3RhbmNlVjguY3BwOgorICAgICAgICAoSmF2YUluc3RhbmNl Ojp2aXJ0dWFsQmVnaW4pOgorICAgICAgICAoSmF2YUluc3RhbmNlOjp2aXJ0dWFsRW5kKToKKyAg ICAgICAgKiBicmlkZ2Uvam5pL3Y4L0phdmFJbnN0YW5jZVY4Lmg6CisKIDIwMTAtMDctMDIgIEFk YW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmlj IFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvYnJpZGdlL2puaS92OC9KYXZhSW5zdGFuY2VWOC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0phdmFJbnN0YW5jZVY4LmNwcAko cmV2aXNpb24gNjIzNzcpCisrKyBXZWJDb3JlL2JyaWRnZS9qbmkvdjgvSmF2YUluc3RhbmNlVjgu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw5ICszMiw2IEBACiAjaW5jbHVkZSAiSmF2YUNsYXNz VjguaCIKIAogI2luY2x1ZGUgPGFzc2VydC5oPgotI2luY2x1ZGUgPHV0aWxzL0xvZy5oPgotCi0j ZGVmaW5lIExPR19UQUcgInY4YmluZGluZyIKIAogdXNpbmcgbmFtZXNwYWNlIEpTQzo6QmluZGlu Z3M7CiAKQEAgLTUwLDYgKzQ3LDE4IEBAIEphdmFJbnN0YW5jZTo6fkphdmFJbnN0YW5jZSgpCiAg ICAgZGVsZXRlIG1fY2xhc3M7CiB9CiAKKyNkZWZpbmUgTlVNX0xPQ0FMX1JFRlMgNjQKKwordm9p ZCBKYXZhSW5zdGFuY2U6OnZpcnR1YWxCZWdpbigpCit7CisgICAgZ2V0Sk5JRW52KCktPlB1c2hM b2NhbEZyYW1lKE5VTV9MT0NBTF9SRUZTKTsKK30KKwordm9pZCBKYXZhSW5zdGFuY2U6OnZpcnR1 YWxFbmQoKQoreworICAgIGdldEpOSUVudigpLT5Qb3BMb2NhbEZyYW1lKDApOworfQorCiBKYXZh Q2xhc3MqIEphdmFJbnN0YW5jZTo6Z2V0Q2xhc3MoKSBjb25zdAogewogICAgIGlmICghbV9jbGFz cykKSW5kZXg6IFdlYkNvcmUvYnJpZGdlL2puaS92OC9KYXZhSW5zdGFuY2VWOC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvYnJpZGdlL2puaS92OC9KYXZhSW5zdGFuY2VWOC5oCShyZXZpc2lvbiA2 MjM3NykKKysrIFdlYkNvcmUvYnJpZGdlL2puaS92OC9KYXZhSW5zdGFuY2VWOC5oCSh3b3JraW5n IGNvcHkpCkBAIC04OSw4ICs4OSw4IEBAIHByb3RlY3RlZDoKICAgICBSZWZQdHI8Sk9iamVjdFdy YXBwZXI+IG1faW5zdGFuY2U7CiAgICAgbXV0YWJsZSBKYXZhQ2xhc3MqIG1fY2xhc3M7CiAKLSAg ICB2aXJ0dWFsIHZvaWQgdmlydHVhbEJlZ2luKCkge30KLSAgICB2aXJ0dWFsIHZvaWQgdmlydHVh bEVuZCgpIHt9CisgICAgdmlydHVhbCB2b2lkIHZpcnR1YWxCZWdpbigpOworICAgIHZpcnR1YWwg dm9pZCB2aXJ0dWFsRW5kKCk7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBCaW5kaW5ncwo= 60364 2010-07-02 07:03:20 -0700 2010-07-07 02:39:48 -0700 Patch bug-41516-20100702150318.patch text/plain 2669 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MjM3OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDctMDIgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEphdmFJbnN0YW5jZVY4IG5lZWRzIHRvIHB1c2ggYSBsb2NhbCByZWZlcmVuY2UgZnJhbWUgdG8g YXZvaWQgdGFibGUgb3ZlcmZsb3cuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00MTUxNgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAq IGJyaWRnZS9qbmkvdjgvSmF2YUluc3RhbmNlVjguY3BwOgorICAgICAgICAoSmF2YUluc3RhbmNl Ojp2aXJ0dWFsQmVnaW4pOgorICAgICAgICAoSmF2YUluc3RhbmNlOjp2aXJ0dWFsRW5kKToKKyAg ICAgICAgKiBicmlkZ2Uvam5pL3Y4L0phdmFJbnN0YW5jZVY4Lmg6CisKIDIwMTAtMDctMDIgIEFk YW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmlj IFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvYnJpZGdlL2puaS92OC9KYXZhSW5zdGFuY2VWOC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0phdmFJbnN0YW5jZVY4LmNwcAko cmV2aXNpb24gNjIzNzcpCisrKyBXZWJDb3JlL2JyaWRnZS9qbmkvdjgvSmF2YUluc3RhbmNlVjgu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw5ICszMiw2IEBACiAjaW5jbHVkZSAiSmF2YUNsYXNz VjguaCIKIAogI2luY2x1ZGUgPGFzc2VydC5oPgotI2luY2x1ZGUgPHV0aWxzL0xvZy5oPgotCi0j ZGVmaW5lIExPR19UQUcgInY4YmluZGluZyIKIAogdXNpbmcgbmFtZXNwYWNlIEpTQzo6QmluZGlu Z3M7CiAKQEAgLTUwLDYgKzQ3LDE4IEBAIEphdmFJbnN0YW5jZTo6fkphdmFJbnN0YW5jZSgpCiAg ICAgZGVsZXRlIG1fY2xhc3M7CiB9CiAKKyNkZWZpbmUgTlVNX0xPQ0FMX1JFRlMgNjQKKwordm9p ZCBKYXZhSW5zdGFuY2U6OnZpcnR1YWxCZWdpbigpCit7CisgICAgZ2V0Sk5JRW52KCktPlB1c2hM b2NhbEZyYW1lKE5VTV9MT0NBTF9SRUZTKTsKK30KKwordm9pZCBKYXZhSW5zdGFuY2U6OnZpcnR1 YWxFbmQoKQoreworICAgIGdldEpOSUVudigpLT5Qb3BMb2NhbEZyYW1lKDApOworfQorCiBKYXZh Q2xhc3MqIEphdmFJbnN0YW5jZTo6Z2V0Q2xhc3MoKSBjb25zdAogewogICAgIGlmICghbV9jbGFz cykKQEAgLTc5LDEwICs4OCw4IEBAIGJvb2wgSmF2YUluc3RhbmNlOjppbnZva2VNZXRob2QoY29u c3QgY2gKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfQotICAgIGlmICghbWV0 aG9kKSB7Ci0gICAgICAgIExPR1coInVuYWJsZSB0byBmaW5kIGFuIGFwcHJvcGlhdGUgbWV0aG9k XG4iKTsKKyAgICBpZiAoIW1ldGhvZCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KIAog ICAgIGNvbnN0IEphdmFNZXRob2QqIGpNZXRob2QgPSBzdGF0aWNfY2FzdDxjb25zdCBKYXZhTWV0 aG9kKj4obWV0aG9kKTsKIApAQCAtMTU2LDE0ICsxNjMsMTEgQEAgSk9iamVjdFdyYXBwZXI6OkpP YmplY3RXcmFwcGVyKGpvYmplY3QgaQogCiAgICAgbV9pbnN0YW5jZSA9IG1fZW52LT5OZXdHbG9i YWxSZWYoaW5zdGFuY2UpOwogCi0gICAgTE9HVigibmV3IGdsb2JhbCByZWYgJXAgZm9yICVwXG4i LCBtX2luc3RhbmNlLCBpbnN0YW5jZSk7Ci0KICAgICBpZiAoIW1faW5zdGFuY2UpCiAgICAgICAg IGZwcmludGYoc3RkZXJyLCAiJXM6ICBjb3VsZCBub3QgZ2V0IEdsb2JhbFJlZiBmb3IgJXBcbiIs IF9fUFJFVFRZX0ZVTkNUSU9OX18sIGluc3RhbmNlKTsKIH0KIAogSk9iamVjdFdyYXBwZXI6On5K T2JqZWN0V3JhcHBlcigpCiB7Ci0gICAgTE9HVigiZGVsZXRpbmcgZ2xvYmFsIHJlZiAlcFxuIiwg bV9pbnN0YW5jZSk7CiAgICAgbV9lbnYtPkRlbGV0ZUdsb2JhbFJlZihtX2luc3RhbmNlKTsKIH0K SW5kZXg6IFdlYkNvcmUvYnJpZGdlL2puaS92OC9KYXZhSW5zdGFuY2VWOC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvYnJpZGdlL2puaS92OC9KYXZhSW5zdGFuY2VWOC5oCShyZXZpc2lvbiA2MjM3 NykKKysrIFdlYkNvcmUvYnJpZGdlL2puaS92OC9KYXZhSW5zdGFuY2VWOC5oCSh3b3JraW5nIGNv cHkpCkBAIC04OSw4ICs4OSw4IEBAIHByb3RlY3RlZDoKICAgICBSZWZQdHI8Sk9iamVjdFdyYXBw ZXI+IG1faW5zdGFuY2U7CiAgICAgbXV0YWJsZSBKYXZhQ2xhc3MqIG1fY2xhc3M7CiAKLSAgICB2 aXJ0dWFsIHZvaWQgdmlydHVhbEJlZ2luKCkge30KLSAgICB2aXJ0dWFsIHZvaWQgdmlydHVhbEVu ZCgpIHt9CisgICAgdmlydHVhbCB2b2lkIHZpcnR1YWxCZWdpbigpOworICAgIHZpcnR1YWwgdm9p ZCB2aXJ0dWFsRW5kKCk7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBCaW5kaW5ncwo=