41492 2010-07-01 16:16:12 -0700 [chromium] WebCore::GLES2Context should allow creating onscreen and offscreen contexts 2010-07-07 14:49:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jamesr jamesr kbr scheib oldest_to_newest 245632 0 jamesr 2010-07-01 16:16:12 -0700 WebCore::GLES2Context should allow creating onscreen and offscreen contexts 245691 1 60324 jamesr 2010-07-01 18:00:02 -0700 Created attachment 60324 Patch 247737 2 60324 kbr 2010-07-07 14:01:47 -0700 Comment on attachment 60324 Patch Looks fine to me. As we've discussed offline, this class should expose a couple of additional entry points, but this seems like a fine self-contained patch. 247770 3 60324 dglazkov 2010-07-07 14:41:01 -0700 Comment on attachment 60324 Patch ok. 247776 4 60324 jamesr 2010-07-07 14:49:26 -0700 Comment on attachment 60324 Patch Clearing flags on attachment: 60324 Committed r62702: <http://trac.webkit.org/changeset/62702> 247777 5 jamesr 2010-07-07 14:49:30 -0700 All reviewed patches have been landed. Closing bug. 60324 2010-07-01 18:00:02 -0700 2010-07-07 14:49:26 -0700 Patch bug-41492-20100701180000.patch text/plain 5958 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGU0OGVkNTNiYjMwZmVmMDFiZWJkOTY4MjhlMTU5OTA3ZjI4MzlkOS4uYTdkYjVlOGExZWNlYzU1 NmJhYWM4YmIzZjYxYzdiMjMyMDliODkwNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNy0wMSAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPiBhbmQgVmluY2VudCBTY2hlaWIgPHNj aGllYkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViQ29yZTo6R0xFUzJDb250ZXh0IHNob3VsZCBhbGxvdyBjcmVhdGluZyBv bnNjcmVlbiBhbmQgb2Zmc2NyZWVuIGNvbnRleHRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTQ5MgorCisgICAgICAgIFlvdSBzaG91bGQgYmUgYWJs ZSB0byBjcmVhdGUgYSBHTEVTMkNvbnRleHQgZm9yIHJlbmRlcmluZyBib3RoIG9uIHNjcmVlbgor ICAgICAgICBhbmQgb2ZmIHNjcmVlbiAodG8gYSB0ZXh0dXJlKS4gIENocm9taXVtJ3MgbGF5ZXIg cmVuZGVyZXIgKHVzZWQgZm9yIGNvbXBvc2l0aW5nKQorICAgICAgICBkb2VzIHRoZSBmb3JtZXIu ICBDdXJyZW50bHkgV2ViR0wgZG9lcyB0aGUgbGF0dGVyIGJ5IHNpZGUgc3RlcHBpbmcgdGhlCisg ICAgICAgIFdlYkNvcmU6OkdMRVMyQ29udGV4dCBBUEkgY29tcGxldGVseS4gIExvbmdlciB0ZXJt IGl0IHNob3VsZCBtb3ZlIG92ZXIgdG8gdXNpbmcgdGhpcy4KKworICAgICAgICAqIHBsYXRmb3Jt L2Nocm9taXVtL0dMRVMyQ29udGV4dC5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXll clJlbmRlcmVyQ2hyb21pdW06OmluaXRHTCk6CisKIDIwMTAtMDctMDEgIEVyaWMgU2VpZGVsICA8 ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuICBGaXggcGFzdGUtbyBpbiBH dGsgYnVpbGQgZmlsZS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vR0xF UzJDb250ZXh0LmggYi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0dMRVMyQ29udGV4dC5oCmlu ZGV4IDkzYTM0M2NhNmI2NjNkNjA3MWY0M2JhNzlmOWJjN2M3YTYwMGE4M2UuLmVmNjcwMTI1MmQ2 ZGY1OWQ3YjMxMDYwZTA1N2Y2NTQ3MWU1NjVhNmIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vR0xFUzJDb250ZXh0LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1 bS9HTEVTMkNvbnRleHQuaApAQCAtNDIsMTAgKzQyLDE0IEBAIGNsYXNzIFBhZ2U7CiAKIGNsYXNz IEdMRVMyQ29udGV4dCA6IHB1YmxpYyBOb25jb3B5YWJsZSB7CiBwdWJsaWM6Ci0gICAgLy8gSWYg YSBQYWdlIGlzIHNwZWNpZmllZCB0aGVuIHRoZSByZXN1bHRpbmcgR0wgRVMgY29udGV4dCBkcmF3 cyBkaXJlY3RseQotICAgIC8vIHRvIHRoZSB3aW5kb3cgYXNzb2NpYXRlZCB3aXRoIHRoZSBQYWdl LCBvdGhlcndpc2UgYW4gb2ZmLXNjcmVlbiBHTCBFUyBjb250ZXh0IGlzCi0gICAgLy8gY3JlYXRl ZC4KLSAgICBzdGF0aWMgUGFzc093blB0cjxHTEVTMkNvbnRleHQ+IGNyZWF0ZShQYWdlKik7Cisg ICAgLy8gQ3JlYXRlcyBhIEdMIEVTIGNvbnRleHQgdGhhdCBkcmF3cyBkaXJlY3RseSB0byB0aGUg d2luZG93IGFzc29jaWF0ZWQgd2l0aAorICAgIC8vIHRoZSBQYWdlLgorICAgIHN0YXRpYyBQYXNz T3duUHRyPEdMRVMyQ29udGV4dD4gY3JlYXRlT25zY3JlZW4oUGFnZSopOworCisgICAgLy8gQ3Jl YXRlcyBhIEdMIEVTIGNvbnRleHQgdGhhdCByZW5kZXJzIG9mZnNjcmVlbiwgb3B0aW9uYWxseSBh cyBhIGNoaWxkCisgICAgLy8gb2YgdGhlIGdpdmVuIHBhcmVudCBpZiBzcGVjaWZpZWQuCisgICAg c3RhdGljIFBhc3NPd25QdHI8R0xFUzJDb250ZXh0PiBjcmVhdGVPZmZzY3JlZW4oR0xFUzJDb250 ZXh0KiBwYXJlbnQpOworCiAgICAgfkdMRVMyQ29udGV4dCgpOwogCiAgICAgYm9vbCBtYWtlQ3Vy cmVudCgpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9M YXllclJlbmRlcmVyQ2hyb21pdW0uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCmluZGV4IDU5ZGE5YWUzMDZkZjRmMDVlNmFk MjlkZmNjZjBlMDI3MTJjYzY3MmMuLjlhYzUwNmMyYzQ2YmExMGY2OTQ1MTAzODk4Mzg1N2U3YmUw NmYzOGQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5 ZXJSZW5kZXJlckNocm9taXVtLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAKQEAgLTY0Nyw3ICs2NDcsNyBAQCBib29s IExheWVyUmVuZGVyZXJDaHJvbWl1bTo6bWFrZUNvbnRleHRDdXJyZW50KCkKIAogYm9vbCBMYXll clJlbmRlcmVyQ2hyb21pdW06OmluaXRHTCgpCiB7Ci0gICAgbV9nbGVzMkNvbnRleHQgPSBHTEVT MkNvbnRleHQ6OmNyZWF0ZShtX3BhZ2UpOworICAgIG1fZ2xlczJDb250ZXh0ID0gR0xFUzJDb250 ZXh0OjpjcmVhdGVPbnNjcmVlbihtX3BhZ2UpOwogCiAgICAgaWYgKCFtX2dsZXMyQ29udGV4dCkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggYTI2OWI1NzkwZTdmMDM0ZTY3 M2QxMzg3YTNiNjU4MGE1ZmIxZDg1MC4uY2VjMjNlMDc4YmY0MTUzZjFmNjEwOTViYjI5YzMwOGU5 NmFjZDE0OCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDctMDEgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4gYW5kIFZpbmNlbnQgU2NoZWliIDxzY2hp ZWJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdlYkNvcmU6OkdMRVMyQ29udGV4dCBzaG91bGQgYWxsb3cgY3JlYXRpbmcgb25z Y3JlZW4gYW5kIG9mZnNjcmVlbiBjb250ZXh0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE0OTIKKworICAgICAgICBZb3Ugc2hvdWxkIGJlIGFibGUg dG8gY3JlYXRlIGEgR0xFUzJDb250ZXh0IGZvciByZW5kZXJpbmcgYm90aCBvbiBzY3JlZW4KKyAg ICAgICAgYW5kIG9mZiBzY3JlZW4gKHRvIGEgdGV4dHVyZSkuICBDdXJyZW50bHkgV2ViR0wgZG9l cyB0aGUgbGF0dGVyIGJ5IHNpZGUKKyAgICAgICAgc3RlcHBpbmcgdGhlIFdlYkNvcmU6OkdMRVMy Q29udGV4dCBBUEkgY29tcGxldGVseS4gIExvbmdlciB0ZXJtIGl0IHNob3VsZAorICAgICAgICBt b3ZlIG92ZXIgdG8gdXNpbmcgdGhpcy4KKworICAgICAgICAqIHNyYy9HTEVTMkNvbnRleHQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R0xFUzJDb250ZXh0SW50ZXJuYWw6OmluaXRpYWxpemVPbnNj cmVlbik6CisgICAgICAgIChXZWJDb3JlOjpHTEVTMkNvbnRleHRJbnRlcm5hbDo6aW5pdGlhbGl6 ZU9mZnNjcmVlbik6CisgICAgICAgIChXZWJDb3JlOjpHTEVTMkNvbnRleHQ6OmNyZWF0ZU9uc2Ny ZWVuKToKKyAgICAgICAgKFdlYkNvcmU6OkdMRVMyQ29udGV4dDo6Y3JlYXRlT2Zmc2NyZWVuKToK KwogMjAxMC0wNy0wMSAgQWFyb24gQm9vZG1hbiAgPGFhQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0v c3JjL0dMRVMyQ29udGV4dC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0dMRVMyQ29udGV4dC5j cHAKaW5kZXggYjZkNjE5YzcwZGJhYTY0NDZhYTNjZTA0YjIzMGU3ZTY2M2RiZjhlZi4uMmI0NWE5 MThhM2YyZWFiZTk4MzQ4Y2EwMTVlZjRmMDQ0YzRmNWQ5NiAxMDA2NDQKLS0tIGEvV2ViS2l0L2No cm9taXVtL3NyYy9HTEVTMkNvbnRleHQuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvR0xF UzJDb250ZXh0LmNwcApAQCAtNTYsNyArNTYsOCBAQCBwdWJsaWM6CiAgICAgR0xFUzJDb250ZXh0 SW50ZXJuYWwoKSB7fQogICAgIH5HTEVTMkNvbnRleHRJbnRlcm5hbCgpIHt9CiAKLSAgICBib29s IGluaXRpYWxpemUoUGFnZSopOworICAgIGJvb2wgaW5pdGlhbGl6ZU9uc2NyZWVuKFBhZ2UqKTsK KyAgICBib29sIGluaXRpYWxpemVPZmZzY3JlZW4oR0xFUzJDb250ZXh0Kik7CiAKICAgICBXZWJH TEVTMkNvbnRleHQqIGdldFdlYkdMRVMyQ29udGV4dCgpIHsgcmV0dXJuIG1faW1wbDsgfQogCkBA IC02NCw3ICs2NSw3IEBAIHByaXZhdGU6CiAgICAgV2ViR0xFUzJDb250ZXh0KiBtX2ltcGw7CiB9 OwogCi1ib29sIEdMRVMyQ29udGV4dEludGVybmFsOjppbml0aWFsaXplKFBhZ2UqIHBhZ2UpCiti b29sIEdMRVMyQ29udGV4dEludGVybmFsOjppbml0aWFsaXplT25zY3JlZW4oUGFnZSogcGFnZSkK IHsKICAgICBBU1NFUlQocGFnZSk7CiAgICAgV2ViVmlld0ltcGwqIHdlYlZpZXcgPSBXZWJWaWV3 SW1wbDo6ZnJvbVBhZ2UocGFnZSk7CkBAIC03NSwxMCArNzYsMjIgQEAgYm9vbCBHTEVTMkNvbnRl eHRJbnRlcm5hbDo6aW5pdGlhbGl6ZShQYWdlKiBwYWdlKQogICAgIHJldHVybiB0cnVlOwogfQog Ci1QYXNzT3duUHRyPEdMRVMyQ29udGV4dD4gR0xFUzJDb250ZXh0OjpjcmVhdGUoUGFnZSogcGFn ZSkKK2Jvb2wgR0xFUzJDb250ZXh0SW50ZXJuYWw6OmluaXRpYWxpemVPZmZzY3JlZW4oR0xFUzJD b250ZXh0KiBwYXJlbnQpCit7CisgICAgbV9pbXBsID0gd2ViS2l0Q2xpZW50KCktPmNyZWF0ZUdM RVMyQ29udGV4dCgpOworICAgIGlmICghbV9pbXBsKQorICAgICAgICByZXR1cm4gZmFsc2U7Cisg ICAgaWYgKCFtX2ltcGwtPmluaXRpYWxpemUoMCwgcGFyZW50ID8gcGFyZW50LT5tX2ludGVybmFs LT5tX2ltcGwgOiAwKSkgeworICAgICAgICBkZWxldGUgbV9pbXBsOworICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgfQorICAgIHJldHVybiB0cnVlOworfQorCitQYXNzT3duUHRyPEdMRVMyQ29u dGV4dD4gR0xFUzJDb250ZXh0OjpjcmVhdGVPbnNjcmVlbihQYWdlKiBwYWdlKQogewogICAgIEdM RVMyQ29udGV4dEludGVybmFsKiBpbnRlcm5hbCA9IG5ldyBHTEVTMkNvbnRleHRJbnRlcm5hbCgp OwotICAgIGlmICghaW50ZXJuYWwtPmluaXRpYWxpemUocGFnZSkpIHsKKyAgICBpZiAoIWludGVy bmFsLT5pbml0aWFsaXplT25zY3JlZW4ocGFnZSkpIHsKICAgICAgICAgZGVsZXRlIGludGVybmFs OwogICAgICAgICByZXR1cm4gMDsKICAgICB9CkBAIC04Nyw2ICsxMDAsMTkgQEAgUGFzc093blB0 cjxHTEVTMkNvbnRleHQ+IEdMRVMyQ29udGV4dDo6Y3JlYXRlKFBhZ2UqIHBhZ2UpCiAgICAgcmV0 dXJuIHJlc3VsdDsKIH0KIAorUGFzc093blB0cjxHTEVTMkNvbnRleHQ+IEdMRVMyQ29udGV4dDo6 Y3JlYXRlT2Zmc2NyZWVuKEdMRVMyQ29udGV4dCogcGFyZW50KQoreworICAgIEdMRVMyQ29udGV4 dEludGVybmFsKiBpbnRlcm5hbCA9IG5ldyBHTEVTMkNvbnRleHRJbnRlcm5hbCgpOworICAgIGlm ICghaW50ZXJuYWwtPmluaXRpYWxpemVPZmZzY3JlZW4ocGFyZW50KSkgeworICAgICAgICBkZWxl dGUgaW50ZXJuYWw7CisgICAgICAgIHJldHVybiAwOworICAgIH0KKyAgICBQYXNzT3duUHRyPEdM RVMyQ29udGV4dD4gcmVzdWx0ID0gbmV3IEdMRVMyQ29udGV4dCgpOworICAgIHJlc3VsdC0+bV9p bnRlcm5hbC5zZXQoaW50ZXJuYWwpOworICAgIHJldHVybiByZXN1bHQ7Cit9CisKKwogR0xFUzJD b250ZXh0Ojp+R0xFUzJDb250ZXh0KCkKIHsKIH0K