41484 2010-07-01 14:15:55 -0700 [Qt] Clamp color stops passed to QGradient to 1.0 2010-07-26 06:55:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 35784 1 kling webkit-qt-unassigned commit-queue hausmann oldest_to_newest 245540 0 kling 2010-07-01 14:15:55 -0700 The conversion between HTML5 gradients and QRadialGradient values can overflow a tiny bit (1.00000002 anyone?) QGradient::addColorStop() will silently (release builds) ignore these color stops. 245541 1 60285 kling 2010-07-01 14:18:49 -0700 Created attachment 60285 Proposed patch 245542 2 kling 2010-07-01 14:20:16 -0700 Oops, that's QGradient::setColorAt(). addColorStop() is the CanvasGradient counterpart. 245546 3 60285 vestbo 2010-07-01 14:24:20 -0700 Comment on attachment 60285 Proposed patch qMin(lastStop, 1.0f) 245547 4 60287 kling 2010-07-01 14:24:47 -0700 Created attachment 60287 Proposed patch v2 *cough* Updated to use qMin() for less fugliness. 245549 5 60287 vestbo 2010-07-01 14:27:03 -0700 Comment on attachment 60287 Proposed patch v2 <3 245550 6 kling 2010-07-01 14:28:00 -0700 (In reply to comment #5) > <3 <3 245736 7 60287 commit-queue 2010-07-01 20:51:37 -0700 Comment on attachment 60287 Proposed patch v2 Clearing flags on attachment: 60287 Committed r62353: <http://trac.webkit.org/changeset/62353> 245737 8 commit-queue 2010-07-01 20:51:43 -0700 All reviewed patches have been landed. Closing bug. 256000 9 kling 2010-07-26 05:57:55 -0700 Adding as release blocker since it fixes display artifacts on some popular canvas demos. 256026 10 hausmann 2010-07-26 06:55:35 -0700 Revision r62353 cherry-picked into qtwebkit-2.0 with commit 6621e196cc9e867434eab580b02fe1dee1d9141e 60285 2010-07-01 14:18:49 -0700 2010-07-01 14:24:47 -0700 Proposed patch bug-41484.diff text/plain 1372 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDljZTcxMi4uOGJjY2ZjYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNy0wMSAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQ2xhbXAgY29sb3Igc3RvcHMgcGFzc2VkIHRvIFFH cmFkaWVudCB0byAxLjAKKyAgICAgICAgW2h0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MTQ4NAorCisgICAgICAgIEZpeGVzIGFuIGlzc3VlIHdoZXJlIGNvbG9yIHN0b3Bz IHdvdWxkIGJlIHNpbGVudGx5IGRyb3BwZWQgZnJvbSByYWRpYWwgZ3JhZGllbnRzLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhZGllbnRRdC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHcmFkaWVudDo6cGxhdGZvcm1HcmFkaWVudCk6CisKIDIwMTAtMDctMDEgIFNoZXJpZmYg Qm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHI2MjI0Ni4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvcXQvR3JhZGllbnRRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYWRp ZW50UXQuY3BwCmluZGV4IDE4MjAzZGQuLjdkYjdlZjAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvR3JhZGllbnRRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9HcmFkaWVudFF0LmNwcApAQCAtNjcsNyArNjcsNyBAQCBRR3JhZGllbnQqIEdy YWRpZW50OjpwbGF0Zm9ybUdyYWRpZW50KCkKICAgICAgICAgICAgIGxhc3RTdG9wID0gc3RvcEl0 ZXJhdG9yLT5zdG9wOwogICAgICAgICBpZiAobV9yYWRpYWwgJiYgbV9yMCkKICAgICAgICAgICAg IGxhc3RTdG9wID0gbV9yMCAvIG1fcjEgKyBsYXN0U3RvcCAqICgxLjBmIC0gbV9yMCAvIG1fcjEp OwotICAgICAgICBtX2dyYWRpZW50LT5zZXRDb2xvckF0KGxhc3RTdG9wLCBzdG9wQ29sb3IpOwor ICAgICAgICBtX2dyYWRpZW50LT5zZXRDb2xvckF0KGxhc3RTdG9wID49IDEuMGYgPyAxLjBmIDog bGFzdFN0b3AsIHN0b3BDb2xvcik7CiAgICAgICAgIC8vIEtlZXAgdGhlIGxhc3RTdG9wIGFzIG9y Z2luYWwgdmFsdWUsIHNpbmNlIHRoZSBmb2xsb3dpbmcgc3RvcENvbG9yIGRlcGVuZCBpdAogICAg ICAgICBsYXN0U3RvcCA9IHN0b3BJdGVyYXRvci0+c3RvcDsKICAgICAgICAgKytzdG9wSXRlcmF0 b3I7Cg== 60287 2010-07-01 14:24:47 -0700 2010-07-01 20:51:37 -0700 Proposed patch v2 bug-41484-v2.diff text/plain 1365 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDljZTcxMi4uOGJjY2ZjYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNy0wMSAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQ2xhbXAgY29sb3Igc3RvcHMgcGFzc2VkIHRvIFFH cmFkaWVudCB0byAxLjAKKyAgICAgICAgW2h0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00MTQ4NAorCisgICAgICAgIEZpeGVzIGFuIGlzc3VlIHdoZXJlIGNvbG9yIHN0b3Bz IHdvdWxkIGJlIHNpbGVudGx5IGRyb3BwZWQgZnJvbSByYWRpYWwgZ3JhZGllbnRzLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhZGllbnRRdC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHcmFkaWVudDo6cGxhdGZvcm1HcmFkaWVudCk6CisKIDIwMTAtMDctMDEgIFNoZXJpZmYg Qm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHI2MjI0Ni4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvcXQvR3JhZGllbnRRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYWRp ZW50UXQuY3BwCmluZGV4IDE4MjAzZGQuLjFmMDVhMTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvR3JhZGllbnRRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9HcmFkaWVudFF0LmNwcApAQCAtNjcsNyArNjcsNyBAQCBRR3JhZGllbnQqIEdy YWRpZW50OjpwbGF0Zm9ybUdyYWRpZW50KCkKICAgICAgICAgICAgIGxhc3RTdG9wID0gc3RvcEl0 ZXJhdG9yLT5zdG9wOwogICAgICAgICBpZiAobV9yYWRpYWwgJiYgbV9yMCkKICAgICAgICAgICAg IGxhc3RTdG9wID0gbV9yMCAvIG1fcjEgKyBsYXN0U3RvcCAqICgxLjBmIC0gbV9yMCAvIG1fcjEp OwotICAgICAgICBtX2dyYWRpZW50LT5zZXRDb2xvckF0KGxhc3RTdG9wLCBzdG9wQ29sb3IpOwor ICAgICAgICBtX2dyYWRpZW50LT5zZXRDb2xvckF0KHFNaW4obGFzdFN0b3AsIHFyZWFsKDEuMGYp KSwgc3RvcENvbG9yKTsKICAgICAgICAgLy8gS2VlcCB0aGUgbGFzdFN0b3AgYXMgb3JnaW5hbCB2 YWx1ZSwgc2luY2UgdGhlIGZvbGxvd2luZyBzdG9wQ29sb3IgZGVwZW5kIGl0CiAgICAgICAgIGxh c3RTdG9wID0gc3RvcEl0ZXJhdG9yLT5zdG9wOwogICAgICAgICArK3N0b3BJdGVyYXRvcjsK