41478 2010-07-01 12:10:49 -0700 canvas/philip/tests/2d.imageData.get.source.outside.html fails on the Mac bot 2024-05-27 20:47:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac All RESOLVED CONFIGURATION CHANGED HTML5, PlatformOnly P2 Normal --- 1 kling webkit-unassigned abarth ahmad.saleem792 commit-queue darin eric karlcow kkinnunen mdelaney7 sabouhallawa webkit.review.bot oldest_to_newest 245469 0 kling 2010-07-01 12:10:49 -0700 This test already works, thanks to the following code in getImageData: if (rect.x() < 0 || rect.y() < 0 || (rect.x() + rect.width()) > size.width() || (rect.y() + rect.height()) > size.height()) memset(data, 0, result->data()->length()); 245472 1 60269 kling 2010-07-01 12:13:26 -0700 Created attachment 60269 Proposed patch 245708 2 60269 commit-queue 2010-07-01 19:37:54 -0700 Comment on attachment 60269 Proposed patch Rejecting patch 60269 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: ing build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found Testing 19271 test cases. canvas/philip/tests/2d.imageData.get.source.outside.html -> failed Exiting early after 1 failures. 387 tests run. 17.69s total testing time 386 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://webkit-commit-queue.appspot.com/results/3398077 249873 3 kling 2010-07-12 09:07:56 -0700 (In reply to comment #2) > canvas/philip/tests/2d.imageData.get.source.outside.html -> failed Not sure what to do about this, the test passes when I run it on a Mac here. 250487 4 kling 2010-07-13 07:25:12 -0700 Committed r63202: <http://trac.webkit.org/changeset/63202> 250518 5 webkit.review.bot 2010-07-13 08:20:57 -0700 http://trac.webkit.org/changeset/63202 might have broken Leopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/63202 http://trac.webkit.org/changeset/63203 250523 6 kling 2010-07-13 08:30:34 -0700 Reopening since it fails reproducibly on the bot. 250525 7 kling 2010-07-13 08:32:51 -0700 Put it back on the mac skiplist: <http://trac.webkit.org/changeset/63209> 263020 8 60269 abarth 2010-08-10 22:38:23 -0700 Comment on attachment 60269 Proposed patch Looks like we'll need a new patch here. 2038133 9 ahmad.saleem792 2024-05-27 20:47:19 -0700 It is on WPT now and Safari / WebKit passes this: https://wpt.fyi/results/html/canvas?label=master&label=experimental&aligned&q=2d.imagedata.get.source.outside.html Marking this as 'Configuration Changed'. 60269 2010-07-01 12:13:26 -0700 2010-08-10 22:38:23 -0700 Proposed patch bug-41478.diff text/plain 2482 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwNjQ0YTE4Li5hNzA1MTY1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDct MDEgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbnNraXAgY2FudmFzL3BoaWxp cC90ZXN0cy8yZC5pbWFnZURhdGEuZ2V0LnNvdXJjZS5vdXRzaWRlLmh0bWwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNDc4CisKKyAgICAgICAgKiBj YW52YXMvcGhpbGlwL3Rlc3RzLzJkLmltYWdlRGF0YS5nZXQuc291cmNlLm91dHNpZGUtZXhwZWN0 ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL21hYy9Ta2lwcGVkOgorICAgICAgICAqIHBsYXRm b3JtL3F0L1NraXBwZWQ6CisKIDIwMTAtMDctMDEgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIENocm9taXVtIHRlc3Qg ZXhwZWN0YXRpb25zIGZvciBzdmcvVzNDLVNWRy0xLjEvZmlsdGVycy1jb252LTAxLWYuc3ZnCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmltYWdlRGF0YS5n ZXQuc291cmNlLm91dHNpZGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY2FudmFzL3BoaWxp cC90ZXN0cy8yZC5pbWFnZURhdGEuZ2V0LnNvdXJjZS5vdXRzaWRlLWV4cGVjdGVkLnR4dAppbmRl eCAwMGY5NjNlLi40YTk4MWE3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9jYW52YXMvcGhpbGlw L3Rlc3RzLzJkLmltYWdlRGF0YS5nZXQuc291cmNlLm91dHNpZGUtZXhwZWN0ZWQudHh0CisrKyBi L0xheW91dFRlc3RzL2NhbnZhcy9waGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdldC5zb3VyY2Uu b3V0c2lkZS1leHBlY3RlZC50eHQKQEAgLTQsOCArNCwzIEBAIGdldEltYWdlRGF0YSgpIHJldHVy bnMgdHJhbnNwYXJlbnQgYmxhY2sgb3V0c2lkZSB0aGUgY2FudmFzCiBSZWZlcmVuY2VzOiAyZC5p bWFnZURhdGEuZ2V0LmJhc2ljIDJkLmltYWdlRGF0YS5nZXQub3V0c2lkZQogQWN0dWFsIG91dHB1 dDoKIFBhc3NlZAotCi0KLQotCi0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKaW5kZXggNThmZDQ2 MS4uMDZiYzg3MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKQEAgLTIyMiw3ICsyMjIsNiBA QCBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC5vdXRzaWRlMS5odG1sCiBj YW52YXMvcGhpbGlwL3Rlc3RzLzJkLmltYWdlRGF0YS5jcmVhdGUxLnR5cGUuaHRtbAogY2FudmFz L3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEuY3JlYXRlMi50eXBlLmh0bWwKIGNhbnZhcy9waGls aXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdldC5zb3VyY2UubmVnYXRpdmUuaHRtbAotY2FudmFzL3Bo aWxpcC90ZXN0cy8yZC5pbWFnZURhdGEuZ2V0LnNvdXJjZS5vdXRzaWRlLmh0bWwKIGNhbnZhcy9w aGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdldC50eXBlLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVz dHMvMmQuaW1hZ2VEYXRhLm9iamVjdC5yb3VuZC5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJk LmltYWdlRGF0YS5vYmplY3Qud3JhcC5odG1sCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAppbmRleCA4 ZjdjZTZlLi5jNmMwZGJhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lw cGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKQEAgLTUyNjAsNyArNTI2 MCw2IEBAIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLnRvdWNoMy5odG1s CiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmltYWdlRGF0YS5jcmVhdGUxLnR5cGUuaHRtbAogY2Fu dmFzL3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEuY3JlYXRlMi50eXBlLmh0bWwKIGNhbnZhcy9w aGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdldC5zb3VyY2UubmVnYXRpdmUuaHRtbAotY2FudmFz L3BoaWxpcC90ZXN0cy8yZC5pbWFnZURhdGEuZ2V0LnNvdXJjZS5vdXRzaWRlLmh0bWwKIGNhbnZh cy9waGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmdldC50eXBlLmh0bWwKIGNhbnZhcy9waGlsaXAv dGVzdHMvMmQuaW1hZ2VEYXRhLm9iamVjdC5yb3VuZC5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3Rz LzJkLmltYWdlRGF0YS5vYmplY3Qud3JhcC5odG1sCg==