4147 2005-07-26 15:12:47 -0700 Array.toString() and toLocaleString() improvements from KDE KJS 2012-08-22 03:51:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ Other Linux RESOLVED FIXED P2 Normal --- 94688 1 porten ggaren oldest_to_newest 15212 0 porten 2005-07-26 15:12:47 -0700 I have problems reaching KDE's websvn server so I'm posting patches by linking to the CVS mail archive: The tests I added in http://lists.kde.org/?l=kde-commits&m=112241237705027&w=2 demonstrate a set of problems that the current JSC (and also KDE's previous) implementation of Array.toString() and toLocaleString() has. The patch I added http://lists.kde.org/?l=kde-commits&m=112241230116304&w=2 tries to implement the behavior as I understand it. Maybe there's more to it. Could well be that the code should be factored out. Would appreciate if possible changes to the patch would be fed back to KDE. Thanks. 15288 1 3123 ggaren 2005-07-27 16:52:41 -0700 Created attachment 3123 Patch Uploaded JSC patch. 15289 2 3124 ggaren 2005-07-27 16:53:28 -0700 Created attachment 3124 fast/js/toString-overrides.html Uploaded layout test. 3123 2005-07-27 16:52:41 -0700 2005-07-27 16:52:41 -0700 Patch patch.txt text/plain 2179 ggaren PyBhdHRyCj8gcGF0Y2gudHh0CkluZGV4OiBranMvYXJyYXlfb2JqZWN0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvSmF2YVNjcmlwdENvcmUva2pzL2FycmF5X29iamVjdC5jcHAs dgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDYKZGlmZiAtdSAtcjEuNDYgYXJyYXlfb2JqZWN0LmNw cAotLS0ga2pzL2FycmF5X29iamVjdC5jcHAJMjUgSnVsIDIwMDUgMjI6MTc6MTIgLTAwMDAJMS40 NgorKysga2pzL2FycmF5X29iamVjdC5jcHAJMjcgSnVsIDIwMDUgMjM6MzY6MDggLTAwMDAKQEAg LTQ4MiwxNSArNDgyLDQxIEBACiAgICAgICBpZiAoZWxlbWVudC50eXBlKCkgPT0gVW5kZWZpbmVk VHlwZSB8fCBlbGVtZW50LnR5cGUoKSA9PSBOdWxsVHlwZSkKICAgICAgICAgY29udGludWU7CiAK LSAgICAgIE9iamVjdCBvID0gZWxlbWVudC50b09iamVjdChleGVjKTsKLSAgICAgIE9iamVjdCBj b252ZXJzaW9uRnVuY3Rpb247CisgICAgICBib29sIGZhbGxiYWNrID0gZmFsc2U7CiAgICAgICBp ZiAoaWQgPT0gVG9Mb2NhbGVTdHJpbmcpIHsKLSAgICAgICAgY29udmVyc2lvbkZ1bmN0aW9uID0g T2JqZWN0OjpkeW5hbWljQ2FzdChvLmdldChleGVjLCB0b0xvY2FsZVN0cmluZ1Byb3BlcnR5TmFt ZSkpOwotICAgICAgfSBlbHNlIHsKLSAgICAgICAgY29udmVyc2lvbkZ1bmN0aW9uID0gT2JqZWN0 OjpkeW5hbWljQ2FzdChvLmdldChleGVjLCB0b1N0cmluZ1Byb3BlcnR5TmFtZSkpOworICAgICAg ICBPYmplY3QgbyA9IGVsZW1lbnQudG9PYmplY3QoZXhlYyk7CisgICAgICAgIE9iamVjdCBjb252 ZXJzaW9uRnVuY3Rpb24gPQorICAgICAgICAgIE9iamVjdDo6ZHluYW1pY0Nhc3Qoby5nZXQoZXhl YywgdG9Mb2NhbGVTdHJpbmdQcm9wZXJ0eU5hbWUpKTsKKyAgICAgICAgaWYgKGNvbnZlcnNpb25G dW5jdGlvbi5pc1ZhbGlkKCkgJiYKKyAgICAgICAgICAgIGNvbnZlcnNpb25GdW5jdGlvbi5pbXBs ZW1lbnRzQ2FsbCgpKSB7CisgICAgICAgICAgc3RyICs9IGNvbnZlcnNpb25GdW5jdGlvbi5jYWxs KGV4ZWMsIG8sIExpc3QoKSkudG9TdHJpbmcoZXhlYyk7CisgICAgICAgIH0gZWxzZSB7CisgICAg ICAgICAgLy8gdHJ5IHRvU3RyaW5nKCkgZmFsbGJhY2sKKyAgICAgICAgICBmYWxsYmFjayA9IHRy dWU7CisgICAgICAgIH0KICAgICAgIH0KLSAgICAgIHN0ciArPSBjb252ZXJzaW9uRnVuY3Rpb24u Y2FsbChleGVjLCBvLCBMaXN0KCkpLnRvU3RyaW5nKGV4ZWMpOwotICAgICAgCisKKyAgICAgIGlm IChpZCA9PSBUb1N0cmluZyB8fCBpZCA9PSBKb2luIHx8IGZhbGxiYWNrKSB7CisgICAgICAgIGlm IChlbGVtZW50LnR5cGUoKSA9PSBPYmplY3RUeXBlKSB7CisgICAgICAgICAgT2JqZWN0IG8gPSBP YmplY3Q6OmR5bmFtaWNDYXN0KGVsZW1lbnQpOworICAgICAgICAgIE9iamVjdCBjb252ZXJzaW9u RnVuY3Rpb24gPQorICAgICAgICAgICAgT2JqZWN0OjpkeW5hbWljQ2FzdChvLmdldChleGVjLCB0 b1N0cmluZ1Byb3BlcnR5TmFtZSkpOworICAgICAgICAgIGlmIChjb252ZXJzaW9uRnVuY3Rpb24u aXNWYWxpZCgpICYmCisgICAgICAgICAgICAgIGNvbnZlcnNpb25GdW5jdGlvbi5pbXBsZW1lbnRz Q2FsbCgpKSB7CisgICAgICAgICAgICBzdHIgKz0gY29udmVyc2lvbkZ1bmN0aW9uLmNhbGwoZXhl YywgbywgTGlzdCgpKS50b1N0cmluZyhleGVjKTsKKyAgICAgICAgICB9IGVsc2UgeworICAgICAg ICAgICAgVVN0cmluZyBtc2cgPSAiQ2FuJ3QgY29udmVydCAiICsgby5jbGFzc05hbWUoKSArCisg ICAgICAgICAgICAgICIgb2JqZWN0IHRvIHN0cmluZyI7CisgICAgICAgICAgICBPYmplY3QgZXJy b3IgPSBFcnJvcjo6Y3JlYXRlKGV4ZWMsIFJhbmdlRXJyb3IsCisgICAgICAgICAgICAgICAgbXNn LmNzdHJpbmcoKS5jX3N0cigpKTsKKyAgICAgICAgICAgIGV4ZWMtPnNldEV4Y2VwdGlvbihlcnJv cik7CisgICAgICAgICAgICByZXR1cm4gZXJyb3I7CisgICAgICAgICAgfQorICAgICAgICB9IGVs c2UgeworICAgICAgICAgIHN0ciArPSBlbGVtZW50LnRvU3RyaW5nKGV4ZWMpOworICAgICAgICB9 CisgICAgICB9CisKICAgICAgIGlmICggZXhlYy0+aGFkRXhjZXB0aW9uKCkgKQogICAgICAgICBi cmVhazsKICAgICB9Cg== 3124 2005-07-27 16:53:28 -0700 2005-07-27 16:53:28 -0700 fast/js/toString-overrides.html toString-overrides.html text/html 3122 ggaren PGh0bWw+CjxoZWFkPgo8c2NyaXB0PgpmdW5jdGlvbiBkZWJ1ZyhtZXNzYWdlKSB7CiAgICB2YXIg cGFyYWdyYXBoID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgicCIpOwogICAgcGFyYWdyYXBoLmFw cGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1lc3NhZ2UpKTsKICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIikuYXBwZW5kQ2hpbGQocGFyYWdyYXBoKTsKfQoKZnVu Y3Rpb24gdGVzdCgpIHsKICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKICAg ICAgICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogICAgfQoKICAg IC8vIFV0aWxpdHkgZnVuY3Rpb25zIGZvciBKUyB0ZXN0IHN1aXRlCiAgICAvLyAoYykgMjAwMSBI YXJyaSBQb3J0ZW4gPHBvcnRlbkBrZGUub3JnPgoKICAgIGZ1bmN0aW9uIHRlc3RQYXNzZWQobXNn KQogICAgewogICAgICAgIGRlYnVnKCJQQVNTLiAiICsgbXNnKTsKICAgIH0KCiAgICBmdW5jdGlv biB0ZXN0RmFpbGVkKG1zZykKICAgIHsKICAgICAgICBkZWJ1ZygiRkFJTC4gIiArIG1zZyk7CiAg ICB9CgogICAgZnVuY3Rpb24gc2hvdWxkQmUoX2EsIF9iKQogICAgewogICAgICAgIGlmICh0eXBl b2YgX2EgIT0gInN0cmluZyIgfHwgdHlwZW9mIF9iICE9ICJzdHJpbmciKQogICAgICAgICAgICBk ZWJ1ZygiV0FSTjogc2hvdWxkQmUoKSBleHBlY3RzIHN0cmluZyBhcmd1bWVudHMiKTsKICAgICAg ICB2YXIgX2F2ID0gZXZhbChfYSk7CiAgICAgICAgdmFyIF9idiA9IGV2YWwoX2IpOwoKICAgICAg ICBpZiAoX2F2ID09PSBfYnYpCiAgICAgICAgICAgIHRlc3RQYXNzZWQoX2EgKyAiIGlzICIgKyBf Yik7CiAgICAgICAgZWxzZQogICAgICAgICAgICB0ZXN0RmFpbGVkKF9hICsgIiBzaG91bGQgYmUg IiArIF9idiArICIuIFdhcyAiICsgX2F2KTsKICAgIH0KCiAgICBmdW5jdGlvbiBzaG91bGRCZVRy dWUoX2EpIHsgc2hvdWxkQmUoX2EsICJ0cnVlIik7IH0KCiAgICBmdW5jdGlvbiBzaG91bGRCZUZh bHNlKF9hKSB7IHNob3VsZEJlKF9hLCAiZmFsc2UiKTsgfQoKICAgIGZ1bmN0aW9uIHNob3VsZEJl VW5kZWZpbmVkKF9hKQogICAgewogICAgICAgIHZhciBfYXYgPSBldmFsKF9hKTsKICAgICAgICBp ZiAodHlwZW9mIF9hdiA9PSAidW5kZWZpbmVkIikKICAgICAgICAgICAgdGVzdFBhc3NlZChfYSAr ICIgaXMgdW5kZWZpbmVkLiIpOwogICAgICAgIGVsc2UKICAgICAgICAgICAgdGVzdEZhaWxlZChf YSArICIgc2hvdWxkIGJlIHVuZGVmaW5lZC4gV2FzICIgKyBfYXYpOwogICAgfQoKICAgIC8vIDE1 LjQgQXJyYXkgT2JqZWN0cwogICAgLy8gKGMpIDIwMDEgSGFycmkgUG9ydGVuIDxwb3J0ZW5Aa2Rl Lm9yZz4KCiAgICAvLyBiYWNrdXAKICAgIHZhciBiYWNrdXBOdW1iZXJUb1N0cmluZyA9IE51bWJl ci5wcm90b3R5cGUudG9TdHJpbmc7CiAgICB2YXIgYmFja3VwTnVtYmVyVG9Mb2NhbGVTdHJpbmcg PSBOdW1iZXIucHJvdG90eXBlLnRvTG9jYWxlU3RyaW5nOwogICAgdmFyIGJhY2t1cFJlZ0V4cFRv U3RyaW5nID0gUmVnRXhwLnByb3RvdHlwZS50b1N0cmluZzsKICAgIHZhciBiYWNrdXBSZWdFeHBU b0xvY2FsZVN0cmluZyA9IFJlZ0V4cC5wcm90b3R5cGUudG9Mb2NhbGVTdHJpbmc7CgogICAgLy8g Y2hhbmdlIGZ1bmN0aW9ucwogICAgTnVtYmVyLnByb3RvdHlwZS50b1N0cmluZyA9IGZ1bmN0aW9u KCkgeyByZXR1cm4gInRvU3RyaW5nIjsgfQogICAgTnVtYmVyLnByb3RvdHlwZS50b0xvY2FsZVN0 cmluZyA9IGZ1bmN0aW9uKCkgeyByZXR1cm4gInRvTG9jYWxlU3RyaW5nIjsgfQogICAgUmVnRXhw LnByb3RvdHlwZS50b1N0cmluZyA9IGZ1bmN0aW9uKCkgeyByZXR1cm4gInRvU3RyaW5nMiI7IH0K ICAgIFJlZ0V4cC5wcm90b3R5cGUudG9Mb2NhbGVTdHJpbmcgPSBmdW5jdGlvbigpIHsgcmV0dXJu ICJ0b0xvY2FsZVN0cmluZzIiOyB9CgogICAgLy8gdGhlIHRlc3RzCiAgICBzaG91bGRCZSgiWzFd LnRvU3RyaW5nKCkiLCAiJzEnIik7CiAgICBzaG91bGRCZSgiWzFdLnRvTG9jYWxlU3RyaW5nKCki LCAiJ3RvTG9jYWxlU3RyaW5nJyIpOwogICAgTnVtYmVyLnByb3RvdHlwZS50b0xvY2FsZVN0cmlu ZyA9ICJpbnZhbGlkIjsKICAgIHNob3VsZEJlKCJbMV0udG9Mb2NhbGVTdHJpbmcoKSIsICInMSci KTsKICAgIHNob3VsZEJlKCJbL3IvXS50b1N0cmluZygpIiwgIid0b1N0cmluZzInIik7CiAgICBz aG91bGRCZSgiWy9yL10udG9Mb2NhbGVTdHJpbmcoKSIsICIndG9Mb2NhbGVTdHJpbmcyJyIpOwog ICAgUmVnRXhwLnByb3RvdHlwZS50b0xvY2FsZVN0cmluZyA9ICJpbnZhbGlkIjsKICAgIHNob3Vs ZEJlKCJbL3IvXS50b0xvY2FsZVN0cmluZygpIiwgIid0b1N0cmluZzInIik7CgogICAgdmFyIGNh dWdodCA9IGZhbHNlOwogICAgdHJ5IHsKICAgICAgICBbeyB0b1N0cmluZyA6IDAgfV0udG9TdHJp bmcoKTsKICAgIH0gY2F0Y2ggKGUpIHsKICAgICAgICBjYXVnaHQgPSB0cnVlOwogICAgfQogICAg c2hvdWxkQmVUcnVlKCJjYXVnaHQiKTsKCiAgICAvLyByZXN0b3JlCiAgICBOdW1iZXIucHJvdG90 eXBlLnRvU3RyaW5nID0gYmFja3VwTnVtYmVyVG9TdHJpbmc7CiAgICBOdW1iZXIucHJvdG90eXBl LnRvTG9jYWxlU3RyaW5nID0gYmFja3VwTnVtYmVyVG9Mb2NhbGVTdHJpbmc7CiAgICBSZWdFeHAu cHJvdG90eXBlLnRvU3RyaW5nID0gYmFja3VwUmVnRXhwVG9TdHJpbmc7CiAgICBSZWdFeHAucHJv dG90eXBlLnRvTG9jYWxlU3RyaW5nID0gYmFja3VwUmVnRXhwVG9Mb2NhbGVTdHJpbmc7Cn0KPC9z Y3JpcHQ+CjwvaGVhZD4KPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgo8cD5UaGlzIHRlc3QgY2hlY2tz IGZvciByZWdyZXNzaW9uIGFnYWluc3QgPGEgaHJlZj0iaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3 aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD00MTQ3Ij40MTQ3OiBBcnJheS50b1N0cmluZygpIGFuZCB0 b0xvY2FsZVN0cmluZygpIGltcHJvdmVtZW50cyBmcm9tIEtERSBLSlMuPC9hPjwvcD4KPHA+T24g c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcy48L3A+Cjxo cj4KPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CjwvYm9keT4KPC9odG1sPgo=