41451 2010-07-01 03:11:56 -0700 [Qt] Crash when destroying a QWebView with a QComboBox as its child. 2010-07-01 12:52:30 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All CLOSED FIXED Qt, QtTriaged P1 Critical --- 35784 1 jturcotte webkit-unassigned commit-queue hausmann oldest_to_newest 245237 0 jturcotte 2010-07-01 03:11:56 -0700 To reproduce: - Open a page with combo boxes and click one of them (like http://www.google.com/advanced_search ) - Get the QWebView destroyed (either by closing the tab in Arora or by switching to graphics web view in QtTestBrowser) - Wander around browsing waiting for the cache to get cleaned (might take something between 1 and 5 minutes) What happens is that when we show the combo box popup, we set the QWebView as the QComboBox parent. If the QComboBox gets destroyed because of its parent getting destroyed, the reference in the render tree become dangling. 245245 1 60220 jturcotte 2010-07-01 03:49:50 -0700 Created attachment 60220 Patch 245265 2 60220 commit-queue 2010-07-01 05:17:24 -0700 Comment on attachment 60220 Patch Clearing flags on attachment: 60220 Committed r62251: <http://trac.webkit.org/changeset/62251> 245266 3 commit-queue 2010-07-01 05:17:29 -0700 All reviewed patches have been landed. Closing bug. 245498 4 hausmann 2010-07-01 12:52:20 -0700 Revision r62251 cherry-picked into qtwebkit-2.0 with commit ed5e839ffbd751c0a39de712f0b37c91e6e5dcc7 60220 2010-07-01 03:49:50 -0700 2010-07-01 05:17:24 -0700 Patch combopopup_onthefly.patch text/plain 5324 jturcotte ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDg1OWE5MTUuLmM0MDMyZTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEwLTA3LTAxICBKb2Nl bHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBDcmVhdGUgUUNvbWJvQm94 ZXMgd2hlbiBjbGlja2VkIGFuZCBkZXN0cm95IG9uIGhpZGUuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTQ1MQorCisgICAgICAgIEN1cnJlbnRseSBh IFFDb21ib0JveCBpcyBjcmVhdGVkIGZvciBlYWNoIFJlbmRlck1lbnVMaXN0IGFuZAorICAgICAg ICBpdCBnZXRzIGRlc3Ryb3llZCBlaXRoZXIgd2hlbiB0aGUgUmVuZGVyTWVudUxpc3Qgb3IgdGhl CisgICAgICAgIFFXZWJWaWV3IChpdHMgUXQgcGFyZW50KSBpcyBkZXN0cm95ZWQuIFRoaXMgY2F1 c2UgYSBjcmFzaAorICAgICAgICB3aGVuIHRoZSBRV2ViVmlldyBpcyBkZXN0cm95ZWQgYmVmb3Jl IHRoZSByZW5kZXIgdHJlZSAod2hpY2gKKyAgICAgICAgaXMga2VwdCBpbiBjYWNoZSkuCisKKyAg ICAgICAgVGhpcyBwYXRjaCBhaW0gdG8gZGVzdHJveSB0aGUgUUNvbWJvQm94IGFzIHNvb24gYXMg aXRzIHBvcHVwCisgICAgICAgIGdldHMgaGlkZGVuLCBhbmQgbGlrZXdpc2UsIGNyZWF0ZSBpdCBv bmx5IHdoZW4gdGhlIHBvcHVwIGlzCisgICAgICAgIHJlcXVlc3RlZCB0byBiZSBzaG93bi4KKyAg ICAgICAgSXQgYWxzbyByZW1vdmVzIHRoZSB1bm5lZWRlZCByZWZlcmVuY2UgdG8gdGhlIFFHcmFw aGljc1Byb3h5V2lkZ2V0LAorICAgICAgICBkZXN0cm95aW5nIHRoZSBRQ29tYm9Cb3ggYXV0b21h dGljYWxseSBkZXN0cm95cyBpdHMgYm91bmQKKyAgICAgICAgcHJveHl3aWRnZXQuCisKKyAgICAg ICAgKiBXZWJDb3JlU3VwcG9ydC9RdEZhbGxiYWNrV2ViUG9wdXAuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UXRGYWxsYmFja1dlYlBvcHVwQ29tYm86OmhpZGVQb3B1cCk6CisgICAgICAgIChXZWJD b3JlOjpRdEZhbGxiYWNrV2ViUG9wdXA6OlF0RmFsbGJhY2tXZWJQb3B1cCk6CisgICAgICAgIChX ZWJDb3JlOjpRdEZhbGxiYWNrV2ViUG9wdXA6On5RdEZhbGxiYWNrV2ViUG9wdXApOgorICAgICAg ICAoV2ViQ29yZTo6UXRGYWxsYmFja1dlYlBvcHVwOjpzaG93KToKKyAgICAgICAgKFdlYkNvcmU6 OlF0RmFsbGJhY2tXZWJQb3B1cDo6aGlkZSk6CisgICAgICAgIChXZWJDb3JlOjpRdEZhbGxiYWNr V2ViUG9wdXA6OmRlc3Ryb3lQb3B1cCk6CisgICAgICAgIChXZWJDb3JlOjpRdEZhbGxiYWNrV2Vi UG9wdXA6OnBvcHVsYXRlKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9RdEZhbGxiYWNrV2Vi UG9wdXAuaDoKKwogMjAxMC0wNi0zMCAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290 dGVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0 aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1F0RmFsbGJhY2tX ZWJQb3B1cC5jcHAgYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUXRGYWxsYmFja1dlYlBvcHVw LmNwcAppbmRleCAxYTg3NDYzLi41OWFjODdiIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29y ZVN1cHBvcnQvUXRGYWxsYmFja1dlYlBvcHVwLmNwcAorKysgYi9XZWJLaXQvcXQvV2ViQ29yZVN1 cHBvcnQvUXRGYWxsYmFja1dlYlBvcHVwLmNwcApAQCAtNzUsMTQgKzc1LDEyIEBAIHZvaWQgUXRG YWxsYmFja1dlYlBvcHVwQ29tYm86OmhpZGVQb3B1cCgpCiAKICAgICBRQ29tYm9Cb3g6OmhpZGVQ b3B1cCgpOwogCi0gICAgaWYgKFFHcmFwaGljc1Byb3h5V2lkZ2V0KiBwcm94eSA9IGdyYXBoaWNz UHJveHlXaWRnZXQoKSkKLSAgICAgICAgcHJveHktPnNldFZpc2libGUoZmFsc2UpOwotCiAgICAg aWYgKCFtX293bmVyUG9wdXAubV9wb3B1cFZpc2libGUpCiAgICAgICAgIHJldHVybjsKIAogICAg IG1fb3duZXJQb3B1cC5tX3BvcHVwVmlzaWJsZSA9IGZhbHNlOwogICAgIG1fb3duZXJQb3B1cC5w b3B1cERpZEhpZGUoKTsKKyAgICBtX293bmVyUG9wdXAuZGVzdHJveVBvcHVwKCk7CiB9CiAKIGJv b2wgUXRGYWxsYmFja1dlYlBvcHVwQ29tYm86OmV2ZW50RmlsdGVyKFFPYmplY3QqIHdhdGNoZWQs IFFFdmVudCogZXZlbnQpCkBAIC0xMDIsMTkgKzEwMCwxMyBAQCBib29sIFF0RmFsbGJhY2tXZWJQ b3B1cENvbWJvOjpldmVudEZpbHRlcihRT2JqZWN0KiB3YXRjaGVkLCBRRXZlbnQqIGV2ZW50KQog UXRGYWxsYmFja1dlYlBvcHVwOjpRdEZhbGxiYWNrV2ViUG9wdXAoKQogICAgIDogUXRBYnN0cmFj dFdlYlBvcHVwKCkKICAgICAsIG1fcG9wdXBWaXNpYmxlKGZhbHNlKQotICAgICwgbV9jb21ibyhu ZXcgUXRGYWxsYmFja1dlYlBvcHVwQ29tYm8oKnRoaXMpKQotICAgICwgbV9wcm94eSgwKQorICAg ICwgbV9jb21ibygwKQogewotICAgIGNvbm5lY3QobV9jb21ibywgU0lHTkFMKGFjdGl2YXRlZChp bnQpKSwKLSAgICAgICAgICAgIFNMT1QoYWN0aXZlQ2hhbmdlZChpbnQpKSwgUXQ6OlF1ZXVlZENv bm5lY3Rpb24pOwogfQogCiBRdEZhbGxiYWNrV2ViUG9wdXA6On5RdEZhbGxiYWNrV2ViUG9wdXAo KQogewotICAgIC8vIElmIHdlIGNyZWF0ZSBhIHByb3h5LCB0aGVuIHRoZSBkZWxldGlvbiBvZiB0 aGUgcHJveHkgYW5kIHRoZQotICAgIC8vIGNvbWJvIHdpbGwgYmUgZG9uZSBieSB0aGUgcHJveHkn cyBwYXJlbnQgKFFHcmFwaGljc1dlYlZpZXcpCi0gICAgaWYgKCFtX3Byb3h5ICYmIG1fY29tYm8p Ci0gICAgICAgIG1fY29tYm8tPmRlbGV0ZUxhdGVyKCk7CisgICAgZGVzdHJveVBvcHVwKCk7CiB9 CiAKIHZvaWQgUXRGYWxsYmFja1dlYlBvcHVwOjpzaG93KCkKQEAgLTEyNSwxNyArMTE3LDIwIEBA IHZvaWQgUXRGYWxsYmFja1dlYlBvcHVwOjpzaG93KCkKICNpZiBFTkFCTEUoU1lNQklBTl9ESUFM T0dfUFJPVklERVJTKQogICAgIFRSQVBfSUdOT1JFKHNob3dTNjBCcm93c2VyRGlhbG9nKCkpOwog I2Vsc2UKKworICAgIGRlc3Ryb3lQb3B1cCgpOworICAgIG1fY29tYm8gPSBuZXcgUXRGYWxsYmFj a1dlYlBvcHVwQ29tYm8oKnRoaXMpOworICAgIGNvbm5lY3QobV9jb21ibywgU0lHTkFMKGFjdGl2 YXRlZChpbnQpKSwKKyAgICAgICAgICAgIFNMT1QoYWN0aXZlQ2hhbmdlZChpbnQpKSwgUXQ6OlF1 ZXVlZENvbm5lY3Rpb24pOworCiAgICAgcG9wdWxhdGUoKTsKICAgICBtX2NvbWJvLT5zZXRDdXJy ZW50SW5kZXgoY3VycmVudEluZGV4KCkpOwogCiAgICAgUVJlY3QgcmVjdCA9IGdlb21ldHJ5KCk7 CiAgICAgaWYgKFFHcmFwaGljc1dlYlZpZXcgKndlYlZpZXcgPSBxb2JqZWN0X2Nhc3Q8UUdyYXBo aWNzV2ViVmlldyo+KHBhZ2VDbGllbnQoKS0+cGx1Z2luUGFyZW50KCkpKSB7Ci0gICAgICAgIGlm ICghbV9wcm94eSkgewotICAgICAgICAgICAgbV9wcm94eSA9IG5ldyBRR3JhcGhpY3NQcm94eVdp ZGdldCh3ZWJWaWV3KTsKLSAgICAgICAgICAgIG1fcHJveHktPnNldFdpZGdldChtX2NvbWJvKTsK LSAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICBtX3Byb3h5LT5zZXRWaXNpYmxlKHRydWUpOwot ICAgICAgICBtX3Byb3h5LT5zZXRHZW9tZXRyeShyZWN0KTsKKyAgICAgICAgUUdyYXBoaWNzUHJv eHlXaWRnZXQqIHByb3h5ID0gbmV3IFFHcmFwaGljc1Byb3h5V2lkZ2V0KHdlYlZpZXcpOworICAg ICAgICBwcm94eS0+c2V0V2lkZ2V0KG1fY29tYm8pOworICAgICAgICBwcm94eS0+c2V0R2VvbWV0 cnkocmVjdCk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgbV9jb21iby0+c2V0UGFyZW50KHBhZ2VD bGllbnQoKS0+b3duZXJXaWRnZXQoKSk7CiAgICAgICAgIG1fY29tYm8tPnNldEdlb21ldHJ5KFFS ZWN0KHJlY3QubGVmdCgpLCByZWN0LnRvcCgpLApAQCAtMjA0LDEzICsxOTksMjEgQEAgdm9pZCBR dEZhbGxiYWNrV2ViUG9wdXA6OnNob3dTNjBCcm93c2VyRGlhbG9nKCkKIAogdm9pZCBRdEZhbGxi YWNrV2ViUG9wdXA6OmhpZGUoKQogewotICAgIG1fY29tYm8tPmhpZGVQb3B1cCgpOworICAgIC8v IERlc3Ryb3lpbmcgdGhlIFFDb21ib0JveCBoZXJlIGNhdXNlIHByb2JsZW1zIGlmIHRoZSBwb3B1 cCBpcyBpbiB0aGUKKyAgICAvLyBtaWRkbGUgb2YgaXRzIHNob3cgYW5pbWF0aW9uLiBJbnN0ZWFk IHdlIHJlbHkgb24gdGhlIGZhY3QgdGhhdCB0aGUKKyAgICAvLyBRdDo6UG9wdXAgd2luZG93IHdp bGwgaGlkZSBpdHNlbGYgb24gbW91c2UgZXZlbnRzIG91dHNpZGUgaXRzIHdpbmRvdy4KK30KKwor dm9pZCBRdEZhbGxiYWNrV2ViUG9wdXA6OmRlc3Ryb3lQb3B1cCgpCit7CisgICAgaWYgKG1fY29t Ym8pIHsKKyAgICAgICAgbV9jb21iby0+ZGVsZXRlTGF0ZXIoKTsKKyAgICAgICAgbV9jb21ibyA9 IDA7CisgICAgfQogfQogCiB2b2lkIFF0RmFsbGJhY2tXZWJQb3B1cDo6cG9wdWxhdGUoKQogewot ICAgIG1fY29tYm8tPmNsZWFyKCk7Ci0KICAgICBRU3RhbmRhcmRJdGVtTW9kZWwqIG1vZGVsID0g cW9iamVjdF9jYXN0PFFTdGFuZGFyZEl0ZW1Nb2RlbCo+KG1fY29tYm8tPm1vZGVsKCkpOwogICAg IFFfQVNTRVJUKG1vZGVsKTsKIApkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0 L1F0RmFsbGJhY2tXZWJQb3B1cC5oIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1F0RmFsbGJh Y2tXZWJQb3B1cC5oCmluZGV4IDg2MGU5ZmEuLmU2YzM3MWYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9x dC9XZWJDb3JlU3VwcG9ydC9RdEZhbGxiYWNrV2ViUG9wdXAuaAorKysgYi9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvUXRGYWxsYmFja1dlYlBvcHVwLmgKQEAgLTQyLDYgKzQyLDggQEAgcHVibGlj OgogICAgIHZpcnR1YWwgdm9pZCBzaG93KCk7CiAgICAgdmlydHVhbCB2b2lkIGhpZGUoKTsKIAor ICAgIHZvaWQgZGVzdHJveVBvcHVwKCk7CisKIHByaXZhdGUgc2xvdHM6CiAgICAgdm9pZCBhY3Rp dmVDaGFuZ2VkKGludCk7CiAKQEAgLTQ5LDcgKzUxLDYgQEAgcHJpdmF0ZToKICAgICBmcmllbmQg Y2xhc3MgUXRGYWxsYmFja1dlYlBvcHVwQ29tYm87CiAgICAgYm9vbCBtX3BvcHVwVmlzaWJsZTsK ICAgICBRdEZhbGxiYWNrV2ViUG9wdXBDb21ibyogbV9jb21ibzsKLSAgICBRR3JhcGhpY3NQcm94 eVdpZGdldCogbV9wcm94eTsKIAogICAgIHZvaWQgcG9wdWxhdGUoKTsKICNpZiBFTkFCTEUoU1lN QklBTl9ESUFMT0dfUFJPVklERVJTKQo=