41450 2010-07-01 02:34:36 -0700 RenderSVGContainer/RenderSVGRoot report wrong strokeBoundingBox() 2010-07-01 02:47:12 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zimmermann zimmermann oldest_to_newest 245221 0 zimmermann 2010-07-01 02:34:36 -0700 RenderSVGContainer/RenderSVGRoot::strokeBoundingBox() actually dump their childrens repaintRectInLocalCoordinates(). This is only visible when inspecting such nodes with our WebInspector - the highlighted rects are too small, eg. in LayoutTests/svg/filters/filter-clip.svg 245223 1 60217 zimmermann 2010-07-01 02:38:23 -0700 Created attachment 60217 Initial patch 245226 2 60217 krit 2010-07-01 02:43:00 -0700 Comment on attachment 60217 Initial patch r=me. Fix the typo acftual, mentioned on IRC and upload it :-) 245228 3 zimmermann 2010-07-01 02:47:12 -0700 Landed in r62244. 60217 2010-07-01 02:38:23 -0700 2010-07-01 02:43:00 -0700 Initial patch FixStrokeBbox.diff text/plain 7497 zimmermann SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MjI0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjkgQEAKKzIwMTAtMDctMDEgIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJt YW5uQHJpbS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVuZGVyU1ZHQ29udGFpbmVyL1JlbmRlclNWR1Jvb3QgcmVwb3J0IHdyb25nIHN0cm9r ZUJvdW5kaW5nQm94KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQxNDUwCisKKyAgICAgICAgc3Ryb2tlQm91bmRpbmdCb3goKSB3YXMgcmVwb3J0aW5n IHRoZSByZXBhaW50UmVjdEluTG9jYWxDb29yZGluYXRlcygpIGZvciBjaGlsZHJlbiBvZiBhIGNv bnRhaW5lciwKKyAgICAgICAgaW5zdGVhZCBvZiB0aGUgYWNmdHVhbCBzdHJva2VCb3VuZGluZ0Jv eCgpLiBPbmx5IHZpc2libGUgaW4gV2ViSW5zcGVjdG9yIHdoZW4gbG9va2luZyBhdCBhIGNvbnRh aW5lcgorICAgICAgICB3aGljaCBoYXMgYSByZXNvdXJjZSBhcHBsaWVkLCBhbmQgY29udGFpbnMg YSBjaGlsZHJlbiB3aGljaCBhbHNvIGhhcyBhIHJlc291cmNlIGFwcGxpZWQuCisKKyAgICAgICAg RG9lc24ndCBhZmZlY3QgYW55IHRlc3QgcmVzdWx0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJTVkdDb250YWluZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHQ29udGFp bmVyOjpvYmplY3RCb3VuZGluZ0JveCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdDb250 YWluZXI6OnN0cm9rZUJvdW5kaW5nQm94KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR0Nv bnRhaW5lcjo6cmVwYWludFJlY3RJbkxvY2FsQ29vcmRpbmF0ZXMpOgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJTVkdSb290LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR1Jvb3Q6 Om9iamVjdEJvdW5kaW5nQm94KTogRGVpbmxpbmVkIHRoaXMgZnVuY3Rpb25zLCBpdCdzIHZpcnR1 YWwgc28gdGhlcmUncyBubyBnYWluLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHUm9vdDo6 c3Ryb2tlQm91bmRpbmdCb3gpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR1Jv b3Q6OnJlcGFpbnRSZWN0SW5Mb2NhbENvb3JkaW5hdGVzKToKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyU1ZHUm9vdC5oOgorICAgICAgICAqIHJlbmRlcmluZy9TVkdSZW5kZXJTdXBwb3J0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1JlbmRlclN1cHBvcnQ6OmNvbXB1dGVDb250YWluZXJC b3VuZGluZ0JveCk6CisgICAgICAgICogcmVuZGVyaW5nL1NWR1JlbmRlclN1cHBvcnQuaDogQWRk IGVudW0gY29udHJvbGxpbmcgdGhlIG1vZGUgb2YgY29udGFpbmVyIGJvdW5kaW5nIGJveCBtb2Rl IGNhbGN1bGF0aW9uLgorCiAyMDEwLTA3LTAxICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJTVkdDb250YWluZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclNWR0NvbnRhaW5lci5jcHAJKHJldmlzaW9uIDYyMjM4KQorKysgV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyU1ZHQ29udGFpbmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTMw LDE3ICsxMzAsMTcgQEAgdm9pZCBSZW5kZXJTVkdDb250YWluZXI6OmFkZEZvY3VzUmluZ1JlYwog CiBGbG9hdFJlY3QgUmVuZGVyU1ZHQ29udGFpbmVyOjpvYmplY3RCb3VuZGluZ0JveCgpIGNvbnN0 CiB7Ci0gICAgcmV0dXJuIFNWR1JlbmRlclN1cHBvcnQ6OmNvbXB1dGVDb250YWluZXJCb3VuZGlu Z0JveCh0aGlzLCBmYWxzZSk7CisgICAgcmV0dXJuIFNWR1JlbmRlclN1cHBvcnQ6OmNvbXB1dGVD b250YWluZXJCb3VuZGluZ0JveCh0aGlzLCBTVkdSZW5kZXJTdXBwb3J0OjpPYmplY3RCb3VuZGlu Z0JveCk7CiB9CiAKIEZsb2F0UmVjdCBSZW5kZXJTVkdDb250YWluZXI6OnN0cm9rZUJvdW5kaW5n Qm94KCkgY29uc3QKIHsKLSAgICByZXR1cm4gU1ZHUmVuZGVyU3VwcG9ydDo6Y29tcHV0ZUNvbnRh aW5lckJvdW5kaW5nQm94KHRoaXMsIHRydWUpOworICAgIHJldHVybiBTVkdSZW5kZXJTdXBwb3J0 Ojpjb21wdXRlQ29udGFpbmVyQm91bmRpbmdCb3godGhpcywgU1ZHUmVuZGVyU3VwcG9ydDo6U3Ry b2tlQm91bmRpbmdCb3gpOwogfQogCiBGbG9hdFJlY3QgUmVuZGVyU1ZHQ29udGFpbmVyOjpyZXBh aW50UmVjdEluTG9jYWxDb29yZGluYXRlcygpIGNvbnN0CiB7Ci0gICAgRmxvYXRSZWN0IHJlcGFp bnRSZWN0ID0gc3Ryb2tlQm91bmRpbmdCb3goKTsKKyAgICBGbG9hdFJlY3QgcmVwYWludFJlY3Qg PSBTVkdSZW5kZXJTdXBwb3J0Ojpjb21wdXRlQ29udGFpbmVyQm91bmRpbmdCb3godGhpcywgU1ZH UmVuZGVyU3VwcG9ydDo6UmVwYWludEJvdW5kaW5nQm94KTsKICAgICBTVkdSZW5kZXJTdXBwb3J0 OjppbnRlcnNlY3RSZXBhaW50UmVjdFdpdGhSZXNvdXJjZXModGhpcywgcmVwYWludFJlY3QpOwog ICAgIHJldHVybiByZXBhaW50UmVjdDsKIH0KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clNWR1Jvb3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR1Jv b3QuY3BwCShyZXZpc2lvbiA2MjIzOCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR1Jv b3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTUsMTAgKzI1NSwyMCBAQCBjb25zdCBBZmZpbmVU cmFuc2Zvcm0mIFJlbmRlclNWR1Jvb3Q6OmxvCiAgICAgcmV0dXJuIG1fbG9jYWxUb1BhcmVudFRy YW5zZm9ybTsKIH0KIAorRmxvYXRSZWN0IFJlbmRlclNWR1Jvb3Q6Om9iamVjdEJvdW5kaW5nQm94 KCkgY29uc3QKK3sKKyAgICByZXR1cm4gU1ZHUmVuZGVyU3VwcG9ydDo6Y29tcHV0ZUNvbnRhaW5l ckJvdW5kaW5nQm94KHRoaXMsIFNWR1JlbmRlclN1cHBvcnQ6Ok9iamVjdEJvdW5kaW5nQm94KTsK K30KKworRmxvYXRSZWN0IFJlbmRlclNWR1Jvb3Q6OnN0cm9rZUJvdW5kaW5nQm94KCkgY29uc3QK K3sKKyAgICByZXR1cm4gU1ZHUmVuZGVyU3VwcG9ydDo6Y29tcHV0ZUNvbnRhaW5lckJvdW5kaW5n Qm94KHRoaXMsIFNWR1JlbmRlclN1cHBvcnQ6OlN0cm9rZUJvdW5kaW5nQm94KTsKK30KKwogRmxv YXRSZWN0IFJlbmRlclNWR1Jvb3Q6OnJlcGFpbnRSZWN0SW5Mb2NhbENvb3JkaW5hdGVzKCkgY29u c3QKIHsKICAgICAvLyBGSVhNRTogVGhpcyBkb2VzIG5vdCBpbmNsdWRlIHRoZSBib3JkZXIgYnV0 IGl0IHNob3VsZCEKLSAgICBGbG9hdFJlY3QgcmVwYWludFJlY3QgPSBzdHJva2VCb3VuZGluZ0Jv eCgpOworICAgIEZsb2F0UmVjdCByZXBhaW50UmVjdCA9IFNWR1JlbmRlclN1cHBvcnQ6OmNvbXB1 dGVDb250YWluZXJCb3VuZGluZ0JveCh0aGlzLCBTVkdSZW5kZXJTdXBwb3J0OjpSZXBhaW50Qm91 bmRpbmdCb3gpOwogICAgIHN0eWxlKCktPnN2Z1N0eWxlKCktPmluZmxhdGVGb3JTaGFkb3cocmVw YWludFJlY3QpOwogICAgIHJldHVybiByZXBhaW50UmVjdDsKIH0KSW5kZXg6IFdlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclNWR1Jvb3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJTVkdSb290LmgJKHJldmlzaW9uIDYyMTcxKQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyU1ZHUm9vdC5oCSh3b3JraW5nIGNvcHkpCkBAIC02Miw4ICs2Miw4IEBAIHByaXZhdGU6CiAg ICAgYm9vbCBmaWxsQ29udGFpbnMoY29uc3QgRmxvYXRQb2ludCYpIGNvbnN0OwogICAgIGJvb2wg c3Ryb2tlQ29udGFpbnMoY29uc3QgRmxvYXRQb2ludCYpIGNvbnN0OwogCi0gICAgdmlydHVhbCBG bG9hdFJlY3Qgb2JqZWN0Qm91bmRpbmdCb3goKSBjb25zdCB7IHJldHVybiBTVkdSZW5kZXJTdXBw b3J0Ojpjb21wdXRlQ29udGFpbmVyQm91bmRpbmdCb3godGhpcywgZmFsc2UpOyB9Ci0gICAgdmly dHVhbCBGbG9hdFJlY3Qgc3Ryb2tlQm91bmRpbmdCb3goKSBjb25zdCB7IHJldHVybiBTVkdSZW5k ZXJTdXBwb3J0Ojpjb21wdXRlQ29udGFpbmVyQm91bmRpbmdCb3godGhpcywgdHJ1ZSk7IH0KKyAg ICB2aXJ0dWFsIEZsb2F0UmVjdCBvYmplY3RCb3VuZGluZ0JveCgpIGNvbnN0OworICAgIHZpcnR1 YWwgRmxvYXRSZWN0IHN0cm9rZUJvdW5kaW5nQm94KCkgY29uc3Q7CiAgICAgdmlydHVhbCBGbG9h dFJlY3QgcmVwYWludFJlY3RJbkxvY2FsQ29vcmRpbmF0ZXMoKSBjb25zdDsKIAogICAgIHZpcnR1 YWwgYm9vbCBub2RlQXRQb2ludChjb25zdCBIaXRUZXN0UmVxdWVzdCYsIEhpdFRlc3RSZXN1bHQm LCBpbnQgeCwgaW50IHksIGludCB0eCwgaW50IHR5LCBIaXRUZXN0QWN0aW9uKTsKSW5kZXg6IFdl YkNvcmUvcmVuZGVyaW5nL1NWR1JlbmRlclN1cHBvcnQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcmVuZGVyaW5nL1NWR1JlbmRlclN1cHBvcnQuY3BwCShyZXZpc2lvbiA2MjIzOCkKKysrIFdl YkNvcmUvcmVuZGVyaW5nL1NWR1JlbmRlclN1cHBvcnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y MTAsMTUgKzIxMCwyNiBAQCB2b2lkIFNWR1JlbmRlclN1cHBvcnQ6OnJlbmRlclN1YnRyZWVUb0lt CiAgICAgICAgIHN2Z0NvbnRhaW5lci0+c2V0RHJhd3NDb250ZW50cyhmYWxzZSk7CiB9CiAKLUZs b2F0UmVjdCBTVkdSZW5kZXJTdXBwb3J0Ojpjb21wdXRlQ29udGFpbmVyQm91bmRpbmdCb3goY29u c3QgUmVuZGVyT2JqZWN0KiBjb250YWluZXIsIGJvb2wgaW5jbHVkZUFsbFBhaW50ZWRDb250ZW50 KQorRmxvYXRSZWN0IFNWR1JlbmRlclN1cHBvcnQ6OmNvbXB1dGVDb250YWluZXJCb3VuZGluZ0Jv eChjb25zdCBSZW5kZXJPYmplY3QqIGNvbnRhaW5lciwgQ29udGFpbmVyQm91bmRpbmdCb3hNb2Rl IG1vZGUpCiB7CiAgICAgRmxvYXRSZWN0IGJvdW5kaW5nQm94OwogCi0gICAgUmVuZGVyT2JqZWN0 KiBjdXJyZW50ID0gY29udGFpbmVyLT5maXJzdENoaWxkKCk7Ci0gICAgZm9yICg7IGN1cnJlbnQg IT0gMDsgY3VycmVudCA9IGN1cnJlbnQtPm5leHRTaWJsaW5nKCkpIHsKLSAgICAgICAgRmxvYXRS ZWN0IGNoaWxkQkJveCA9IGluY2x1ZGVBbGxQYWludGVkQ29udGVudCA/IGN1cnJlbnQtPnJlcGFp bnRSZWN0SW5Mb2NhbENvb3JkaW5hdGVzKCkgOiBjdXJyZW50LT5vYmplY3RCb3VuZGluZ0JveCgp OwotICAgICAgICBGbG9hdFJlY3QgY2hpbGRCQm94SW5Mb2NhbENvb3JkcyA9IGN1cnJlbnQtPmxv Y2FsVG9QYXJlbnRUcmFuc2Zvcm0oKS5tYXBSZWN0KGNoaWxkQkJveCk7Ci0gICAgICAgIGJvdW5k aW5nQm94LnVuaXRlKGNoaWxkQkJveEluTG9jYWxDb29yZHMpOworICAgIGZvciAoUmVuZGVyT2Jq ZWN0KiBjdXJyZW50ID0gY29udGFpbmVyLT5maXJzdENoaWxkKCk7IGN1cnJlbnQ7IGN1cnJlbnQg PSBjdXJyZW50LT5uZXh0U2libGluZygpKSB7CisgICAgICAgIEZsb2F0UmVjdCBjaGlsZEJvdW5k aW5nQm94OworCisgICAgICAgIHN3aXRjaCAobW9kZSkgeworICAgICAgICBjYXNlIE9iamVjdEJv dW5kaW5nQm94OgorICAgICAgICAgICAgY2hpbGRCb3VuZGluZ0JveCA9IGN1cnJlbnQtPm9iamVj dEJvdW5kaW5nQm94KCk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBTdHJva2VC b3VuZGluZ0JveDoKKyAgICAgICAgICAgIGNoaWxkQm91bmRpbmdCb3ggPSBjdXJyZW50LT5zdHJv a2VCb3VuZGluZ0JveCgpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgUmVwYWlu dEJvdW5kaW5nQm94OgorICAgICAgICAgICAgY2hpbGRCb3VuZGluZ0JveCA9IGN1cnJlbnQtPnJl cGFpbnRSZWN0SW5Mb2NhbENvb3JkaW5hdGVzKCk7CisgICAgICAgICAgICBicmVhazsKKyAgICAg ICAgfQorCisgICAgICAgIGJvdW5kaW5nQm94LnVuaXRlKGN1cnJlbnQtPmxvY2FsVG9QYXJlbnRU cmFuc2Zvcm0oKS5tYXBSZWN0KGNoaWxkQm91bmRpbmdCb3gpKTsKICAgICB9CiAKICAgICByZXR1 cm4gYm91bmRpbmdCb3g7CkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9TVkdSZW5kZXJTdXBwb3J0 LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvU1ZHUmVuZGVyU3VwcG9ydC5oCShy ZXZpc2lvbiA2MjIzOCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1NWR1JlbmRlclN1cHBvcnQuaAko d29ya2luZyBjb3B5KQpAQCAtNTgsOSArNTgsMTUgQEAgcHVibGljOgogICAgIC8vIERldGVybWlu ZXMgd2hldGhlciB0aGUgcGFzc2VkIHBvaW50IGxpZXMgaW4gYSBjbGlwcGluZyBhcmVhCiAgICAg c3RhdGljIGJvb2wgcG9pbnRJbkNsaXBwaW5nQXJlYShjb25zdCBSZW5kZXJPYmplY3QqLCBjb25z dCBGbG9hdFBvaW50Jik7CiAKKyAgICBlbnVtIENvbnRhaW5lckJvdW5kaW5nQm94TW9kZSB7Cisg ICAgICAgIE9iamVjdEJvdW5kaW5nQm94LAorICAgICAgICBTdHJva2VCb3VuZGluZ0JveCwKKyAg ICAgICAgUmVwYWludEJvdW5kaW5nQm94CisgICAgfTsKKwogICAgIC8vIFVzZWQgdG8gc2hhcmUg dGhlICJ3YWxrIGFsbCB0aGUgY2hpbGRyZW4iIGxvZ2ljIGJldHdlZW4gb2JqZWN0Qm91bmRpbmdC b3gKICAgICAvLyBhbmQgcmVwYWludFJlY3RJbkxvY2FsQ29vcmRpbmF0ZXMgaW4gUmVuZGVyU1ZH Um9vdCBhbmQgUmVuZGVyU1ZHQ29udGFpbmVyCi0gICAgc3RhdGljIEZsb2F0UmVjdCBjb21wdXRl Q29udGFpbmVyQm91bmRpbmdCb3goY29uc3QgUmVuZGVyT2JqZWN0KiBjb250YWluZXIsIGJvb2wg aW5jbHVkZUFsbFBhaW50ZWRDb250ZW50KTsKKyAgICBzdGF0aWMgRmxvYXRSZWN0IGNvbXB1dGVD b250YWluZXJCb3VuZGluZ0JveChjb25zdCBSZW5kZXJPYmplY3QqIGNvbnRhaW5lciwgQ29udGFp bmVyQm91bmRpbmdCb3hNb2RlKTsKIAogICAgIC8vIEltcG9ydGFudCBmdW5jdGlvbnMgdXNlZCBi eSBuZWFybHkgYWxsIFNWRyByZW5kZXJlcnMgY2VudHJhbGl6aW5nIGNvb3JkaW5hdGUgdHJhbnNm b3JtYXRpb25zIC8gcmVwYWludCByZWN0IGNhbGN1bGF0aW9ucwogICAgIHN0YXRpYyBJbnRSZWN0 IGNsaXBwZWRPdmVyZmxvd1JlY3RGb3JSZXBhaW50KFJlbmRlck9iamVjdCosIFJlbmRlckJveE1v ZGVsT2JqZWN0KiByZXBhaW50Q29udGFpbmVyKTsK