41448 2010-07-01 01:11:55 -0700 HTMLTokenizer should ASSERT that it never emits a null character 2010-07-01 20:15:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 eric eric abarth commit-queue oldest_to_newest 245184 0 eric 2010-07-01 01:11:55 -0700 HTMLTokenizer should ASSERT that it never emits a null character 245185 1 eric 2010-07-01 01:13:09 -0700 These ASSERTs would have prevented the problems seen in bug 41436 (which were fixed by bug 41439). 245186 2 60214 eric 2010-07-01 01:14:59 -0700 Created attachment 60214 Patch 245471 3 ap 2010-07-01 12:10:51 -0700 I still think it's a bad bad idea in HTML5 to replace nulls with FFFD's. 245521 4 eric 2010-07-01 13:33:59 -0700 The ASSERTs here are mostly to guard against us ever emitting \0 which we've repurposed to mean EndOfFile. You should definitely take your complaints up with Hixie. If we do allow emitting \0 at some point then we'll need to use a different character to mean EOF. Also, one side-effect of allowing \0 in the rendered content is that diff treats files with \0 in them as binary (which bit us in bug 41436). 245714 5 60214 abarth 2010-07-01 19:58:18 -0700 Comment on attachment 60214 Patch @ap: I don't mean to ignore your comments. I certainly find them valuable, but that's an spec-level issue, not something that should block us ASSERTing that the implementation is doing what we intend it to do at the moment. 245728 6 60214 commit-queue 2010-07-01 20:15:41 -0700 Comment on attachment 60214 Patch Clearing flags on attachment: 60214 Committed r62352: <http://trac.webkit.org/changeset/62352> 245729 7 commit-queue 2010-07-01 20:15:46 -0700 All reviewed patches have been landed. Closing bug. 60214 2010-07-01 01:14:59 -0700 2010-07-01 20:15:41 -0700 Patch bug-41448-20100701011456.patch text/plain 3342 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjA0ZDNhMGFiMTEwN2RjMzBhOTAxNTk4MTNlYThhMDg4MTNmYTliZS4uMzM2NGQ4YzY5OWZiYjRl ZmI0NWYxNTA0ZWQ2NWNmNDM4NTliZTgzMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wNy0wMSAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSFRNTFRva2VuaXplciBzaG91bGQgQVNTRVJUIHRoYXQgaXQg bmV2ZXIgZW1pdHMgYSBudWxsIGNoYXJhY3RlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE0NDgKKworICAgICAgICBObyBmdW5jdGlvbmFsIGNoYW5n ZSwgdGh1cyBubyB0ZXN0cy4gIFRoZXNlIEFTU0VSVHMgd291bGQgaGF2ZQorICAgICAgICBjYXVn aHQgdGhlIGNvZGluZyBlcnJvciB3aGljaCBjYXVzZWQgdGhlIHRyb3VibGUgaW4gYnVnIDQxNDM2 CisgICAgICAgICh3aGljaCB3YXMgZml4ZWQgYnkgYnVnIDQxNDM5KS4KKworICAgICAgICAqIGh0 bWwvSFRNTFRva2VuLmg6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVG9rZW46OmJlZ2luU3RhcnRU YWcpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRva2VuOjpiZWdpbkNoYXJhY3Rlcik6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MVG9rZW46OmJlZ2luRE9DVFlQRSk6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MVG9rZW46OmFwcGVuZFRvTmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVG9rZW46 OmFwcGVuZFRvQ29tbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVG9rZW46OmFwcGVuZFRv QXR0cmlidXRlTmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVG9rZW46OmFwcGVuZFRvQXR0 cmlidXRlVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRva2VuOjphcHBlbmRUb1B1Ymxp Y0lkZW50aWZpZXIpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRva2VuOjphcHBlbmRUb1N5c3Rl bUlkZW50aWZpZXIpOgorCiAyMDEwLTA3LTAxICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJD b3JlL2h0bWwvSFRNTFRva2VuLmggYi9XZWJDb3JlL2h0bWwvSFRNTFRva2VuLmgKaW5kZXggZThh MTlmOGY0YjgyNjVkM2UyODlmMjYwZTEyMTYxMDM3NjJkNzU3Yi4uZjk2YjI2MjZmMmUxNTEwOTMx YTIzNmE4YjYzM2FlMjI3ZDE2YjZlOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxUb2tl bi5oCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MVG9rZW4uaApAQCAtNjgsNiArNjgsNyBAQCBwdWJs aWM6CiAKICAgICB2b2lkIGJlZ2luU3RhcnRUYWcoVUNoYXIgY2hhcmFjdGVyKQogICAgIHsKKyAg ICAgICAgQVNTRVJUKGNoYXJhY3Rlcik7CiAgICAgICAgIEFTU0VSVChtX3R5cGUgPT0gVW5pbml0 aWFsaXplZCk7CiAgICAgICAgIG1fdHlwZSA9IFN0YXJ0VGFnOwogICAgICAgICBtX2RhdGEuY2xl YXIoKTsKQEAgLTkzLDYgKzk0LDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBiZWdpbkNoYXJhY3Rl cihVQ2hhciBjaGFyYWN0ZXIpCiAgICAgeworICAgICAgICBBU1NFUlQoY2hhcmFjdGVyKTsKICAg ICAgICAgQVNTRVJUKG1fdHlwZSA9PSBVbmluaXRpYWxpemVkKTsKICAgICAgICAgbV90eXBlID0g Q2hhcmFjdGVyOwogICAgICAgICBtX2RhdGEuY2xlYXIoKTsKQEAgLTExNiwxMiArMTE4LDE0IEBA IHB1YmxpYzoKIAogICAgIHZvaWQgYmVnaW5ET0NUWVBFKFVDaGFyIGNoYXJhY3RlcikKICAgICB7 CisgICAgICAgIEFTU0VSVChjaGFyYWN0ZXIpOwogICAgICAgICBiZWdpbkRPQ1RZUEUoKTsKICAg ICAgICAgbV9kYXRhLmFwcGVuZChjaGFyYWN0ZXIpOwogICAgIH0KIAogICAgIHZvaWQgYXBwZW5k VG9OYW1lKFVDaGFyIGNoYXJhY3RlcikKICAgICB7CisgICAgICAgIEFTU0VSVChjaGFyYWN0ZXIp OwogICAgICAgICBBU1NFUlQobV90eXBlID09IFN0YXJ0VGFnIHx8IG1fdHlwZSA9PSBFbmRUYWcg fHwgbV90eXBlID09IERPQ1RZUEUpOwogICAgICAgICBtX2RhdGEuYXBwZW5kKGNoYXJhY3Rlcik7 CiAgICAgfQpAQCAtMTM1LDYgKzEzOSw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgYXBwZW5kVG9D b21tZW50KFVDaGFyIGNoYXJhY3RlcikKICAgICB7CisgICAgICAgIEFTU0VSVChjaGFyYWN0ZXIp OwogICAgICAgICBBU1NFUlQobV90eXBlID09IENvbW1lbnQpOwogICAgICAgICBtX2RhdGEuYXBw ZW5kKGNoYXJhY3Rlcik7CiAgICAgfQpAQCAtMTQ4LDEyICsxNTMsMTQgQEAgcHVibGljOgogCiAg ICAgdm9pZCBhcHBlbmRUb0F0dHJpYnV0ZU5hbWUoVUNoYXIgY2hhcmFjdGVyKQogICAgIHsKKyAg ICAgICAgQVNTRVJUKGNoYXJhY3Rlcik7CiAgICAgICAgIEFTU0VSVChtX3R5cGUgPT0gU3RhcnRU YWcgfHwgbV90eXBlID09IEVuZFRhZyk7CiAgICAgICAgIG1fY3VycmVudEF0dHJpYnV0ZS0+bV9u YW1lLmFwcGVuZChjaGFyYWN0ZXIpOwogICAgIH0KIAogICAgIHZvaWQgYXBwZW5kVG9BdHRyaWJ1 dGVWYWx1ZShVQ2hhciBjaGFyYWN0ZXIpCiAgICAgeworICAgICAgICBBU1NFUlQoY2hhcmFjdGVy KTsKICAgICAgICAgQVNTRVJUKG1fdHlwZSA9PSBTdGFydFRhZyB8fCBtX3R5cGUgPT0gRW5kVGFn KTsKICAgICAgICAgbV9jdXJyZW50QXR0cmlidXRlLT5tX3ZhbHVlLmFwcGVuZChjaGFyYWN0ZXIp OwogICAgIH0KQEAgLTIzMiw2ICsyMzksNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGFwcGVuZFRv UHVibGljSWRlbnRpZmllcihVQ2hhciBjaGFyYWN0ZXIpCiAgICAgeworICAgICAgICBBU1NFUlQo Y2hhcmFjdGVyKTsKICAgICAgICAgQVNTRVJUKG1fdHlwZSA9PSBET0NUWVBFKTsKICAgICAgICAg QVNTRVJUKG1fZG9jdHlwZURhdGEtPm1faGFzUHVibGljSWRlbnRpZmllcik7CiAgICAgICAgIG1f ZG9jdHlwZURhdGEtPm1fcHVibGljSWRlbnRpZmllci5hcHBlbmQoY2hhcmFjdGVyKTsKQEAgLTIz OSw2ICsyNDcsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGFwcGVuZFRvU3lzdGVtSWRlbnRpZmll cihVQ2hhciBjaGFyYWN0ZXIpCiAgICAgeworICAgICAgICBBU1NFUlQoY2hhcmFjdGVyKTsKICAg ICAgICAgQVNTRVJUKG1fdHlwZSA9PSBET0NUWVBFKTsKICAgICAgICAgQVNTRVJUKG1fZG9jdHlw ZURhdGEtPm1faGFzU3lzdGVtSWRlbnRpZmllcik7CiAgICAgICAgIG1fZG9jdHlwZURhdGEtPm1f c3lzdGVtSWRlbnRpZmllci5hcHBlbmQoY2hhcmFjdGVyKTsK