41439 2010-06-30 17:30:01 -0700 BogusCommentState should come in from the cold 2010-07-01 01:13:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 41436 1 abarth abarth commit-queue eric oldest_to_newest 245032 0 abarth 2010-06-30 17:30:01 -0700 BogusCommentState should come in from the cold 245033 1 60174 abarth 2010-06-30 17:33:14 -0700 Created attachment 60174 Patch 245035 2 60174 eric 2010-06-30 17:49:45 -0700 Comment on attachment 60174 Patch LayoutTests/html5lib/webkit-resumer-expected.txt:159 + resources/webkit01.dat: Geez, we still need to fix this output. WebCore/html/HTMLTokenizer.cpp:1078 + else if (cc == InputStreamPreprocessor::endOfFileMarker) I should have written these as isEndOfFileMarker(cc) Why do we need ContinueBogusCommentState? Why not just check m_token->type() == Comment? 245057 3 abarth 2010-06-30 19:18:53 -0700 > WebCore/html/HTMLTokenizer.cpp:1078 > + else if (cc == InputStreamPreprocessor::endOfFileMarker) > I should have written these as isEndOfFileMarker(cc) Oh, ok. I just copied another state/ > Why do we need ContinueBogusCommentState? Why not just check m_token->type() == Comment? Because that would be an extra branch per character. 245091 4 eric 2010-06-30 22:09:28 -0700 (In reply to comment #3) > > Why do we need ContinueBogusCommentState? Why not just check m_token->type() == Comment? > > Because that would be an extra branch per character. Really? I meant in the BogusCommentState itself. Are we commonly in the BogusCommentState? I agree this is fewer branches. 245163 5 60174 commit-queue 2010-07-01 00:40:10 -0700 Comment on attachment 60174 Patch Clearing flags on attachment: 60174 Committed r62233: <http://trac.webkit.org/changeset/62233> 245164 6 commit-queue 2010-07-01 00:40:14 -0700 All reviewed patches have been landed. Closing bug. 60174 2010-06-30 17:33:14 -0700 2010-07-01 00:40:10 -0700 Patch bug-41439-20100630173313.patch text/plain 5108 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhODdiZDgwMTgwNWZjZGU3MDQ2MjhlNzY0YmRlMmUyMjcxOGU2YTY4Li4yMmIyYTli NjhmOGM0NDEzNTljMjEzYWI2YjZjZjg2MWE0ZTA1Mjg0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDYtMzAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCb2d1c0NvbW1lbnRTdGF0ZSBz aG91bGQgY29tZSBpbiBmcm9tIHRoZSBjb2xkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MTQzOQorCisgICAgICAgIFRlc3QgcHJvZ3Jlc3Npb24gPT4g OikKKworICAgICAgICAqIGh0bWw1bGliL3J1bm5lci1leHBlY3RlZC50eHQ6CisgICAgICAgICog aHRtbDVsaWIvd2Via2l0LXJlc3VtZXItZXhwZWN0ZWQudHh0OgorCiAyMDEwLTA2LTMwICBCZXRo IERha2luICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVy bnN0ZWluLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcnVubmVyLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2h0bWw1bGliL3J1bm5lci1leHBlY3RlZC50eHQKaW5kZXggZDg5 MzBiNzgwYjVkYzgxODUwMjRjZTkzNGRiM2NkYjE0ZDI3MDIzOS4uMDBiMmQxN2UwZjQwNDAxOTBm ZWNlNWRkODk5NjQ2ZTFmOTk2Y2RhOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHRtbDVsaWIv cnVubmVyLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9odG1sNWxpYi9ydW5uZXItZXhw ZWN0ZWQudHh0CkBAIC05LDcgKzksNiBAQCByZXNvdXJjZXMvdGVzdHMxLmRhdDoKIDMyCiAzMwog MzQKLTQxCiA1MAogNTEKIDUyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odG1sNWxpYi93ZWJr aXQtcmVzdW1lci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odG1sNWxpYi93ZWJraXQtcmVz dW1lci1leHBlY3RlZC50eHQKaW5kZXggOGQ4ODljN2JkZTM5ODhjODU5ZmM2N2VlNGY4Zjk5ZTM1 ZjNmZjYxNi4uOGJkYjQzMzM5MzlhNTI2Y2YwMGVjNjdmYjI0N2M0YTM1NDdlM2M3OCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvaHRtbDVsaWIvd2Via2l0LXJlc3VtZXItZXhwZWN0ZWQudHh0Cisr KyBiL0xheW91dFRlc3RzL2h0bWw1bGliL3dlYmtpdC1yZXN1bWVyLWV4cGVjdGVkLnR4dApAQCAt MTU3LDExICsxNTcsNiBAQCBDT05TT0xFIE1FU1NBR0U6IGxpbmUgMjogRk9PPHNwYW4+QkFSPC9z cGFuPkJBWgogQ09OU09MRSBNRVNTQUdFOiBsaW5lIDI6IEZPTzxzcGFuPkJBUjwvc3Bhbj5CQVoK IENPTlNPTEUgTUVTU0FHRTogbGluZSAyOiBGT088c3Bhbj5CQVI8L3NwYW4+QkFaCiByZXNvdXJj ZXMvd2Via2l0MDEuZGF0OgotNTE5LjMKLTUyMC40Ci01MjEuNQotNTIyLjYKLTUyMy43CiA1OTMu MQogNTk0LjIKIDU5NS4zCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDMzMGZlZWY3Y2MyNjhkYWE4NjhiN2ViYzBhYTY3MjllYzI2ZjQ5NWEu LmJmMWJiZTExODE4YWYxYjk2OGJmYzBkOGY2YTI4ODU5YjA1M2VjNmYgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjggQEAK IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBCb2d1c0Nv bW1lbnRTdGF0ZSBzaG91bGQgY29tZSBpbiBmcm9tIHRoZSBjb2xkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTQzOQorCisgICAgICAgIFRoZSBCb2d1 c0NvbW1lbnRTdGF0ZSBoYXMgYWx3YXlzIGJlZW4gd3JvbmcuICBUaGUgcHJveGltYXRlIGlzc3Vl IGlzCisgICAgICAgIHRoYXQgaXQgZGlkbid0IGhhbmRsZSByZXN1bWluZyBjb3JyZWN0bHkgd2hl biBwYXJzaW5nIGEgcGFydGlhbCBpbnB1dAorICAgICAgICBzdHJlYW0uICBOb3cgdGhhdCB3ZSBo YXZlIEVPRiB3b3JraW5nIHByb3Blcmx5LCB3ZSBjYW4gYWN0dWFsbHkKKyAgICAgICAgaW1wbGVt ZW50IHRoaXMgc3RhdGUgY29ycmVjdGx5LgorCisgICAgICAgIFdlIG5lZWQgdG8gZGlzdGluZ3Vp c2ggd2hlbiB3ZSBlbnRlciB0aGlzIHN0YXRlIGZyb20gd2hlbiB3ZSBjb250aW51ZQorICAgICAg ICBpbiB0aGlzIHN0YXRlLiAgV2UgY291bGQgZG8gdGhhdCB3aXRoIGEgYnJhbmNoIGZvciBlYWNo IGNoYXJhY3RlciwgYnV0CisgICAgICAgIGl0IHNlZW1lZCBlYXNpZXIgdG8gc3BsaXQgdGhlIHN0 YXRlIGluIHR3bywgZXZlbiB0aG91Z2ggdGhhdCBsZWF2ZXMgdXMKKyAgICAgICAgd2l0aCBvbmUg bW9yZSBzdGF0ZSBpbiBvdXIgdG9rZW5pemVyIHRoYW4gd2UgaGF2ZSBpbiB0aGUgSFRNTDUgc3Bl Yy4KKworICAgICAgICAqIGh0bWwvSFRNTFRva2VuaXplci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MVG9rZW5pemVyOjpuZXh0VG9rZW4pOgorICAgICAgICAqIGh0bWwvSFRNTFRva2VuaXpl ci5oOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRva2VuaXplcjo6KToKKworMjAxMC0wNi0zMCAg QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCiAgICAgICAgIEFic3RyYWN0ICdhJy0neicgY2hlY2tzIGludG8gYSBm dW5jdGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDE0MzgKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxUb2tlbml6ZXIuY3BwIGIvV2Vi Q29yZS9odG1sL0hUTUxUb2tlbml6ZXIuY3BwCmluZGV4IDVkZDkxZThmZTc5NGNmMjM2NTQxMDBj MDlkZmFhZThkOWRhZWNjZDYuLmU4MGNiNDgxZWQ4N2EwNWJlMWQ4OWMwYzM0ZWQ5OGJlMGJiZmYz N2EgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MVG9rZW5pemVyLmNwcAorKysgYi9XZWJD b3JlL2h0bWwvSFRNTFRva2VuaXplci5jcHAKQEAgLTEwNjcsMjEgKzEwNjcsMjAgQEAgYm9vbCBI VE1MVG9rZW5pemVyOjpuZXh0VG9rZW4oU2VnbWVudGVkU3RyaW5nJiBzb3VyY2UsIEhUTUxUb2tl biYgdG9rZW4pCiAgICAgRU5EX1NUQVRFKCkKIAogICAgIEJFR0lOX1NUQVRFKEJvZ3VzQ29tbWVu dFN0YXRlKSB7Ci0gICAgICAgIC8vIEZJWE1FOiBUaGlzIHN0YXRlIGlzbid0IGNvcnJlY3QgYmVj YXVzZSB3ZSdsbCB0ZXJtaW5hdGUgdGhlCi0gICAgICAgIC8vIGNvbW1lbnQgZWFybHkgaWYgd2Ug ZG9uJ3QgaGF2ZSB0aGUgd2hvbGUgaW5wdXQgc3RyZWFtIGF2YWlsYWJsZS4KICAgICAgICAgbV90 b2tlbi0+YmVnaW5Db21tZW50KCk7Ci0gICAgICAgIHdoaWxlICghc291cmNlLmlzRW1wdHkoKSkg ewotICAgICAgICAgICAgY2MgPSBtX2lucHV0U3RyZWFtUHJlcHJvY2Vzc29yLm5leHRJbnB1dENo YXJhY3RlcigpOwotICAgICAgICAgICAgaWYgKGNjID09ICc+JykKLSAgICAgICAgICAgICAgICBy ZXR1cm4gZW1pdEFuZFJlc3VtZUluKHNvdXJjZSwgRGF0YVN0YXRlKTsKKyAgICAgICAgUkVDT05T VU1FX0lOKENvbnRpbnVlQm9ndXNDb21tZW50U3RhdGUpOworICAgIH0KKyAgICBFTkRfU1RBVEUo KQorCisgICAgQkVHSU5fU1RBVEUoQ29udGludWVCb2d1c0NvbW1lbnRTdGF0ZSkgeworICAgICAg ICBpZiAoY2MgPT0gJz4nKQorICAgICAgICAgICAgcmV0dXJuIGVtaXRBbmRSZXN1bWVJbihzb3Vy Y2UsIERhdGFTdGF0ZSk7CisgICAgICAgIGVsc2UgaWYgKGNjID09IElucHV0U3RyZWFtUHJlcHJv Y2Vzc29yOjplbmRPZkZpbGVNYXJrZXIpCisgICAgICAgICAgICByZXR1cm4gZW1pdEFuZFJlY29u c3VtZUluKHNvdXJjZSwgRGF0YVN0YXRlKTsKKyAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICBt X3Rva2VuLT5hcHBlbmRUb0NvbW1lbnQoY2MpOwotICAgICAgICAgICAgbV9pbnB1dFN0cmVhbVBy ZXByb2Nlc3Nvci5hZHZhbmNlKHNvdXJjZSwgbV9saW5lTnVtYmVyKTsKLSAgICAgICAgICAgIC8v IFdlIGlnbm9yZSB0aGUgcmV0dXJuIHZhbHVlICh3aGljaCBpbmRpY2F0ZXMgdGhhdCB8c291cmNl fCBpcwotICAgICAgICAgICAgLy8gZW1wdHkpIGJlY2F1c2UgaXQncyBjaGVja2VkIGJ5IHRoZSBs b29wIGNvbmRpdGlvbiBhYm92ZS4KKyAgICAgICAgICAgIEFEVkFOQ0VfVE8oQ29udGludWVCb2d1 c0NvbW1lbnRTdGF0ZSk7CiAgICAgICAgIH0KLSAgICAgICAgbV9zdGF0ZSA9IERhdGFTdGF0ZTsK LSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAgIC8vIEZJWE1FOiBIYW5kbGUgRU9GIHByb3Bl cmx5LgogICAgIH0KICAgICBFTkRfU1RBVEUoKQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwv SFRNTFRva2VuaXplci5oIGIvV2ViQ29yZS9odG1sL0hUTUxUb2tlbml6ZXIuaAppbmRleCA4NDc5 ZGZjZDVlZTc4Y2RiMWRhNGFhNWRmMWJhNzY0NDE0MTU5NWQ2Li45NmMyZDdjNjlhZDU1MjExZTk4 Y2MwOTMzNjYzMDg0Y2ZmNmM4Y2ZjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTFRva2Vu aXplci5oCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MVG9rZW5pemVyLmgKQEAgLTgzLDYgKzgzLDEw IEBAIHB1YmxpYzoKICAgICAgICAgQWZ0ZXJBdHRyaWJ1dGVWYWx1ZVF1b3RlZFN0YXRlLAogICAg ICAgICBTZWxmQ2xvc2luZ1N0YXJ0VGFnU3RhdGUsCiAgICAgICAgIEJvZ3VzQ29tbWVudFN0YXRl LAorICAgICAgICAvLyBUaGUgQ29udGludWVCb2d1c0NvbW1lbnRTdGF0ZSBpcyBub3QgaW4gdGhl IEhUTUw1IHNwZWMsIGJ1dCB3ZSB1c2UKKyAgICAgICAgLy8gaXQgaW50ZXJuYWxseSB0byBrZWVw IHRyYWNrIG9mIHdoZXRoZXIgd2UndmUgc3RhcnRlZCB0aGUgYm9ndXMKKyAgICAgICAgLy8gY29t bWVudCB0b2tlbiB5ZXQuCisgICAgICAgIENvbnRpbnVlQm9ndXNDb21tZW50U3RhdGUsCiAgICAg ICAgIE1hcmt1cERlY2xhcmF0aW9uT3BlblN0YXRlLAogICAgICAgICBDb21tZW50U3RhcnRTdGF0 ZSwKICAgICAgICAgQ29tbWVudFN0YXJ0RGFzaFN0YXRlLAo=