41433 2010-06-30 16:09:21 -0700 make_names.pl should ignore pre-processor definitions when generating FooNames.* 2010-07-20 18:00:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 eric eric abarth ossy oldest_to_newest 244983 0 eric 2010-06-30 16:09:21 -0700 make_names.pl should ignore pre-processor definitions when generating FooNames.* 244986 1 60162 eric 2010-06-30 16:11:11 -0700 Created attachment 60162 work in progress 244989 2 abarth 2010-06-30 16:12:11 -0700 You should generate names for the extra tags we need in the new tree builder too. 244993 3 eric 2010-06-30 16:14:47 -0700 This will require changes to make_names to make it ignore preprocessor definitions in the Names case, and not in the ElementFactory case. I'm not quite sure how to do that yet though. This is important for making a correctly functioning HTML5 TreeBuilder since it needs to respect "foreignObject" as a name, even if our foreignObject support is disabled. I'm not actively working on this bug atm, but we'll have to fix it before we can pass the entire libhtml5 test suite in all configurations. 245005 4 abarth 2010-06-30 16:29:22 -0700 Block against master? 60162 2010-06-30 16:11:11 -0700 2010-06-30 16:13:55 -0700 work in progress bug-41433-20100630161109.patch text/plain 6911 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTA2ZTNjOTljYzM1NTgxYjcxYTY1NDUwZjE2YmFjYzJjNzlhNjA0Ni4uYmY3ZDQ3NTU0ZDM2MDVh ZmMyZWE4ZDNkNzhiZDFlNWZlZWYyYWU4ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwzMiBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIG1ha2VfbmFtZXMucGwgc2hvdWxkIGln bm9yZSBwcmUtcHJvY2Vzc29yIGRlZmluaXRpb25zIHdoZW4gZ2VuZXJhdGluZyBGb29OYW1lcy4q CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTQzMwor CisgICAgICAgIEFsbCBTVkdOYW1lczo6IHNob3VsZCBiZSBkZWZpbmVkLCBldmVuIHdoZW4gdGhl IGFzc29jaWF0ZWQKKyAgICAgICAgZmVhdHVyZSBpcyBub3QgZW5hYmxlZC4KKworICAgICAgICAq IGRvbS9UZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHQ6OmNyZWF0ZVJlbmRlcmVyKToK KyAgICAgICAgKiBzdmcvU1ZHQW5pbWF0ZU1vdGlvbkVsZW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6U1ZHQW5pbWF0ZU1vdGlvbkVsZW1lbnQ6Omhhc1ZhbGlkVGFyZ2V0KToKKyAgICAgICAg KiBzdmcvU1ZHTG9jYXRhYmxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzVmlld3BvcnRFbGVt ZW50KToKKyAgICAgICAgKiBzdmcvU1ZHU1ZHRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTVkdTVkdFbGVtZW50Ojppc091dGVybW9zdFNWRyk6CisgICAgICAgICogc3ZnL1NWR1RleHRF bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1RleHRFbGVtZW50OjpjaGlsZFNob3Vs ZENyZWF0ZVJlbmRlcmVyKToKKyAgICAgICAgKiBzdmcvU1ZHVGV4dFBhdGhFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNWR1RleHRQYXRoRWxlbWVudDo6Y2hpbGRTaG91bGRDcmVhdGVS ZW5kZXJlcik6CisgICAgICAgICogc3ZnL1NWR1VzZUVsZW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6aXNEaXNhbGxvd2VkRWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpTVkdVc2VFbGVt ZW50Ojphc3NvY2lhdGVJbnN0YW5jZXNXaXRoU2hhZG93VHJlZUVsZW1lbnRzKToKKworMjAxMC0w Ni0zMCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgSW1wbGVtZW50IGdlbmVyYXRlSW1wbGllZEVu ZFRhZ3MgYW5kIGRlcGxveSB0byBzdGVwcyB3aGljaCB3ZXJlIGJsb2NrZWQgb24gaXQKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNDMyCiAKZGlmZiAt LWdpdCBhL1dlYkNvcmUvZG9tL1RleHQuY3BwIGIvV2ViQ29yZS9kb20vVGV4dC5jcHAKaW5kZXgg MTU4OWIxMWRmN2UyMDE0ZThjMTFjNWRhMDZmYmI3NmNhYTQ3YjRkYS4uYTg5ZmMyYjc4ZmVmM2Yz NWNmMzRjNWY3ZDVhYWQxYTUwMTYxOTYxYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vVGV4dC5j cHAKKysrIGIvV2ViQ29yZS9kb20vVGV4dC5jcHAKQEAgLTIzOCwxNCArMjM4LDEyIEBAIGJvb2wg VGV4dDo6cmVuZGVyZXJJc05lZWRlZChSZW5kZXJTdHlsZSAqc3R5bGUpCiBSZW5kZXJPYmplY3Qq IFRleHQ6OmNyZWF0ZVJlbmRlcmVyKFJlbmRlckFyZW5hKiBhcmVuYSwgUmVuZGVyU3R5bGUqKQog ewogI2lmIEVOQUJMRShTVkcpCi0gICAgaWYgKHBhcmVudE5vZGUoKS0+aXNTVkdFbGVtZW50KCkK LSNpZiBFTkFCTEUoU1ZHX0ZPUkVJR05fT0JKRUNUKQotICAgICAgICAmJiAhcGFyZW50Tm9kZSgp LT5oYXNUYWdOYW1lKFNWR05hbWVzOjpmb3JlaWduT2JqZWN0VGFnKQotI2VuZGlmCi0gICAgKQor ICAgIC8vIEZJWE1FOiBUaGlzIHNlZW1zIHdyb25nLiAgZm9yZWlnbk9iamVjdCBzaG91bGQgYmVo YXZlIGxpa2UgYW4gaWZyYW1lCisgICAgLy8gdGV4dCBzaG91bGQgZnVuY3Rpb24ganVzdCBsaWtl IGl0IHdvdWxkIGF0IHRoZSByb290IG9mIGEgZG9jdW1lbnQuCisgICAgaWYgKHBhcmVudE5vZGUo KS0+aGFzVGFnTmFtZShTVkdOYW1lczo6Zm9yZWlnbk9iamVjdFRhZykpCiAgICAgICAgIHJldHVy biBuZXcgKGFyZW5hKSBSZW5kZXJTVkdJbmxpbmVUZXh0KHRoaXMsIGRhdGFJbXBsKCkpOwogI2Vu ZGlmCi0gICAgCisKICAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyVGV4dCh0aGlzLCBkYXRh SW1wbCgpKTsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9zdmcvU1ZHQW5pbWF0ZU1vdGlvbkVs ZW1lbnQuY3BwIGIvV2ViQ29yZS9zdmcvU1ZHQW5pbWF0ZU1vdGlvbkVsZW1lbnQuY3BwCmluZGV4 IDlhMGRhN2Y0NDg2MGU0NGJhZmE0YTEwM2JhMTQyMzNhYTcxNGMyZGQuLmI3NGM5MzczOWM0YjNl ZTEwN2ZiMjkyOGMxYjU3YjYyNjI5MTIyYjggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3ZnL1NWR0Fu aW1hdGVNb3Rpb25FbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL3N2Zy9TVkdBbmltYXRlTW90aW9u RWxlbWVudC5jcHAKQEAgLTc1LDkgKzc1LDcgQEAgYm9vbCBTVkdBbmltYXRlTW90aW9uRWxlbWVu dDo6aGFzVmFsaWRUYXJnZXQoKSBjb25zdAogICAgICAgICB8fCB0YXJnZXRFbGVtZW50LT5oYXNU YWdOYW1lKGNsaXBQYXRoVGFnKQogICAgICAgICB8fCB0YXJnZXRFbGVtZW50LT5oYXNUYWdOYW1l KG1hc2tUYWcpCiAgICAgICAgIHx8IHRhcmdldEVsZW1lbnQtPmhhc1RhZ05hbWUoYVRhZykKLSNp ZiBFTkFCTEUoU1ZHX0ZPUkVJR05fT0JKRUNUKQogICAgICAgICB8fCB0YXJnZXRFbGVtZW50LT5o YXNUYWdOYW1lKGZvcmVpZ25PYmplY3RUYWcpCi0jZW5kaWYKICAgICAgICAgKQogICAgICAgICBy ZXR1cm4gdHJ1ZTsKICAgICByZXR1cm4gZmFsc2U7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3N2Zy9T VkdMb2NhdGFibGUuY3BwIGIvV2ViQ29yZS9zdmcvU1ZHTG9jYXRhYmxlLmNwcAppbmRleCBlMDNl ZjkzYmIxNGQxMzIwNmY2YTIzNmZkNDI5MDhhYjc0NjRlNGEwLi4wNmE3ZmE5OTFlMGM5ODM2MWYy ODkyYTdlZWYyOGQyNmM1MjU0MjY2IDEwMDY0NAotLS0gYS9XZWJDb3JlL3N2Zy9TVkdMb2NhdGFi bGUuY3BwCisrKyBiL1dlYkNvcmUvc3ZnL1NWR0xvY2F0YWJsZS5jcHAKQEAgLTQzLDkgKzQzLDcg QEAgc3RhdGljIGJvb2wgaXNWaWV3cG9ydEVsZW1lbnQoTm9kZSogbm9kZSkKIHsKICAgICByZXR1 cm4gKG5vZGUtPmhhc1RhZ05hbWUoU1ZHTmFtZXM6OnN2Z1RhZykKICAgICAgICAgfHwgbm9kZS0+ aGFzVGFnTmFtZShTVkdOYW1lczo6c3ltYm9sVGFnKQotI2lmIEVOQUJMRShTVkdfRk9SRUlHTl9P QkpFQ1QpCiAgICAgICAgIHx8IG5vZGUtPmhhc1RhZ05hbWUoU1ZHTmFtZXM6OmZvcmVpZ25PYmpl Y3RUYWcpCi0jZW5kaWYKICAgICAgICAgfHwgbm9kZS0+aGFzVGFnTmFtZShTVkdOYW1lczo6aW1h Z2VUYWcpKTsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9zdmcvU1ZHU1ZHRWxlbWVudC5jcHAg Yi9XZWJDb3JlL3N2Zy9TVkdTVkdFbGVtZW50LmNwcAppbmRleCAwM2VhZmM4ZTU0ZmE5OWY1NTdj NDNlYzM4YzJkZjRjZjNlNDkzYzkyLi4xNTRhZDdhNWI1NTg5M2Q1Y2I1N2I4NTAxZGM2MGY3ODQx Mjg0NmExIDEwMDY0NAotLS0gYS9XZWJDb3JlL3N2Zy9TVkdTVkdFbGVtZW50LmNwcAorKysgYi9X ZWJDb3JlL3N2Zy9TVkdTVkdFbGVtZW50LmNwcApAQCAtNTIyLDExICs1MjIsOSBAQCBib29sIFNW R1NWR0VsZW1lbnQ6OmlzT3V0ZXJtb3N0U1ZHKCkgY29uc3QKICAgICBpZiAoIXBhcmVudE5vZGUo KSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKLSNpZiBFTkFCTEUoU1ZHX0ZPUkVJR05fT0JKRUNU KQogICAgIC8vIFdlIGFjdCBsaWtlIGFuIG91dGVybW9zdCBTVkcgZWxlbWVudCwgaWYgd2UncmUg YSBkaXJlY3QgY2hpbGQgb2YgYSA8Zm9yZWlnbk9iamVjdD4gZWxlbWVudC4KICAgICBpZiAocGFy ZW50Tm9kZSgpLT5oYXNUYWdOYW1lKFNWR05hbWVzOjpmb3JlaWduT2JqZWN0VGFnKSkKICAgICAg ICAgcmV0dXJuIHRydWU7Ci0jZW5kaWYKIAogICAgIC8vIFRoaXMgaXMgdHJ1ZSB3aGVuZXZlciB0 aGlzIGlzIHRoZSBvdXRlcm1vc3QgU1ZHLCBldmVuIGlmIHRoZXJlIGFyZSBIVE1MIGVsZW1lbnRz IG91dHNpZGUgaXQKICAgICByZXR1cm4gIXBhcmVudE5vZGUoKS0+aXNTVkdFbGVtZW50KCk7CmRp ZmYgLS1naXQgYS9XZWJDb3JlL3N2Zy9TVkdUZXh0RWxlbWVudC5jcHAgYi9XZWJDb3JlL3N2Zy9T VkdUZXh0RWxlbWVudC5jcHAKaW5kZXggMGFiYTA0YmYwY2VmZWE1NDY5YTM2MzBmODQzOWIzMTUz NmFiMTRmMS4uNWVjOTU2ZmNmMjFkMGI4YjYyOGQzZjZiMWJjNjk5ZTUwNzIwMzcyZiAxMDA2NDQK LS0tIGEvV2ViQ29yZS9zdmcvU1ZHVGV4dEVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvc3ZnL1NW R1RleHRFbGVtZW50LmNwcApAQCAtMTAyLDkgKzEwMiw3IEBAIFJlbmRlck9iamVjdCogU1ZHVGV4 dEVsZW1lbnQ6OmNyZWF0ZVJlbmRlcmVyKFJlbmRlckFyZW5hKiBhcmVuYSwgUmVuZGVyU3R5bGUq KQogYm9vbCBTVkdUZXh0RWxlbWVudDo6Y2hpbGRTaG91bGRDcmVhdGVSZW5kZXJlcihOb2RlKiBj aGlsZCkgY29uc3QKIHsKICAgICBpZiAoY2hpbGQtPmlzVGV4dE5vZGUoKQotI2lmIEVOQUJMRShT VkdfRk9OVFMpCiAgICAgICAgIHx8IGNoaWxkLT5oYXNUYWdOYW1lKFNWR05hbWVzOjphbHRHbHlw aFRhZykKLSNlbmRpZgogICAgICAgICB8fCBjaGlsZC0+aGFzVGFnTmFtZShTVkdOYW1lczo6dHNw YW5UYWcpIHx8IGNoaWxkLT5oYXNUYWdOYW1lKFNWR05hbWVzOjp0cmVmVGFnKSB8fCBjaGlsZC0+ aGFzVGFnTmFtZShTVkdOYW1lczo6YVRhZykgfHwgY2hpbGQtPmhhc1RhZ05hbWUoU1ZHTmFtZXM6 OnRleHRQYXRoVGFnKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgcmV0dXJuIGZhbHNlOwpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9zdmcvU1ZHVGV4dFBhdGhFbGVtZW50LmNwcCBiL1dlYkNvcmUv c3ZnL1NWR1RleHRQYXRoRWxlbWVudC5jcHAKaW5kZXggNGEyY2VhNTdlNzE1N2IxZTNmY2JhNTQ3 ZGNkZTBmYzgxOGUzZmY2OC4uMTkwYWRiNWU4NzdkZjI1ZjM5ZWM1YTE4ODZiYTU5NzNhMTAzYzE5 YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9zdmcvU1ZHVGV4dFBhdGhFbGVtZW50LmNwcAorKysgYi9X ZWJDb3JlL3N2Zy9TVkdUZXh0UGF0aEVsZW1lbnQuY3BwCkBAIC05OSw5ICs5OSw3IEBAIFJlbmRl ck9iamVjdCogU1ZHVGV4dFBhdGhFbGVtZW50OjpjcmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSog YXJlbmEsIFJlbmRlclN0eWxlCiBib29sIFNWR1RleHRQYXRoRWxlbWVudDo6Y2hpbGRTaG91bGRD cmVhdGVSZW5kZXJlcihOb2RlKiBjaGlsZCkgY29uc3QKIHsKICAgICBpZiAoY2hpbGQtPmlzVGV4 dE5vZGUoKQotI2lmIEVOQUJMRShTVkdfRk9OVFMpCiAgICAgICAgIHx8IGNoaWxkLT5oYXNUYWdO YW1lKFNWR05hbWVzOjphbHRHbHlwaFRhZykKLSNlbmRpZgogICAgICAgICB8fCBjaGlsZC0+aGFz VGFnTmFtZShTVkdOYW1lczo6dHJlZlRhZykgfHwgY2hpbGQtPmhhc1RhZ05hbWUoU1ZHTmFtZXM6 OnRzcGFuVGFnKSB8fCBjaGlsZC0+aGFzVGFnTmFtZShTVkdOYW1lczo6dGV4dFBhdGhUYWcpKQog ICAgICAgICByZXR1cm4gdHJ1ZTsKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9zdmcvU1ZHVXNlRWxl bWVudC5jcHAgYi9XZWJDb3JlL3N2Zy9TVkdVc2VFbGVtZW50LmNwcAppbmRleCAxN2I0MjEyNmZm YmQ2MmNhY2E1ZGM0Yjk3ZWUzYzYxZTc2ZGIzOTQwLi5lMDljZGFkMmU0NThhNzAwYTc2NzIxYzFl OTllZTg5MTg2ZDhkYzA1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3N2Zy9TVkdVc2VFbGVtZW50LmNw cAorKysgYi9XZWJDb3JlL3N2Zy9TVkdVc2VFbGVtZW50LmNwcApAQCAtMzgxLDExICszODEsMTAg QEAgdm9pZCBkdW1wSW5zdGFuY2VUcmVlKHVuc2lnbmVkIGludCYgZGVwdGgsIFN0cmluZyYgdGV4 dCwgU1ZHRWxlbWVudEluc3RhbmNlKiB0YXIKIAogc3RhdGljIGJvb2wgaXNEaXNhbGxvd2VkRWxl bWVudChOb2RlKiBlbGVtZW50KQogewotI2lmIEVOQUJMRShTVkdfRk9SRUlHTl9PQkpFQ1QpCi0g ICAgLy8gPGZvcmVpZ25PYmplY3Q+IHNob3VsZCBuZXZlciBiZSBjb250YWluZWQgaW4gYSA8dXNl PiB0cmVlLiBUb28gZGFuZ2Vyb3VzIHNpZGUgZWZmZWN0cyBwb3NzaWJsZS4KKyAgICAvLyBEaXNh bGxvdyA8Zm9yZWlnbk9iamVjdD4gaW4gYSA8dXNlPiB0cmVlLiAgQWxsb3dpbmcgc3VjaAorICAg IC8vIGNhbiBjb25mdXNlIEhUTUwgcmVuZGVyaW5nIGNvZGUgYW5kIGNhdXNlIGNyYXNoZXMuCiAg ICAgaWYgKGVsZW1lbnQtPmhhc1RhZ05hbWUoU1ZHTmFtZXM6OmZvcmVpZ25PYmplY3RUYWcpKQog ICAgICAgICByZXR1cm4gdHJ1ZTsKLSNlbmRpZgogI2lmIEVOQUJMRShTVkdfQU5JTUFUSU9OKQog ICAgIGlmIChTVkdTTUlMRWxlbWVudDo6aXNTTUlMRWxlbWVudChlbGVtZW50KSkKICAgICAgICAg cmV0dXJuIHRydWU7CkBAIC04OTMsNyArODkyLDcgQEAgdm9pZCBTVkdVc2VFbGVtZW50Ojphc3Nv Y2lhdGVJbnN0YW5jZXNXaXRoU2hhZG93VHJlZUVsZW1lbnRzKE5vZGUqIHRhcmdldCwgU1ZHRWwK ICNlbmRpZgogICAgIH0gZWxzZSBpZiAob3JpZ2luYWxFbGVtZW50LT5oYXNUYWdOYW1lKFNWR05h bWVzOjpzeW1ib2xUYWcpKSB7CiAgICAgICAgIC8vIDxzeW1ib2w+IGdldHMgcmVwbGFjZWQgYnkg PHN2Zz4KLSNpZiBFTkFCTEUoU1ZHKSAmJiBFTkFCTEUoU1ZHX1VTRSkgJiYgRU5BQkxFKFNWR19G T1JFSUdOX09CSkVDVCkKKyNpZiBFTkFCTEUoU1ZHKSAmJiBFTkFCTEUoU1ZHX1VTRSkKICAgICAg ICAgQVNTRVJUKHRhcmdldC0+bm9kZU5hbWUoKSA9PSBTVkdOYW1lczo6c3ZnVGFnKTsKICNlbmRp ZgogICAgIH0gZWxzZQo=