41429 2010-06-30 14:25:00 -0700 Buildfix for !ENABLE(SVG_FOREIGN_OBJECT) 2010-06-30 16:10:08 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 paroga webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 244943 0 paroga 2010-06-30 14:25:00 -0700 see patch 244944 1 60153 paroga 2010-06-30 14:26:35 -0700 Created attachment 60153 Patch 244946 2 webkit.review.bot 2010-06-30 14:28:14 -0700 Attachment 60153 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/HTMLElementStack.cpp:165: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 244968 3 abarth 2010-06-30 15:22:26 -0700 We'll need to think about how to handle this case. Our parsing of a page shoudn't be different based on the value of that define. 244969 4 eric 2010-06-30 15:24:10 -0700 SVGNames should aways define foreignObject, even when it's not compiled in. This is the wrong fix. 244970 5 eric 2010-06-30 15:24:32 -0700 (In reply to comment #4) > SVGNames should aways define foreignObject, even when it's not compiled in. This is the wrong fix. even when support for foreignObject is not compiled in I mean. 244971 6 60153 commit-queue 2010-06-30 15:25:03 -0700 Comment on attachment 60153 Patch Clearing flags on attachment: 60153 Committed r62208: <http://trac.webkit.org/changeset/62208> 244972 7 commit-queue 2010-06-30 15:25:08 -0700 All reviewed patches have been landed. Closing bug. 244985 8 eric 2010-06-30 16:10:08 -0700 Filed bug 41433 for the proper fix. 60153 2010-06-30 14:26:35 -0700 2010-06-30 15:25:03 -0700 Patch bug-41429.patch text/plain 1138 paroga SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDYyMjAwKQ0KKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp DQpAQCAtMSwzICsxLDEyIEBADQorMjAxMC0wNi0zMCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJv Z2FAcGFyb2dhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBCdWlsZGZpeCBmb3IgIUVOQUJMRShTVkdfRk9SRUlHTl9PQkpFQ1QpIGFmdGVyIHI2 MjE5Ni4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQx NDI5CisKKyAgICAgICAgKiBodG1sL0hUTUxFbGVtZW50U3RhY2suY3BwOgorCiAyMDEwLTA2LTMw ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBH dXN0YXZvIE5vcm9uaGEuCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnRTdGFjay5jcHAN Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0NCi0tLSBXZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnRTdGFjay5jcHAJKHJldmlz aW9uIDYyMjAwKQ0KKysrIFdlYkNvcmUvaHRtbC9IVE1MRWxlbWVudFN0YWNrLmNwcAkod29ya2lu ZyBjb3B5KQ0KQEAgLTE1OSw3ICsxNTksMTAgQEANCiAgICAgICAgIHx8IGVsZW1lbnQtPmhhc1Rh Z05hbWUoYnV0dG9uVGFnKQogICAgICAgICB8fCBlbGVtZW50LT5oYXNUYWdOYW1lKG1hcnF1ZWVU YWcpCiAgICAgICAgIHx8IGVsZW1lbnQtPmhhc1RhZ05hbWUob2JqZWN0VGFnKQotICAgICAgICB8 fCBlbGVtZW50LT5oYXNUYWdOYW1lKFNWR05hbWVzOjpmb3JlaWduT2JqZWN0VGFnKTsKKyNpZiBF TkFCTEUoU1ZHX0ZPUkVJR05fT0JKRUNUKQorICAgICAgICB8fCBlbGVtZW50LT5oYXNUYWdOYW1l KFNWR05hbWVzOjpmb3JlaWduT2JqZWN0VGFnKQorI2VuZGlmCisgICAgICAgIDsKIH0KIAogaW5s aW5lIGJvb2wgaXNMaXN0SXRlbVNjb3BlTWFya2VyKGNvbnN0IEVsZW1lbnQqIGVsZW1lbnQpCg==