41420 2010-06-30 10:34:11 -0700 Canvas: arc() with startAngle == endAngle shouldn't add to the path 2010-07-12 05:17:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED HTML5 P2 Normal --- 1 kling webkit-unassigned commit-queue mdelaney7 oldest_to_newest 244834 0 kling 2010-06-30 10:34:11 -0700 Quoth HTML5: "Zero-length line segments must be pruned before stroking a path. Empty subpaths must be ignored." This would fix one in-tree test: * canvas/philip/tests/2d.path.stroke.prune.arc.html Spec link: http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-stroke 244838 1 60131 kling 2010-06-30 10:38:34 -0700 Created attachment 60131 Proposed patch 244862 2 60131 commit-queue 2010-06-30 11:34:43 -0700 Comment on attachment 60131 Proposed patch Rejecting patch 60131 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: iling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found Testing 19237 test cases. canvas/philip/tests/2d.path.stroke.prune.arc.html -> failed Exiting early after 1 failures. 551 tests run. 31.37s total testing time 550 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3354269 244870 3 60139 kling 2010-06-30 11:50:52 -0700 Created attachment 60139 Proposed patch v2 Only unskip test on Qt, test also uses arcTo() which isn't up-to-spec on Mac I guess. Unfortunately I can't verify that since I don't have a Mac dev env handy. The missing logic as implemented in Qt's Path::addArcTo(): FloatPoint p0(m_path.currentPosition()); if ((p1.x() == p0.x() && p1.y() == p0.y()) || (p1.x() == p2.x() && p1.y() == p2.y()) || radius == 0.f) { m_path.lineTo(p1); return; } 245240 4 60131 eric 2010-07-01 03:17:10 -0700 Comment on attachment 60131 Proposed patch Cleared Darin Adler's review+ from obsolete attachment 60131 so that this bug does not appear in http://webkit.org/pending-commit. 249763 5 60139 commit-queue 2010-07-12 05:17:50 -0700 Comment on attachment 60139 Proposed patch v2 Clearing flags on attachment: 60139 Committed r63073: <http://trac.webkit.org/changeset/63073> 249764 6 commit-queue 2010-07-12 05:17:55 -0700 All reviewed patches have been landed. Closing bug. 60131 2010-06-30 10:38:34 -0700 2010-07-01 03:17:10 -0700 Proposed patch bug-41420.diff text/plain 3421 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxYjA2NWE0Li5jZmUzMjU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjIgQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBDYW52YXM6IGFyYygpIHdp dGggc3RhcnRBbmdsZSA9PSBlbmRBbmdsZSBzaG91bGRuJ3QgYWRkIHRvIHRoZSBwYXRoCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTQyMAorCisgICAg ICAgIFVuc2tpcCB0ZXN0IHRoYXQgbm93IHBhc3NlczoKKyAgICAgICAgLSBjYW52YXMvcGhpbGlw L3Rlc3RzLzJkLnBhdGguc3Ryb2tlLnBydW5lLmFyYy5odG1sCisKKyAgICAgICAgU3BlYyBsaW5r OgorICAgICAgICBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13 b3JrLyNkb20tY29udGV4dC0yZC1zdHJva2UKKworICAgICAgICAqIHBsYXRmb3JtL21hYy9Ta2lw cGVkOgorICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisKKzIwMTAtMDYtMzAgIEFuZHJl YXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBbUXRdIENhbnZhcyBhcmNUbygpIHNob3VsZCBk cmF3IHN0cmFpZ2h0IGxpbmUgdG8gcDEgaWYgcDAsIHAxIGFuZCBwMiBhcmUgY29sbGluZWFyCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTQxMgogCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZCBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL21hYy9Ta2lwcGVkCmluZGV4IDE4NWIwZjEuLjI5YjZmOWEgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9Ta2lwcGVkCkBAIC0yMzYsNyArMjM2LDYgQEAgY2FudmFzL3BoaWxpcC90ZXN0cy8y ZC5wYXRoLmNsaXAuZW1wdHkuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLnF1YWRy YXRpY0N1cnZlVG8uZW5zdXJlc3VicGF0aC4yLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQu cGF0aC5yZWN0LndpbmRpbmcuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLnJlY3Qu emVyby40Lmh0bWwKLWNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5zdHJva2UucHJ1bmUuYXJj Lmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5zdHJva2UucHJ1bmUuY2xvc2VkLmh0 bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5zdHJva2UucHJ1bmUuY3VydmUuaHRtbAog Y2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLnN0cm9rZS5wcnVuZS5saW5lLmh0bWwKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC9Ta2lwcGVkCmluZGV4IGM5YjZkYjAuLjBiYzViZTMgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQv U2tpcHBlZApAQCAtNTI3OSw3ICs1Mjc5LDYgQEAgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRo LnF1YWRyYXRpY0N1cnZlVG8uc2hhcGUuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRo LnJlY3Qud2luZGluZy5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdGgucmVjdC56ZXJv LjQuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLnJlY3QuemVyby42Lmh0bWwKLWNh bnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5zdHJva2UucHJ1bmUuYXJjLmh0bWwKIGNhbnZhcy9w aGlsaXAvdGVzdHMvMmQucGF0aC5zdHJva2Uuc2NhbGUyLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVz dHMvMmQucGF0dGVybi5pbWFnZS5icm9rZW4uaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5w YXR0ZXJuLmltYWdlLmluY29tcGxldGUuaHRtbApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyYWYxOTFhLi4wNDY5M2NhIDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMiw2ICsyLDE5 IEBACiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAKKyAgICAgICAgQ2Fu dmFzOiBhcmMoKSB3aXRoIHN0YXJ0QW5nbGUgPT0gZW5kQW5nbGUgc2hvdWxkbid0IGFkZCB0byB0 aGUgcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDE0MjAKKworICAgICAgICBTcGVjIGxpbms6CisgICAgICAgIGh0dHA6Ly93d3cud2hhdHdnLm9y Zy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsvI2RvbS1jb250ZXh0LTJkLXN0cm9rZQorCisg ICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6YXJjKToKKworMjAxMC0wNi0z MCAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFtRdF0gQ2FudmFzIGFyY1RvKCkg c2hvdWxkIGRyYXcgc3RyYWlnaHQgbGluZSB0byBwMSBpZiBwMCwgcDEgYW5kIHAyIGFyZSBjb2xs aW5lYXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQx NDEyCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29u dGV4dDJELmNwcCBiL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJE LmNwcAppbmRleCBiNjI2N2Y3Li44NDRkNzI2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvY2Fu dmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL2NhbnZh cy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCkBAIC02MTUsNiArNjE1LDEwIEBAIHZvaWQg Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjphcmMoZmxvYXQgeCwgZmxvYXQgeSwgZmxvYXQgciwg ZmxvYXQgc2EsIGZsb2F0IGVhCiAgICAgICAgIGVjID0gSU5ERVhfU0laRV9FUlI7CiAgICAgICAg IHJldHVybjsKICAgICB9CisKKyAgICBpZiAoc2EgPT0gZWEpCisgICAgICAgIHJldHVybjsKKwog ICAgIGlmICghc3RhdGUoKS5tX2ludmVydGlibGVDVE0pCiAgICAgICAgIHJldHVybjsKICAgICBt X3BhdGguYWRkQXJjKEZsb2F0UG9pbnQoeCwgeSksIHIsIHNhLCBlYSwgYW50aWNsb2Nrd2lzZSk7 Cg== 60139 2010-06-30 11:50:52 -0700 2010-07-12 05:17:50 -0700 Proposed patch v2 bug-41420-v2.diff text/plain 2579 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZjhkODA4Li5kNzE3YjBmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDYt MzAgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYW52YXM6IGFyYygpIHdpdGgg c3RhcnRBbmdsZSA9PSBlbmRBbmdsZSBzaG91bGRuJ3QgYWRkIHRvIHRoZSBwYXRoCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MTQyMAorCisgICAgICAg IFVuc2tpcCAoZm9yIFF0KSB0ZXN0IHRoYXQgbm93IHBhc3NlczoKKyAgICAgICAgLSBjYW52YXMv cGhpbGlwL3Rlc3RzLzJkLnBhdGguc3Ryb2tlLnBydW5lLmFyYy5odG1sCisKKyAgICAgICAgU3Bl YyBsaW5rOgorICAgICAgICBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3Vy cmVudC13b3JrLyNkb20tY29udGV4dC0yZC1zdHJva2UKKworICAgICAgICAqIHBsYXRmb3JtL3F0 L1NraXBwZWQ6CisKIDIwMTAtMDYtMzAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RA Z21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI2MjE4Mi4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4IGMzMjlkZWUuLmExYjljZjIgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvU2tpcHBlZApAQCAtNTI4MSw3ICs1MjgxLDYgQEAgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5w YXRoLnF1YWRyYXRpY0N1cnZlVG8uc2hhcGUuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5w YXRoLnJlY3Qud2luZGluZy5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdGgucmVjdC56 ZXJvLjQuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXRoLnJlY3QuemVyby42Lmh0bWwK LWNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5zdHJva2UucHJ1bmUuYXJjLmh0bWwKIGNhbnZh cy9waGlsaXAvdGVzdHMvMmQucGF0aC5zdHJva2Uuc2NhbGUyLmh0bWwKIGNhbnZhcy9waGlsaXAv dGVzdHMvMmQucGF0dGVybi5pbWFnZS5icm9rZW4uaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8y ZC5wYXR0ZXJuLmltYWdlLmluY29tcGxldGUuaHRtbApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFu Z2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmNjQyZWNlLi5mNjIzZjgxIDEwMDY0NAot LS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEwLTA2LTMwICBBbmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2Fu dmFzOiBhcmMoKSB3aXRoIHN0YXJ0QW5nbGUgPT0gZW5kQW5nbGUgc2hvdWxkbid0IGFkZCB0byB0 aGUgcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDE0MjAKKworICAgICAgICBTcGVjIGxpbms6CisgICAgICAgIGh0dHA6Ly93d3cud2hhdHdnLm9y Zy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsvI2RvbS1jb250ZXh0LTJkLXN0cm9rZQorCisg ICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6YXJjKToKKwogMjAxMC0wNi0z MCAgVmljdG9yIFdhbmcgIDx2aWN0b3J3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZh c1JlbmRlcmluZ0NvbnRleHQyRC5jcHAgYi9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRl cmluZ0NvbnRleHQyRC5jcHAKaW5kZXggYjYyNjdmNy4uODQ0ZDcyNiAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCisrKyBiL1dlYkNv cmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcApAQCAtNjE1LDYgKzYx NSwxMCBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6YXJjKGZsb2F0IHgsIGZsb2F0 IHksIGZsb2F0IHIsIGZsb2F0IHNhLCBmbG9hdCBlYQogICAgICAgICBlYyA9IElOREVYX1NJWkVf RVJSOwogICAgICAgICByZXR1cm47CiAgICAgfQorCisgICAgaWYgKHNhID09IGVhKQorICAgICAg ICByZXR1cm47CisKICAgICBpZiAoIXN0YXRlKCkubV9pbnZlcnRpYmxlQ1RNKQogICAgICAgICBy ZXR1cm47CiAgICAgbV9wYXRoLmFkZEFyYyhGbG9hdFBvaW50KHgsIHkpLCByLCBzYSwgZWEsIGFu dGljbG9ja3dpc2UpOwo=