4142 2005-07-26 11:06:56 -0700 Date object does not always adjust daylight savings correctly 2005-10-24 13:45:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 412 Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 carsten ggaren ggaren staikos oldest_to_newest 15202 0 carsten 2005-07-26 11:06:56 -0700 This will fix ecma/Date/15.9.4.3.js ecma/Date/15.9.5.28-1.js There seems to be a problem with daylight savings when a time change crosses the daylight savings start/ end dates. 15204 1 ggaren 2005-07-26 11:15:11 -0700 (In reply to comment #0) FYI, Mac IE has the same problem. Win IE and Mac FF don't. 21276 2 staikos 2005-10-03 12:35:01 -0700 Adding this before the return in KJS::makeTime() fixes it for me: // Determine if we passed over a DST change boundary if (!utc) { time_t tval = mktime(t) + utcOffset + int((ms + yearOffset)/1000); struct tm t3; localtime_r(&tval, &t3); t->tm_isdst = t3.tm_isdst; } Does not seem to introduce any regressions. I am a bit worried about overflow and rounding though. It might break down very close to the changeover period. 21629 3 4271 ggaren 2005-10-09 14:58:00 -0700 Created attachment 4271 Patch Implemented George's suggestion. 21634 4 4271 darin 2005-10-09 16:00:35 -0700 Comment on attachment 4271 Patch What's the rationale for calling the local variable "t3"? The FIXME says "on some systems", but this will happen on all systems; there's no system where time_t has enough range to include all the years we want our function to handle. So I suggest re-wording it. Otherwise, looks fine. 21751 5 staikos 2005-10-10 15:47:43 -0700 There is already a t and a t2, and although t3 wasn't perhaps the best sequel, I didn't see fit to leave it out. :-) And yes, "all systems" is correct. I don't know if it's a realistic problem to put more effort into at this time though. 22834 6 sullivan 2005-10-24 13:45:37 -0700 I checked this in. It did fix ecma/Date/15.9.5.28-1.js, but ecma/Date/15.9.4.3.js was apparently fixed by some earlier checkin. 4271 2005-10-09 14:58:00 -0700 2005-10-09 16:00:35 -0700 Patch patch-dst.txt text/plain 957 ggaren SW5kZXg6IGtqcy9kYXRlX29iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290 L0phdmFTY3JpcHRDb3JlL2tqcy9kYXRlX29iamVjdC5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuNTkKZGlmZiAtdSAtcjEuNTkgZGF0ZV9vYmplY3QuY3BwCi0tLSBranMvZGF0ZV9vYmplY3Qu Y3BwCTQgT2N0IDIwMDUgMDE6NDM6NTggLTAwMDAJMS41OQorKysga2pzL2RhdGVfb2JqZWN0LmNw cAk5IE9jdCAyMDA1IDIxOjU4OjQzIC0wMDAwCkBAIC0xMDI4LDYgKzEwMjgsMTcgQEAKICAgICAg IHQtPnRtX3llYXIgPSBiYXNlWWVhciAtIDE5MDA7CiAgICAgfQogCisgICAgLy8gRGV0ZXJtaW5l IHdoZXRoZXIgRFNUIGlzIGluIGVmZmVjdC4gbWt0aW1lKCkgY2FuJ3QgZG8gdGhpcyBmb3IgdXMg YmVjYXVzZQorICAgIC8vIGl0IGRvZXNuJ3Qga25vdyBhYm91dCBtcyBhbmQgeWVhck9mZnNldC4K KyAgICAvLyBGSVhNRTogT24gc29tZSBzeXN0ZW1zLCBjYXN0aW5nIHZhbHVlcyBvZiBsYXJnZSBt YWduaXR1ZGUgdG8gdGltZV90IChsb25nKSB3aWxsIAorICAgIC8vIHByb2R1Y2UgaW5jb3JyZWN0 IHJlc3VsdHMsIGJ1dCB0aGVyZSdzIG5vIG90aGVyIG9wdGlvbiB3aGVuIGNhbGxpbmcgbG9jYWx0 aW1lX3IoKS4KKyAgICBpZiAoIXV0YykgeyAKKyAgICAgIHRpbWVfdCB0dmFsID0gbWt0aW1lKHQp ICsgKHRpbWVfdCkoKG1zICsgeWVhck9mZnNldCkgLyAxMDAwKTsgIAorICAgICAgc3RydWN0IHRt IHQzOyAgCisgICAgICBsb2NhbHRpbWVfcigmdHZhbCwgJnQzKTsgIAorICAgICAgdC0+dG1faXNk c3QgPSB0My50bV9pc2RzdDsgIAorICAgIH0KKyAgICAKICAgICByZXR1cm4gKG1rdGltZSh0KSAr IHV0Y09mZnNldCkgKiAxMDAwLjAgKyBtcyArIHllYXJPZmZzZXQ7CiB9CiAK