41412 2010-06-30 09:29:28 -0700 [Qt] Canvas arcTo() should draw straight line to p1 if p0, p1 and p2 are collinear 2010-07-02 08:39:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All CLOSED FIXED HTML5, Qt, QtTriaged P2 Normal --- 35784 1 kling webkit-unassigned hausmann mdelaney7 webkit.review.bot oldest_to_newest 244806 0 kling 2010-06-30 09:29:28 -0700 If p0, p1 and p2 are all points on a single straight line, arcTo() should draw a straight line from p0 to p1. Spec link: http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arcto This fixes two in-tree tests: * canvas/philip/tests/2d.path.arcTo.collinear.2.html * canvas/philip/tests/2d.path.arcTo.collinear.3.html 244810 1 60126 kling 2010-06-30 09:32:25 -0700 Created attachment 60126 Proposed patch 244811 2 webkit.review.bot 2010-06-30 09:34:11 -0700 Attachment 60126 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/graphics/qt/PathQt.cpp:209: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 245449 3 kling 2010-07-01 11:40:00 -0700 Relevant part of HTML5 spec: "... if the points (x0, y0), (x1, y1), and (x2, y2) all lie on a single straight line, then the method must add the point (x1, y1) to the subpath, and connect that point to the previous point (x0, y0) by a straight line." Note that p0 (or (x0, x0)) here refers to the last point in the current subpath. 245464 4 60126 vestbo 2010-07-01 12:05:56 -0700 Comment on attachment 60126 Proposed patch LGTM 245474 5 60126 vestbo 2010-07-01 12:21:39 -0700 Comment on attachment 60126 Proposed patch r- for now until we can verify the collinar() 245909 6 vestbo 2010-07-02 07:26:42 -0700 Fix for this is coming, preparing patch 245917 7 vestbo 2010-07-02 08:24:29 -0700 Landed in http://trac.webkit.org/changeset/62383 245919 8 hausmann 2010-07-02 08:34:14 -0700 <cherry-pick-for-backport: r62383> 245921 9 hausmann 2010-07-02 08:38:51 -0700 Revision r62383 cherry-picked into qtwebkit-2.0 with commit 13b5b7048431a554e48c4b28235cf206c6a08bf5 60126 2010-06-30 09:32:25 -0700 2010-07-01 12:21:39 -0700 Proposed patch bug-41412.diff text/plain 3362 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZjhkODA4Li4xYjA2NWE0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDYt MzAgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIENhbnZhcyBhcmNUbygp IHNob3VsZCBkcmF3IHN0cmFpZ2h0IGxpbmUgdG8gcDEgaWYgcDAsIHAxIGFuZCBwMiBhcmUgY29s bGluZWFyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MTQxMgorCisgICAgICAgIFVuc2tpcCB0d28gdGVzdHMgdGhhdCBub3cgcGFzczoKKyAgICAgICAg LSBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdGguYXJjVG8uY29sbGluZWFyLjIuaHRtbAorICAg ICAgICAtIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5hcmNUby5jb2xsaW5lYXIuMy5odG1s CisKKyAgICAgICAgU3BlYyBsaW5rOgorICAgICAgICBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3Bl Y3Mvd2ViLWFwcHMvY3VycmVudC13b3JrLyNkb20tY29udGV4dC0yZC1hcmN0bworCisgICAgICAg ICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKwogMjAxMC0wNi0zMCAgU2hlcmlmZiBCb3QgIDx3ZWJr aXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjYyMTgyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBi L0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKaW5kZXggYzMyOWRlZS4uYzliNmRiMCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCkBAIC01MjcyLDggKzUyNzIsNiBAQCBjYW52YXMvcGhp bGlwL3Rlc3RzLzJkLmxpbmUuam9pbi5wYXJhbGxlbC5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3Rz LzJkLmxpbmUubWl0ZXIubGluZWVkZ2UuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5taXNz aW5nYXJncy5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdGguYXJjLnR3b3BpZS4zLmh0 bWwKLWNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5hcmNUby5jb2xsaW5lYXIuMi5odG1sCi1j YW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdGguYXJjVG8uY29sbGluZWFyLjMuaHRtbAogY2FudmFz L3BoaWxpcC90ZXN0cy8yZC5wYXRoLmJlemllckN1cnZlVG8uZW5zdXJlc3VicGF0aC4yLmh0bWwK IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQucGF0aC5xdWFkcmF0aWNDdXJ2ZVRvLmVuc3VyZXN1YnBh dGguMi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBhdGgucXVhZHJhdGljQ3VydmVUby5z Y2FsZWQuaHRtbApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCAxOTE1ZDM0Li44MTY4MDBlIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEwLTA2LTMwICBB bmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBDYW52YXMgYXJjVG8oKSBzaG91 bGQgZHJhdyBzdHJhaWdodCBsaW5lIHRvIHAxIGlmIHAwLCBwMSBhbmQgcDIgYXJlIGNvbGxpbmVh cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE0MTIK KworICAgICAgICBTcGVjIGxpbms6CisgICAgICAgIGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVj cy93ZWItYXBwcy9jdXJyZW50LXdvcmsvI2RvbS1jb250ZXh0LTJkLWFyY3RvCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9QYXRoUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YXJl Q29sbGluZWFyKToKKyAgICAgICAgKFdlYkNvcmU6OlBhdGg6OmFkZEFyY1RvKToKKwogMjAxMC0w Ni0zMCAgSmVyZW15IE1vc2tvdmljaCAgPGplcmVteUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvUGF0aFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvUGF0 aFF0LmNwcAppbmRleCA4ZjFmOTEyLi41Zjg3NzhkIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3F0L1BhdGhRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9xdC9QYXRoUXQuY3BwCkBAIC0xODgsNiArMTg4LDExIEBAIHZvaWQgUGF0aDo6YWRkQmV6aWVy Q3VydmVUbyhjb25zdCBGbG9hdFBvaW50JiBjcDEsIGNvbnN0IEZsb2F0UG9pbnQmIGNwMiwgY29u c3QKICAgICBtX3BhdGguY3ViaWNUbyhjcDEsIGNwMiwgcCk7CiB9CiAKK3N0YXRpYyBib29sIGFy ZUNvbGxpbmVhcihjb25zdCBGbG9hdFBvaW50JiBhLCBjb25zdCBGbG9hdFBvaW50JiBiLCBjb25z dCBGbG9hdFBvaW50JiBjKQoreworICAgIHJldHVybiAoYi54KCkgLSBhLngoKSkgKiAoYy55KCkg LSBhLnkoKSkgPT0gKGMueCgpIC0gYS54KCkpICogKGIueSgpIC0gYS55KCkpOworfQorCiB2b2lk IFBhdGg6OmFkZEFyY1RvKGNvbnN0IEZsb2F0UG9pbnQmIHAxLCBjb25zdCBGbG9hdFBvaW50JiBw MiwgZmxvYXQgcmFkaXVzKQogewogICAgIC8vIE1ha2Ugc3VyZSB0aGVyZSBpcyBhIHN1YnBhdGgg Zm9yIHAxLCB0aGUgYmVoYXZpb3IgZGVwZW5kIG9uIHRoZSBsYXN0IGVsZW1lbnQgb2YgdGhlIHN1 YnBhdGguCkBAIC0yMDEsNyArMjA2LDcgQEAgdm9pZCBQYXRoOjphZGRBcmNUbyhjb25zdCBGbG9h dFBvaW50JiBwMSwgY29uc3QgRmxvYXRQb2ludCYgcDIsIGZsb2F0IHJhZGl1cykKIAogICAgIEZs b2F0UG9pbnQgcDAobV9wYXRoLmN1cnJlbnRQb3NpdGlvbigpKTsKIAotICAgIGlmICgocDEueCgp ID09IHAwLngoKSAmJiBwMS55KCkgPT0gcDAueSgpKSB8fCAocDEueCgpID09IHAyLngoKSAmJiBw MS55KCkgPT0gcDIueSgpKSB8fCByYWRpdXMgPT0gMC5mKSB7CisgICAgaWYgKChwMS54KCkgPT0g cDAueCgpICYmIHAxLnkoKSA9PSBwMC55KCkpIHx8IChwMS54KCkgPT0gcDIueCgpICYmIHAxLnko KSA9PSBwMi55KCkpIHx8IHJhZGl1cyA9PSAwLmYgfHwgYXJlQ29sbGluZWFyKHAwLCBwMSwgcDIp KSB7CiAgICAgICAgIG1fcGF0aC5saW5lVG8ocDEpOwogICAgICAgICByZXR1cm47CiAgICAgfQo=