41407 2010-06-30 06:43:30 -0700 [Qt] Make "disallow multiple calls to SetWindow" on windowed plugins a quirk 2010-07-18 14:16:01 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All Linux RESOLVED FIXED Qt, QtTriaged P2 Normal --- 40879 1 kling webkit-unassigned commit-queue reethu.j oldest_to_newest 244752 0 kling 2010-06-30 06:43:30 -0700 Right now, we disallow more than one call to SetWindow on plugins since Flash used to crash if not running on top of Gtk+. Gtk+ unnecessarily copied this logic from PluginViewQt.cpp 244754 1 60116 kling 2010-06-30 06:53:53 -0700 Created attachment 60116 Proposed patch 244773 2 60116 kenneth 2010-06-30 07:59:37 -0700 Comment on attachment 60116 Proposed patch PluginViewQt should really have Linux in its name :-) 244778 3 60116 commit-queue 2010-06-30 08:16:36 -0700 Comment on attachment 60116 Proposed patch Clearing flags on attachment: 60116 Committed r62185: <http://trac.webkit.org/changeset/62185> 244779 4 commit-queue 2010-06-30 08:16:40 -0700 All reviewed patches have been landed. Closing bug. 253002 5 kling 2010-07-18 14:16:01 -0700 *** Bug 41037 has been marked as a duplicate of this bug. *** 60116 2010-06-30 06:53:53 -0700 2010-06-30 08:16:35 -0700 Proposed patch bug-41407.diff text/plain 4772 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTk4MmQxOS4uZDU2YjFkYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyOCBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIFtRdF0gTWFrZSAiZGlzYWxsb3cgbXVsdGlwbGUgY2Fs bHMgdG8gU2V0V2luZG93IiBvbiB3aW5kb3dlZCBwbHVnaW5zIGEgcXVpcmsKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNDA3CisKKyAgICAgICAgT25s eSBkaXNhbGxvdyBjYWxsaW5nIFNldFdpbmRvdyBtb3JlIHRoYW4gb25jZSBpZiB3ZSdyZSB1c2lu ZyBGbGFzaCA5IG9yIG9sZGVyLgorICAgICAgICBUaGlzIGZpeGVzIHJlc2l6aW5nIG9mIFlvdVR1 YmUgdmlkZW9zIHZpYSB0aGUgcGxheWVyJ3Mgb3duIGJ1dHRvbi4KKworICAgICAgICBSZW1vdmVk IGNvcHktcGFzdGVkIGxvZ2ljIGluIFBsdWdpblZpZXdHdGsgc2luY2UgdGhlIGlzc3VlIG9ubHkg ZXhpc3RzCisgICAgICAgIHdoZW4gcnVubmluZyBGbGFzaCB3aXRoIGEgbm9uLUd0ayB0b29sa2l0 LgorCisgICAgICAgICogcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlBsdWdpblBhY2thZ2U6OmRldGVybWluZVF1aXJrcyk6CisgICAgICAgICogcGx1Z2lucy9Q bHVnaW5RdWlya1NldC5oOgorICAgICAgICAoV2ViQ29yZTo6KToKKyAgICAgICAgKiBwbHVnaW5z L2d0ay9QbHVnaW5WaWV3R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnNl dE5QV2luZG93SWZOZWVkZWQpOiBSZW1vdmUgdW5uZWNlc3NhcnkgbG9naWMgY29weS1wYXN0ZWQg ZnJvbSBQbHVnaW5WaWV3UXQuCisgICAgICAgICogcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6c2V0TlBXaW5kb3dJZk5lZWRlZCk6CisK KzIwMTAtMDYtMzAgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBbUXQsIEd0aywg U3ltYmlhbl0gTWluZCB0aGUgc2VtYW50aWNzIG9mIE5QUmVjdCBmb3Igd2luZG93ZWQgcGx1Z2lu IGNsaXAgcmVjdHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQxNDA2CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNw cCBiL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcAppbmRleCBjOWUxOWJiLi4yOTVl YTFkIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAKKysrIGIv V2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwCkBAIC0xODksNiArMTg5LDEwIEBAIHZv aWQgUGx1Z2luUGFja2FnZTo6ZGV0ZXJtaW5lUXVpcmtzKGNvbnN0IFN0cmluZyYgbWltZVR5cGUp CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAvLyBGbGFzaCA5IGFuZCBvbGRlciByZXF1 ZXN0cyB3aW5kb3dsZXNzIHBsdWdpbnMgaWYgd2UgcmV0dXJuIGEgbW96aWxsYSB1c2VyIGFnZW50 CiAgICAgICAgICAgICBtX3F1aXJrcy5hZGQoUGx1Z2luUXVpcmtXYW50c01vemlsbGFVc2VyQWdl bnQpOworI2lmIFBMQVRGT1JNKFFUKQorICAgICAgICAgICAgLy8gRmxhc2ggOSBhbmQgb2xkZXIg d291bGQgY3Jhc2ggb24gcmVwZWF0ZWQgY2FsbHMgdG8gU2V0V2luZG93IGluIHdpbmRvd2VkIG1v ZGUKKyAgICAgICAgICAgIG1fcXVpcmtzLmFkZChQbHVnaW5RdWlya0RvbnRDYWxsU2V0V2luZG93 TW9yZVRoYW5PbmNlKTsKKyNlbmRpZgogICAgICAgICB9CiAKICAgICAgICAgbV9xdWlya3MuYWRk KFBsdWdpblF1aXJrVGhyb3R0bGVJbnZhbGlkYXRlKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1 Z2lucy9QbHVnaW5RdWlya1NldC5oIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblF1aXJrU2V0LmgK aW5kZXggZGUyOWJhZi4uN2Y1MmY2YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL1BsdWdp blF1aXJrU2V0LmgKKysrIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblF1aXJrU2V0LmgKQEAgLTQ2 LDcgKzQ2LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBQbHVnaW5RdWlya0RvbnRT ZXROdWxsV2luZG93SGFuZGxlT25EZXN0cm95ID0gMSA8PCAxMCwKICAgICAgICAgUGx1Z2luUXVp cmtEb250QWxsb3dNdWx0aXBsZUluc3RhbmNlcyA9IDEgPDwgMTEsCiAgICAgICAgIFBsdWdpblF1 aXJrUmVxdWlyZXNHdGtUb29sS2l0ID0gMSA8PCAxMiwKLSAgICAgICAgUGx1Z2luUXVpcmtSZXF1 aXJlc0RlZmF1bHRTY3JlZW5EZXB0aCA9IDEgPDwgMTMKKyAgICAgICAgUGx1Z2luUXVpcmtSZXF1 aXJlc0RlZmF1bHRTY3JlZW5EZXB0aCA9IDEgPDwgMTMsCisgICAgICAgIFBsdWdpblF1aXJrRG9u dENhbGxTZXRXaW5kb3dNb3JlVGhhbk9uY2UgPSAxIDw8IDE0CiAgICAgfTsKIAogICAgIGNsYXNz IFBsdWdpblF1aXJrU2V0IHsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2lu Vmlld0d0ay5jcHAgYi9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCmluZGV4 IDE0ZTYxNTQuLjc4YzY2MzYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2lu Vmlld0d0ay5jcHAKKysrIGIvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcApA QCAtNTIyLDYgKzUyMiw4IEBAIHZvaWQgUGx1Z2luVmlldzo6c2V0TlBXaW5kb3dJZk5lZWRlZCgp CiAgICAgfSBlbHNlIHsKICAgICAgICAgbV9ucFdpbmRvdy54ID0gMDsKICAgICAgICAgbV9ucFdp bmRvdy55ID0gMDsKKyAgICAgICAgbV9ucFdpbmRvdy53aWR0aCA9IG1fd2luZG93UmVjdC53aWR0 aCgpOworICAgICAgICBtX25wV2luZG93LmhlaWdodCA9IG1fd2luZG93UmVjdC5oZWlnaHQoKTsK IAogICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmxlZnQgPSAwOwogICAgICAgICBtX25wV2lu ZG93LmNsaXBSZWN0LnRvcCA9IDA7CkBAIC01MjksMTMgKzUzMSw2IEBAIHZvaWQgUGx1Z2luVmll dzo6c2V0TlBXaW5kb3dJZk5lZWRlZCgpCiAgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QuYm90 dG9tID0gMDsKICAgICB9CiAKLSAgICAvLyBGTEFTSCBXT1JLQVJPVU5EOiBPbmx5IHNldCBpbml0 aWFsbHkuIE11bHRpcGxlIGNhbGxzIHRvCi0gICAgLy8gc2V0TlBXaW5kb3coKSBjYXVzZSB0aGUg cGx1Z2luIHRvIGNyYXNoIGluIHdpbmRvd2VkIG1vZGUuCi0gICAgaWYgKCFtX2lzV2luZG93ZWQg fHwgbV9ucFdpbmRvdy53aWR0aCA9PSAodW5zaWduZWQgaW50KS0xIHx8IG1fbnBXaW5kb3cuaGVp Z2h0ID09ICh1bnNpZ25lZCBpbnQpLTEpIHsKLSAgICAgICAgbV9ucFdpbmRvdy53aWR0aCA9IG1f d2luZG93UmVjdC53aWR0aCgpOwotICAgICAgICBtX25wV2luZG93LmhlaWdodCA9IG1fd2luZG93 UmVjdC5oZWlnaHQoKTsKLSAgICB9Ci0KICAgICBQbHVnaW5WaWV3OjpzZXRDdXJyZW50UGx1Z2lu Vmlldyh0aGlzKTsKICAgICBKU0M6OkpTTG9jazo6RHJvcEFsbExvY2tzIGRyb3BBbGxMb2NrcyhK U0M6OlNpbGVuY2VBc3NlcnRpb25zT25seSk7CiAgICAgc2V0Q2FsbGluZ1BsdWdpbih0cnVlKTsK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwIGIvV2ViQ29y ZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAKaW5kZXggYWUwOTg5YS4uMGNhMzU2YiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAKKysrIGIvV2ViQ29y ZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAKQEAgLTUwNyw5ICs1MDcsMTQgQEAgdm9pZCBQ bHVnaW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKCkKICAgICAgICAgbV9ucFdpbmRvdy5jbGlw UmVjdC5ib3R0b20gPSAwOwogICAgIH0KIAotICAgIC8vIEZMQVNIIFdPUktBUk9VTkQ6IE9ubHkg c2V0IGluaXRpYWxseS4gTXVsdGlwbGUgY2FsbHMgdG8KLSAgICAvLyBzZXROUFdpbmRvdygpIGNh dXNlIHRoZSBwbHVnaW4gdG8gY3Jhc2ggaW4gd2luZG93ZWQgbW9kZS4KLSAgICBpZiAoIW1faXNX aW5kb3dlZCB8fCBtX25wV2luZG93LndpZHRoID09IC0xIHx8IG1fbnBXaW5kb3cuaGVpZ2h0ID09 IC0xKSB7CisgICAgaWYgKG1fcGx1Z2luLT5xdWlya3MoKS5jb250YWlucyhQbHVnaW5RdWlya0Rv bnRDYWxsU2V0V2luZG93TW9yZVRoYW5PbmNlKSkgeworICAgICAgICAvLyBGTEFTSCBXT1JLQVJP VU5EOiBPbmx5IHNldCBpbml0aWFsbHkuIE11bHRpcGxlIGNhbGxzIHRvCisgICAgICAgIC8vIHNl dE5QV2luZG93KCkgY2F1c2UgdGhlIHBsdWdpbiB0byBjcmFzaCBpbiB3aW5kb3dlZCBtb2RlLgor ICAgICAgICBpZiAoIW1faXNXaW5kb3dlZCB8fCBtX25wV2luZG93LndpZHRoID09IC0xIHx8IG1f bnBXaW5kb3cuaGVpZ2h0ID09IC0xKSB7CisgICAgICAgICAgICBtX25wV2luZG93LndpZHRoID0g bV93aW5kb3dSZWN0LndpZHRoKCk7CisgICAgICAgICAgICBtX25wV2luZG93LmhlaWdodCA9IG1f d2luZG93UmVjdC5oZWlnaHQoKTsKKyAgICAgICAgfQorICAgIH0gZWxzZSB7CiAgICAgICAgIG1f bnBXaW5kb3cud2lkdGggPSBtX3dpbmRvd1JlY3Qud2lkdGgoKTsKICAgICAgICAgbV9ucFdpbmRv dy5oZWlnaHQgPSBtX3dpbmRvd1JlY3QuaGVpZ2h0KCk7CiAgICAgfQo=