41406 2010-06-30 05:44:06 -0700 [Qt, Gtk, Symbian] Mind the semantics of NPRect for windowed plugin clip rects 2010-06-30 07:20:22 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Other All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling webkit-unassigned commit-queue hausmann oldest_to_newest 244742 0 kling 2010-06-30 05:44:06 -0700 There is code like this in PluginView{Qt,Gtk,Symbian}.cpp: m_npWindow.clipRect.left = m_clipRect.x(); m_npWindow.clipRect.top = m_clipRect.y(); m_npWindow.clipRect.right = m_clipRect.width(); m_npWindow.clipRect.bottom = m_clipRect.height(); (right vs width, bottom vs height) This causes incorrect clipping of windowed plugins. 244745 1 60114 kling 2010-06-30 05:49:06 -0700 Created attachment 60114 Proposed patch 244747 2 hausmann 2010-06-30 05:59:39 -0700 Can you explain on which website this breaks and/or what your test-case was? 244749 3 kling 2010-06-30 06:07:27 -0700 (In reply to comment #2) > Can you explain on which website this breaks and/or what your test-case was? I have no test-case, I'm actually working on bug 40879 but wanted to do this in a separate patch since it touches other platforms' files. 244760 4 60114 commit-queue 2010-06-30 07:20:17 -0700 Comment on attachment 60114 Proposed patch Clearing flags on attachment: 60114 Committed r62184: <http://trac.webkit.org/changeset/62184> 244761 5 commit-queue 2010-06-30 07:20:22 -0700 All reviewed patches have been landed. Closing bug. 60114 2010-06-30 05:49:06 -0700 2010-06-30 07:20:16 -0700 Proposed patch bug-41406.diff text/plain 3813 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDlkNzYwMS4uMGE2YmQ5MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNi0zMCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdCwgR3RrLCBTeW1iaWFuXSBNaW5kIHRoZSBzZW1hbnRp Y3Mgb2YgTlBSZWN0IGZvciB3aW5kb3dlZCBwbHVnaW4gY2xpcCByZWN0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDE0MDYKKworICAgICAgICBOUFJl Y3QgaGFzIHJpZ2h0L2JvdHRvbSBpbnN0ZWFkIG9mIHdpZHRoL2hlaWdodC4KKyAgICAgICAgVGhp cyB3YXMgZml4ZWQgaW4gUGx1Z2luVmlld01hYyB3aXRoIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcv Y2hhbmdlc2V0LzQ1ODE1CisKKyAgICAgICAgKiBwbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnNldE5QV2luZG93SWZOZWVkZWQpOgor ICAgICAgICAqIHBsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlBsdWdpblZpZXc6OnNldE5QV2luZG93SWZOZWVkZWQpOgorICAgICAgICAqIHBsdWdpbnMvc3lt Ymlhbi9QbHVnaW5WaWV3U3ltYmlhbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3 OjpzZXROUFdpbmRvd0lmTmVlZGVkKToKKwogMjAxMC0wNi0yOSAgRXJpYyBTZWlkZWwgIDxlcmlj QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAgYi9XZWJDb3JlL3BsdWdp bnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCmluZGV4IGRjYTdkYWQuLjE0ZTYxNTQgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKKysrIGIvV2ViQ29yZS9w bHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcApAQCAtNTA2LDEwICs1MDYsMTAgQEAgdm9pZCBQ bHVnaW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKCkKICAgICAgICAgbV9ucFdpbmRvdy53aWR0 aCA9IG1fd2luZG93UmVjdC53aWR0aCgpOwogICAgICAgICBtX25wV2luZG93LmhlaWdodCA9IG1f d2luZG93UmVjdC5oZWlnaHQoKTsKIAotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmxlZnQg PSBtX2NsaXBSZWN0LngoKTsKLSAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC50b3AgPSBtX2Ns aXBSZWN0LnkoKTsKLSAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5yaWdodCA9IG1fY2xpcFJl Y3Qud2lkdGgoKTsKLSAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5ib3R0b20gPSBtX2NsaXBS ZWN0LmhlaWdodCgpOworICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmxlZnQgPSBtYXgoMCwg bV9jbGlwUmVjdC54KCkpOworICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnRvcCA9IG1heCgw LCBtX2NsaXBSZWN0LnkoKSk7CisgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QucmlnaHQgPSBt X2NsaXBSZWN0LngoKSArIG1fY2xpcFJlY3Qud2lkdGgoKTsKKyAgICAgICAgbV9ucFdpbmRvdy5j bGlwUmVjdC5ib3R0b20gPSBtX2NsaXBSZWN0LnkoKSArIG1fY2xpcFJlY3QuaGVpZ2h0KCk7CiAK ICAgICAgICAgR3RrQWxsb2NhdGlvbiBhbGxvY2F0aW9uID0geyBtX3dpbmRvd1JlY3QueCgpLCBt X3dpbmRvd1JlY3QueSgpLCBtX3dpbmRvd1JlY3Qud2lkdGgoKSwgbV93aW5kb3dSZWN0LmhlaWdo dCgpIH07CiAgICAgICAgIGd0a193aWRnZXRfc2l6ZV9hbGxvY2F0ZShwbGF0Zm9ybVBsdWdpbldp ZGdldCgpLCAmYWxsb2NhdGlvbik7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1 Z2luVmlld1F0LmNwcCBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCmluZGV4 IDZhMGZhMzkuLmFlMDk4OWEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5W aWV3UXQuY3BwCisrKyBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCkBAIC00 OTMsMTAgKzQ5MywxMCBAQCB2b2lkIFBsdWdpblZpZXc6OnNldE5QV2luZG93SWZOZWVkZWQoKQog ICAgICAgICBtX25wV2luZG93LnggPSBtX3dpbmRvd1JlY3QueCgpOwogICAgICAgICBtX25wV2lu ZG93LnkgPSBtX3dpbmRvd1JlY3QueSgpOwogCi0gICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3Qu bGVmdCA9IG1fY2xpcFJlY3QueCgpOwotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnRvcCA9 IG1fY2xpcFJlY3QueSgpOwotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnJpZ2h0ID0gbV9j bGlwUmVjdC53aWR0aCgpOwotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmJvdHRvbSA9IG1f Y2xpcFJlY3QuaGVpZ2h0KCk7CisgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QubGVmdCA9IG1h eCgwLCBtX2NsaXBSZWN0LngoKSk7CisgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QudG9wID0g bWF4KDAsIG1fY2xpcFJlY3QueSgpKTsKKyAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5yaWdo dCA9IG1fY2xpcFJlY3QueCgpICsgbV9jbGlwUmVjdC53aWR0aCgpOworICAgICAgICBtX25wV2lu ZG93LmNsaXBSZWN0LmJvdHRvbSA9IG1fY2xpcFJlY3QueSgpICsgbV9jbGlwUmVjdC5oZWlnaHQo KTsKICAgICB9IGVsc2UgewogICAgICAgICBtX25wV2luZG93LnggPSAwOwogICAgICAgICBtX25w V2luZG93LnkgPSAwOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL3N5bWJpYW4vUGx1Z2lu Vmlld1N5bWJpYW4uY3BwIGIvV2ViQ29yZS9wbHVnaW5zL3N5bWJpYW4vUGx1Z2luVmlld1N5bWJp YW4uY3BwCmluZGV4IDhhMGM2YTQuLmJhYTk4MzkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lu cy9zeW1iaWFuL1BsdWdpblZpZXdTeW1iaWFuLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvc3lt Ymlhbi9QbHVnaW5WaWV3U3ltYmlhbi5jcHAKQEAgLTI2NywxMCArMjY3LDEwIEBAIHZvaWQgUGx1 Z2luVmlldzo6c2V0TlBXaW5kb3dJZk5lZWRlZCgpCiAgICAgICAgIG1fbnBXaW5kb3cueCA9IG1f d2luZG93UmVjdC54KCk7CiAgICAgICAgIG1fbnBXaW5kb3cueSA9IG1fd2luZG93UmVjdC55KCk7 CiAKLSAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5sZWZ0ID0gbV9jbGlwUmVjdC54KCk7Ci0g ICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QudG9wID0gbV9jbGlwUmVjdC55KCk7Ci0gICAgICAg IG1fbnBXaW5kb3cuY2xpcFJlY3QucmlnaHQgPSBtX2NsaXBSZWN0LndpZHRoKCk7Ci0gICAgICAg IG1fbnBXaW5kb3cuY2xpcFJlY3QuYm90dG9tID0gbV9jbGlwUmVjdC5oZWlnaHQoKTsKKyAgICAg ICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5sZWZ0ID0gbWF4KDAsIG1fY2xpcFJlY3QueCgpKTsKKyAg ICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC50b3AgPSBtYXgoMCwgbV9jbGlwUmVjdC55KCkpOwor ICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnJpZ2h0ID0gbV9jbGlwUmVjdC54KCkgKyBtX2Ns aXBSZWN0LndpZHRoKCk7CisgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QuYm90dG9tID0gbV9j bGlwUmVjdC55KCkgKyBtX2NsaXBSZWN0LmhlaWdodCgpOwogICAgIAogICAgIH0gZWxzZSB7CiAg ICAgICAgIC8vIGFsd2F5cyBjYWxsIHRoaXMgbWV0aG9kIGJlZm9yZSBwYWludGluZy4K