41377 2010-06-29 15:09:44 -0700 Change the copy location for Chromium's Mac layout test plugin 2010-10-19 14:22:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.6 RESOLVED DUPLICATE 47850 P2 Normal --- 1 stuartmorgan stuartmorgan tkent tony oldest_to_newest 244514 0 stuartmorgan 2010-06-29 15:09:44 -0700 Chromium no longer needs to use an internal directory directory for test plugins, now that there's a --extra-plugin-dir argument, so we should start handling the layout plugin the same on the Mac as we do on the other platforms (which is to say, copy it to a plugins/ directory next to the application). 244548 1 60070 stuartmorgan 2010-06-29 16:18:57 -0700 Created attachment 60070 Switch copy destination 244626 2 tkent 2010-06-29 22:21:37 -0700 Chromium DumpRenderTree has no --extra-plugin-dir option. So this patch won't work, right? 244780 3 stuartmorgan 2010-06-30 08:19:57 -0700 Doh, I wasn't thinking about this having a different launch infrastructure. So would the right fix be to add that flag to the command line in SetUpTestEnvironmentImpl? 245050 4 tkent 2010-06-30 18:37:33 -0700 (In reply to comment #3) > So would the right fix be to add that flag to the command line in SetUpTestEnvironmentImpl? I think so. 296402 5 tony 2010-10-19 14:22:56 -0700 Fixed with 47850. *** This bug has been marked as a duplicate of bug 47850 *** 60070 2010-06-29 16:18:57 -0700 2010-06-30 08:10:31 -0700 Switch copy destination 41377.patch text/plain 1207 stuartmorgan SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjIxNDgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMjkgIFN0dWFy dCBNb3JnYW4gIDxzdHVhcnRtb3JnYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN3aXRjaCB0aGUgTWFjIHRlc3QgcGx1Z2lu IGNvcHkgc3RlcCB0byB0aGUgbm9uLWJ1bmRsZWQgbG9jYXRpb24uCisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMzc3CisKKyAgICAgICAgKiBXZWJL aXQuZ3lwOgorCiAyMDEwLTA2LTI5ICBaaGUgU3UgIDxzdXpoZUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL1dl YktpdC5neXAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAJKHJldmlz aW9uIDYyMTQ3KQorKysgV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAJKHdvcmtpbmcgY29weSkK QEAgLTcxOSw3ICs3MTksNyBAQAogICAgICAgICAgICAgICAgICAgICAgICAgJzwoU0hBUkVEX0lO VEVSTUVESUFURV9ESVIpL3dlYmtpdC90ZXh0QXJlYVJlc2l6ZUNvcm5lci5wbmcnLAogICAgICAg ICAgICAgICAgICAgICBdLAogICAgICAgICAgICAgICAgICAgICAnY29waWVzJzogW3sKLSAgICAg ICAgICAgICAgICAgICAgICAgICdkZXN0aW5hdGlvbic6ICc8KFBST0RVQ1RfRElSKS9EdW1wUmVu ZGVyVHJlZS5hcHAvQ29udGVudHMvUGx1Z0lucy8nLAorICAgICAgICAgICAgICAgICAgICAgICAg J2Rlc3RpbmF0aW9uJzogJzwoUFJPRFVDVF9ESVIpL3BsdWdpbnMvJywKICAgICAgICAgICAgICAg ICAgICAgICAgICdmaWxlcyc6IFsnPChQUk9EVUNUX0RJUikvVGVzdE5ldHNjYXBlUGx1Z0luLnBs dWdpbi8nXSwKICAgICAgICAgICAgICAgICAgICAgfV0sCiAgICAgICAgICAgICAgICAgfSx7ICMg T1MhPSJtYWMiCg==