<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>41376</bug_id>
          
          <creation_ts>2010-06-29 14:50:00 -0700</creation_ts>
          <short_desc>[chromium] update webcore gyp to use v8 dll for chromium multi dll build</short_desc>
          <delta_ts>2010-06-30 10:00:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Victor Wang">victorw</reporter>
          <assigned_to name="Victor Wang">victorw</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>fishd</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>244499</commentid>
    <comment_count>0</comment_count>
    <who name="Victor Wang">victorw</who>
    <bug_when>2010-06-29 14:50:00 -0700</bug_when>
    <thetext>For chromium multi dll build, needs to update webcore gyp so webcore is compiled to use the v8 dll.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244502</commentid>
    <comment_count>1</comment_count>
      <attachid>60061</attachid>
    <who name="Victor Wang">victorw</who>
    <bug_when>2010-06-29 14:54:57 -0700</bug_when>
    <thetext>Created attachment 60061
Proposed Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244507</commentid>
    <comment_count>2</comment_count>
      <attachid>60063</attachid>
    <who name="Victor Wang">victorw</who>
    <bug_when>2010-06-29 14:58:53 -0700</bug_when>
    <thetext>Created attachment 60063
Proposed Patch

The previous patch is wrong.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244822</commentid>
    <comment_count>3</comment_count>
      <attachid>60063</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-06-30 10:00:19 -0700</bug_when>
    <thetext>Comment on attachment 60063
Proposed Patch

Clearing flags on attachment: 60063

Committed r62189: &lt;http://trac.webkit.org/changeset/62189&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244823</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-06-30 10:00:23 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>60061</attachid>
            <date>2010-06-29 14:54:57 -0700</date>
            <delta_ts>2010-06-29 14:58:53 -0700</delta_ts>
            <desc>Proposed Patch</desc>
            <filename>webcore_v8.patch</filename>
            <type>text/plain</type>
            <size>1126</size>
            <attacher name="Victor Wang">victorw</attacher>
            
              <data encoding="base64">SW5kZXg6IHRoaXJkX3BhcnR5L1dlYktpdC9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lw
DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09DQotLS0gdGhpcmRfcGFydHkvV2ViS2l0L1dlYkNvcmUvV2ViQ29yZS5neXAv
V2ViQ29yZS5neXAJKHJldmlzaW9uIDYxOTk2KQ0KKysrIHRoaXJkX3BhcnR5L1dlYktpdC9XZWJD
b3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCSh3b3JraW5nIGNvcHkpDQpAQCAtNjU5LDYgKzY1
OSwxMyBAQA0KICAgICAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAgICAgJzwoY2hy
b21pdW1fc3JjX2RpcikvdjgvdG9vbHMvZ3lwL3Y4Lmd5cDp2OCcsCiAgICAgICAgICAgXSwKKyAg
ICAgICAgICAnY29uZGl0aW9ucyc6IFsKKyAgICAgICAgICAgIFsnaW5zaWRlX2Nocm9taXVtX2J1
aWxkPT0xIGFuZCBPUz09IndpbiIgYW5kIGNvbXBvbmVudD09InNoYXJlZF9saWJyYXJ5IicsIHsK
KyAgICAgICAgICAgICAgJ2RlZmluZXMnOiBbCisgICAgICAgICAgICAgICAgJ1VTSU5HX1Y4X1NI
QVJFRCcsCisgICAgICAgICAgICAgIF0sCisgICAgICAgICAgICB9XSwKKyAgICAgICAgICBdLAog
ICAgICAgICB9XSwKICAgICAgICAgWydlbmFibGVfc3ZnIT0wJywgewogICAgICAgICAgICdzb3Vy
Y2VzJzogWwpAQCAtODgxLDYgKzg4OCwxMyBAQA0KICAgICAgICAgICAnZXhwb3J0X2RlcGVuZGVu
dF9zZXR0aW5ncyc6IFsKICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3Y4L3Rvb2xz
L2d5cC92OC5neXA6djgnLAogICAgICAgICAgIF0sCisgICAgICAgICAgJ2NvbmRpdGlvbnMnOiBb
CisgICAgICAgICAgICBbJ2luc2lkZV9jaHJvbWl1bV9idWlsZD09MSBhbmQgT1M9PSJ3aW4iIGFu
ZCBjb21wb25lbnQ9PSJzaGFyZWRfbGlicmFyeSInLCB7CisgICAgICAgICAgICAgICdkZWZpbmVz
JzogWworICAgICAgICAgICAgICAgICdVU0lOR19WOF9TSEFSRUQnLAorICAgICAgICAgICAgICBd
LAorICAgICAgICAgICAgfV0sCisgICAgICAgICAgXSwKICAgICAgICAgfV0sCiAgICAgICAgIFsn
ZW5hYmxlX3N2ZyE9MCcsIHsKICAgICAgICAgICAnc291cmNlcy8nOiBbCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>60063</attachid>
            <date>2010-06-29 14:58:53 -0700</date>
            <delta_ts>2010-06-30 10:00:19 -0700</delta_ts>
            <desc>Proposed Patch</desc>
            <filename>webcore_v8_dll.patch</filename>
            <type>text/plain</type>
            <size>1606</size>
            <attacher name="Victor Wang">victorw</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA2MjE0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMjkgIFZpY3RvciBXYW5nICA8dmljdG9yd0BjaHJvbWl1
bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
W2Nocm9taXVtXSB1cGRhdGUgd2ViY29yZSBneXAgdG8gdXNlIHY4IGRsbCBmb3IgY2hyb21pdW0g
bXVsdGkgZGxsIGJ1aWxkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD00MTM3NgorCisgICAgICAgICogV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6CisK
IDIwMTAtMDYtMjkgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgogCiAgICAgICAg
IFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5neXAv
V2ViQ29yZS5neXAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5
cAkocmV2aXNpb24gNjIxNDYpCisrKyBXZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCSh3
b3JraW5nIGNvcHkpCkBAIC02NTksNiArNjU5LDEzIEBACiAgICAgICAgICAgJ2RlcGVuZGVuY2ll
cyc6IFsKICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3Y4L3Rvb2xzL2d5cC92OC5n
eXA6djgnLAogICAgICAgICAgIF0sCisgICAgICAgICAgJ2NvbmRpdGlvbnMnOiBbCisgICAgICAg
ICAgICBbJ2luc2lkZV9jaHJvbWl1bV9idWlsZD09MSBhbmQgT1M9PSJ3aW4iIGFuZCBjb21wb25l
bnQ9PSJzaGFyZWRfbGlicmFyeSInLCB7CisgICAgICAgICAgICAgICdkZWZpbmVzJzogWworICAg
ICAgICAgICAgICAgICdVU0lOR19WOF9TSEFSRUQnLAorICAgICAgICAgICAgICBdLAorICAgICAg
ICAgICAgfV0sCisgICAgICAgICAgXSwKICAgICAgICAgfV0sCiAgICAgICAgIFsnZW5hYmxlX3N2
ZyE9MCcsIHsKICAgICAgICAgICAnc291cmNlcyc6IFsKQEAgLTg4MSw2ICs4ODgsMTMgQEAKICAg
ICAgICAgICAnZXhwb3J0X2RlcGVuZGVudF9zZXR0aW5ncyc6IFsKICAgICAgICAgICAgICc8KGNo
cm9taXVtX3NyY19kaXIpL3Y4L3Rvb2xzL2d5cC92OC5neXA6djgnLAogICAgICAgICAgIF0sCisg
ICAgICAgICAgJ2NvbmRpdGlvbnMnOiBbCisgICAgICAgICAgICBbJ2luc2lkZV9jaHJvbWl1bV9i
dWlsZD09MSBhbmQgT1M9PSJ3aW4iIGFuZCBjb21wb25lbnQ9PSJzaGFyZWRfbGlicmFyeSInLCB7
CisgICAgICAgICAgICAgICdkZWZpbmVzJzogWworICAgICAgICAgICAgICAgICdVU0lOR19WOF9T
SEFSRUQnLAorICAgICAgICAgICAgICBdLAorICAgICAgICAgICAgfV0sCisgICAgICAgICAgXSwK
ICAgICAgICAgfV0sCiAgICAgICAgIFsnZW5hYmxlX3N2ZyE9MCcsIHsKICAgICAgICAgICAnc291
cmNlcy8nOiBbCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>