41366 2010-06-29 11:57:06 -0700 [QT][S60] QGraphicsWebView based plugin crashes while destroying 2010-07-01 05:53:33 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED DUPLICATE 37303 Qt P2 Normal --- 0 maheshk webkit-unassigned abhinav.mithal cshu kenneth laszlo.gombos yael oldest_to_newest 244412 0 maheshk 2010-06-29 11:57:06 -0700 Double deletion of PluginContainerSymbian causes crash while destroying the plugin on symbian phone. This is noticed only on QGraphicsWebView. Documentation from http://doc.trolltech.com/4.6.2/qgraphicsproxywidget.html "QGraphicsProxyWidget shares ownership with QWidget, so if either of the two widgets are destroyed, the other widget will be automatically destroyed as well." 244422 1 60042 maheshk 2010-06-29 12:14:41 -0700 Created attachment 60042 proposed fix No need to delete proxy separately as deleting any widget deletes both proxy and qwidget. 244439 2 yael 2010-06-29 12:53:34 -0700 This patch will cause all proxy widgets to be deleted only when the browser is exiting and I don't think it is desired behavior. Abhinav & I looked at this yesterday, and we thought that since the desctuctor of the QGraphicsProxyWidget deletes the container, we should not delete the container if there is a proxy widget. Abhinav is preparing a patch for that. 245083 3 60042 maheshk 2010-06-30 21:34:21 -0700 Comment on attachment 60042 proposed fix fix for this bug is checked in as part of https://bugs.webkit.org/show_bug.cgi?id=37303 Obsoleting the bug and closing the bug 245084 4 maheshk 2010-06-30 21:35:21 -0700 *** This bug has been marked as a duplicate of bug 37303 *** 245281 5 yael 2010-07-01 05:46:56 -0700 (In reply to comment #2) > This patch will cause all proxy widgets to be deleted only when the browser is exiting and I don't think it is desired behavior. > Abhinav & I looked at this yesterday, and we thought that since the desctuctor of the QGraphicsProxyWidget deletes the container, we should not delete the container if there is a proxy widget. > Abhinav is preparing a patch for that. Actually, the above comment is not true. Abhinav & I checked the code of QGraphicsProxyWidget and found that the proxy widget would have been deleted togather with the container. Sorry for the wrong comment :-) 245286 6 maheshk 2010-07-01 05:53:33 -0700 (In reply to comment #5) > (In reply to comment #2) > > This patch will cause all proxy widgets to be deleted only when the browser is exiting and I don't think it is desired behavior. > > Abhinav & I looked at this yesterday, and we thought that since the desctuctor of the QGraphicsProxyWidget deletes the container, we should not delete the container if there is a proxy widget. > > Abhinav is preparing a patch for that. > > Actually, the above comment is not true. Abhinav & I checked the code of QGraphicsProxyWidget and found that the proxy widget would have been deleted togather with the container. Sorry for the wrong comment :-) NP :) IMO either container or proxy deletion results in deletion of both by which we could avoid an extra check. 60042 2010-06-29 12:14:41 -0700 2010-06-30 21:34:21 -0700 proposed fix symbian_Crash.patch text/plain 1586 maheshk SW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9zeW1iaWFuL1BsdWdpblZpZXdTeW1iaWFuLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvc3ltYmlhbi9QbHVnaW5WaWV3U3ltYmlhbi5jcHAJ KHJldmlzaW9uIDYxMzkwKQorKysgV2ViQ29yZS9wbHVnaW5zL3N5bWJpYW4vUGx1Z2luVmlld1N5 bWJpYW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MTgsNyArNDE4LDYgQEAKIHsKICAgICBpZiAo cGxhdGZvcm1QbHVnaW5XaWRnZXQoKSkgewogICAgICAgICBQbHVnaW5Db250YWluZXJTeW1iaWFu KiBjb250YWluZXIgPSBzdGF0aWNfY2FzdDxQbHVnaW5Db250YWluZXJTeW1iaWFuKj4ocGxhdGZv cm1QbHVnaW5XaWRnZXQoKSk7Ci0gICAgICAgIGRlbGV0ZSBjb250YWluZXItPnByb3h5KCk7CiAg ICAgICAgIGRlbGV0ZSBjb250YWluZXI7CiAgICAgfQogfQpJbmRleDogV2ViQ29yZS9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYyMTQwKQorKysg V2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0w Ni0yOSAgTWFoZXNoIEt1bGthcm5pICA8bWFoZXNoLmt1bGthcm5pQG5va2lhLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDEzNjYKKyAgICAgICAgCisgICAgICAgIENhdXNl cyBhIGNyYXNoIGluIHN5bWJpYW4gZGV2aWNlIHdoaWxlIGRlc3Ryb3lpbmcgUGx1Z2luQ29udGFp bmVyU3ltYmlhbi4gCisgICAgICAgIFFHcmFwaGljc1Byb3h5V2lkZ2V0IG5lZWQgbm90IGJlIGRl bGV0ZWQgZXhwbGljaXRseSBhcyBpdCBpcyB0YWtlbiBjYXJlIGJ5IHBhcmVudCBkZWxldGUKKwor ICAgICAgICBObyBuZXcgdGVzdHMsIGFzIHRoZXJlIGlzIG5vIG5ldyBmdW5jdGlvbmFsaXR5Lgor ICAgICAgICAKKyAgICAgICAgKiBwbHVnaW5zL3N5bWJpYW4vUGx1Z2luVmlld1N5bWJpYW4uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6cGxhdGZvcm1EZXN0cm95KToKKwogMjAx MC0wNi0yOSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjYyMDUyLgpAQCAtNTYsNyArNzAsNyBAQAog MjAxMC0wNi0yOSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhcmluIEFkbGVyLgotCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYXMgdGhlcmUg aXMgbm8gbmV3IGZ1bmN0aW9uYWxpdHkuCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTc1ODQy PiBDZXJ0YWluIHRleHQgaXMgcmVwZWF0ZWQgYWZ0ZXIgdXNpbmcgc3BsaXRUZXh0KCkKIAogICAg ICAgICBUZXN0czogZmFzdC90ZXh0L3NldERhdGEtZGlydHktbGluZXMuaHRtbAo=