41338 2010-06-29 01:48:49 -0700 REGRESSION(62052): It broke --minimal build 2010-06-29 11:17:41 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P1 Critical --- 41362 40484 1 ossy webkit-unassigned ap beidson commit-queue oldest_to_newest 244160 0 ossy 2010-06-29 01:48:49 -0700 http://trac.webkit.org/changeset/62052 broke --minimal build: ../../../WebCore/bindings/js/ScriptEventListener.cpp:40:22: error: SVGNames.h: No such file or directory ../../../WebCore/bindings/js/ScriptEventListener.cpp: In function ‘WTF::PassRefPtr<WebCore::JSLazyEventListener> WebCore::createWindowAttributeEventListener(WebCore::Element*, WebCore::Attribute*)’: ../../../WebCore/bindings/js/ScriptEventListener.cpp:87: error: invalid use of incomplete type ‘struct WebCore::Element’ ../../../WebCore/dom/Node.h:52: error: forward declaration of ‘struct WebCore::Element’ ../../../WebCore/bindings/js/ScriptEventListener.cpp:110: error: no matching function for call to ‘WebCore::JSLazyEventListener::create(const WebCore::String&, const WebCore::String&, const WebCore::AtomicString&, WebCore::Element*&, WebCore::String&, int&, JSC::JSObject*&, WebCore::DOMWrapperWorld*)’ ../../../WebCore/bindings/js/JSLazyEventListener.h:32: note: candidates are: static WTF::PassRefPtr<WebCore::JSLazyEventListener> WebCore::JSLazyEventListener::create(const WebCore::String&, const WebCore::String&, const WebCore::String&, WebCore::Node*, const WebCore::String&, int, JSC::JSObject*, WebCore::DOMWrapperWorld*) 244199 1 60006 ossy 2010-06-29 04:29:11 -0700 Created attachment 60006 Patch 244200 2 ossy 2010-06-29 04:31:56 -0700 !ENABLE(SVG) case needs #include "Element.h" 244215 3 60010 ossy 2010-06-29 05:11:08 -0700 Created attachment 60010 Patch 244218 4 60010 ossy 2010-06-29 05:12:39 -0700 Comment on attachment 60010 Patch Updated based on IRC discussing with Nikolas 244239 5 60010 zimmermann 2010-06-29 05:43:11 -0700 Comment on attachment 60010 Patch r=me. 244329 6 beidson 2010-06-29 09:44:37 -0700 Sorry about this one guys. The full Qt build has an EWS bot, which passed. I would've fixed this if the minimal build also had EWS ;) 244343 7 60010 commit-queue 2010-06-29 10:04:01 -0700 Comment on attachment 60010 Patch Clearing flags on attachment: 60010 Committed r62129: <http://trac.webkit.org/changeset/62129> 244344 8 commit-queue 2010-06-29 10:04:06 -0700 All reviewed patches have been landed. Closing bug. 60006 2010-06-29 04:29:11 -0700 2010-06-29 05:11:01 -0700 Patch bug-41338-20100629042909.patch text/plain 1668 ossy SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MjEwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMjkgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWlsZGZpeCBmb3IgLS1taW5pbWFsIGJ1aWxkIGFmdGVyIHI2MjA1MgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDEzMzgKKworICAgICAgICAqIGJp bmRpbmdzL2pzL1NjcmlwdEV2ZW50TGlzdGVuZXIuY3BwOiAjaWYgRU5BQkxFKFNWRykgZ3VhcmRz IGFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlV2luZG93QXR0cmlidXRlRXZlbnRMaXN0 ZW5lcik6CisKIDIwMTAtMDYtMjkgIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJp bS5jb20+CiAKICAgICAgICAgTm90IHJldmlld2VkLiBTb3J0IFhjb2RlIHByb2plY3QgZmlsZS4K SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RXZlbnRMaXN0ZW5lci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRFdmVudExpc3RlbmVyLmNwcAkocmV2 aXNpb24gNjIxMDEpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdEV2ZW50TGlzdGVuZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMywxMSArMzMsMTQgQEAKIAogI2luY2x1ZGUgIkF0dHJp YnV0ZS5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCisjaW5jbHVkZSAiRWxlbWVudC5oIgogI2lu Y2x1ZGUgIkV2ZW50TGlzdGVuZXIuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkhU TUxOYW1lcy5oIgogI2luY2x1ZGUgIkpTTm9kZS5oIgorI2lmIEVOQUJMRShTVkcpCiAjaW5jbHVk ZSAiU1ZHTmFtZXMuaCIKKyNlbmRpZgogI2luY2x1ZGUgIlhTU0F1ZGl0b3IuaCIKICNpbmNsdWRl IDxydW50aW1lL0pTTG9jay5oPgogCkBAIC04Miw4ICs4NSw5IEBAIFBhc3NSZWZQdHI8SlNMYXp5 RXZlbnRMaXN0ZW5lcj4gY3JlYXRlQXQKIAogUGFzc1JlZlB0cjxKU0xhenlFdmVudExpc3RlbmVy PiBjcmVhdGVXaW5kb3dBdHRyaWJ1dGVFdmVudExpc3RlbmVyKEVsZW1lbnQqIHdpbmRvd0VxdWl2 YWxlbnRFbGVtZW50LCBBdHRyaWJ1dGUqIGF0dHIpCiB7CisjaWYgRU5BQkxFKFNWRykKICAgICBB U1NFUlQod2luZG93RXF1aXZhbGVudEVsZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpib2R5 VGFnKSB8fCB3aW5kb3dFcXVpdmFsZW50RWxlbWVudC0+aGFzVGFnTmFtZShIVE1MTmFtZXM6OmZy YW1lc2V0VGFnKSB8fCB3aW5kb3dFcXVpdmFsZW50RWxlbWVudC0+aGFzVGFnTmFtZShTVkdOYW1l czo6c3ZnVGFnKSk7Ci0gICAgCisjZW5kaWYKICAgICBGcmFtZSogZnJhbWUgPSB3aW5kb3dFcXVp dmFsZW50RWxlbWVudC0+ZG9jdW1lbnQoKS0+ZnJhbWUoKTsKICAgICBpZiAoIWZyYW1lKQogICAg ICAgICByZXR1cm4gMDsK 60010 2010-06-29 05:11:08 -0700 2010-06-29 10:04:01 -0700 Patch bug-41338-20100629051106.patch text/plain 1809 ossy SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MjEwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMjkgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWlsZGZpeCBmb3IgLS1taW5pbWFsIGJ1aWxkIGFmdGVyIHI2MjA1MgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDEzMzgKKworICAgICAgICAqIGJp bmRpbmdzL2pzL1NjcmlwdEV2ZW50TGlzdGVuZXIuY3BwOiAjaWYgRU5BQkxFKFNWRykgZ3VhcmRz IGFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlV2luZG93QXR0cmlidXRlRXZlbnRMaXN0 ZW5lcik6CisKIDIwMTAtMDYtMjkgIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJp bS5jb20+CiAKICAgICAgICAgTm90IHJldmlld2VkLiBTb3J0IFhjb2RlIHByb2plY3QgZmlsZS4K SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RXZlbnRMaXN0ZW5lci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRFdmVudExpc3RlbmVyLmNwcAkocmV2 aXNpb24gNjIxMDMpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdEV2ZW50TGlzdGVuZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMywxMSArMzMsMTQgQEAKIAogI2luY2x1ZGUgIkF0dHJp YnV0ZS5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCisjaW5jbHVkZSAiRWxlbWVudC5oIgogI2lu Y2x1ZGUgIkV2ZW50TGlzdGVuZXIuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkhU TUxOYW1lcy5oIgogI2luY2x1ZGUgIkpTTm9kZS5oIgorI2lmIEVOQUJMRShTVkcpCiAjaW5jbHVk ZSAiU1ZHTmFtZXMuaCIKKyNlbmRpZgogI2luY2x1ZGUgIlhTU0F1ZGl0b3IuaCIKICNpbmNsdWRl IDxydW50aW1lL0pTTG9jay5oPgogCkBAIC04Miw4ICs4NSwxMSBAQCBQYXNzUmVmUHRyPEpTTGF6 eUV2ZW50TGlzdGVuZXI+IGNyZWF0ZUF0CiAKIFBhc3NSZWZQdHI8SlNMYXp5RXZlbnRMaXN0ZW5l cj4gY3JlYXRlV2luZG93QXR0cmlidXRlRXZlbnRMaXN0ZW5lcihFbGVtZW50KiB3aW5kb3dFcXVp dmFsZW50RWxlbWVudCwgQXR0cmlidXRlKiBhdHRyKQogeworI2lmIEVOQUJMRShTVkcpCiAgICAg QVNTRVJUKHdpbmRvd0VxdWl2YWxlbnRFbGVtZW50LT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6Ym9k eVRhZykgfHwgd2luZG93RXF1aXZhbGVudEVsZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpm cmFtZXNldFRhZykgfHwgd2luZG93RXF1aXZhbGVudEVsZW1lbnQtPmhhc1RhZ05hbWUoU1ZHTmFt ZXM6OnN2Z1RhZykpOwotICAgIAorI2Vsc2UKKyAgICBBU1NFUlQod2luZG93RXF1aXZhbGVudEVs ZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpib2R5VGFnKSB8fCB3aW5kb3dFcXVpdmFsZW50 RWxlbWVudC0+aGFzVGFnTmFtZShIVE1MTmFtZXM6OmZyYW1lc2V0VGFnKSk7CisjZW5kaWYKICAg ICBGcmFtZSogZnJhbWUgPSB3aW5kb3dFcXVpdmFsZW50RWxlbWVudC0+ZG9jdW1lbnQoKS0+ZnJh bWUoKTsKICAgICBpZiAoIWZyYW1lKQogICAgICAgICByZXR1cm4gMDsK