41331 2010-06-28 21:56:27 -0700 REGRESSION(r62084): PassRefPtr is a harsh mistress (Requested by abarth on #webkit). 2010-06-28 22:06:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41326 1 webkit.review.bot webkit.review.bot abarth oldest_to_newest 244083 0 webkit.review.bot 2010-06-28 21:56:27 -0700 http://trac.webkit.org/changeset/62084 broke the build: PassRefPtr is a harsh mistress (Requested by abarth on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 244084 1 59983 webkit.review.bot 2010-06-28 21:56:41 -0700 Created attachment 59983 ROLLOUT of r62084 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 244089 2 59983 abarth 2010-06-28 22:05:59 -0700 Comment on attachment 59983 ROLLOUT of r62084 For better or worse, I tried a live fix. 59983 2010-06-28 21:56:41 -0700 2010-06-28 22:05:59 -0700 ROLLOUT of r62084 bug-41331-20100629045639.patch text/plain 3221 webkit.review.bot ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWFiYTQ5YWJiYzU2YWEyZmM0YjQxMjI5NjUzMmRjMWE5ZWIxZDYxNS4uYWYyMjFkMDYwYWZlZDFm ZWZiMDlhOWI1ODIzZDhkYWVkZWY0NWM5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNi0yOCAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjYyMDg0LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC82MjA4NAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDEzMzEKKworICAgICAgICBQYXNzUmVmUHRyIGlzIGEgaGFyc2ggbWlzdHJlc3Mg KFJlcXVlc3RlZCBieSBhYmFydGggb24KKyAgICAgICAgI3dlYmtpdCkuCisKKyAgICAgICAgKiBk b20vQ29udGFpbmVyTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb250YWluZXJOb2RlOjpw YXJzZXJBZGRDaGlsZCk6CisgICAgICAgIChXZWJDb3JlOjpDb250YWluZXJOb2RlOjpsZWdhY3lQ YXJzZXJBZGRDaGlsZCk6CisgICAgICAgICogZG9tL0NvbnRhaW5lck5vZGUuaDoKKwogMjAxMC0w Ni0yOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3 ZWQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcCBiL1dlYkNvcmUv ZG9tL0NvbnRhaW5lck5vZGUuY3BwCmluZGV4IDNiMWU3ZGUwNzhkMzdlM2Y4YjkyOGQ1M2ZkOGFm ZWQ0M2U0YTNkYmUuLjlmNTRhMmIzYjRhZWQ3ZTA1N2UxYzViYWYzZTIxMzNkMmUzNmE4ODIgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCisrKyBiL1dlYkNvcmUvZG9t L0NvbnRhaW5lck5vZGUuY3BwCkBAIC01MzcsOCArNTM3LDEyIEBAIGJvb2wgQ29udGFpbmVyTm9k ZTo6YXBwZW5kQ2hpbGQoUGFzc1JlZlB0cjxOb2RlPiBuZXdDaGlsZCwgRXhjZXB0aW9uQ29kZSYg ZWMsIGJvCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLXZvaWQgQ29udGFpbmVyTm9kZTo6YWRkQ2hp bGRDb21tb24oUGFzc1JlZlB0cjxOb2RlPiBuZXdDaGlsZCkKK3ZvaWQgQ29udGFpbmVyTm9kZTo6 cGFyc2VyQWRkQ2hpbGQoUGFzc1JlZlB0cjxOb2RlPiBuZXdDaGlsZCkKIHsKKyAgICBBU1NFUlQo bmV3Q2hpbGQpOworICAgIC8vIFRoaXMgZnVuY3Rpb24gaXMgb25seSB1c2VkIGR1cmluZyBwYXJz aW5nLgorICAgIC8vIEl0IGRvZXMgbm90IHNlbmQgYW55IERPTSBtdXRhdGlvbiBldmVudHMuCisK ICAgICBmb3JiaWRFdmVudERpc3BhdGNoKCk7CiAgICAgTm9kZSogbGFzdCA9IG1fbGFzdENoaWxk OwogICAgIGFwcGVuZENoaWxkVG9Db250YWluZXI8Tm9kZSwgQ29udGFpbmVyTm9kZT4obmV3Q2hp bGQuZ2V0KCksIHRoaXMpOwpAQCAtNTUwLDE1ICs1NTQsNiBAQCB2b2lkIENvbnRhaW5lck5vZGU6 OmFkZENoaWxkQ29tbW9uKFBhc3NSZWZQdHI8Tm9kZT4gbmV3Q2hpbGQpCiAgICAgY2hpbGRyZW5D aGFuZ2VkKHRydWUsIGxhc3QsIDAsIDEpOwogfQogCi12b2lkIENvbnRhaW5lck5vZGU6OnBhcnNl ckFkZENoaWxkKFBhc3NSZWZQdHI8Tm9kZT4gbmV3Q2hpbGQpCi17Ci0gICAgQVNTRVJUKG5ld0No aWxkKTsKLSAgICAvLyBUaGlzIGZ1bmN0aW9uIGlzIG9ubHkgdXNlZCBkdXJpbmcgcGFyc2luZy4K LSAgICAvLyBJdCBkb2VzIG5vdCBzZW5kIGFueSBET00gbXV0YXRpb24gZXZlbnRzLgotCi0gICAg YWRkQ2hpbGRDb21tb24obmV3Q2hpbGQpOwotfQotCiBDb250YWluZXJOb2RlKiBDb250YWluZXJO b2RlOjpsZWdhY3lQYXJzZXJBZGRDaGlsZChQYXNzUmVmUHRyPE5vZGU+IG5ld0NoaWxkKQogewog ICAgIEFTU0VSVChuZXdDaGlsZCk7CkBAIC01NjksOCArNTY0LDE2IEBAIENvbnRhaW5lck5vZGUq IENvbnRhaW5lck5vZGU6OmxlZ2FjeVBhcnNlckFkZENoaWxkKFBhc3NSZWZQdHI8Tm9kZT4gbmV3 Q2hpbGQpCiAgICAgaWYgKGRvY3VtZW50KCktPmlzSFRNTERvY3VtZW50KCkgJiYgIWNoaWxkQWxs b3dlZChuZXdDaGlsZC5nZXQoKSkpCiAgICAgICAgIHJldHVybiAwOwogCi0gICAgYWRkQ2hpbGRD b21tb24obmV3Q2hpbGQpOworICAgIGZvcmJpZEV2ZW50RGlzcGF0Y2goKTsKKyAgICBOb2RlKiBs YXN0ID0gbV9sYXN0Q2hpbGQ7CisgICAgYXBwZW5kQ2hpbGRUb0NvbnRhaW5lcjxOb2RlLCBDb250 YWluZXJOb2RlPihuZXdDaGlsZC5nZXQoKSwgdGhpcyk7CisgICAgYWxsb3dFdmVudERpc3BhdGNo KCk7CiAKKyAgICBkb2N1bWVudCgpLT5pbmNET01UcmVlVmVyc2lvbigpOworICAgIGlmIChpbkRv Y3VtZW50KCkpCisgICAgICAgIG5ld0NoaWxkLT5pbnNlcnRlZEludG9Eb2N1bWVudCgpOworICAg IGNoaWxkcmVuQ2hhbmdlZCh0cnVlLCBsYXN0LCAwLCAxKTsKKyAgICAKICAgICBpZiAobmV3Q2hp bGQtPmlzRWxlbWVudE5vZGUoKSkKICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PENvbnRhaW5l ck5vZGUqPihuZXdDaGlsZC5nZXQoKSk7CiAgICAgcmV0dXJuIHRoaXM7CmRpZmYgLS1naXQgYS9X ZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmggYi9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmgK aW5kZXggODQyMzgwODVjOGJkY2FiNGEwZTYwYTcwYzNhNjRkM2MzN2U3YmY5ZS4uOWE5ODExMDgx MTIwZGZmMzM1MTA4ZTQwMzZmYjU4MTk4ZTFmMDUxZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20v Q29udGFpbmVyTm9kZS5oCisrKyBiL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuaApAQCAtOTEs MTIgKzkxLDEwIEBAIHByb3RlY3RlZDoKIAogICAgIHZvaWQgc2V0Rmlyc3RDaGlsZChOb2RlKiBj aGlsZCkgeyBtX2ZpcnN0Q2hpbGQgPSBjaGlsZDsgfQogICAgIHZvaWQgc2V0TGFzdENoaWxkKE5v ZGUqIGNoaWxkKSB7IG1fbGFzdENoaWxkID0gY2hpbGQ7IH0KLQorICAgIAogcHJpdmF0ZToKLSAg ICB2b2lkIGFkZENoaWxkQ29tbW9uKFBhc3NSZWZQdHI8Tm9kZT4pOwotCiAgICAgc3RhdGljIHZv aWQgZGlzcGF0Y2hQb3N0QXR0YWNoQ2FsbGJhY2tzKCk7Ci0KKyAgICAKICAgICBib29sIGdldFVw cGVyTGVmdENvcm5lcihGbG9hdFBvaW50JikgY29uc3Q7CiAgICAgYm9vbCBnZXRMb3dlclJpZ2h0 Q29ybmVyKEZsb2F0UG9pbnQmKSBjb25zdDsKIAo=